diff options
| author | Eric Sandeen <sandeen@sandeen.net> | 2019-05-01 20:26:30 -0700 |
|---|---|---|
| committer | Darrick J. Wong <darrick.wong@oracle.com> | 2019-05-01 20:26:30 -0700 |
| commit | 910832697cf85536c7fe26edb8bc6f830c4b9bb6 (patch) | |
| tree | 7209ecf8be203230e30b679156767e63ff88ebd1 /fs/xfs/xfs_ioctl32.c | |
| parent | 75efa57d0bf5fcf650a183f0ce0dc011ba8c4bc8 (diff) | |
xfs: change some error-less functions to void types
There are several functions which have no opportunity to return
an error, and don't contain any ASSERTs which could be argued
to be better constructed as error cases. So, make them voids
to simplify the callers.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Diffstat (limited to 'fs/xfs/xfs_ioctl32.c')
| -rw-r--r-- | fs/xfs/xfs_ioctl32.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/fs/xfs/xfs_ioctl32.c b/fs/xfs/xfs_ioctl32.c index 65997a6315e9..614fc6886d24 100644 --- a/fs/xfs/xfs_ioctl32.c +++ b/fs/xfs/xfs_ioctl32.c @@ -53,11 +53,8 @@ xfs_compat_ioc_fsgeometry_v1( compat_xfs_fsop_geom_v1_t __user *arg32) { struct xfs_fsop_geom fsgeo; - int error; - error = xfs_fs_geometry(&mp->m_sb, &fsgeo, 3); - if (error) - return error; + xfs_fs_geometry(&mp->m_sb, &fsgeo, 3); /* The 32-bit variant simply has some padding at the end */ if (copy_to_user(arg32, &fsgeo, sizeof(struct compat_xfs_fsop_geom_v1))) return -EFAULT; |