diff options
| author | Chengguang Xu <cgxu519@mykernel.net> | 2019-10-22 17:17:38 +0800 |
|---|---|---|
| committer | Jan Kara <jack@suse.cz> | 2019-10-22 11:24:48 +0200 |
| commit | ba1af2e47446ac353395b4c274408944284ceeaa (patch) | |
| tree | fc3a0fed5f1fcc5de6195fccb45697df6fb4de37 /fs/ext2 | |
| parent | 158be76c01172f4ffa3f10e2b4b433b3e496c75d (diff) | |
ext2: add missing brelse in ext2_new_blocks()
Fix missing brelse of bitmap_bh in the case of retry.
Link: https://lore.kernel.org/r/20191022091738.9160-1-cgxu519@mykernel.net
Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
Signed-off-by: Jan Kara <jack@suse.cz>
Diffstat (limited to 'fs/ext2')
| -rw-r--r-- | fs/ext2/balloc.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/fs/ext2/balloc.c b/fs/ext2/balloc.c index 924c1c765306..4664d324567c 100644 --- a/fs/ext2/balloc.c +++ b/fs/ext2/balloc.c @@ -1313,6 +1313,13 @@ retry_alloc: if (free_blocks > 0) { grp_target_blk = ((goal - le32_to_cpu(es->s_first_data_block)) % EXT2_BLOCKS_PER_GROUP(sb)); + /* + * In case we retry allocation (due to fs reservation not + * working out or fs corruption), the bitmap_bh is non-null + * pointer and we have to release it before calling + * read_block_bitmap(). + */ + brelse(bitmap_bh); bitmap_bh = read_block_bitmap(sb, group_no); if (!bitmap_bh) goto io_error; |