diff options
| author | Qiushi Wu <wu000273@umn.edu> | 2020-05-27 16:00:19 -0500 |
|---|---|---|
| committer | Joerg Roedel <jroedel@suse.de> | 2020-05-29 15:27:50 +0200 |
| commit | 7cc31613734c4870ae32f5265d576ef296621343 (patch) | |
| tree | c31d4380cd1288528d51702675b51cc657b24797 /drivers/iommu | |
| parent | ed3119e45519880a246b085ba6a96aa1074da532 (diff) | |
iommu: Fix reference count leak in iommu_group_alloc.
kobject_init_and_add() takes reference even when it fails.
Thus, when kobject_init_and_add() returns an error,
kobject_put() must be called to properly clean up the kobject.
Fixes: d72e31c93746 ("iommu: IOMMU Groups")
Signed-off-by: Qiushi Wu <wu000273@umn.edu>
Link: https://lore.kernel.org/r/20200527210020.6522-1-wu000273@umn.edu
Signed-off-by: Joerg Roedel <jroedel@suse.de>
Diffstat (limited to 'drivers/iommu')
| -rw-r--r-- | drivers/iommu/iommu.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c index 1faa08c8bbb4..03d6a26687bc 100644 --- a/drivers/iommu/iommu.c +++ b/drivers/iommu/iommu.c @@ -510,7 +510,7 @@ struct iommu_group *iommu_group_alloc(void) NULL, "%d", group->id); if (ret) { ida_simple_remove(&iommu_group_ida, group->id); - kfree(group); + kobject_put(&group->kobj); return ERR_PTR(ret); } |