diff options
| author | Luis de Bethencourt <luis@debethencourt.com> | 2014-04-27 18:29:11 -0400 |
|---|---|---|
| committer | Luis de Bethencourt <luis@debethencourt.com> | 2014-04-27 18:31:48 -0400 |
| commit | 3943c3ec08fd733441e69bf30227f9130a3e1b14 (patch) | |
| tree | 3913d38d6cb90e94d7b1beadc89f2a5b005a866e /gst/goom | |
| parent | 5dc2e6bef1cb35e9473dcb785d3711e0892c7e38 (diff) | |
goom: fix undefined behaviour of left-shift
Don't left-shift into the sign bit, the result is undefined and potentially
an overflow could flip the sign.
Diffstat (limited to 'gst/goom')
| -rw-r--r-- | gst/goom/filters.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/gst/goom/filters.c b/gst/goom/filters.c index b1584f11e..338070cee 100644 --- a/gst/goom/filters.c +++ b/gst/goom/filters.c @@ -731,7 +731,7 @@ generatePrecalCoef (int precalCoef[16][16]) if (!(coefh || coefv)) { i = 255; } else { - int i1, i2, i3, i4; + uint i1, i2, i3, i4; i1 = diffcoeffh * diffcoeffv; i2 = coefh * diffcoeffv; |