summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVivia Nikolaidou <vivia@toolsonair.com>2016-08-19 17:18:16 +0300
committerSebastian Dröge <sebastian@centricular.com>2016-08-19 17:53:25 +0300
commit64fd099a3a431237e6d9d2deeed812700d884883 (patch)
tree0a422b94350e27d416447b252411cbc6f5e8e62c
parent4048a4e1373a265802144a867fdd6dbcbc87d119 (diff)
isomp4: Fix coverity warning
If atom_copy_data fails to write anything, return 0 CID #1371458
-rw-r--r--gst/isomp4/atoms.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/gst/isomp4/atoms.c b/gst/isomp4/atoms.c
index b2f7f748c..f53004ebd 100644
--- a/gst/isomp4/atoms.c
+++ b/gst/isomp4/atoms.c
@@ -2115,7 +2115,8 @@ sample_entry_tx3g_copy_data (SampleTableEntryTX3G * tx3g, guint8 ** buffer,
Atom atom;
atom_header_set (&atom, FOURCC_ftab, 18, 0);
- atom_copy_data (&atom, buffer, size, offset);
+ if (!atom_copy_data (&atom, buffer, size, offset))
+ return 0;
prop_copy_uint16 (1, buffer, size, offset); /* Count must be 1 */
prop_copy_uint16 (1, buffer, size, offset); /* Font id: 1 */
prop_copy_size_string ((guint8 *) "Serif", 5, buffer, size, offset);
@@ -2150,7 +2151,8 @@ sample_entry_tmcd_copy_data (SampleTableEntryTMCD * tmcd, guint8 ** buffer,
guint64 name_offset = *offset;
atom_header_set (&atom, FOURCC_name, 0, 0);
- atom_copy_data (&atom, buffer, size, offset);
+ if (!atom_copy_data (&atom, buffer, size, offset))
+ return 0;
prop_copy_uint16 (strlen (tmcd->name.name), buffer, size, offset);
prop_copy_uint16 (tmcd->name.language_code, buffer, size, offset);
prop_copy_fixed_size_string ((guint8 *) tmcd->name.name,