From 003e30a66a249f5c70b30d1c187385124cd4cdad Mon Sep 17 00:00:00 2001 From: Alan Coopersmith Date: Tue, 1 Jan 2019 14:34:04 -0800 Subject: Avoid use-after-free in _XimProtoSetIMValues() Fixes gitlab issue #49 Signed-off-by: Alan Coopersmith --- modules/im/ximcp/imDefIm.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/modules/im/ximcp/imDefIm.c b/modules/im/ximcp/imDefIm.c index 970df0cf..cf922e48 100644 --- a/modules/im/ximcp/imDefIm.c +++ b/modules/im/ximcp/imDefIm.c @@ -1297,8 +1297,6 @@ _XimProtoSetIMValues( if ((name = _XimEncodeIMATTRIBUTE(im, im->core.im_resources, im->core.im_num_resources, arg, &arg_ret, data, data_len, &ret_len, (XPointer)&im_values, XIM_SETIMVALUES))) { - if (buf != tmp_buf) - Xfree(buf); break; } -- cgit v1.2.3