diff options
| author | Christian Linhart <chris@demorecorder.com> | 2014-09-04 17:48:55 +0200 |
|---|---|---|
| committer | Christian Linhart <chris@demorecorder.com> | 2014-11-03 11:23:22 +0100 |
| commit | c9b1523b23af52087a6354730f86b8d19fa3c7c0 (patch) | |
| tree | d9c72295bbbfce0ad5ee1b7db1a90ff3515edb35 | |
| parent | b92405a2d0dc533b22ad2950d9daf0fb48139713 (diff) | |
present: specify length of RedirectNotify.notifies
The list "notifies" of the event RedirectNotify didn't have
a length.
The missing length has caused uncompilable C-Code with our
event-acessors patch because the length-acessor for that list
has used an undeclared variable for the list-length.
Having a length for that list is good anyways for ease of use.
Since the event doesn't contain a field which specifies the
length of the list, the length is derived from the length
of the event.
spec:
http://cgit.freedesktop.org/xorg/proto/presentproto/tree/presentproto.txt?id=presentproto-1.0#n429
http://cgit.freedesktop.org/xorg/proto/presentproto/tree/presentproto.txt?id=presentproto-1.0#n710
note:
The event definition starting at line 429 lists the relationship between
length of event ( "length" ) and length of list ( "n" )
as 17+2n where as the definition starting at line 710
lists 18+2n. The latter is correct according to my verification.
The spec should be fixed.
Message-ID: <1409845742-38797-1-git-send-email-chris@demorecorder.com>
Patch-Thread-Subject: [Xcb] support popcount of a list and associated xml changes
Patch-Set: PopcountList
Patch-Number: proto 1/8
Patch-Version: V1
Signed-off-by: Christian Linhart <chris@DemoRecorder.com>
| -rw-r--r-- | src/present.xml | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/src/present.xml b/src/present.xml index a9adc2b..95fee01 100644 --- a/src/present.xml +++ b/src/present.xml @@ -199,7 +199,15 @@ OF THIS SOFTWARE. <field type="CARD64" name="target_msc" /> <field type="CARD64" name="divisor" /> <field type="CARD64" name="remainder" /> - <list type="Notify" name="notifies"/> + <list type="Notify" name="notifies"> + <op op="/"> + <op op="-"> + <fieldref>length</fieldref> + <value>18</value> + </op> + <value>2</value> + </op> + </list> </event> </xcb> |