diff options
author | zhanghailiang <zhang.zhanghailiang@huawei.com> | 2014-11-14 10:18:08 +0800 |
---|---|---|
committer | Paolo Bonzini <pbonzini@redhat.com> | 2014-11-14 12:15:40 +0100 |
commit | 50fc1c5dd931c82c166c051f287858bd98910851 (patch) | |
tree | f946a1f9badb00b0efeb8b59c887427be536dd18 | |
parent | 43d84715e28eac517ad36af4b396f47b00895be1 (diff) |
libcacard: fix resource leakv2.2.0-rc5v2.2.0-rc4v2.2.0-rc3v2.2.0-rc2v2.2.0
In function connect_to_qemu(), getaddrinfo() will allocate memory
that is stored into server, it should be freed by using freeaddrinfo()
before connect_to_qemu() return.
Cc: qemu-stable@nongnu.org
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
-rw-r--r-- | libcacard/vscclient.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/libcacard/vscclient.c b/libcacard/vscclient.c index 80111df..fa6041d 100644 --- a/libcacard/vscclient.c +++ b/libcacard/vscclient.c @@ -597,7 +597,7 @@ connect_to_qemu( const char *port ) { struct addrinfo hints; - struct addrinfo *server; + struct addrinfo *server = NULL; int ret, sock; sock = socket(AF_INET, SOCK_STREAM, 0); @@ -629,9 +629,14 @@ connect_to_qemu( if (verbose) { printf("Connected (sizeof Header=%zd)!\n", sizeof(VSCMsgHeader)); } + + freeaddrinfo(server); return sock; cleanup_socket: + if (server) { + freeaddrinfo(server); + } closesocket(sock); return -1; } |