diff options
| author | Rob Clark <robclark@freedesktop.org> | 2016-08-02 16:16:02 -0400 |
|---|---|---|
| committer | Rob Clark <robclark@freedesktop.org> | 2016-08-02 16:22:45 -0400 |
| commit | b214b05ccd433c484a6a65e491a1a51b19e4811d (patch) | |
| tree | f0704c06633f10660ad16efe70bde0b9b59d8cfb /util_double_list.h | |
| parent | f19cd3a52827a2368040649c2fc5e7e75db10d08 (diff) | |
list: fix an issue with android build using clang
Sorry, I don't understand the android build system enough to say *which*
version of clang this effects, but either "clang-2812033" or
"clang-3016494" (probably the later).
But when 'sample' is undefined (ie. unitialized variable), the result is
not as well defined as it is with gcc. Instead use a typeof() cast with
a defined value (ie. zero).
This fixes a crash that was reported on android.
Reported-by: John Stultz <john.stultz@linaro.org>
Signed-off-by: Rob Clark <robclark@freedesktop.org>
Diffstat (limited to 'util_double_list.h')
| -rw-r--r-- | util_double_list.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/util_double_list.h b/util_double_list.h index 5d01f52d..7e48b26c 100644 --- a/util_double_list.h +++ b/util_double_list.h @@ -110,7 +110,7 @@ static inline void list_delinit(struct list_head *item) #ifndef container_of #define container_of(ptr, sample, member) \ (void *)((char *)(ptr) \ - - ((char *)&(sample)->member - (char *)(sample))) + - ((char *)&((typeof(sample))0)->member)) #endif #define LIST_FOR_EACH_ENTRY(pos, head, member) \ |