summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMichael Meeks <michael.meeks@collabora.com>2019-02-13 18:33:06 +0100
committerMichael Meeks <michael.meeks@collabora.com>2019-02-13 18:35:32 +0100
commite1f3a6a38872165ff99e130cde03e994445ef0bd (patch)
tree106233a8ac29e36d52574d5c1a1afd8a90a919a8
parent92cf5707cfa1a0a3e43b89a394c335a97b7d3164 (diff)
Tweak problemms.
Change-Id: I35d82dffba9f0e58ea70c782ee8ce7fcf8f9b314
-rw-r--r--PROBLEMS8
-rw-r--r--wsd/TileCache.cpp1
2 files changed, 3 insertions, 6 deletions
diff --git a/PROBLEMS b/PROBLEMS
index f220b85ec..cfe2a01b7 100644
--- a/PROBLEMS
+++ b/PROBLEMS
@@ -35,11 +35,9 @@
poll() calls to be without timeout. Or something similar, depending
on case.
-- Recursive mutexes are evil. In general, I think the consensus is
- that recursive mutexes should be avoided. One should use them only
- when absolutely necessary because the code-base is so complex that
- one has no idea how it works. That was hopefully not the case when
- recursive mutexes were introduced here? But probably it is by now...
+- Recursive mutexes are evil. The last remaining instances should be
+ removed from the Kit/ChildSession.cppp as/when we move to a single
+ threaded Kit process.
- Occasionally Control-C (SIGINT) doesn't shut down loolwsd. One has
to kill it with SIGKILL. Which of course leaves all the chroot jails
diff --git a/wsd/TileCache.cpp b/wsd/TileCache.cpp
index b46d16044..65b1c5a41 100644
--- a/wsd/TileCache.cpp
+++ b/wsd/TileCache.cpp
@@ -33,7 +33,6 @@
#include "ClientSession.hpp"
#include <Common.hpp>
#include <Protocol.hpp>
-#include "SenderQueue.hpp"
#include <Unit.hpp>
#include <Util.hpp>
#include <common/FileUtil.hpp>