From b4e4a5ca8ed52a57d39b06ae7183fd4586e980eb Mon Sep 17 00:00:00 2001 From: Tor Lillqvist Date: Tue, 5 May 2020 19:15:52 +0300 Subject: On iOS, avoid catching exceptions to just immediately exit or abort anyway It is better to let the exception be uncaught and then catch that in the debugger. (Maybe even inspect its backtrace from a crash dump automatically sent from an end-user device.) Change-Id: Ice02d5cbd7f4a59eae7ce8a9fac47dec8b234a5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93505 Tested-by: Jenkins CollaboraOffice Reviewed-by: Tor Lillqvist Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93601 Tested-by: Jenkins Reviewed-by: Andras Timar Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93646 --- vcl/source/app/salusereventlist.cxx | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'vcl') diff --git a/vcl/source/app/salusereventlist.cxx b/vcl/source/app/salusereventlist.cxx index cb9104d7a5c1..088bc141f5a6 100644 --- a/vcl/source/app/salusereventlist.cxx +++ b/vcl/source/app/salusereventlist.cxx @@ -103,10 +103,13 @@ bool SalUserEventList::DispatchUserEvents( bool bHandleAllCurrentEvents ) continue; } +#ifndef IOS try +#endif { ProcessEvent( aEvent ); } +#ifndef IOS catch (css::uno::Exception&) { TOOLS_WARN_EXCEPTION("vcl", "Uncaught"); @@ -122,6 +125,7 @@ bool SalUserEventList::DispatchUserEvents( bool bHandleAllCurrentEvents ) SAL_WARN("vcl", "Uncaught exception during DispatchUserEvents!"); std::abort(); } +#endif aResettableListGuard.reset(); if (!bHandleAllCurrentEvents) break; -- cgit v1.2.3