From 4bb6533d398cc76d7ff292a9e47dae87fac74f83 Mon Sep 17 00:00:00 2001 From: Luboš Luňák Date: Thu, 7 Oct 2021 18:02:12 +0200 Subject: use pull model also for LOK text selection MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Make LOK_CALLBACK_TEXT_SELECTION, LOK_CALLBACK_TEXT_SELECTION_START, LOK_CALLBACK_TEXT_SELECTION_END and LOK_CALLBACK_TEXT_VIEW_SELECTION also use pull model, i.e. LO core will only set a flag and when CallbackFlushHandler needs the actual data it'll use getLOKPayload(). This again avoids a large number of messages passed to CallbackFlushHandler only for them to be sooner or later discarded. Change-Id: Ia7528039be996a6e9e8491b4eba3f4133582fa56 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124146 Tested-by: Jenkins Reviewed-by: Luboš Luňák --- test/source/lokcallback.cxx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'test') diff --git a/test/source/lokcallback.cxx b/test/source/lokcallback.cxx index 6a39b9064470..90ca5f2c9203 100644 --- a/test/source/lokcallback.cxx +++ b/test/source/lokcallback.cxx @@ -143,7 +143,7 @@ void TestLokCallbackWrapper::flushLOKData() return shell->GetViewShellId().get() == m_viewId; }); assert(viewShell != nullptr); - // First move data to local structures, so that notifyFromLOKCallback() doesn't modify it. + // First move data to local structures, so that callbacks don't possibly modify it. std::vector updatedTypes; std::swap(updatedTypes, m_updatedTypes); std::vector updatedTypesPerViewId; -- cgit v1.2.3