From 6e67c03dc0225fc66343546b14e902b9d238b1a3 Mon Sep 17 00:00:00 2001 From: Stephan Bergmann Date: Wed, 14 Mar 2012 13:27:56 +0100 Subject: Enable -Wnon-virtual-dtor for GCC 4.6 ...which has the necessary features to support it. Change a lot of classes to either contain a protected non-virtual dtor (which is backwards compatible, so even works for cppumaker-generated UNO headers) or a public virtual one. cppuhelper/propertysetmixin.hxx still needs to disable the warning, as the relevant class has a non-virtual dtor but friends, which would still cause GCC to warn. Includes a patch for libcmis, intended to be upstreamed. --- test/inc/test/container/xindexaccess.hxx | 2 ++ test/inc/test/sheet/cellproperties.hxx | 3 +++ test/inc/test/sheet/datapilotfield.hxx | 3 +++ test/inc/test/sheet/xcellrangedata.hxx | 3 +++ test/inc/test/sheet/xcellrangereferrer.hxx | 3 +++ test/inc/test/sheet/xcellrangesquery.hxx | 2 ++ test/inc/test/sheet/xdatabaserange.hxx | 3 +++ test/inc/test/sheet/xdatapilotdescriptor.hxx | 4 ++++ test/inc/test/sheet/xdatapilotfieldgrouping.hxx | 3 +++ test/inc/test/sheet/xnamedrange.hxx | 2 ++ test/inc/test/sheet/xspreadsheetdocument.hxx | 4 ++++ test/inc/test/util/xreplaceable.hxx | 3 +++ 12 files changed, 35 insertions(+) (limited to 'test/inc') diff --git a/test/inc/test/container/xindexaccess.hxx b/test/inc/test/container/xindexaccess.hxx index bd09a8f870d6..7c4ce83fe14c 100644 --- a/test/inc/test/container/xindexaccess.hxx +++ b/test/inc/test/container/xindexaccess.hxx @@ -43,6 +43,8 @@ public: // will throw an exception and should fail if not void testGetByIndexException(); +protected: + ~XIndexAccess() {} private: sal_Int32 mnItems; diff --git a/test/inc/test/sheet/cellproperties.hxx b/test/inc/test/sheet/cellproperties.hxx index f2a3b7150060..d9fe22a6a9c6 100644 --- a/test/inc/test/sheet/cellproperties.hxx +++ b/test/inc/test/sheet/cellproperties.hxx @@ -41,6 +41,9 @@ public: void testVertJustify(); void testRotateReference(); + +protected: + ~CellProperties() {} }; } diff --git a/test/inc/test/sheet/datapilotfield.hxx b/test/inc/test/sheet/datapilotfield.hxx index c87dfc07537b..b05d50b67bd0 100644 --- a/test/inc/test/sheet/datapilotfield.hxx +++ b/test/inc/test/sheet/datapilotfield.hxx @@ -43,6 +43,9 @@ public: void testAutoShowInfo(); void testReference(); void testIsGroupField(); + +protected: + ~DataPilotField() {} }; } diff --git a/test/inc/test/sheet/xcellrangedata.hxx b/test/inc/test/sheet/xcellrangedata.hxx index 013b01f6cfd0..824399e4925c 100644 --- a/test/inc/test/sheet/xcellrangedata.hxx +++ b/test/inc/test/sheet/xcellrangedata.hxx @@ -41,6 +41,9 @@ public: void testGetDataArray(); void testSetDataArray(); + +protected: + ~XCellRangeData() {} }; } diff --git a/test/inc/test/sheet/xcellrangereferrer.hxx b/test/inc/test/sheet/xcellrangereferrer.hxx index b799993581a3..8a9da34d84ee 100644 --- a/test/inc/test/sheet/xcellrangereferrer.hxx +++ b/test/inc/test/sheet/xcellrangereferrer.hxx @@ -43,6 +43,9 @@ public: void testGetReferredCells(); +protected: + ~XCellRangeReferrer() {} + private: table::CellRangeAddress maCellRange; }; diff --git a/test/inc/test/sheet/xcellrangesquery.hxx b/test/inc/test/sheet/xcellrangesquery.hxx index c315163f5b90..d0ddd7f1664d 100644 --- a/test/inc/test/sheet/xcellrangesquery.hxx +++ b/test/inc/test/sheet/xcellrangesquery.hxx @@ -50,6 +50,8 @@ public: void testQueryRowDifference(); void testQueryVisibleCells(); +protected: + ~XCellRangesQuery() {} }; } diff --git a/test/inc/test/sheet/xdatabaserange.hxx b/test/inc/test/sheet/xdatabaserange.hxx index 3e3805687146..0c3263821619 100644 --- a/test/inc/test/sheet/xdatabaserange.hxx +++ b/test/inc/test/sheet/xdatabaserange.hxx @@ -46,6 +46,9 @@ public: void testGetImportDescriptor(); void testGetFilterDescriptor(); void testRefresh(); + +protected: + ~XDatabaseRange() {} }; } diff --git a/test/inc/test/sheet/xdatapilotdescriptor.hxx b/test/inc/test/sheet/xdatapilotdescriptor.hxx index eb5b8c10770d..16b4e735683e 100644 --- a/test/inc/test/sheet/xdatapilotdescriptor.hxx +++ b/test/inc/test/sheet/xdatapilotdescriptor.hxx @@ -52,6 +52,10 @@ public: void testGetHiddenFields(); virtual uno::Reference< uno::XInterface > init() = 0; + +protected: + ~XDataPilotDescriptor() {} + private: void testGetDataPilotFields_Impl( uno::Reference< sheet::XDataPilotDescriptor > xDescr ); diff --git a/test/inc/test/sheet/xdatapilotfieldgrouping.hxx b/test/inc/test/sheet/xdatapilotfieldgrouping.hxx index b1e086461693..828d02d2fd73 100644 --- a/test/inc/test/sheet/xdatapilotfieldgrouping.hxx +++ b/test/inc/test/sheet/xdatapilotfieldgrouping.hxx @@ -41,6 +41,9 @@ public: void testCreateDateGroup(); virtual uno::Reference< uno::XInterface > init() = 0; + +protected: + ~XDataPilotFieldGrouping() {} }; } diff --git a/test/inc/test/sheet/xnamedrange.hxx b/test/inc/test/sheet/xnamedrange.hxx index 1859237a5c96..b21e0c89cf4b 100644 --- a/test/inc/test/sheet/xnamedrange.hxx +++ b/test/inc/test/sheet/xnamedrange.hxx @@ -47,6 +47,8 @@ public: void testGetReferencePosition(); void testSetReferencePosition(); protected: + ~XNamedRange() {} + virtual uno::Reference< sheet::XNamedRange> getNamedRange(const rtl::OUString&) = 0; }; diff --git a/test/inc/test/sheet/xspreadsheetdocument.hxx b/test/inc/test/sheet/xspreadsheetdocument.hxx index e4e258a5f51f..026d166ba655 100644 --- a/test/inc/test/sheet/xspreadsheetdocument.hxx +++ b/test/inc/test/sheet/xspreadsheetdocument.hxx @@ -41,6 +41,10 @@ public: virtual uno::Reference< uno::XInterface > init() = 0; void testGetSheets(); + +protected: + ~XSpreadsheetDocument() {} + private: sal_Int32 mnSheets; }; diff --git a/test/inc/test/util/xreplaceable.hxx b/test/inc/test/util/xreplaceable.hxx index 4f66ea1e9a50..53dc1507678f 100644 --- a/test/inc/test/util/xreplaceable.hxx +++ b/test/inc/test/util/xreplaceable.hxx @@ -44,6 +44,9 @@ public: void testCreateReplaceDescriptor(); void testReplaceAll(); +protected: + ~XReplaceable() {} + private: rtl::OUString maSearchString; rtl::OUString maReplaceString; -- cgit v1.2.3