From c2348bbbbd960e29087f0578244f3be7f4df4c8c Mon Sep 17 00:00:00 2001 From: Eike Rathke Date: Tue, 4 Jul 2017 15:22:23 +0200 Subject: Set error on more than max params (255) per function Parameter count is size byte, so.. SUM(1,1,1,...) with 256 arguments resulted in 0 (uint8 wrapping around). (cherry picked from commit 209cc5c211260a6c20cc6fb5ac02fd5a88100314) Change-Id: Ib9997ad0d0d13d4c5171f276148b6c5cad570d5b Reviewed-on: https://gerrit.libreoffice.org/39505 Tested-by: Jenkins Reviewed-by: Markus Mohrhard --- include/formula/FormulaCompiler.hxx | 1 + 1 file changed, 1 insertion(+) (limited to 'include') diff --git a/include/formula/FormulaCompiler.hxx b/include/formula/FormulaCompiler.hxx index f6650201bba1..f105250181fc 100644 --- a/include/formula/FormulaCompiler.hxx +++ b/include/formula/FormulaCompiler.hxx @@ -39,6 +39,7 @@ #define FORMULA_MAXJUMPCOUNT 32 /* maximum number of jumps (ocChoose) */ #define FORMULA_MAXTOKENS 8192 /* maximum number of tokens in formula */ +#define FORMULA_MAXPARAMS 255 /* maximum number of parameters per function (byte) */ namespace com { namespace sun { namespace star { -- cgit v1.2.3