From e40e5726e0062b214f4198ad9156d606d830d4ee Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Mon, 17 Aug 2020 08:21:13 +0200 Subject: loplugin:unusedmethods Change-Id: I31002cc322c43498ef8c37f6b7f94ae1a8278ba9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100857 Tested-by: Jenkins Reviewed-by: Noel Grandin --- dbaccess/source/ui/control/tabletree.cxx | 48 ---------------------- dbaccess/source/ui/inc/JoinTableView.hxx | 2 - dbaccess/source/ui/inc/TableWindowListBox.hxx | 3 -- dbaccess/source/ui/inc/callbacks.hxx | 11 ----- dbaccess/source/ui/inc/tabletree.hxx | 2 - dbaccess/source/ui/querydesign/JoinTableView.cxx | 4 -- .../source/ui/querydesign/TableWindowListBox.cxx | 10 ----- 7 files changed, 80 deletions(-) (limited to 'dbaccess') diff --git a/dbaccess/source/ui/control/tabletree.cxx b/dbaccess/source/ui/control/tabletree.cxx index ead1d5483cbf..52da1cd8779a 100644 --- a/dbaccess/source/ui/control/tabletree.cxx +++ b/dbaccess/source/ui/control/tabletree.cxx @@ -480,54 +480,6 @@ std::unique_ptr TableTreeListBox::getAllObjectsEntry() const return xRet; } -void OTableTreeListBox::checkedButton_noBroadcast(const weld::TreeIter& rEntry) -{ - if (!m_bShowToggles) - return; - TriState eState = m_xTreeView->get_toggle(rEntry); - OSL_ENSURE(TRISTATE_INDET != eState, "OTableTreeListBox::CheckButtonHdl: user action which lead to TRISTATE?"); - - if (m_xTreeView->iter_has_child(rEntry)) // if it has children, check those too - { - std::unique_ptr xChildEntry(m_xTreeView->make_iterator(&rEntry)); - std::unique_ptr xSiblingEntry(m_xTreeView->make_iterator(&rEntry)); - bool bChildEntry = m_xTreeView->iter_next(*xChildEntry); - bool bSiblingEntry = m_xTreeView->iter_next_sibling(*xSiblingEntry); - while (bChildEntry && (!bSiblingEntry || !xChildEntry->equal(*xSiblingEntry))) - { - m_xTreeView->set_toggle(*xChildEntry, eState); - bChildEntry = m_xTreeView->iter_next(*xChildEntry); - } - } - - if (m_xTreeView->is_selected(rEntry)) - { - m_xTreeView->selected_foreach([this, eState](weld::TreeIter& rSelected){ - m_xTreeView->set_toggle(rSelected, eState); - if (m_xTreeView->iter_has_child(rSelected)) // if it has children, check those too - { - std::unique_ptr xChildEntry(m_xTreeView->make_iterator(&rSelected)); - std::unique_ptr xSiblingEntry(m_xTreeView->make_iterator(&rSelected)); - bool bChildEntry = m_xTreeView->iter_next(*xChildEntry); - bool bSiblingEntry = m_xTreeView->iter_next_sibling(*xSiblingEntry); - while (bChildEntry && (!bSiblingEntry || !xChildEntry->equal(*xSiblingEntry))) - { - m_xTreeView->set_toggle(*xChildEntry, eState); - bChildEntry = m_xTreeView->iter_next(*xChildEntry); - } - } - return false; - }); - } - - CheckButtons(); - - // if an entry has children, it makes a difference if the entry is checked - // because all children are checked or if the user checked it explicitly. - // So we track explicit (un)checking - implEmphasize(rEntry, eState == TRISTATE_TRUE); -} - TriState OTableTreeListBox::implDetermineState(weld::TreeIter& rEntry) { if (!m_bShowToggles) diff --git a/dbaccess/source/ui/inc/JoinTableView.hxx b/dbaccess/source/ui/inc/JoinTableView.hxx index 413cccf32e7d..53201878ad56 100644 --- a/dbaccess/source/ui/inc/JoinTableView.hxx +++ b/dbaccess/source/ui/inc/JoinTableView.hxx @@ -75,7 +75,6 @@ namespace dbaui class OJoinTableView : public vcl::Window, - public IDragTransferableListener, public DropTargetHelper { friend class OJoinMoveTabWinUndoAct; @@ -275,7 +274,6 @@ namespace dbaui virtual void Resize() override; - virtual void dragFinished( ) override; /// @note here the physical position (that can be changed while /// resizing) is used, as no scrolling can take place while resizing virtual void Command(const CommandEvent& rEvt) override; diff --git a/dbaccess/source/ui/inc/TableWindowListBox.hxx b/dbaccess/source/ui/inc/TableWindowListBox.hxx index 5ca01098266b..968ef93ab506 100644 --- a/dbaccess/source/ui/inc/TableWindowListBox.hxx +++ b/dbaccess/source/ui/inc/TableWindowListBox.hxx @@ -50,7 +50,6 @@ namespace dbaui class OTableWindowListBox : public InterimItemWindow - , public IDragTransferableListener { std::unique_ptr m_xTreeView; std::unique_ptr m_xDragDropTargetHelper; @@ -72,8 +71,6 @@ namespace dbaui virtual void LoseFocus() override; virtual void GetFocus() override; - virtual void dragFinished( ) override; - public: OTableWindowListBox(OTableWindow* pParent); virtual ~OTableWindowListBox() override; diff --git a/dbaccess/source/ui/inc/callbacks.hxx b/dbaccess/source/ui/inc/callbacks.hxx index e3a0ce03751a..8ce83ec2edb9 100644 --- a/dbaccess/source/ui/inc/callbacks.hxx +++ b/dbaccess/source/ui/inc/callbacks.hxx @@ -97,17 +97,6 @@ namespace dbaui ~IContextMenuProvider() {} }; - // IDragTransferableListener - class SAL_NO_VTABLE IDragTransferableListener - { - public: - /// called when a drag operation done with a Transferable has been finished - virtual void dragFinished( ) = 0; - - protected: - ~IDragTransferableListener() {} - }; - } // namespace dbaui #endif // INCLUDED_DBACCESS_SOURCE_UI_INC_CALLBACKS_HXX diff --git a/dbaccess/source/ui/inc/tabletree.hxx b/dbaccess/source/ui/inc/tabletree.hxx index aee9412cd4c7..93adbb1ee9c5 100644 --- a/dbaccess/source/ui/inc/tabletree.hxx +++ b/dbaccess/source/ui/inc/tabletree.hxx @@ -81,8 +81,6 @@ public: void CheckButtons(); // make the button states consistent (bottom-up) private: - void checkedButton_noBroadcast(const weld::TreeIter& rEntry); - void implEmphasize(const weld::TreeIter& rEntry, bool _bChecked, bool _bUpdateDescendants = true, bool _bUpdateAncestors = true); /** adds the given entry to our list diff --git a/dbaccess/source/ui/querydesign/JoinTableView.cxx b/dbaccess/source/ui/querydesign/JoinTableView.cxx index 5ef30e19aeda..ecd6d47aedea 100644 --- a/dbaccess/source/ui/querydesign/JoinTableView.cxx +++ b/dbaccess/source/ui/querydesign/JoinTableView.cxx @@ -1473,10 +1473,6 @@ sal_Int8 OJoinTableView::ExecuteDrop( const ExecuteDropEvent& /*_rEvt*/ ) return DND_ACTION_NONE; } -void OJoinTableView::dragFinished( ) -{ -} - void OJoinTableView::clearLayoutInformation() { m_pLastFocusTabWin = nullptr; diff --git a/dbaccess/source/ui/querydesign/TableWindowListBox.cxx b/dbaccess/source/ui/querydesign/TableWindowListBox.cxx index 4224fe1a88a9..db2af6ad9458 100644 --- a/dbaccess/source/ui/querydesign/TableWindowListBox.cxx +++ b/dbaccess/source/ui/querydesign/TableWindowListBox.cxx @@ -58,16 +58,6 @@ OTableWindowListBox::OTableWindowListBox( OTableWindow* pParent ) m_xTreeView->connect_drag_begin(LINK(this, OTableWindowListBox, DragBeginHdl)); } -void OTableWindowListBox::dragFinished( ) -{ - // first show the error msg when existing - m_pTabWin->getDesignView()->getController().showError(m_pTabWin->getDesignView()->getController().clearOccurredError()); - // second look for ui activities which should happen after d&d - if (m_nUiEvent) - Application::RemoveUserEvent(m_nUiEvent); - m_nUiEvent = Application::PostUserEvent(LINK(this, OTableWindowListBox, LookForUiHdl), nullptr, true); -} - OTableWindowListBox::~OTableWindowListBox() { disposeOnce(); -- cgit v1.2.3