From 301ff4dfb82dfd961b993aec151784bd478b4f97 Mon Sep 17 00:00:00 2001 From: Julien Nabet Date: Tue, 22 Jan 2019 20:55:31 +0100 Subject: tdf#122885: fix crash when converting odb file to Firebird 4 0x00007fffdfddf846 in (anonymous namespace)::lcl_makeStringFromBigint(std::__debug::vector > const&) (bytes=std::__debug::vector of length 3, capacity 3 = {...}) at /home/julien/lo/libreoffice/dbaccess/source/filter/hsqldb/rowinputbinary.cxx:104 5 0x00007fffdfde04e2 in dbahsql::HsqlRowInputStream::readOneRow(std::__debug::vector > const&) (this=0x7fffffff0350, nColTypes=std::__debug::vector of length 9, capacity 9 = {...}) at /home/julien/lo/libreoffice/dbaccess/source/filter/hsqldb/rowinputbinary.cxx:312 6 0x00007fffdfdf39f0 in dbahsql::HsqlBinaryNode::readRow(dbahsql::HsqlRowInputStream&, std::__debug::vector > const&, int) (this=0x7ffffffefc74, input=..., aColTypes=std::__debug::vector of length 9, capacity 9 = {...}, nIndexCount=2) at /home/julien/lo/libreoffice/dbaccess/source/filter/hsqldb/hsqlbinarynode.cxx:56 See complete bt here: https://bugs.documentfoundation.org/attachment.cgi?id=148530 Change-Id: I0b0373a81d9299fd7bf3107d2262f5836e52e459 Reviewed-on: https://gerrit.libreoffice.org/66752 Reviewed-by: Lionel Elie Mamane Tested-by: Jenkins --- dbaccess/source/filter/hsqldb/rowinputbinary.cxx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'dbaccess') diff --git a/dbaccess/source/filter/hsqldb/rowinputbinary.cxx b/dbaccess/source/filter/hsqldb/rowinputbinary.cxx index 74d8a360cc53..5a447cacb4f3 100644 --- a/dbaccess/source/filter/hsqldb/rowinputbinary.cxx +++ b/dbaccess/source/filter/hsqldb/rowinputbinary.cxx @@ -99,7 +99,7 @@ OUString lcl_makeStringFromBigint(const std::vector& bytes) byte = ~byte; // add 1 to byte array // FIXME e.g. 10000 valid ? - for (size_t i = aBytes.size() - 1; i != 0; ++i) + for (size_t i = aBytes.size() - 1; i != 0; --i) { aBytes[i] += 1; if (aBytes[i] != 0) -- cgit v1.2.3