From b8bb44161aeb6e00526a38343b63e678ce7d4a1a Mon Sep 17 00:00:00 2001 From: Mike Kaganski Date: Thu, 5 May 2022 08:25:11 +0300 Subject: tdf#146007: make sure to not hold solar mutex COM might need to forward the call to another thread (with corresponding apartment); if that thread happens to wait for solar mutex, COM call may deadlock. Change-Id: I8fcf04619cd29b678fd7ade87254b9aad2f639a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133853 Tested-by: Jenkins Reviewed-by: Mike Kaganski --- fpicker/source/win32/VistaFilePickerImpl.cxx | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/fpicker/source/win32/VistaFilePickerImpl.cxx b/fpicker/source/win32/VistaFilePickerImpl.cxx index 81732ce5cc97..741fdadb621a 100644 --- a/fpicker/source/win32/VistaFilePickerImpl.cxx +++ b/fpicker/source/win32/VistaFilePickerImpl.cxx @@ -37,6 +37,7 @@ #include #include #include +#include #include "WinImplHelper.hxx" #include @@ -962,6 +963,10 @@ void VistaFilePickerImpl::impl_sta_ShowDialogModal(Request& rRequest) HRESULT hResult = E_FAIL; try { + // tdf#146007: Make sure we don't hold solar mutex: COM may need to forward + // the execution to the main thread, and holding solar mutex could deadlock + SolarMutexGuard g; // First acquire, to avoid releaser failure + SolarMutexReleaser r; // show dialog and wait for user decision hResult = iDialog->Show(m_hParentWindow ? m_hParentWindow : choose_parent_window()); // parent window needed -- cgit v1.2.3