summaryrefslogtreecommitdiff
path: root/xmlreader
AgeCommit message (Collapse)AuthorFilesLines
2022-07-29clang-tidy modernize-pass-by-value in xmlreaderNoel Grandin1-2/+3
Change-Id: I448d3119129a864e79dbef336e46545f9aca8b25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137584 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-02Fix clang-cl -Zc:dllexportInlines- buildStephan Bergmann1-0/+2
That flag is only supported by clang-cl, not by MSVC, and c7c9f3f57a2feae5d3bc3c47104786883ed09e44 "use clang-cl's -Zc:dllexportInlines- for clang-cl builds" apparently naively assumed that it would work to build LO with clang-cl and that flag without actually trying it out, and 1040228c356d75c5228cde4d6103f9b446848e4b "My clang-cl build does not work with -Zc:dllexportInlines-" effectively disabled it completely. The way to avoid unresolved external symbols during linking of URE libraries (see the 1040228c356d75c5228cde4d6103f9b446848e4b commit message) is apparently to also build libraries that the URE libraries depend on with the flag, hence the change from gb_Library_set_is_ure_library to gb_Library_set_is_ure_library_or_dependency. For now, I only marked those additional libraries (unoil and xmlreader) that actually caused issues when linking the URE libraries. Change-Id: I3a85c73246250981cd86b7ee41f87b41f393a4b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126012 Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Tested-by: Jenkins
2021-05-14Revert "improve perf of xmlreader::Pad"Noel Grandin1-14/+11
This reverts commit de5af8315e014ce3408f66c6de3c9c4e841f8437. Reason for revert: this commit needs bounds checking before it can reland Change-Id: I686a533cc27fc4644cce918ca64bd168bba19617 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115518 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-11improve perf of xmlreader::PadNoel Grandin1-11/+14
Change-Id: I83cc88977e7c287b0f428a3e01f289179b6dbad9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115353 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-10speed up XmlReader::handleSkippedTextNoel Grandin1-3/+3
this part of config loading is fairly hot at startup, so inlining this memchr call from rtl_str_indexOfChar_WithLength shaves off 2% of my load time. Change-Id: Ia79f43179475c51d856b685f053f597919cf12af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113924 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-07Updated README.md files to represent current code / use Markdown formatHossein1-3/+3
Previously, all of the README files have been renamed to README.md and now, the contents of these files were changed to use Markdown format. Other than format inconsistency, some README.md files lacked information about modules, or were out of date. By using LibreOffice / OpenOffice wiki and other documentation websites, these files were updated. Now every README.md file has a title, and some description. The top-level README.md file is changed to add links to the modules. The result of processing the Markdown format README.md files can be seen at: https://docs.libreoffice.org/ Change-Id: Ic3b0c3c064a2498d6a435253b041df010cd7797a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113424 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-03-24Using .md extension/Markdown syntax for modules READMEHossein1-0/+0
Renaming all README files for all top level modules to README.md, applying no content change at this stage to be able to track history of the files. These files should be edited to use correct Markdown syntax later. Change-Id: I542fa3f3d32072156f16eaad2211a397cc212665 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112977 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2019-10-10Revert "Optimize getNamespaceId (xmlreader)"Julien Nabet2-15/+0
This reverts commit def00961243da0662f394bdf58b1157cfd45dfab. Finally after other tests, it doesn't improve perfs Change-Id: Icbaaf751181069dd36dba0c676a4c9a2a6c8a9f3 Reviewed-on: https://gerrit.libreoffice.org/80565 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-10-08cleanups in xmlreaderNoel Grandin1-1/+5
(*) fix order of headers (*) include the right headers in span.hxx (*) use std::memcmp instead of memcmp (*) clear entries from cache when the namespaces array is resized Change-Id: I04319bbaa84369e5470799578fadcda66a591c9f Reviewed-on: https://gerrit.libreoffice.org/80347 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-06we can use Span for the cache key hereNoel Grandin2-4/+6
Change-Id: I77894e3c5e3d68cb2a12abcc0b09f2c042664ba0 Reviewed-on: https://gerrit.libreoffice.org/80315 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-06convert equals() to operator== in xmlreader::SpanNoel Grandin1-6/+6
Change-Id: Ic6a8eae344c06be87e2bc4bf7f242a2d18ebc8ad Reviewed-on: https://gerrit.libreoffice.org/80312 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-06Optimize getNamespaceId (xmlreader)Julien Nabet1-0/+10
Adding a map to cache values allows me 20s -> 13s to start LO Change-Id: If343225def253e29696b96f223cdcb54d0d8525d Reviewed-on: https://gerrit.libreoffice.org/80290 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-02-04tdf#42949 Fix IWYU warnings in xmlreader/Gabor Kelemen3-3/+2
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I9e64ad0a20654e2b97de5b23302ce2cab1a09c00 Reviewed-on: https://gerrit.libreoffice.org/66975 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-09-15Simplify containers iterations in xmlhelp, xmlreader, xmlscript, xmlsecurityArkadiy Illarionov1-7/+6
Use range-based loop or replace with functions from std algorithm. Change-Id: I5b1859da37c2a6c6e5e70602287bfc2ada951893 Reviewed-on: https://gerrit.libreoffice.org/60463 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-24loplugin:unusedfields,can-be-const in xmlreaderNoel Grandin1-2/+2
Change-Id: I762a749b858063a1c063ee918bb6d33e06328876 Reviewed-on: https://gerrit.libreoffice.org/57852 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-23Silence -Werror=implicit-fallthrough= (upcoming GCC 8)Stephan Bergmann1-1/+1
Earlier GCC already require a similar workaround to silence -Werror=return-type ("control reaches end of non-void function") a few lines further down, so it's rather consequential that GCC now also warns about the potential fall-through here (i.e., for these warnings, GCC apparently assumes that an enum can take on all of the values from its range of values, not just those denoted by an enumerator). Change-Id: I1537a7f6975f900861225ee7a521366a5e57046a
2017-09-14clang-tidy modernize-use-emplace in variousNoel Grandin1-9/+7
Change-Id: Id1bbd3f380c17beeaab11f7140d4df1304c3d0d8 Reviewed-on: https://gerrit.libreoffice.org/41750 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-25loplugin:unusedmethodsNoel Grandin1-14/+0
Change-Id: Ia874baf21257e5fe41e104211068a2bcc50446eb Reviewed-on: https://gerrit.libreoffice.org/40391 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-21gbuild: Remove MSVC 2013 legacy codeDavid Ostrovsky1-1/+0
Uwinapi is discontinued. Change-Id: I063b4d0d8fab2d60de168e960a63b8181158ac01 Reviewed-on: https://gerrit.libreoffice.org/23198 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Tested-by: David Ostrovsky <david@ostrovsky.org>
2016-08-31convert XmlReader::State to scoped enumNoel Grandin1-14/+14
Change-Id: I8020843ad238ac3487f7f2781693ca619db5e1b3
2016-05-25Convert XmlReader::Result to scoped enumNoel Grandin1-8/+8
Change-Id: I6a0d1dcf5ae51d2ac08aacdfec50865f93e51c21 Reviewed-on: https://gerrit.libreoffice.org/25365 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-24Convert XmlReader::Text to scoped enumNoel Grandin1-3/+3
Change-Id: I4741b13fcf887a95b85886cb41f8236e128e81a2 Reviewed-on: https://gerrit.libreoffice.org/25364 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-13clang-tidy modernize-loop-convert in writerfilter to xmlsecurityNoel Grandin1-5/+5
Change-Id: I334411c6b57c028ffb41b5deb72002f9d54038c3 Reviewed-on: https://gerrit.libreoffice.org/24923 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-02cleanup: remove unused Reference.h(xx) includesJochen Nitschke1-1/+0
and unused using-declarations from Reference.h Change-Id: I297a7ae6044fa329d245ecf08fd5c4cb930f5b19 Reviewed-on: https://gerrit.libreoffice.org/23735 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-31use SAL_N_ELEMENTS in for loopsNoel Grandin1-1/+1
for with git grep -n 'for.*sizeof' Change-Id: I6211024385e03ac5eeeb38690d2c1c699e015c2f Reviewed-on: https://gerrit.libreoffice.org/23569 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-15Rename rtl::isValidCodePoint -> rtl::isUnicodeCodePointStephan Bergmann1-4/+5
...and fix its documentation, and use it throughout the code base. Change-Id: I349bc2009b1b0aa7115ea90bc6ecd0a812f63698
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann3-18/+18
Change-Id: I86546bcf9b476c73da2d6bff30ee1e56933f69c4
2014-06-17improve the inlinesimplememberfunctions clang pluginNoel Grandin1-3/+0
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-05various: remove SAL_THROW macroNoel Grandin1-2/+0
Change-Id: I9464179a736b91f5bc32eb5e5e89b3b4e3da3494
2014-05-23remove boilerplate in UNO Exception constructor callsNoel Grandin2-64/+32
Now that we have default values for Exception constructor params, remove lots of boilerplate code. Change-Id: I620bd641eecfed38e6123873b3b94aaf47922e74
2014-04-30coverity#708727 Uninitialized pointer fieldCaolán McNamara1-2/+3
Change-Id: I816f7e239f83c35666101aac057912dd7e65ecff
2014-01-23coverity#1158416 Uninitialized pointer fieldCaolán McNamara1-0/+2
Change-Id: I5c1b07bd3898e89141fe3c3c8f8b63b81513a97e
2013-12-06Zip .ui translations per UIConfig target.Matúš Kukan1-0/+14
Fix installer / scp2 to not ignore directory prefix in 'Name'. Change-Id: Ib319363c8be73a72029f1ba3833e518e15c55e29 Reviewed-on: https://gerrit.libreoffice.org/6915 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-11-11xmlreader: include <> for external includesNorbert Thiebaud3-26/+26
Change-Id: I8ee7c2155a721eedb9d54fc00a681f3a08790194
2013-06-24fdo#43460 shell,vcl,xmlreader: use isEmpty()Jelle van der Waa1-2/+2
Change-Id: Ie3d16da6c246b79c4c304b21476f84b2788f0d6e Reviewed-on: https://gerrit.libreoffice.org/4444 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-06-03re-base on ALv2 code. Includes:Michael Meeks2-42/+24
Patches contributed by Mathias Bauer gnumake4 work variously http://svn.apache.org/viewvc?view=revision&revision=1394707 http://svn.apache.org/viewvc?view=revision&revision=1394326 http://svn.apache.org/viewvc?view=revision&revision=1397337 http://svn.apache.org/viewvc?view=revision&revision=1397315 http://svn.apache.org/viewvc?view=revision&revision=1396797 Patches contributed by Andre Fischer Fixed getcsym.awk to handle #-comments that contain special regexp chars. http://svn.apache.org/viewvc?view=revision&revision=1230971 118778: Added ADDITIONAL_REPOSITORIES environment variable and its automatic setup in configure. http://svn.apache.org/viewvc?view=revision&revision=1232004 118160: Added external CoinMP library. http://svn.apache.org/viewvc?view=revision&revision=1233909 Patches contributed by Herbert Duerr #i119168# use generic LICENSE file for langpacks and sdks http://svn.apache.org/viewvc?view=revision&revision=1310178 macosxotoolhelper: need to quote perl regexp if it may contain regexp metachars http://svn.apache.org/viewvc?view=revision&revision=1183367 allow gbuild with empty sysroot on linux http://svn.apache.org/viewvc?view=revision&revision=1179186 Patches contributed by Ingo Schmidt native373: #164472# improvements for msi database http://svn.apache.org/viewvc?view=revision&revision=1167540 http://svn.apache.org/viewvc?view=revision&revision=1167539 Patches contributed by Jurgen Schmidt adapt setup package scripts to handle special DS_Store file for developer snapshot builds http://svn.apache.org/viewvc?view=revision&revision=1232430 imported patch extensions_i117681.patch http://svn.apache.org/viewvc?view=revision&revision=1172102 Patches contributed by Michael Stahl gbuild: RepositoryFixes.mk should be optional http://svn.apache.org/viewvc?view=revision&revision=1166123 xslt filter: remove the FLA horror wordml import filter: replace FLA usage with plain XSLT http://svn.apache.org/viewvc?view=revision&revision=1363727 Patch contributed by Oliver-Rainer Wittmann i#88652: applied patch, remove unicows deps http://svn.apache.org/viewvc?view=revision&revision=1177585 Remove lots of OS2 conditionals, re-extract Rhino Java, unwind cppunit pieces, cleanup Mac image bits, remove coin-mp and re-package lpsolve, Oxygen & Crystal, fixup qstart bits, expand MPLv2 subset checking. Change-Id: Iad5c8a76399620b892671633c0d8c29996db3564
2013-05-16Some string literal clean upStephan Bergmann3-67/+47
Change-Id: I108882af13fa97fa094547ec4efb468f988f337d
2013-05-06cleanup whitespaces due to RTL_CONSTASCII_USTRINGPARAM removalPhilipp Riemer1-64/+27
In e2e2cc61144cb22227eebfadff0ea24b51ccfbd0 the method was removed automatically leaving several line breaks etc. as visual noise.
2013-05-06remove usage of RTL_CONSTASCII_USTRINGPARAMLuboš Luňák1-18/+9
Mechanical removal of usage together with OUString ctor, done by compiler plugin. Change-Id: I554227f76df0dac620b1b46fca32516f78b462c5
2013-04-24gbuild: drop uses of removed packagesDavid Tardon1-2/+0
Change-Id: I400fad08c0ae7b6b34bad63693f54856867e4dac Reviewed-on: https://gerrit.libreoffice.org/3502 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-04-23execute move of global headersBjoern Michaelsen7-424/+0
see https://gerrit.libreoffice.org/#/c/3367/ and Change-Id: I00c96fa77d04b33a6f8c8cd3490dfcd9bdc9e84a for details Change-Id: I199a75bc4042af20817265d5ef85b1134a96ff5a
2013-04-22re-base on ALv2 code.Michael Meeks2-27/+20
2013-04-07mass removal of rtl:: prefixes for O(U)String*Luboš Luňák5-43/+42
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk have kept them, in order not to break external API (the automatic using declaration is LO-internal). Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-04remove HAVE_SFINAE_ANONYMOUS_BROKENLuboš Luňák1-2/+0
Since we no longer support the old Apple SDK using gcc-4.0.1, we can remove the cruft to work around its problems. Woohoo. Change-Id: Idf275e76449443f1f0314e75dab993f213a77eb7
2013-03-20use #if instead of #ifdef for testing config_xxx.hxx macrosLuboš Luňák1-1/+1
http://lists.freedesktop.org/archives/libreoffice/2013-March/047769.html Change-Id: I81ed4500878ff3193e028410a1f0205e28d17fc3
2013-03-19automated removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStringsThomas Arnhold2-36/+22
Done with a perl regex: s/OUString\s*\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/OUString\($1\)/gms Change-Id: Idf28320817cdcbea6d0f7ec06a9bf51bd2c3b3ec Reviewed-on: https://gerrit.libreoffice.org/2832 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-14remove legacy build.pl prj/build.lst files.Michael Meeks1-2/+0
2013-02-28remove all d.lstMichael Stahl1-0/+0
Change-Id: Icba4218c5f9fe89d183d25ea82a8eae52881f885
2013-02-25xmlreader does not depend on any offapi .idl filesStephan Bergmann1-1/+1
Change-Id: I5f008ba23c7f55a53d2b39cb235b27208b7743c5
2013-02-19I want HAVE_SFINAE_ANONYMOUS_BROKEN here rather than RTL_FAST_STRINGCaolán McNamara1-2/+2
Change-Id: Ie5cd55aa7ba4773f3cffbed924467787596dfc9d