summaryrefslogtreecommitdiff
path: root/xmerge
AgeCommit message (Collapse)AuthorFilesLines
2015-07-03Fix typosAndrea Gelmini1-1/+1
Change-Id: I98b4dfb0f72f315065693335e2f882bb2eed3afe Reviewed-on: https://gerrit.libreoffice.org/16713 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2015-06-23Revert "Typo: iff->if"Julien Nabet1-2/+2
This reverts commit cf92da3d6e1de14756efe3f1ee79f393a2f3787d. iff can mean "if and only if" so not a typo
2015-06-23Typo: iff->ifJulien Nabet1-2/+2
Change-Id: I3fc60856b5a56e71d70b55c89323be074bdec3b3
2015-06-15java: 'final static' to 'static final'Noel Grandin7-27/+27
this is the canonical order, and it makes the code easier to read Change-Id: I272e7f1e140296e582702b6dbf77a03eefb65470 Reviewed-on: https://gerrit.libreoffice.org/16242 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Ostrovsky <david@ostrovsky.org>
2015-06-11java:regulatize the order of 'final' and public/privateNoel Grandin1-2/+2
Make the order be 'public static' or 'private static' Just makes the code nicer to read. Change-Id: I182424bda45a2d68642e5d04c6091d268ace1fe2 Reviewed-on: https://gerrit.libreoffice.org/16202 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-02-23remove unnecessary parenthesis in return statementsNoel Grandin2-8/+8
found with $ git grep -lP 'return\s*\(\s*\w+\s*\)\s*;' Change-Id: Ic51606877a9edcadeb647c5bf17bc928b69ab60e
2014-12-19xmerge: store the original exception in the cause field properlyNoel Grandin1-13/+12
Change-Id: I154b8b80aabd824edc62a7fdd831074fcf5cb21b
2014-12-12java: fix non-public UNO implementation classesNoel Grandin1-1/+1
which I messed up in commit 70f56bc22fe952c "java: reduce scope, make member classes private" Change-Id: I817b2a571e2124f551ccd5c0d8e1099d89f0ec46
2014-12-11java: reduce visibility of fields and methodsNoel Grandin8-16/+16
found by PMD Change-Id: Id6737916b68ccbdbdeec5d314747a38410923ac6 Reviewed-on: https://gerrit.libreoffice.org/13409 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-18java: make fields final where possibleNoel Grandin23-49/+49
found by PMD Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini2-5/+5
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12java: convert fields to local variables where possibleNoel Grandin1-2/+1
found by PMD Change-Id: I05b45382b8fb1b734657ce9421a20e6ef6fbe542 Reviewed-on: https://gerrit.libreoffice.org/12376 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12java: reduce excessive code indentation levelsNoel Grandin3-52/+57
by using early return in some methods Change-Id: I3611c8c89b3a94ef7e1772d178acf065fd7fcdc7 Reviewed-on: https://gerrit.libreoffice.org/12374 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-18xmerge: use java.nio.ByteBuffer (JDK 1.4+)Robert Antoni Buj i Gelonch1-52/+16
Change-Id: I6072bb4699c9cd361e0cfe0a12b46cfc1abfe368 Reviewed-on: https://gerrit.libreoffice.org/11998 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-16java: when rethrowing, store the original exceptionNoel Grandin5-22/+23
Change-Id: I34ce000c48d2d79bfec854c8dd55d12f2bee29c7
2014-10-16xmerge: use String.formatRobert Antoni Buj i Gelonch2-38/+14
http://docs.oracle.com/javase/1.5.0/docs/api/java/lang/String.html#format(java.lang.String, java.lang.Object...) Change-Id: I98b7fca9dee870c9a1d0f9842cbb009a13537967 Reviewed-on: https://gerrit.libreoffice.org/11995 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-16java: ensure that the stream is cleaned up before the method returnsRobert Antoni Buj i Gelonch2-50/+59
Change-Id: Id3efeda2fd66173ba2f5662eaacb3629da54573d Reviewed-on: https://gerrit.libreoffice.org/11991 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-16java: always use braces for while loopsNoel Grandin2-2/+4
Change-Id: Iff896b0cace8b8305528b3b0140004ea856169ce
2014-10-16java: reduce the depth of some deeply nested if blocksNoel Grandin1-20/+12
Change-Id: I3c0c7f08d4d8ea594e72fc0d9b93d085d4ab4bf5
2014-10-13java: import from the same packageRobert Antoni Buj i Gelonch1-2/+0
Change-Id: I1bb0999783f365e20b682c3707e73c65724265c9 Reviewed-on: https://gerrit.libreoffice.org/11955 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-13xmerge: ensure that the stream is cleaned up before the method returnsRobert Antoni Buj i Gelonch1-0/+7
Change-Id: I377ae1a7b71c207313ad3468a51b1ab06b9fffd5 Reviewed-on: https://gerrit.libreoffice.org/11939 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-10xmerge: The if statement is redundantRobert Antoni Buj i Gelonch6-30/+7
Change-Id: I56c5727470c4dba9ffa7c298fb6ccea5be750f33 Reviewed-on: https://gerrit.libreoffice.org/11894 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-07java: simplify conditions involving logical negationNoel Grandin1-2/+2
Change-Id: Ib45e58273e650ef9a31dbdb5f71e995a5976f50e
2014-10-07java: remove some unnecessary intermediary object creationNoel Grandin3-3/+3
Change-Id: Id4949fa08546e710fbf9bd0c7e3bf62979f29c83
2014-10-07xmerge: reuse the value of node.getNodeName() and remove duplicated constantsRobert Antoni Buj i Gelonch3-10/+8
Change-Id: Ia835139496ab8e5230a09df2caf23637a5559ba4 Reviewed-on: https://gerrit.libreoffice.org/11836 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-02xmerge: reuse the value of value.indexOf and remove duplicated codeRobert Antoni Buj i Gelonch3-29/+27
Change-Id: I44d72f7d9f8c58436657ea1517d8eb76332abb4b Reviewed-on: https://gerrit.libreoffice.org/11747 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-02xmerge: Converting ArrayList to ArrayRobert Antoni Buj i Gelonch1-3/+1
Change-Id: I67c70ce05d35c8f40bea153499820e7e52c2ff08 Reviewed-on: https://gerrit.libreoffice.org/11748 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-29fix more Java1.5 incompatibilityNoel Grandin2-3/+9
Change-Id: I32881e06d278df6319822a5ecf282aa97cf24bc8
2014-09-25java: when rethrowing exceptions, store the original causeNoel Grandin2-12/+6
so that we get a nice complete stacktrace when it hits the final handler Change-Id: Iec4fcc15a2a25c55f591b5e069dce3d010197a90
2014-09-11xmerge: Convert a primitive type into a stringrbuj1-1/+1
Avoid unnecessary temporaries when converting primitive data types into a String. Change-Id: Ied91859e756ff392b1a0ea8d6d889afae11b2f8d Reviewed-on: https://gerrit.libreoffice.org/11366 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-09xmerge: use String.length()==0 instead of String.equals(empty string)rbuj2-2/+2
Change-Id: I41b64c2dccad41193e15b6be2e62ce9dd63e0c3a Reviewed-on: https://gerrit.libreoffice.org/11358 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-09-09xmerge: use a character literalrbuj6-11/+11
Change-Id: I99168faf1ad346f4e18495c15b5bad79fd16818f Reviewed-on: https://gerrit.libreoffice.org/11357 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-09-08xmerge: Integer & Boolean Parsingrbuj4-22/+7
Change-Id: I9553121a7faf10799c9d9a53336470cb2634c4ee Reviewed-on: https://gerrit.libreoffice.org/11329 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-04xmerge: javadoc maintenance and minor code formattingrbuj96-4521/+3496
Javadoc: * Replaces <code>..</code> tags with {@code ..}. * Replaces HTML entities with {@literal ..} * Removes <p>..</p> tags in the first sentence. * Reduces code snippet spacing. * Adds tables. * Uses only one space after a comment delimiter. * Adjusts the margins. Minor code formating: * Removes some extra blank lines (very few). * Fixes some indentations (very few). * Adjusts the margins in some method headers (very few). Change-Id: I01bd9df58e4cb41bc3a38a2b2d3d7d2612081c32 Reviewed-on: https://gerrit.libreoffice.org/11202 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-03xmerge: replace package.html with package-info.javarbuj20-583/+502
Change-Id: Ia11a2da8ffd9be6942e52b84937d3aa15a1ecb82 Reviewed-on: https://gerrit.libreoffice.org/11221 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-08-30xmerge: fix javadoc errors for JDK 8rbuj9-70/+76
Change-Id: Ic8352b7460c36155215d25339650ede40735e65d Reviewed-on: https://gerrit.libreoffice.org/11189 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-08-20java: don't catch and then just rethrow an exceptionNoel Grandin1-6/+0
without doing anything else useful Change-Id: I5803d84d46e0a70e1759f2202e2c2273087f8723
2014-08-20java: remove modifiers implied by the contextNoel Grandin15-112/+102
found by PMD Change-Id: I04cbf986ddbcffff987784f381b8a9f52f1b3f31
2014-08-20java: avoid unnecessary comparisons in boolean expressionsNoel Grandin5-10/+10
i.e. stuff like "x == true" Change-Id: Ib82a4a30e736df392405332fa197b588482cffcf
2014-08-20no need to instantiate an object to get it's classNoel Grandin1-2/+1
Change-Id: I7b1f8d4621a3db9094bb61753218db3646c33e34
2014-08-20xmerge: Convert a primitive type into a stringrbuj3-7/+5
Avoid unnecessary temporaries when converting primitive data types into a String. Change-Id: If361383be52d8258be7c8c9bddf3ba05d5ca92c1 Reviewed-on: https://gerrit.libreoffice.org/11026 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-08-19java: no need to instantiate String objects directlyNoel Grandin6-9/+9
Change-Id: I7610774c94bf673ed3b574ffce04c4ee6ca93c03
2014-08-19java: use 'Integer.valueOf' instead of 'new Integer'Noel Grandin6-9/+9
Change-Id: Ia8befb8d69914ce971174fc5f2ffc0e2f506a940
2014-08-19java: classes in java.lang package do not need to be fully qualifiedNoel Grandin3-7/+6
Change-Id: I7b18f62336c3a8ca4c538b30ce04c99f202a4756
2014-08-19java: remove unused methodsNoel Grandin1-32/+0
Change-Id: Ibb905e6f3e7d92a0e558f1f6562e5b472cd2717b
2014-08-14java: remove unused importsNoel Grandin3-9/+0
Change-Id: Ic60b30141fd1dc61acfb97b811aec680a2ab9c22
2014-08-13remove dead java constantsNoel Grandin1-70/+0
found by UCDetector Change-Id: I1f8f5ba4f3ab1a1ef134dd0988f913dab7501351
2014-08-13java: remove dead methodsNoel Grandin19-580/+14
found by UCDetector Change-Id: I219caa8e680dba5a395541a778df6144841c4dde
2014-08-13java: remove unused fieldsNoel Grandin7-42/+21
found by UCDetector Change-Id: I4a7c56a9918054c23469de5680658e7b501f0165
2014-08-13java: reduce scope, make some methods privateNoel Grandin15-26/+26
found by UCDetector Change-Id: Ib1425edde146193a65c242dc159b7e3fbf0e4a2e
generated by cgit v1.2.3 (git 2.39.1) at 2024-11-24 01:47:34 +0000