summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)AuthorFilesLines
2016-06-03Teach loplugin:stringconstant about RTL_CONSTASCII_STRINGPARAMStephan Bergmann1-36/+36
Change-Id: I8ff0e104aad045f3835dc8facc760a8339b1d088
2016-06-03Clean up Windows error reporting a bitTor Lillqvist4-49/+23
We have comphelper::WindowsErrorString(), so use it, in SAL_WARNs, right where an error happens. Get rid of the fairly unhelpful ImplWriteLastError() function. Avoid duplicated error reporting. Change-Id: I83374a65980b7c0ffa35fc493b4fb1f2e94f0dbb
2016-06-03tdf#100193: Check earlier and harder whether OpenGL is good enough on WindowsTor Lillqvist2-9/+61
If we notice early enough that OpenGL is broken or not good enough, we can disable it and terminate with EXITHELPER_NORMAL_RESTART. Not beautiful, but works. The earlier added check whether shader compilation and loading of shader program binaries from a cached file works is now just one of the aspects that are checked. Change-Id: I9382576cc607f1916f6002f1fa78a62e23180fe3
2016-06-03Convert NupOrderType to scoped enumNoel Grandin4-28/+15
Change-Id: If04deb1bc080679d1b71d155f7568ab89cb5888d Reviewed-on: https://gerrit.libreoffice.org/25765 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-03Convert whichOfficePath to scoped enumNoel Grandin2-10/+10
Change-Id: If31c00ac8820e6dfce5047e997c35f5e1878db6f Reviewed-on: https://gerrit.libreoffice.org/25763 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-03Convert FontRights to scoped enumNoel Grandin1-3/+3
Change-Id: Ib46fe9dbe4b41bfe2e85e9171e8dcf7a96ccb483 Reviewed-on: https://gerrit.libreoffice.org/25717 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-03Follow-up fix (odd missing ~TheAquaA11yFocusTracker error)Stephan Bergmann4-4/+8
Change-Id: I18501185f52ab4e90d16313cba299b7501106db3
2016-06-03loplugin:refcountingStephan Bergmann2-1/+5
Change-Id: Ia7bd500728e122f1f4c7ff4c020cc067e72613ca
2016-06-02vcl: GIF import: don't use __LP64__ to check for a 64-bit systemMichael Stahl1-1/+1
__LP64__ is not defined in MSVC AMD64 builds, since it doesn't have 64-bit longs. This caused the vcl_filters_test to fail because loading the file for which that check is a work-around succeeded. Change-Id: I4df48d4b196a1d08e9bd5ef61b64ec63501037c9
2016-06-02vcl: remove pointless checkMichael Stahl1-4/+0
This would have been more useful if it checked one of the other types that use inheritance. It would also be more useful if it actually did something to report the issue instead of silently reporting success. Change-Id: I684146244d4eec15669b499e40214b8ede70741f
2016-06-02vcl: fix "sgv" import filter on 64-bit MSVCMichael Stahl2-133/+216
This filter reads entire structs at a time from the SvStream, including structs that are derived from other structs. This happens to work fine with GCC by chance, but MSVC AMD64 by default aligns structs to 8 bytes, and that means if sizeof(super-stuct) = 20 then 4 bytes of padding are inserted and that ruins the import. This causes vcl_filters_test to go into an infinite loop reading SaveAsPicture.sgv. Fix this by reading each member of the structs separately, which also means that the filter doesn't need to byte-swap every member on big-endian platforms since SvStream methods already do that. Change-Id: I237725dbcde5232006728179e645776fcb79cac3
2016-06-02these overrides just call only their parent versionCaolán McNamara2-5/+4
looks like the sort of simplfication that could be automated Change-Id: I29ce13fe1b98e99be096e44239b971f6971c5f98
2016-06-02Accept also hex vendor id in hex in opengl_blacklist_windows.xmlTor Lillqvist3-3/+18
(And not just names from the hardcoded list.) Surely we want it to be possible to add a blacklist entry for a hitherto unhandled vendor to the file at a user site without having to modify the parsing code and rebuilding LO. Change-Id: I01ca45cb91df06e1634a565b3e469fb85fe4e116
2016-06-02tdf#99919: Blacklist that specific vendor, version, and device combinationTor Lillqvist1-0/+4
Change-Id: I12b45b499bdf2041d6b50fa85e30612916462b3e
2016-06-02fix debugging buildCaolán McNamara1-1/+1
Change-Id: Idb1b1d50260a969446ac1385f93163bea6cf6b04
2016-06-02tdf#100187 fix division by zero in comboFragmentShaderTomaž Vajngerl1-1/+1
When feather is 0.0 (used when anti-aliasing is disabled) then we get a "division by zero" situation. As per OpenGL secs. the shader should not fail in this situation however the result is undetermined. Most GPUs handled this correctly but on some the lines didn't draw at all. This should fix this issue. Change-Id: I56ca2f10c393491807321969c72085ef7690d16a
2016-06-02tdf#96099 Reduce number of typedefs used for trivial container typeskrishna keshav1-7/+5
Removed "typedef" for std::unordered_map<int, int> in vcl/win/gdi/winlayout.cxx Change-Id: I2798a21be61d6ceee680762d4145a2ae1fc1242d Reviewed-on: https://gerrit.libreoffice.org/25644 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-02loplugin:unusedfieldsNoel Grandin4-4/+0
Change-Id: Ieed5f4d9411478d2568b8e5f4bbe0782bd1d309d Reviewed-on: https://gerrit.libreoffice.org/25724 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-011 bit masks need each byte to be reversedCaolán McNamara1-1/+1
to match CAIRO_FORMAT_A1 ordering as seen under gtk3 with animated gif of tdf#99519 Change-Id: I62d7197522ad779683e46837ddeabbfe21f3717b
2016-06-01loplugin:unusedmethodsNoel Grandin3-41/+0
Change-Id: Ia7981447e96d9ac87526ad1276585ab3077d7f08 Reviewed-on: https://gerrit.libreoffice.org/25707 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-01Convert printer enums to scoped enumsNoel Grandin3-8/+8
Change-Id: Ic0f9d57181809b3fef3abbad462456fc2d5ced55 Reviewed-on: https://gerrit.libreoffice.org/25719 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-01Convert VCL_MESSAGE to scoped enumNoel Grandin3-13/+13
Change-Id: I976536849fa5585c96cee23b660c56d3d0116933 Reviewed-on: https://gerrit.libreoffice.org/25720 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-31tdf#100159: Remove (harmless) duplicate callTor Lillqvist1-2/+1
Change-Id: I3a836f5d401aaf93154182e6ed195dbc82fc058e
2016-05-31tdf#100159: Use shader preambles as needed, add missing shader combinationsTor Lillqvist1-2/+13
Some shaders are in some cases (or always?) compiled with a preamble, so add that then as applicable when compiling and caching them in advance. Add a few shader combinations that I hadn't noticed. Change-Id: Ib66027e03a36cd4b161fe9f57ceaa338f9fb042d
2016-05-31tdf#100092: Deterministic scheduling to prevent unpredictable behavior.Jan Holesovsky2-1/+29
Low priority idles can fire more or less randomly, and consequently two consequent runs of LibreOffice differ in the amount of the idles that have been performed during an operation. This commit adds a possibility to turn on a 'deterministic mode' where two subsequent runs of LibreOffice trigger about the same amount of events when they perform the same set of operations. Change-Id: I92566ef4eee20e7d604cfd48f01c4df30c77e653
2016-05-31gtk3: crash on reusing a popup menu that has a sub menuCaolán McNamara2-0/+16
Typically popup menus are created froms scratch each time, which is why this wasn't a common problem. To reproduce, under gtk3, set a template as default in the template manager, reset it using dropdown, now set another template as default, and reopen the menu.. it crashes Change-Id: I6107fbd921ada71ef7d676031651deb4b1b2d2fb
2016-05-31It is EXITHELPER_NORMAL_RESTART that we wantTor Lillqvist1-1/+1
Change-Id: Ica1d68dcdd98aef061a2bed0b5389cef327e1ca5
2016-05-31Resolves: tdf#92695 protect both branches against missing ToolItemCaolán McNamara1-1/+1
Change-Id: Ide54fddf7b217e65a405bd80853d5302a419f046
2016-05-31Related: tdf#92695 we already have ImplGetItem from mnHighItemId hereCaolán McNamara1-8/+7
no logic change intended Change-Id: Ia53a21db56c857e1274c60f846fc955fef9e3dfb
2016-05-31Related: tdf#92695 gtk3 only activate/deactive submenus, not the toplevelCaolán McNamara2-4/+4
Change-Id: I5ce7ae39e7db62551733a005f3163ebfbb027af6
2016-05-31Convert ControlType to scoped enumNoel Grandin32-692/+698
Change-Id: Iaa13c3e7030296a97bab144103745867d43b4b19 Reviewed-on: https://gerrit.libreoffice.org/25554 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-31Convert RSC_TOOLBOXITEM to scoped enumNoel Grandin1-22/+11
Change-Id: Ic90b6950016417d5f57963ab69fd20905a943bb7 Reviewed-on: https://gerrit.libreoffice.org/25683 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-31Convert ToolBoxLayoutMode to scoped enumNoel Grandin1-4/+4
Change-Id: I95b2432fc9f4df8d055227331a44151af4d773ab Reviewed-on: https://gerrit.libreoffice.org/25672 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-31loplugin:unusedmethodsNoel Grandin4-80/+0
Change-Id: Ifeb818227a960cab8fd2e8e7352468efbfe1232c Reviewed-on: https://gerrit.libreoffice.org/25668 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-31Convert PrinterSupport to scoped enumNoel Grandin3-12/+12
Change-Id: I2bde7261b8e8f31e6dd5a02cd4130156a04b8a7f Reviewed-on: https://gerrit.libreoffice.org/25657 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-31Convert GfxLinkType to scoped enumNoel Grandin6-40/+40
Change-Id: Iae074ef0927a55f1fbf401cb66f4f183213f547c Reviewed-on: https://gerrit.libreoffice.org/25656 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-30tdf#100068: Initial implementation of ScreenshotIdKatarina Behrens1-0/+5
it's the same as HelpId in default implementation and extended with '=?config=foo' string otherwise, depending on different configurations the dialog/tabpage can have (e.g. different widgets hidden/shown) Change-Id: I01312a5a88ef7ba784bca315b336420cdb63c8dc Reviewed-on: https://gerrit.libreoffice.org/25455 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-05-30replace ImplConvertMenuString nowCaolán McNamara1-10/+5
Change-Id: Ib68b711fb98a917c2d40d0a659353e3983a3766e
2016-05-30move the one single use of EnableMenuStrings to its call siteCaolán McNamara2-7/+1
Change-Id: Ie5087f564c024cae526757ed1445c97113e8a68e
2016-05-30On Windows, compile OpenGL shaders in advance and disable on failureTor Lillqvist1-0/+99
If the shader compilation or loading of an already compiled shader fails, disable OpenGL in the registry and exit with the EXITHELPER_CRASH_WITH_RESTART status. The wrapper process will thus run soffice.bin once more, and this time OpenGL will not be used. Change-Id: I3cc4a615f00a8a1adb584493861e4956c83cec32
2016-05-30loplugin:passstuffbyrefStephan Bergmann1-1/+1
Change-Id: If5c3c92eb2828348cda165d72147d7a570af59f8
2016-05-30Resolves: tdf#100097 dbaccess self-dnd depends on getting its own transferableCaolán McNamara4-9/+41
on drop that it set on drag. It does some uno tunnel foo to drag the data it needs back out of it in some grotesque fashion. So we have to follow the same style of hackery as under MacOSX to detect on drop that there is an active drag started by ourself and so use that active drag's transferable as the source transferable for the drop, rather that use the intermediate universal GtkDnDTransferable. Change-Id: I3c3a94416db908603bde8f15dc5b1c9d726b8dbd
2016-05-30this signalIMPreeditChanged is a cnp from gtk2 implCaolán McNamara1-10/+1
Change-Id: Ib2e624af2e07b28a2e2ca0e3a0a16f3fe453aeaa
2016-05-30Convert WINDOW flags to scoped enumNoel Grandin1-18/+13
Change-Id: I952fcc940cfe4daca5a810a406a2b8ecd3bd6f47 Reviewed-on: https://gerrit.libreoffice.org/25582 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-30Convert RSC_TOOLBOX to scoped enumNoel Grandin1-28/+5
and drop unused (in .src files) constants Change-Id: I1ef085d128893dc3234592e248451f248efb08ba Reviewed-on: https://gerrit.libreoffice.org/25581 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-30tdf#94205 Use o3tl::make_unique instead of new + std::movekrishna keshav1-3/+3
removed std::unique_ptr and std::move to make_unique in vcl/opengl/FixedTextureAtlas.cxx Change-Id: I7cbff152c3daae68a18ec08607cac030a1f4af8e Reviewed-on: https://gerrit.libreoffice.org/25613 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-05-30Convert FontRelief to scoped enumNoel Grandin4-10/+10
Change-Id: I545c83d742db27f1a004b66e5eb1ef768f62e011 Reviewed-on: https://gerrit.libreoffice.org/25626 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-30Convert SelectionMode to scoped enumNoel Grandin2-12/+12
Change-Id: I86c435de3918540cb54a0cb24568e58456c2f9d1 Reviewed-on: https://gerrit.libreoffice.org/25611 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-30Convert ApplicationEvent::Type to scoped enumNoel Grandin2-6/+6
Change-Id: Ie65951d5fd1e155e3d3b36d4725792fb95fb9a52 Reviewed-on: https://gerrit.libreoffice.org/25608 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-30Convert DialogCancelMode to scoped enumNoel Grandin2-5/+5
Change-Id: I7aca03334c6609a8729bbc88ada6ecce4309c21d Reviewed-on: https://gerrit.libreoffice.org/25607 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-12-02 06:51:34 +0000