summaryrefslogtreecommitdiff
path: root/vcl/osx
AgeCommit message (Collapse)AuthorFilesLines
2015-09-11vcl: tdf#88206 replace cppu::WeakImplHelper* etc.Takeshi Abe10-17/+16
with the variadic variants. Change-Id: I4499569f73b04cc7444787d51bf804c090a5c951 Reviewed-on: https://gerrit.libreoffice.org/18478 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-09-02tdf#93867 - clear current GL context before thread switch.Michael Meeks1-1/+1
Fixes regression from otherwise a nice cleanup in: d20092259c7ea63885a539f911788715f8147ee9 Also get polarity of debug logging only with a context right. Change-Id: Id322471f01e5656e758aefc57b0d4d5ad073ec54
2015-08-31loplugin:stringconstant: OUStringBuffer: appendAscii -> appendStephan Bergmann1-1/+1
Change-Id: I69c2c27af718b1d3ff35348a69d8b57914e5ae82
2015-08-28Revert "tdf#93530 - the VCL GDI flushing abstraction should glFlush too."Michael Meeks1-5/+0
This reverts commit e16e64dd862c8f386f80de43ad68e831e169d49d. I somehow forgot that glFlush is context specific, (gl always gets me that way).
2015-08-26tdf#93530 - the VCL GDI flushing abstraction should glFlush too.Michael Meeks1-0/+5
Change-Id: I45cb0e62278d8c3154ae8ad54ca4c93b3e177969 Reviewed-on: https://gerrit.libreoffice.org/18030 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-08-23loplugin:defaultparamsStephan Bergmann1-2/+2
Change-Id: I0db404b84f62db9636fa30f9af1b9cc0d70a2624
2015-08-19Consolidate isFileUrl checksStephan Bergmann1-1/+2
Change-Id: I1b74fdfaa09c4d0d6c296253958e83e78b546a9a
2015-08-13Remove #ifdef ENABLE_TRACING codeStephan Bergmann1-4/+0
...assumming nobody actively uses it for debugging anymore, anyway Change-Id: I097c0cca791a48844550be4c326fa2483a3df231
2015-08-13kill YIELD_GUARD macroNorbert Thiebaud6-67/+77
Change-Id: I81990df584255f4a286cd078bcf15917c00ad504 Reviewed-on: https://gerrit.libreoffice.org/17687 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-05loplugin:unusedmethodsNoel Grandin1-5/+0
Change-Id: I6801618efb5a66d24156fa429e026acb6ca03aba Reviewed-on: https://gerrit.libreoffice.org/17506 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-04loplugin:refcountingStephan Bergmann1-3/+1
Change-Id: I8471af77361364ce677f7a31dda78168909dea90
2015-07-22remove some unused constantsNoel Grandin1-9/+0
Change-Id: I8742db77a0cfd99257584d830162c1c7126da263 Reviewed-on: https://gerrit.libreoffice.org/17283 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-10do not include boost/utility.hppMichael Stahl5-5/+5
It just includes a bunch of other boost headers; mostly we need boost/noncopyable.hpp so include that directly. This eliminates 831 MB(!) of boost/preprocessor/seq/fold_left.hpp completely, which is the 2nd biggest header after ustring.hxx. Change-Id: I3df55770adcb46e56f389af828e8ba80da2dc1f2
2015-07-04Fix typosAndrea Gelmini2-2/+2
Change-Id: Id9296115f30858e7fd470a199e59343a96d7deec Reviewed-on: https://gerrit.libreoffice.org/16712 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2015-06-26vcl: fix Win32 deadlocks from SolarMutexReleaserMichael Stahl1-1/+3
To create and destroy thread-affine Win32 Windows and DCs, non-main threads SendMessage() special messages like SAL_MSG_CREATEFRAME. The main thread must handle these messages and return the result to un-block the other thread. This works fine as long as the main thread is in its message loop anyway and blocked on GetMessage(); however if the main blocks trying to acquire the SolarMutex that is held by the sending thread, deadlock results. In order to work around this, there is some peculiar code in ImplSalYieldMutexAcquireWithWait() to avoid blocking the main thread on mpSalYieldMutex but instead block in GetMessage(). The crucial detail is that GetMessage() will immediately dispatch any message sent via SendMessage(), which avoids the deadlock. https://msdn.microsoft.com/en-us/library/windows/desktop/ms644936.aspx https://msdn.microsoft.com/en-us/library/windows/desktop/ms644927.aspx Most of the Win32 WndProc that acquire SolarMutex do so via ImplSalYieldMutexAcquireWithWait(), but the main thread may also temporarily drop SolarMutex and re-aquire it with the questionable SolarMutexReleaser hack, which calls ImplSalAcquireYieldMutex() instead, which blocks on mpSalYieldMutex. Fix SolarMutexReleaser to call a new function Application::ReAcquireSolarMutex() that does the right thing here: acquire SolarMutex via ImplSalYieldMutexAcquireWithWait(). It turns out that this problem was already fixed before in commit 6a8fd4c76a969ac98d1aff91ff7442f43aee0006 but the problem was insufficiently documented in the commit and it introduced the bug that Application::Reschedule() was called without having the SolarMutex locked, which caused timers to run without SolarMutex, so the commit was reverted in 1ef1781390845d03b6e1518bbac81b818be62f3d. Change-Id: I60aae555a9ee3c6390f584feddbc6b3cb7de0250
2015-06-15cppcheck:redundantAssignmentNoel Grandin1-2/+1
Change-Id: I1167d0ce6b6f6e48309d0551c1d2a283d79546a7
2015-06-15Fix typosAndrea Gelmini2-2/+2
Change-Id: Id05ea8cf8aed878bedfe73c274df3c67b64bad37 Reviewed-on: https://gerrit.libreoffice.org/16263 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-11convert 'it.begin() == it.end()' to 'it.empty()'Noel Grandin1-2/+2
Change-Id: I244a9eb6bce6b1c649653ec38ebb9a39f8b4c145 Reviewed-on: https://gerrit.libreoffice.org/16212 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-10loplugin:bodynotinblockStephan Bergmann1-2/+2
Change-Id: I97d74eebcb45f413dbc73ab96db447228eeb158f
2015-06-10WaE: 'convertScreenToBase:' is deprecated: first deprecated in OS X 10.7Tor Lillqvist1-3/+3
Change-Id: Ic25e9aca7a2a61ac677720427fae7a18a8a179fa
2015-06-10WaE: null passed to a callee that requires a non-null argumentTor Lillqvist1-2/+2
Let's hope passing an empty NSDictionary works fine. Change-Id: I90a9b09d421ae8cd202b602db97b2c08b149fd07
2015-06-09WaE: null passed to a callee that requires a non-null argumentTor Lillqvist1-1/+1
But actually I strongly suspect that this is dead code. [AquaA11yTextWrapper rTFForRangeAttributeForElement:forParameter:] is called only from [AquaA11yWrapper rTFForRangeAttributeForParameter:], and that is not called from our code, nor do I see any mention of either rTFForRangeAttributeForElement or rTFForRangeAttributeForParameter in documentation or when googling. The NSView documentation does talk about accessibilityRTFForRange, though. Could this be some copy/paste error since initial commit, code that has never been tested? Would not surprise me a bit. Change-Id: Ia1351c293e51e0b75d8b222f78ea19f7801a7c18
2015-06-08loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann4-7/+7
Change-Id: I07bf1403e6b992807541a499b786d47f835b2f81
2015-06-02loplugin:loopvartoosmallStephan Bergmann1-1/+1
Change-Id: I08c484c54e27c55157836d68a28d2a0e580499d9
2015-05-27convert EXTTEXTINPUT constants to scoped enumNoel Grandin1-1/+1
Change-Id: I1bb4ff2c13eaa2a9da3e32963ac0802e947e18d9
2015-05-25cppcheck: noExplicitConstructorCaolán McNamara1-1/+1
Change-Id: I62076450ab77472bfd09b3fb9824f54b6ea1e0f7
2015-05-23Remove include stdio (part6)Julien Nabet2-2/+0
Change-Id: I4dde46c81b36b318710e32c8f420dff8d9c2e655 Reviewed-on: https://gerrit.libreoffice.org/15879 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2015-05-23Don't do any magic LO OS X application stuff in a LOKit clientTor Lillqvist1-0/+5
Change-Id: If6b6c3e48c7d0681958ff0e2afe0b0be5f6ee1ab
2015-05-22convert constants in include/vcl/settings.hxx to scoped enumsNoel Grandin1-2/+2
Change-Id: I2a110c017f13eca6ddbd70ef3ed195d24adef0a3 Reviewed-on: https://gerrit.libreoffice.org/15828 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-05-22convert POINTER constants to scoped enumNoel Grandin2-123/+122
Change-Id: Iea29ce5fd6c620535197d3ca8538335078430e19 Reviewed-on: https://gerrit.libreoffice.org/15825 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-05-21convert TABITEM constants to scoped enumNoel Grandin1-8/+8
Change-Id: Ia16127a7d97ef7db59bd2b0e6b8d14d8625bc526 Reviewed-on: https://gerrit.libreoffice.org/15827 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-05-20convert PRINT_CAPABILITIES constants to scoped enumNoel Grandin1-12/+12
Change-Id: Ib8750a7acaf038476b0a5307e4a8a0bc3bf16015 Reviewed-on: https://gerrit.libreoffice.org/15824 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-05-20error: assigning to 'PrintQueueFlags' from incompatible type 'int'David Tardon1-1/+1
Change-Id: I2c307ebe78935ceb19ad0c80b441d30c138ec84a
2015-05-20convert DRAWMODE constants to scoped enumNoel Grandin1-2/+2
Change-Id: I36cbe8057d09226f8b302963bdd94dc5600b686f
2015-05-17loplugin:cstylecastStephan Bergmann1-2/+2
Change-Id: I7bfd93746dee16cd8ef31de339cccef23fe72c2b
2015-05-15gtk3: render native menubar and menubaritemsCaolán McNamara1-0/+1
this needs the addition of a new MenuBarHighlightTextColor which defaults to MenuHighlightTextColor on other platforms Change-Id: Id0550294f1778229cbbe154857ba16c629dc5a87
2015-05-14convert INPUTCONTEXT_ constants to scoped enumNoel Grandin2-4/+4
Change-Id: I5b99e42a3e85527b27d515c468d2ed66386fc9df
2015-05-13fix OSX buildNoel Grandin1-1/+1
after my commit facc91ab4a3f25b3290408c7083ed4c09dd8d759 "convert FLOATWIN_POPUPMODE constants to scoped enum" Change-Id: I5c2264eb2bab9ace89a72adecc840bc5d9d80b9d
2015-05-13fix OSX build (take 3)Noel Grandin1-1/+1
after my commit 7ac403aa7cb2bd531245280d88bdc9fe6553c711 "convert FRAME_DRAW constants to scoped enum" Change-Id: If30425e329b13f971723d007086638abdb06865f
2015-05-13fix OSX build (take 2)Noel Grandin1-2/+3
after my commit 7ac403aa7cb2bd531245280d88bdc9fe6553c711 "convert FRAME_DRAW constants to scoped enum" Change-Id: I9aa8b267b5ca8f1ffaf2302c91d337f0906089f8
2015-05-13fix OSX buildNoel Grandin1-2/+2
after my commit 7ac403aa7cb2bd531245280d88bdc9fe6553c711 "convert FRAME_DRAW constants to scoped enum" Change-Id: Id76d76d5549cd09b35b1d9e8fb68c9549f9fd3a9
2015-05-13convert FRAME_DRAW constants to scoped enumNoel Grandin1-3/+3
Change-Id: I98e52aa56ec063ecc8f3d10baef65eb293c726bf
2015-05-11convert COMMAND_ constants to scoped enumNoel Grandin1-1/+1
Change-Id: I88e67f89dbbab0646e8f106dfeb32c6ee1bb0b95 Reviewed-on: https://gerrit.libreoffice.org/15671 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-05-11invoke sal_detail_deinitialized() on MacOSX tooNorbert Thiebaud1-1/+7
LibreOffice.app on Mac, eventually call NSApplicationMain() which never return.. so the sal_detail_deinitialize() call intented by SAL_IMPLEMENT_MAIN*() is bypassed. This will attempt to call it, as late as possible in the NSApplication lifecycle. Change-Id: I5cb63bfaeafb784a0fee356ff843b332d8e31932 Reviewed-on: https://gerrit.libreoffice.org/15684 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2015-05-11loplugin:staticmethodsStephan Bergmann5-49/+46
Change-Id: If28afc6a2936b150e6659ed84c5ecac9f4c54edc
2015-05-11Remove unused OSXTransferable::isUnicodeTextStephan Bergmann2-7/+0
Change-Id: I20fbfccc3e7799539372e72490fe5721ec009896
2015-05-10tdf#44621: Fixed drag and drop in OSX 10.7+mmeof22-6/+16
Change-Id: Iefcc529d8ffa608e26c75a445341e0b8ae11c613 Reviewed-on: https://gerrit.libreoffice.org/15683 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-05-08loplugin:staticmethodsStephan Bergmann2-3/+4
Change-Id: I186c81923857d06ac7a87caf9d5961f44b89b559
2015-05-08loplugin:staticmethodsStephan Bergmann1-2/+2
Change-Id: I1aeec1e8b00ab0f9e7ec130b6d72b69f35a304cf
2015-05-08loplugin:staticmethodsStephan Bergmann1-14/+18
Change-Id: Ie99d1dd241dc2bfa5c5ac2bff9f2330c491327bc