summaryrefslogtreecommitdiff
path: root/ucb
AgeCommit message (Collapse)AuthorFilesLines
2014-10-17coverity#1247636 Uncaught exceptionCaolán McNamara1-2/+2
Change-Id: If9d635b7345683da0bf6ef7c7b0ffba0450f5dbd
2014-10-17java: final fields that can be staticNoel Grandin1-2/+2
Change-Id: I8c06be7bc0b8a38c662209f0de72a00550e25447
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann5-11/+4
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-11coverity#983990 Uncaught exceptionCaolán McNamara2-2/+3
Change-Id: I78c58822cc92c8964e0b69f44d841c5cdb84b1bb
2014-10-11coverity#1130163 Unchecked return valueCaolán McNamara1-2/+3
Change-Id: Iffc4ba146ac8f851239e93a1ace53c6b34234824
2014-10-10coverity#1241375 Uncaught exceptionCaolán McNamara5-7/+36
and coverity#1241356 Uncaught exception coverity#1241415 Uncaught exception coverity#1241449 Uncaught exception coverity#1241146 Uncaught exception coverity#1241169 Uncaught exception coverity#1241408 Uncaught exception coverity#1241452 Uncaught exception coverity#1241443 Uncaught exception coverity#1241236 Uncaught exception coverity#1241157 Uncaught exception coverity#1241283 Uncaught exception coverity#1241409 Uncaught exception coverity#1241229 Uncaught exception coverity#1241387 Uncaught exception coverity#1241050 Uncaught exception coverity#1241371 Uncaught exception coverity#1241048 Uncaught exception coverity#1241112 Uncaught exception coverity#1241351 Uncaught exception coverity#1241370 Uncaught exception coverity#1241329 Uncaught exception coverity#1241162 Uncaught exception coverity#1241103 Uncaught exception coverity#1241342 Uncaught exception coverity#1241271 Uncaught exception coverity#1241219 Uncaught exception coverity#1241245 Uncaught exception Change-Id: I3418bb54b5c385110201a99a339eba0d0d3048f5
2014-10-08spelling: instanciated -> instantiatedNoel Grandin10-24/+24
Change-Id: I99f3010e30f81786b938dc11736ea1597cd5530d
2014-10-02remove HAVE_GCC_PRAGMA_DIAGNOSTIC_SCOPE check and macroMichael Stahl2-4/+4
This is supported in GCC 4.6.0 already: https://gcc.gnu.org/onlinedocs/gcc-4.6.0/gcc/Diagnostic-Pragmas.html Change-Id: I2f67e588eea3a323a2e9c81e39e56ab2e715a817
2014-10-02remove HAVE_GCC_PRAGMA_DIAGNOSTIC_MODIFY check and macroMichael Stahl2-3/+3
This has been supported by GCC and clang for a very long time. Change-Id: I410a2b39004c932003f8cbefe935aedb109b1163
2014-10-01Remove leftover SAL_WNODEPRECATED_DECLARATIONS_PUSH/POPStephan Bergmann1-2/+0
...from times when code used std::auto_ptr. Change-Id: Ia4eca8b0b95a8846886884404009e895daba8a22
2014-10-01ucb: std::auto_ptr -> std::unique_ptrStephan Bergmann13-85/+38
Change-Id: I779b7a172cecd927f7d18fcbbc0f898f18089d0a
2014-10-01Fix warnings in ucb/source/ucp/webdav/ (--with-webdav=serf)Stephan Bergmann10-80/+80
Change-Id: I6e45a8b00952dc3ef54f29536cf333bfdcee787d
2014-10-01Tired of seing changes made to effectively dead workben codeStephan Bergmann13-3635/+0
Change-Id: I437fdceedac57bbeea7fd2a5fb7098bb71e0b259
2014-10-01fdo#82577: Handle TimeNoel Grandin1-4/+4
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11 Time typedef. Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866 Reviewed-on: https://gerrit.libreoffice.org/11684 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-29loplugin: cstylecastNoel Grandin2-24/+24
Change-Id: Iea517d2287bded4a702c73dfdd1f182023425d67
2014-09-25coverity#1240266 Logically dead codeCaolán McNamara1-4/+0
Change-Id: I97256c687c6d56beef2c3664bbba8c43f685228b
2014-09-23fdo#82577: Handle WindowNoel Grandin1-3/+3
Put the VCL Window class in the vcl namespace. Avoids clash with the X11 Window typedef. Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-18fdo#83512 Make use of OUStringHash and OStringHashDaniel Sikeler4-74/+4
Change-Id: I33cafe68c798e3d54943ea1790fa4e73f85e525d Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-09-12ucb: prevent out of bound access in OUStringNorbert Thiebaud1-1/+1
Change-Id: I451bf13cbf39ec13152d083a6a6728cd043f9fbd
2014-09-11ucb: sal_Bool -> boolStephan Bergmann6-9/+9
Change-Id: I333ffa13159eac5cc53c9f3985dde5a33daf8067
2014-09-10fdo#55380 replaced use of obsolete interfacesDaniel Sikeler2-18/+18
Change-Id: I94fed6a9361f21457b3e631efffc0db833068aef Reviewed-on: https://gerrit.libreoffice.org/11256 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-08-28Fix *_component_getFactory function typeStephan Bergmann1-2/+2
Change-Id: I6b7a9e15da83f1d53a5e59d26b643c363e652619
2014-08-25set names on a bunch more threads...Michael Stahl1-0/+2
Change-Id: I4c2f2f0bcce52839033876ec991529721e06a3c8
2014-08-19java: use 'Short.valueOf' instead of 'new Short'Noel Grandin1-1/+1
Change-Id: Icef19ef61ee0af2dd3bda527263934006271f219
2014-08-19java: use 'Integer.valueOf' instead of 'new Integer'Noel Grandin1-1/+1
Change-Id: Ia8befb8d69914ce971174fc5f2ffc0e2f506a940
2014-08-19java: classes in java.lang package do not need to be fully qualifiedNoel Grandin1-1/+1
Change-Id: I7b18f62336c3a8ca4c538b30ce04c99f202a4756
2014-08-14java: remove unused importsNoel Grandin3-3/+0
Change-Id: Ic60b30141fd1dc61acfb97b811aec680a2ab9c22
2014-08-14java: remove commented out codeNoel Grandin2-25/+0
Change-Id: I05c907a38b562231e968c17f14e09ef80e0a6ed1
2014-08-13java: remove unused interfacesNoel Grandin1-4/+0
found by UCDetector Change-Id: Ide8b3b5c9969048aff84eed16b9eea096abad349
2014-08-13java: remove unused fieldsNoel Grandin3-4/+4
found by UCDetector Change-Id: I4a7c56a9918054c23469de5680658e7b501f0165
2014-08-13java: reduce scope, make member classes privateNoel Grandin1-2/+2
found by UCDetector Change-Id: Ief32d078090102b14b60b35fc36542f8d4fb252b
2014-08-13java: reduce scope, make fields privateNoel Grandin9-19/+19
found by UCDetector Change-Id: I7f97e15667159cf8ee776e8f32fdcdec8ec00ed6
2014-08-12java: remove useless javadoc tagsNoel Grandin1-8/+0
that are not conveying any useful information Change-Id: Ic37934b8cc376fcdcb3d295232452f411dfd43b1
2014-08-12java: add @Override annotation to overriding methodsNoel Grandin2-0/+3
Change-Id: I086964c6f6ce52c60c52b6dbc445d3c21d22c80a
2014-08-08java: variable cannot be nullNoel Grandin1-14/+9
remove null check where null-analyis reveals the variable cannot be null Change-Id: Ied0a24665514bbf68c2ed5f15af9e5c2232a8033
2014-08-08java: remove unnecessary semi-colonsNoel Grandin1-2/+2
Change-Id: Ibeeefc6e6ee8f7bed97a02f569f239ff035d38c4
2014-08-08java: remove unused importsNoel Grandin2-5/+0
Change-Id: Idbba5bb89bee4d88ed0306d5151e238a1bc19cec
2014-08-08java: remove dead methodsNoel Grandin2-62/+0
Change-Id: I9f2e705fd603a7c8832c0f0772bee9f395380a0d
2014-08-05java: remove commented out codeNoel Grandin5-40/+0
Change-Id: I44e2043e5da23bc9421c03e550ef1d8b7ebaad36
2014-08-05java: remove unused fieldsNoel Grandin5-17/+0
Change-Id: I6c93864f501f646a8940eac221a88c87b3f75525
2014-08-04java: remove some casting in lib.TestParameters#getMSFNoel Grandin1-1/+1
where the return value is always cast to XMultiServiceFactory, so just do the cast in the method and avoid noise at the call sites. Change-Id: I3a2e06ac6edb3c6021eda6442032db57aaa22e13
2014-08-04fix spelling compilant -> compliantNoel Grandin3-3/+3
Change-Id: I5a469226a576906f0dd860c008d2e3fab1659ff7
2014-07-28Linked the sax library to CMISMihai Varga1-0/+1
This is needed for the use of DateTime converter. I forgot to add the makefile when I commited this patch: https://gerrit.libreoffice.org/#/c/10586/ Change-Id: I7cb9ab40fab549a95beb6818ab4ad4befdd3dea1
2014-07-28UNO to CMIS properties conversion fixMihai Varga1-13/+50
The initial code always extracted Strings from the UNO instead of extracting the same data type that was written into it. This patch extracts the properties according to their data type and formats them to be reconstructed into CMIS properties. Change-Id: Ib160020e9d923a46e2c4f90924da847f2dac5e7a Reviewed-on: https://gerrit.libreoffice.org/10586 Reviewed-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr> Tested-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr>
2014-07-25Avoid possible memory leaks in case of exceptionsTakeshi Abe9-28/+32
Change-Id: I9983e858c4e634b4cac8ad42fa9b06b7ccc167d6
2014-07-17fdo#72277: don't build and use nsspem when building against system curlCédric Bosdonnat2-0/+8
System CURL will know how to get the CA bundle from the system openSSL. There is no need to have internal NSS CA database support. Change-Id: Ie5074c78f7d78b2c2f452d4d4e11c98222529883
2014-07-15fdo#72277: Use NSS CACERT in cmis ucp with internal curlCédric Bosdonnat2-0/+28
This fix contains two parts: * initialize NSS in the CMIS UCP right before sending an HTTP request in case internal curl is used. This makes internal curl find the NSS CACERT database from the user mozilla profile. * add nsspem to allow curl to use CACERTs from libnssckbi. Without libnsspem curl is unable to read the certificates from the NSS database. The nss-pem code has been extracted from the fedora-hosted repository: https://git.fedorahosted.org/cgit/nss-pem.git Change-Id: Ie8dedf020480cca01bf9761382886566a1150778
2014-07-11webdav: Do not return reference here.Matúš Kukan2-4/+4
This was missing in e07cefb4f7ba39d59d25815e208ed61269079142. Change-Id: I1c9a3f88981ee67d9d5748f9e43eed1237422fb1
2014-07-08webdav: fix locking in webdav_ucp::Content::getResourceType()Matúš Kukan1-1/+11
This commit cherry-picks 49a454225e35699d7351faaba3d296e1858c6107 for serf webdav version. Change-Id: Ic5aba4fba8f8a2a521224b08865500dd932e85bf
2014-07-02InteractionSupplyName is a detail of SimpleNameClashResolveRequestStephan Bergmann1-0/+1
Change-Id: Iecc77b1c4749bd14ce79f1a7f3e98f45fa3abbba