Age | Commit message (Collapse) | Author | Files | Lines |
|
The "which" utility is not guaranteed to be installed either, and if it
is, its behavior is not portable either. This means that when various
programs are installed, the `which` check will report a fatal error
because the which tool did not exist and the shell returned a nonzero
status when attempting to fork+exec. If it did exist, it might not be an
implementation of `which` that returns nonzero when commands do not
exist.
The general scripting suggestion is to use the "command -v" shell
builtin; this is required to exist in all POSIX 2008 compliant shells,
and is thus guaranteed to work everywhere.
For some in-depth discussions on the topic, see:
- https://mywiki.wooledge.org/BashFAQ/081
- https://unix.stackexchange.com/questions/85249/why-not-use-which-what-to-use-then/85250#85250
Examples of open-source shells likely to be installed as /bin/sh on
Linux, which implement the 15-year-old standard: ash, bash, busybox,
dash, ksh, mksh and zsh.
This commit updates packaging recipes.
Change-Id: I934863f6c8e05728e85278568899f581d749e0ea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160664
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
|
|
* officecfg: deprecate Inet::Settings::ooInetFTPProxyName/Port
* ucbhelper: stop handling these settings
* sfx2: remove SID_INET_FTP_PROXY_NAME and SID_INET_FTP_PROXY_PORT
and usage from SfxApplication::GetOptions()
* shell: remove proxy config code from backends
* stoc: the JavaVM would have its "ftp.proxyHost" properties set based
on officecfg values; remove that
* sysui,vcl: remove protocol from KDE desktop files and file picker
Change-Id: Iba02676cf6e519e2fa60ba925209436d38e75f49
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159500
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
|
|
generated location is kept to not have further changes in existing
scripts using those files.
Change-Id: Ia14864bd6f9c69e2c77d39806e733f50155d12b3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158791
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
|
|
https://developer.apple.com/documentation/xcode/embedding-a-helper-tool-in-a-sandboxed-app
"Adding other entitlements to the tool can cause problems. If the tool
immediately crashes with a code signing error when your app runs the
tool, check that the tool is signed with just these two entitlements:
com.apple.security.app-sandbox and com.apple.security.inherit."
This is indeed what happened..
Change-Id: Id03948c03b7d453aae4ca58719f582576e30a16f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158790
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
|
|
Otherwise it is possible that e.g. -Wl,--export-dynamic is passed which is fatal.
Change-Id: I1735641e3149c86456e1164b67509a719e09d446
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154340
Reviewed-by: René Engelhard <rene@debian.org>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
Added more images inside the app/mimetype .ico files to avoid bluriness in Windows
Change-Id: Ie3ccc6f26ab21b2261a2964a70821473c413d86c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148485
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
Added a shadow to the new MacOS icon
Change-Id: I644ae1e63055bbc5fd8f6ade6f5aaed7290831c2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148238
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
simplify dialog title, should be clear what this is about.
Change-Id: I65d8ca89e32cc225a07483703cd27b0fdc630b42
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146715
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
https://issues.oasis-open.org/browse/OFFICE-3745 was resolved.
Replace all wrong:
application/vnd.oasis.opendocument.database
with:
application/vnd.oasis.opendocument.base
There is an identifier "org.oasis-open.opendocument.database"
being used in some MacOSX Info.plist files - there is no indication that
it needs to "match" the mime-type so leave it as is.
Change-Id: Ic8e0d24e3aa74743801a670846daf2d322c33d70
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146040
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
|
|
Now the headings in the ulf files for .desktop files are
in the form [filename_Key]
Gallery names are also adjusted to fit the new scheme, where there is
no longer a need to pass a --key argument to desktop-translate.py
Sync comments with .desktop files and the remaining .ulf and remove
obsolete Mandriva Linux meta data while at it.
Script to mass-replace relevant names in translations will be
provided to infra.
Change-Id: I87e8028aa5b66f5f5560efa62ddd9b1e5b61c49c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138455
Tested-by: Jenkins
Reviewed-by: Sophie Gautier <sophi@libreoffice.org>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
|
|
Added 24x24 and 48x48 images into the .ico files
Change-Id: I1a35428805643dc8d08ab36d3430769f143c75fb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144677
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Tested-by: Jenkins
|
|
Updated .ico files based on the new hicolor icons
Also deleted those that were not listed in any WinResTarget file
Change-Id: If536ea51518d531918b4dda2d2330d7cc7487c93
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143885
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
- Replaced old with new hicolor icons
- Added files wherever were gaps
- Changed non-oasis mimetype files to symlinks
- Removed "draw.svg" and put "drawing.svg" in scalable
- Added "macos" directory for special MacOS icons
Change-Id: Id10a386f6144db4f0a1a7a118c44687fffbe0568
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139754
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
|
|
without those submitting a build for external testing via testflight is
not possible because appstore thinks you were using a beta version of XCode
Change-Id: I6979a9d290c3e67dd9969d6e535625760b639c25
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141496
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
|
|
- Removed all 32x/64x/128x/256x/512x/1024x svgs as their corresponding pngs can be created by using the svgs found in scalables directory
- Removed 22x22 assets as they were used only within KDE apps but KDE has its own LibreOffice 22x22 icons anyway
- Moved extensions.svg as it was probably misplaced
- Removed math.png that was not meant to be in a mimetypes directory
- Renamed 1024x1024 to 512x512@2x (for HiDPI) directory as 1024x1024 is not a standard hicolor directory
Change-Id: I6fe333abb5de6d403e43fc4aa5c7c2a1326c4250
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139715
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
|
|
This change was added in commit 6ed597a7dd1da40248236e7a71843c2d76d6173e
for unclear reasons (that wasn’t asked for in the bug report), and,
besides, it solves an inexistent problem. No one has been confused on their
expectations after clicking this launcher on their app selector or Start menu.
For anyone looking, it is an obvious thing that, if presented with a set of
launchers like:
LibreOffice
LibreOffice Writer
LibreOffice Calc
...
... the option that isn’t specific will launch a general interface. That’s just simple.
“Start Center” is not the brand name of an application. Although, technically, it is
a module, for users, it’s just a welcome screen, to which OOo has added a glorified
name (it seems we’re experts on inventing weird terms for everyday UI paradigms…
just see “NotebookBar”, which is just a ribbon; deal with it).
It shouldn’t be present in the main launcher for the same reason we don’t add
the word “Dialog” to the title of every dialog.
Change-Id: I3703299fcb8a8244c721631c3107c9f9d3264d83
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139805
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
Locolor icons are outdated, apparently not required anymore
by freedesktop.org, and the installation was removed with
I6c7eda89a145365ffb598a066b7e817f27f4ea9b
Also related: tdf#132737
Change-Id: Ibb99b6884f03c184bfde62585f03e7b8d34632da
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139553
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
|
|
Change-Id: I91b719bdc5a7ffac125623e79f5e5729cc431b1c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139206
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
|
|
Having the personal-information.addressbook entitlement is not enough.
Without the plist key NSContactsUsageDescription, macOS will not ask the
user to grant access and the request is implicitly denied without any
feedback/logging.
Change-Id: I954fa86b35a128f08e5c498191bc0949e0edeebf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136619
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
|
|
Change-Id: I94bde89ee8cb122ed04f510e25e558240e3029b5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134708
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
|
|
Our baseline is CentOS 7, it's safe to switch to xz that is supported there.
Here is my measurement on rpm package build time and package size on a
48 core machine, however 48 cores were never used (8-10 max). Compared to
reference w9.gzdio which was used before the patch.
Compression Build Package
method time % size %
w9.gzdio 100% 100%
w7T.xzdio 69% 66%
w6T.xzdio 62% 67%
w5T.xzdio 55% 67%
w4T.xzdio 41% 70%
w3T.xzdio 31% 73%
w2T.xzdio 26% 75%
w1T.xzdio 24% 77%
Conclusion: we'd like to optimize rather for the build time, therefore
w1T.xzdio was picked. The package size was still smaller than the reference
size, and the build time was 4x faster (in this measurement 18m16 -> 4m26).
That makes a difference.
Change-Id: Iabb532628d38a2d5091fa41fd08bfee69007d0ca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128800
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
|
|
since
commit e58a5f6db6d13d078f12c3496f46c227c6943c48
Author: Chris Mayo <aklhfex@gmail.com>
Date: Wed Nov 11 19:27:52 2020 +0000
Remove obsolete GNOME 2 MIME types files
Change-Id: I31e2c8351d8893f3f0336a19b8ef9b53b8ab8555
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123445
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
seen by rpminspect as .desktop "references icon libreoffice-document-new
but no subpackages contain libreoffice-document-new"
introduced by:
commit f767d5e2b017c0d0cfd23ff3318cb30901847722
Date: Sun Sep 1 11:30:12 2019 +0200
Add icons to New Document desktop file actions
in the [Desktop Action NewDocument] section
Change-Id: I64ce5e2dbaca32083b2f76e960c33a815f8a3773
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123444
Tested-by: Jenkins
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ia89059eea51ca396a7c74143625ac9a6706de198
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120773
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
|
|
Change-Id: Idcdb5dbb4f0754425eeca4b137fa1626bba9ef6a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118340
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
|
|
This was already done for Windows in fdd8686987ca4ee693f5f194c8eb482daa69cfef
Change-Id: I2fa43bf2930e9df9fbeb9169d28700ef4bdbaacc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117726
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
|
|
Change-Id: I1d46cd91082549eebfafe4f7e16d3b6d4e2fe9ab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117964
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
|
|
Change-Id: I5cc16b0fdaf032e90aa0361df6f33c04a615abab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108016
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
|
|
but it's not a spreadsheet
since...
commit dad7fe7227fb80a32d3c2c777584dc9d74b9e929
Date: Thu Jan 2 16:16:55 2014 +0100
Fix math categories to make SUSE rpm check happy
Change-Id: I0397ea12cd7f29f4b0c1f0e0ad76a3429b55c455
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116884
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
Change-Id: I8b355bceadeebebc9e6fedbf92a35aa44a356e09
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114819
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
Previously, all of the README files have been renamed to README.md
and now, the contents of these files were changed to use Markdown
format. Other than format inconsistency, some README.md files lacked
information about modules, or were out of date. By using LibreOffice
/ OpenOffice wiki and other documentation websites, these files were
updated. Now every README.md file has a title, and some description.
The top-level README.md file is changed to add links to the modules.
The result of processing the Markdown format README.md files can be
seen at: https://docs.libreoffice.org/
Change-Id: Ic3b0c3c064a2498d6a435253b041df010cd7797a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113424
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
Renaming all README files for all top level modules to README.md,
applying no content change at this stage to be able to track history
of the files. These files should be edited to use correct Markdown
syntax later.
Change-Id: I542fa3f3d32072156f16eaad2211a397cc212665
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112977
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
|
|
Current path /usr/share/appdata is deprecated [1].
[1] https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#spec-component-location
Change-Id: Ibd837240ad329c005a840f9ae2e0f4f13f139b59
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106025
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
|
|
Installed as:
/usr/share/application-registry/libreoffice.applications
/usr/share/mime-info/libreoffice.keys
/usr/share/mime-info/libreoffice.mime
Superseded by Shared MIME-info compliant libreoffice.xml, created as
openoffice.org.xml by create_mime_xml.pl from the .desktop files.
Change-Id: Ib8d9a17d09139dd4f50f65572457cef0178750b7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105606
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
GNOME will use the hicolor theme.
Change-Id: I612c6b076544227bf9adf546ad385c6a5ac20ca1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105200
Tested-by: Jenkins
Reviewed-by: Chris Mayo <aklhfex@gmail.com>
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
|
|
The icons in scalable/mimetypes were multi-image developer files removed
from installation in:
f9ddaae9caa5 ("tdf#132737: Don't install SVG source icons or locolor theme", 2020-10-14)
Change-Id: I6c7eda89a145365ffb598a066b7e817f27f4ea9b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105081
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
|
|
These SVG icons are the source for the PNG icons in the same
directories.
scalable/mimetypes icons each contain the source for all sizes of
PNG icons and are not usable themselves.
The locolor theme is incomplete with only low resolution icons.
Change-Id: I2bc54cfbfec012c29a41e1d954d313c19a47831e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99444
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
|
|
With 315919306c7b6e95db6a280c4aa8d2203970e292 "Set PYTHONWARNINGS to error by
default for --enable-werror" my build on Fedora 32 started to fail in
CustomTarget_sysui/share with
> Exception ignored in: <socket.socket fd=4, family=AddressFamily.AF_UNIX, type=SocketKind.SOCK_STREAM, proto=0>
> Traceback (most recent call last):
> File "/usr/lib/python3.8/site-packages/abrt_exception_handler3.py", line 93, in write_dump
> response = send(data)
> ResourceWarning: unclosed <socket.socket fd=4, family=AddressFamily.AF_UNIX, type=SocketKind.SOCK_STREAM, proto=0>
> Traceback (most recent call last):
> File "/usr/bin/g-ir-scanner", line 103, in <module>
> from giscanner.scannermain import scanner_main
> File "/usr/lib64/gobject-introspection/giscanner/scannermain.py", line 35, in <module>
> from giscanner.ast import Include, Namespace
> File "/usr/lib64/gobject-introspection/giscanner/ast.py", line 29, in <module>
> from .sourcescanner import CTYPE_TYPEDEF, CSYMBOL_TYPE_TYPEDEF
> File "/usr/lib64/gobject-introspection/giscanner/sourcescanner.py", line 24, in <module>
> from .libtoolimporter import LibtoolImporter
> File "/usr/lib64/gobject-introspection/giscanner/libtoolimporter.py", line 21, in <module>
> import imp
> File "/usr/lib64/python3.8/imp.py", line 31, in <module>
> warnings.warn("the imp module is deprecated in favour of importlib; "
> DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses
Change-Id: I919caaad482e844ef1549f248a2faf2274c9efa0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103177
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
When submitting for the App Store Apple enforces that each document
type in Info.plist has an LSHandlerRank.
Change-Id: I1f963cef31e87ed2176178754490a1e2194e4743
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102238
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>
|
|
Apple does enforce that CFBundleVersion and CFBundleShortVersionString
consist of three integers. So make sure that is the case when building
for the App Store. (We infer that when using --enable-macosx-sandbox
we are building for the App Store. So far that is true.)
Change-Id: I677b28f65aa9be9466811a982023e0932dce0893
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102237
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>
|
|
This reverts commit a26a5bb71c32c1cf8c5ad4d2ef79f3ece5065a02.
Reason for revert: apparently compilation with installation sets wasn't tested at all/the change is incomplete and breaks because of missing files.
Change-Id: Ied6973659bd0c25f613d615a4cae699b04ae2a43
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99398
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
|
|
GNOME will use the hicolor theme.
Change-Id: I3a163fd9b43457063167701c2964a457aac85cb6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93712
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
|
|
Change-Id: I6377db152ededc4d46ba7bbbaa9bc66210964e18
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96770
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
|
|
Added generic icon declarations to the "Imported Type UTIs"
Some 3rd party formats are only in the "Document types",
most notably the old MS formats
Those need to be restructured to at minimum be by type
(e.g., text), or moved to Imported Type UTIs
Change-Id: I43f4d15a7c13f511178fb34371ccea4860e6873e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94625
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>
|
|
Change-Id: I5e2a309409094da19f755cf82767097ad2990380
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93139
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Previous approach of setting the bundle version made e.g.,
6.4.0.3 show up as version 6.4.3 which was clearly wrong
CFBundleShortVersionString is supposed to be only three integers,
but this does not seem to be enforced by Apple.
Other applications, such as Spotiy, include even more than LO
Removed CFBundleGetInfoString as it's been deprecated since 10.5
Change-Id: I7c64553f6bc2712506062d8f8ec388f5279b333d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94623
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
|
|
Change-Id: I0766b7a12686c829f8b0fe43df6d5256139d4f10
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94359
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
|
|
Flash technology is going to be retired by the end of 2020 by Adobe:
https://theblog.adobe.com/adobe-flash-update/
With this ahead doesn't make much sense for LO 7.0 to support exporting
presentations and drawings to swf anymore.
Change-Id: Ic2c6e95db2f56bcd4eb25abdd0a6748aee9b0e4c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92507
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
|
|
...and not also whatever other prerequisites those two rules might have (e.g.,
instdir/program/python.bin).
Before 01344a8ca57636ac87108c22f777a02fe6d963d5 "convert sysui to gbuild and add
to tail_build", the corresponding dmake code in sysui/desktop/share/makefile.mk
had been
> $(COMMONMISC)$/{$(PRODUCTLIST)}$/openoffice.keys : ../mimetypes/openoffice.mime brand.pl translate.pl ../productversion.mk $(ULFDIR)$/documents.ulf
> $(COMMONMISC)$/{$(PRODUCTLIST)}$/openoffice.keys : ../mimetypes/{$(MIMELIST)}.keys
[...]
> @$(PERL) brand.pl -p $(PRODUCTNAME.$(@:d:d:f)) -u $(UNIXFILENAME.$(@:d:d:f)) --iconprefix '$(ICONPREFIX.$(@:d:d:f))-' $< $(MISC)/$(@:d:d:f)
[...]
and
> $(LAUNCHERFLAGFILE) : ../productversion.mk brand.pl translate.pl $(ULFDIR)$/launcher_name.ulf $(ULFDIR)$/launcher_comment.ulf $(ULFDIR)/launcher_genericname.ulf $(ULFDIR)/launcher_unityquicklist.ulf
> $(LAUNCHERFLAGFILE) : $(LAUNCHERDEPN)
[...]
> @$(PERL) brand.pl -p '$${{PRODUCTNAME}} $${{PRODUCTVERSION}}' -u $(UNIXWRAPPERNAME) --iconprefix '$${{UNIXBASISROOTNAME}}-' $< $(@:db).$(INPATH).$(@:f)
[...]
where Dmake's $< denotes "the list of prerequisites specified in the current
rule" (<https://www.openoffice.org/tools/dmake/dmake_4.11.html>, section
"RUNTIME MACROS"), whereas GNU Make's $^ denotes all prerequisites.
Change-Id: Ie6efc5d9512408711db32502e0959b32ec232603
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91566
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
while (<>) { ... }
opens all the file names given on the command line in succession, and executes
the loop body once for every line read from those files. So the existing loop
processed each file over and over N times, where N is the number of lines in
that file. This appears to have been broken ever since the code's introduction
in be63ae6cba16a0e31c1388cd5e0bc418cb41afd6 "INTEGRATION: CWS networker3
(1.1.2); FILE ADDED: 2004/05/20 11:38:58 obr 1.1.2.1: #i20355#,#i20356# new
directories for system wide desktop integration".
Change-Id: I8b4f0c6812bf3ba42da4b7c55c38e52c91dd4229
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91558
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|