summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)AuthorFilesLines
2015-06-15Fix typosAndrea Gelmini5-5/+5
Change-Id: Id05ea8cf8aed878bedfe73c274df3c67b64bad37 Reviewed-on: https://gerrit.libreoffice.org/16263 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-15loplugin:vclwidgetsStephan Bergmann2-2/+3
Change-Id: Ib64f7585bf44bdaa6dd1101b97848baa1f121725
2015-06-14Paragraph related part of Background Tab is unused nowZolnai Tamás3-11/+1
For paragraphs Area Tab is used for setting background. Change-Id: I83859a1b2125374b81c084cfa45487a42adcd5a6
2015-06-14Handle highlighting case inside SvxBackgroundPage classZolnai Tamás1-19/+2
... instead of converting attributes. Change-Id: I3e45c0641389a7b6bdecb5141646aa13ee5c0aa5
2015-06-14tdf#89830: Ambiguous naming of character backgroundZolnai Tamás4-2/+9
Use 'Highlighting' also on Character Dialog. Change-Id: Ie81d25651e5998a35b4e2646089b8f2c590cfb98
2015-06-14Transparency part of Background Tab is unused nowZolnai Tamás1-10/+0
It was used for frames, but on Frame Dialog Background Tab was replaced with Area Tab. Change-Id: I69774c7321a210094f6e139a5b3d4d5819947ceb
2015-06-14Fix insertion and deletion in IndexedPropertyValuesContainerMatthew J. Francis1-1/+17
The cases for iterating to an element from the end (used for elements in the second half of the underlying array) had an off by one error causing the wrong elements to be inserted/removed Change-Id: Idcbf158cc31afaf02fce3f1975509edf6239d3ae Reviewed-on: https://gerrit.libreoffice.org/16073 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-06-14cppcheck: redundantCondition [part2]Julien Nabet10-24/+13
Change-Id: I23e8a4834fa7858adb292ce0a4dfa5dab1ab5f00
2015-06-13Typo: corected->correctedJulien Nabet1-1/+1
Change-Id: I9a41d801b8807ed122a6737a924ba6792b449c45
2015-06-13sw: overloading in C++ fail episode 6234Michael Stahl1-1/+1
Change-Id: Ida670ac9c6687314d8b425c3ac1f9896f54f2a15
2015-06-12Added test for redline with as-char frameVarun2-0/+9
fixed by commits 4dd2e61 and fae87e0 Change-Id: Ib6ca689af61187b32283753f80abaed96406f409 Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-06-12Make SwFrameControlManager an EditWin ptr member to reduce re-compiles.Michael Meeks8-13/+25
Change-Id: Ic2491948aa555fa71f9e14af554bdf204c12247d Reviewed-on: https://gerrit.libreoffice.org/16236 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-06-12Writer FrameControl lifecycle and management cleanup.Michael Meeks7-63/+107
We can't derive from a VclPtr base-class, and also another base, and then use boost::shared_ptr for that; re-factor to use a boost_ptr to hold a VclPtr<> for now. Also fix leaking envelope dialog. Change-Id: I2e1efbfaee3b6051e38ff7a14903a83ccd75136b Reviewed-on: https://gerrit.libreoffice.org/16160 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-06-12tdf#91228: need to check the format's IsLockModified(), not the node'sMichael Stahl2-39/+21
commit 9f01951b858453684f2622541af0eb85d4544fc6 also did the extra Remove/Add for Draw fly objects, and it turns out that that's actually wrong because SwTextFlyCnt::SetAnchor() will set the anchor without locking anything if it's a Draw object. Replace it with a different hack in SetAnchor() that applies only if it calls LockModify(). Thanks to Varun Dhall for creating a reproducer document. Not sure if the LockModify() could be replaced completely, perhaps it's just an optimization to avoid re-creating layout frames for the fly. Change-Id: Ib3236f289c2c4202d48ac378a53ce02130d4ce2c
2015-06-11tdf#91781 Make Styles a new main menu bar entry and small rearrangmentsYousuf Philips1-32/+33
Change-Id: I9b8ab749978826741b2c893197aaf7ebc1758d3f Reviewed-on: https://gerrit.libreoffice.org/16227 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com>
2015-06-11tdf#90713 tdf#90925 remove footnote mark from TOC/List of Figures entryAndras Timar1-1/+2
Change-Id: I58ab0fbc6a247c29c77a4e9d7febc11daa4a79c8 Reviewed-on: https://gerrit.libreoffice.org/16233 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2015-06-11tdf#90926 remove footnote mark from cross referenceAndras Timar1-1/+1
Change-Id: I0354bca230395d8061bb6d9ce9f9b7a6229b73a7 Reviewed-on: https://gerrit.libreoffice.org/16234 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2015-06-11best effort export of ooo72950-1.odt to docx without crashingCaolán McNamara3-3/+9
the curious case of ooo72950-1.odt which has no nodes in the first line of the table as seen from the visual layout perspective seeing as the table is split over two columns with the second column portion of the table higher than the left column portion Change-Id: I38526bf80ff8cef1688aa5f5f686e437c4a3d6e5
2015-06-11SwDocShell: re-store embedded data source def only when location changesMiklos Vajna2-1/+7
Change-Id: Ic667491026e9e88a72253aa079c77b8079cac588
2015-06-11Resolves: tdf#91878 vertical text entry missingCaolán McNamara1-0/+4
Change-Id: I3be1a13a00e3219cb8912ef61a9627d37036d19a
2015-06-11java:regulatize the order of 'final' and public/privateNoel Grandin1-1/+1
Make the order be 'public static' or 'private static' Just makes the code nicer to read. Change-Id: I182424bda45a2d68642e5d04c6091d268ace1fe2 Reviewed-on: https://gerrit.libreoffice.org/16202 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-11sw tiled rendering: Ignore window size check.Henry Castro2-10/+3
In the tiled rendering case it does not need to check if the window size is (0,0). But it still has to trigger LOKit LOK_CALLBACK_INVALIDATE_TILES Change-Id: I4c458edfd6e44599b8c8148e0f8543fb0563e627
2015-06-11convert expressions like 'size() == 0' to 'empty()'Noel Grandin8-33/+33
Change-Id: Ia5c8c0f38a347f398d587970a22e03f29ffd37af
2015-06-11So assume SwUiWriterTest::testEmbeddedDataSource works on MACOSX now tooStephan Bergmann1-2/+0
...similar to 6cca91f7ada91701443225061a5dd0ae81a98b8e "CppunitTest_sw_uiwriter: enable on Windows," whatever the original problem was in 601ba26cb5737970e7e9a173515bb21ebde55db9 "Fix the Windows and OS X build temporarily." Change-Id: Ia1befff90d773637e01e6d88e398ae21a1d47108
2015-06-11SwDBManager: avoid registering two data sources when creating an emebedded oneMiklos Vajna1-2/+3
SwDBManager::LoadAndRegisterDataSource() calls SwXDocumentSettings::setPropertyValue() to set its EmbeddedDatabaseName UNO property, when creating the embedded data source definition. OTOH, during load, SwXDocumentSettings calls SwDBManager::LoadAndRegisterEmbeddedDataSource() to register the data source. The result is that when creating the embedded definition using the MM wizard, we registered two data sources. Fix the problem by first setting the UNO property, and only then storing the data source definition. Change-Id: I3efc141d9ab94828007a48a8bf5949b4f3b6510a
2015-06-11Typo: vertival -> verticalAndras Timar1-2/+2
Change-Id: I3dce3d131ce78713333d6e4bc2f3e839af5e04ec
2015-06-11tdf#91613 restore functionality of clicking to .uno:Size status bar elementAndras Timar1-0/+53
... in Writer. This (partially) reverts commit ebabf6d1fa648d62dd63529e9fe64dcb631caee8. I did not see the point to open Fields dialog by default, but other uses are fully valid. Change-Id: Ia06803fbb956266fb40c53f51099f9a32ddd6548 Reviewed-on: https://gerrit.libreoffice.org/16221 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2015-06-10coverity#1302618 deref of NULLCaolán McNamara3-9/+9
on examination this PreparePaint virtual is only called from SvTreeListBox::PaintEntry1 and PaintEntry1 is only called from SvImpLBox::Paint in a for(sal_uInt16 n=0; n< nCount && pEntry; n++) { /*long nMaxRight=*/ pView->PaintEntry1 loop so pEntry always exists given that test. Re-jig things so these families of method take a reference instead of a pointer so verifying it cannot be NULL and a whole pile of else paths fall away Change-Id: Ied40acb1c2263c21b4447832f8cb86f64ed9e80d
2015-06-10tdf#90640: add a unit test for thisMichael Stahl1-0/+11
Change-Id: I72aecb66d0de4ba2bc3a44f664aab8170ffb3d0f
2015-06-10Revert sw: LOK_CALLBACK_CURSOR_VISIBLE callback.Henry Castro1-6/+0
Already fixed by Miklos Vajna. Change-Id: I848f2296c5f5a4d250308ed3a851c46524181340
2015-06-10sw: remove embedded data source on location deregistrationMiklos Vajna4-4/+114
Change-Id: I5b2a24fee50a25a41ba26787f7e30409348d7808
2015-06-10Prop_pSegmentInfo is totally misunderstood apparentlyCaolán McNamara2-38/+51
digging into the crash on export of kde216114-1.odt reveals various horrors Change-Id: I0d24fe303d561a00a08098b306d10fd8273af928
2015-06-10CppunitTest_sw_uiwriter: enable on WindowsMiklos Vajna1-1/+1
I hope that the underlying problem is fixed now by commit 670100fcfbb39d3dbe4afdb27fbced26d7b14283 (Remove FastLoader optimization, 2015-06-10). Change-Id: I1cb577ec1f50a45b40683031e79c0999338a2926
2015-06-10loplugin:salboolStephan Bergmann1-2/+2
Change-Id: I030321e8cb905be78b68f9e404926e22723632ef
2015-06-10sw: fix GCC undefined reference to `typeinfo for sw::LegacyModifyHint'Michael Stahl2-10/+16
Stop pointlessly inlining these virtual functions. Change-Id: I11d123bc704ec6cf54925a13d139fce70cc59566
2015-06-10Revert "There's SAL_DLLPUBLIC_RTTI for that"Stephan Bergmann2-2/+2
This reverts commit 8761ab9b5ec7860eb5bc7d05271da081f66a452b; thinko, as the RTTI needs to be visible with GCC too in the test code.
2015-06-10Added Test for Export to PictureVarun1-0/+29
Change-Id: I62d44e29cd4376f17270cef548d2cec6f4b621b9 Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-06-10Added Test for tdf#91145 Set Cell Background ColorVarun1-0/+40
Change-Id: I7c41f1d596946706dde4adbeb5434ae0be58b04b Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-06-10There's SAL_DLLPUBLIC_RTTI for thatStephan Bergmann2-2/+2
Change-Id: I1937374b56b506681876d100112852b68f099038
2015-06-10Ensure single RTTI symbol instanceStephan Bergmann5-9/+8
...to make typeid comparison in sw::UnoCursorPointer::SwClientNotify work also under the Itanium C++ ABI/libc++ semantics (as used on Mac OS X), not only the less strict GCC/libstc++ semantics (as typically used on Linux). This caused CppunitTest_sw_uiwriter's testUnoCursorPointer to fail on Mac OS X. (DocDisposingHint and LegacyModifyHint need to be SW_DLLPUBLIC even though they are nominally only used inside the sw library, because they are also used from the CppunitTest_sw_uiwriter test code.) Change-Id: Ideceade22ca3049ae287aea468de93c72bee5fdc
2015-06-10tdf#88290 Adapt the numbering popup to more than 8 itemsMaxim Monastirsky2-36/+27
The items count of NumberingTypeMgr is limited by 8, but some languages have more items, so remove that limitation. Also fix the behavior of the 10th item. The old sidebar popup had a "None" item, whose id was 10 (defined by DEFAULT_NONE from include/svx/nbdtmg.hxx), and that causes now the 10th item to behave as on/off toggle. Since we don't have a "None" item anymore, get rid of that behavior completely. Change-Id: I5546ca637f9951cc093a7bbf8fda11dc35341d4e
2015-06-10SwDBManager::LoadAndRegisterDataSource: restore lost hunkMiklos Vajna1-0/+6
Accidently removed in commit f01f31201f9b26b3071ab25f9a5a3a0311ff7423 (SwDBManager: extract StoreEmbeddedDataSource() from registration code, 2015-06-09). Change-Id: I27e47249b92b8fd19dcd09a1226f5e80184ea8db
2015-06-10VMLExport::Commit is riddled with out of bounds writes on exportCaolán McNamara1-5/+5
Change-Id: I9490d888ad148caecba034ef12b7398ae5c66a3f
2015-06-10similarly fix fatal export of kde216114-1.odt to docxCaolán McNamara2-0/+6
Change-Id: I78478de91473681fd8d836293dabe7b790dda516
2015-06-10fix fatal attempt to export kde302504-1.odt to docxCaolán McNamara2-0/+6
the enhanced-path contains decimal points so the last element is a double not an integer Change-Id: I90be76a2d4cb90ee7a904aa72fe65770c675fc53
2015-06-10fix crash on export of ooo67471-2.sxw to docxCaolán McNamara5-44/+82
This old-school table has three rows in it, but the second row is of 0 height so is indistinguisable from the third row by layout positioning, so the WW8TableNodeInfo view of the table is that it has two rows, and the comparison of being on the last row is done with the m_xTableWrt->GetRows view which considers it to have 3, so the table end marks are never output. add a new finalEndOfLine property that the WW8TableNodeInfo sets on the last end of row of the table as it sees it, which should resolve this. old style tables are a cess pit, which is why they were replaced Change-Id: I996aa59a338a594487f49ec0f228af3fb3032d15
2015-06-10sw: fix gcc-4.7 buildMiklos Vajna1-1/+1
Change-Id: I6223691a25d5bdcf83b60a26e344fa964d995354
2015-06-10loplugin:unreffunStephan Bergmann1-1/+7
Change-Id: Ibc1634886a85f4c7936ea175c754d31ea21eefe1
2015-06-09sw: tiled rendering, set minimal window size.Henry Castro1-0/+10
Set minimal window size (1,1), so it can trigger LOK_CALLBACK_INVALIDATE_TILES Change-Id: If6ef9aeec94b396febd41375b3ce96b1aa1d6115
2015-06-09sw: LOK_CALLBACK_CURSOR_VISIBLE callback.Henry Castro1-0/+6
Change-Id: Ibf62a9d46df7d56dda737b4671d79b59bd01d35a
generated by cgit v1.2.3 (git 2.39.1) at 2024-11-24 00:53:59 +0000