summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)AuthorFilesLines
2017-08-22Fix two issues in ActiveX DOCX import / export codeTamás Zolnai4-9/+73
* Inline anchored VML shape had wrong vertical position ** In MSO inline shapes are positioned to the top of the baseline * During export all shape ids were the same (shape_0) ** VML shapes used to be exported only as fallback, I guess that's why it did not cause any issue before. ** Override the shapeid generator with a new one, which actually generates unique shapeids. Change-Id: I752f39d092d0b61d91824141655dae662dbeafbc Reviewed-on: https://gerrit.libreoffice.org/41319 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-08-22tdf#108706 Unify loading document progress bar labelTakeshi Abe2-3/+3
This also reduces the number of strings to be translated. Change-Id: I032ba12c1e762ee3851658d439dfe2c81c6bd34f Reviewed-on: https://gerrit.libreoffice.org/41329 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-08-21Fix typo in codeAndrea Gelmini1-1/+1
Change-Id: I1a26ab5e9c029c533b87c67499d6aebf871011e7 Reviewed-on: https://gerrit.libreoffice.org/41371 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-21Temporary fix for Clang on F26Tor Lillqvist1-0/+2
I get a mysterious linking error: sw/qa/core/uwriter.cxx:1416: undefined reference to `SfxEnumItem<SvxRotateMode>::operator==(SfxPoolItem const&) const' Change-Id: I2363ebf84784d17b8aea2f37cece191f48a1b717
2017-08-21tdf#111626 switch underline color.Mark Hung1-3/+13
Switch underline font color if it is from the underline color of the portion. If the underline color is auto, take the font color into consideration. Change-Id: I81a0e100cd024add603b574f07e10b5e3a785d0b Reviewed-on: https://gerrit.libreoffice.org/41090 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Hung <marklh9@gmail.com>
2017-08-21sw: check the target text node, not the sourceMichael Stahl1-4/+4
Change-Id: I386f4ded70cc3deffc2f2e43709edf16eba94c63
2017-08-21tdf#111524 sw: don't expand annotation mark when showing redline...Michael Stahl1-1/+1
... at a position directly behind the annotation mark. This happens with the the annotation "__Annotation__5847_848227920" in the bugdoc, followed by <text:change text:change-id="ct266312216"/>. When the redline is shown, the annotation mark expands from 5 - 101 to 5 - 240, but the SwPostItField is of course still at 101, so during the ODF export lcl_FillAnnotationStartArray() asserts. The problem is that the "bDelete" parameter of SwTextNode::Update() disables a whole bunch of code that prevents update of positions of redlines, bookmarks, fly frames, and shell cursors. This was introduced in 2004 with CWS dvoea1, but there is absolutely no documentation of what problem it was supposed to solve. So just try to remove it here and see if it causes any issue. Change-Id: I2d1f78c7163eddaf0ce6bbb7c6685ca759874ec5
2017-08-21tdf#111524 sw: delete annotation marks when creating delete redlineMichael Stahl1-1/+36
Range annotations are represented by a SwPostItField at the end of the annotated range, and a AnnotationMark that covers the range (including the field). During a normal delete, SwUndoDelete calls SwUndoSaveContent::DelContentIndex(), which has a special case to remove the AnnotationMark if the field is deleted. The problem is that when change tracking is enabled, the AnnotationMark survives, but the field is moved out of the paragraph when the redlines are hidden (as happens during ODF export), hence lcl_FillAnnotationStartArray() doesn't find its field. There doesn't appear to be a good solution to this, because in ODF it's also not possible to represent this, because the deleted content is outside the text:p element. It doesn't work to delete the annotation mark in DelBookmarks(), when hiding the redline, because then no Undo is created to restore the mark, and DelBookmarks() is also called from Undo code from SwUndoDelete, which breaks with this change. So delete the annotation mark when creating the redline in DocumentContentOperationsManager::DeleteAndJoinWithRedlineImpl(). Fixes the assert and the subsequent crash, which is a regression from 31c54fa7bb03768b425ae019096e0a0e26e9c736. Change-Id: I361ffee8e6ab86de499c25f34a96ceeaf83d9e0b
2017-08-21remove dead sw error codesNoel Grandin7-98/+48
and inline some macros Change-Id: Ida8db46bec4fcec46a779da0180fe3bf1a1af59d Reviewed-on: https://gerrit.libreoffice.org/41375 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-21Fix typosAndrea Gelmini1-1/+1
Change-Id: I3f3abc3c6e12536d4bc38f0c676d5fc20532a1e3 Reviewed-on: https://gerrit.libreoffice.org/41370 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-08-20This test intended to be an export testTamás Zolnai1-2/+3
Change-Id: Ib233bd603185efdb85ed30f3d00c28512d57a0ac Reviewed-on: https://gerrit.libreoffice.org/41355 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-08-19no need to redefine WB_RIGHT_ALIGNEDNoel Grandin1-4/+0
Change-Id: I99387a402354a8d982e1d36e7d2fdbb710658a97 Reviewed-on: https://gerrit.libreoffice.org/41300 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-19tdf#98700 docxexport: don't force on ParaKeepTogetherJustin Luth3-2/+13
The mere presence of SvxFormatKeepItem was ENABLING it during export, without checking to see if it was actually turned on or off. Both DOC and RTF check the value, and set accordingly, so do the same for DOCX. Merely toggling the setting on and off is enough to create the property, so this is a nasty bug that only affects inquisitive people. Change-Id: I02d83a255f5b4ff8c5124302a52a3126dad40b67 Reviewed-on: https://gerrit.libreoffice.org/41309 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2017-08-18tdf#99692 sw: fix the fix: don't set bNullContent if node was splitMichael Stahl1-1/+2
When showing the redlines in rhbz908615-13.odt, the following assertion happens: Assertion `IDocumentMarkAccess::IsLegalPaMForCrossRefHeadingBookmark(rPaM) && "<CrossRefBookmark::CrossRefBookmark(..)>" "- creation of cross-reference bookmark with an illegal PaM that does not expand over exactly one whole paragraph."' failed. This is because in DocumentContentOperationsManager::MoveRange() the flag bNullContent is set after the node has been split; in this case the nContent is of course always 0. Later the function then restores aSavePam to the index 0 of the next node, when it actually shouldn't do anything because the JoinNext() already positioned it correctly at the merge-index of the re-joined node. (regression from 850795942b3e168cab8ce88b4f2b421945ff29ca) Change-Id: I64d50e70b19e2fd81537a9771fa8706898b17642
2017-08-18new loplugin:expressionalwayszeroNoel Grandin1-3/+1
The code in SvXMLExportItemMapper::exportXML was broken as far back as its introduction in commit 0c28e3c480a95c03b513c55f029b979bcd9c0401 "Move SvXMLAttrContainerItem to SVX, moved writer only code to sw" Change-Id: I90043ce8b7263aa56fd0883d350e29b97eeaf99b Reviewed-on: https://gerrit.libreoffice.org/41282 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-18loplugin:unnecessaryparenNoel Grandin2-2/+2
look for statements like return (function()); Change-Id: I906cf2183489f87225b99b987caca67e39b26cc3 Reviewed-on: https://gerrit.libreoffice.org/41260 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-18Fix typosAndrea Gelmini2-2/+2
Change-Id: I795059109e23800987cda6f04c58ab18c488ad07 Reviewed-on: https://gerrit.libreoffice.org/41242 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-18NdTopLeft is unused now.Tamás Zolnai4-22/+21
Change-Id: I39184b8fdf666676c21560d39911f6204b0afd52 Reviewed-on: https://gerrit.libreoffice.org/41257 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-08-17tdf#50097: DOCX: export form controls as MSO ActiveX controlsTamás Zolnai15-194/+203
* Use the same structure for export what MSO uses ** Position and size information are exported as VML shape properties ** Different handling of inline and floating controls (pict or object) ** Do some changes on VML shape export to match how MSO exports these controls ** Write out activeX.xml and activeX.bin to store control properties ** Use persistStorage storage type defined in activeX.xml * Drop grabbaging of activex.XML and activeX.bin * Cleanup control related test code Change-Id: I38bb2b2ffd2676c5459b61ec2549c31348bab41c Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/41256 Tested-by: Jenkins <ci@libreoffice.org>
2017-08-17Fix typosAndrea Gelmini5-5/+5
Change-Id: Iaa9c0aea3ea1a239e378bd714ba335f91bb1faf3 Reviewed-on: https://gerrit.libreoffice.org/41194 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-08-17drop unused SdrCustomShapeReplacementURLItemJochen Nitschke1-1/+0
no user found at least since 2004 last traceable commit 50a73f5963c4d0ca34629f36cc04e8b45f61bd62 Date: Fri Apr 2 13:07:39 2004 +0000 INTEGRATION: CWS sj05 (1.1.2); FILE ADDED Change-Id: Iaaf80e93ed60611f5e03688f4d95ab0a7d024e79 Reviewed-on: https://gerrit.libreoffice.org/41262 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-17drop unused SdrCustomShapeAdjustmentItemJochen Nitschke1-1/+0
unused since commit 935baf97a926baa50d985808736e0adb8837c716 Date: Tue May 19 09:32:45 2009 +0000 CWS-TOOLING: integrate CWS impress169 Change-Id: I1e8b0285ae1f6e8d92efd3f5a2463ff3126f1a0d Reviewed-on: https://gerrit.libreoffice.org/41248 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-17tdf#55427 ww8export: treat document-end-footnotes as endnotesJustin Luth9-5/+125
MSWord has two choices for footnotes - at page-end or page-bottom. LO has different choices for footnotes - at document-end or page-bottom. Since document-end footnotes act like endnotes, convert those footnotes into endnotes during DOC/DOCX/RTF export. No matter what happens in this situation, some compromises have to be made. The main compromise now is that the anchor numbering for endnotes defaults to i,ii,iii while footnotes are 1,2,3. The conversion obviously will switch to endnote style. This is user adjustable of course and will be retained on following round-trips. Also the (footnote) paragraph style is retained, but future endnotes will use a potentially different endnote paragraph style. Remedying those perceived deficiency is left as an exercise for the motivated reader, who of course will take into account the possibility of both endnotes and chapter-end footnotes existing in the same document... The unit tests' primary purpose is to ensure that footnotes following down the endnote export path don't cause LO to crash. Change-Id: I219d499df7981a14f824a664b15051ad10ff6642 Reviewed-on: https://gerrit.libreoffice.org/38634 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-08-17implementing callback for ruler invalidationAditya Dewan6-1/+68
adding commands to fetch and changee ruler state '.uno:RulerState' and '.uno:RulerStateChange' Change-Id: I66107039a7ae5893691feb45c8ab2e4aa476ea76 Reviewed-on: https://gerrit.libreoffice.org/40727 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-08-17remove unnecessary use of OUString::getStrNoel Grandin6-11/+8
Change-Id: I3d13e1c0bb6aa4a7aacc463198747c1368ebc9b4 Reviewed-on: https://gerrit.libreoffice.org/38114 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-17MSWord export: adapt interface to avoid const_castMiklos Vajna7-17/+14
If the implementation uses const_cast anyway, then it's clearer to just not pretend const at the interface level. Change-Id: Ib819efe9204440fde6dc2af890e5ff2769f4b9d3 Reviewed-on: https://gerrit.libreoffice.org/41238 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-08-17remove UL/L suffixes from integer constants on the RHS of expressionsNoel Grandin28-117/+117
Change-Id: I899a8126c9d971601fea6c77eca165718aea0ac5 Reviewed-on: https://gerrit.libreoffice.org/41237 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-17Removing unused serialisation codeVarun Dhall1-1/+1
Change-Id: I86911c77f0831d448ff803afae2a74ec55ad4dd8 Reviewed-on: https://gerrit.libreoffice.org/41233 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-08-17Clean up uses of OUString::fromUtf8 around string literalsStephan Bergmann3-12/+12
Change-Id: I9a2990e49c95a01ce505f13408be8c19db1cf5d1
2017-08-17remove UL/L suffixes from integer constants in initialiser/call expressionsNoel Grandin22-50/+50
Change-Id: Iae081567c4fa5b88edbd12cf2fbafd2b8f31b300 Reviewed-on: https://gerrit.libreoffice.org/41214 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-16i#95698 sw: fix crash on splitting in-table section containing a nested tableMiklos Vajna3-0/+22
Found by crashtesting, ooo95698-1.odt crashed sw layout on load. The intended use-case is splitting section frames inside a table frame, so can just blacklist the non-interesting table-in-section-in-table case that causes the problem here. Change-Id: Ic47cd8c46cc71f7eaa36b03ec2c4a5df8ca8051c Reviewed-on: https://gerrit.libreoffice.org/41224 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-08-16Translated "Methoden" to complete b1f6e6299cf5Andrea Gelmini1-1/+1
No more "methoden" in the tree... Change-Id: I4deec3c47bfab12beabd1b6d56c9b9c3c2b6c4a7 Reviewed-on: https://gerrit.libreoffice.org/41226 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-16tdf#39468 Translate German comments/termsJens Carl2-2/+2
Change-Id: I3c8d8ba10de007429b1cdf26f5e8b207f7cc5eea Reviewed-on: https://gerrit.libreoffice.org/41201 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-08-16convert dialog result methods from long->sal_Int32Noel Grandin3-5/+5
Change-Id: Id3c56a2c9f8f8813e3bbff4c4ae9156b2185fc9c Reviewed-on: https://gerrit.libreoffice.org/41206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-16assert on duplicate listener in SfxListenerNoel Grandin2-4/+8
To enable finding the source of the duplicate calls, I add new SAL API (only for internal use) to retrieve and symbolise stack backtraces. The theory is that it relatively cheap to just store a backtrace, but quite expense to symbolise it to strings. Note that the backtrace() library we use on Linux does not do a particularly good job, but it gives enough information that developers can use the addr2line tool to get more precise info. Explanation of fixes in the code that triggered the assert: In SwFrameHolder, we need to only call StartListening() if the pFrame member is actually changing. We also need to call EndListening() on the old values when pFrame changes. In SwNavigationPI, there is already a StartListening() call in the only place we assign to m_pCreateView. In ImpEditEngine, we need to ignore duplicates, because it is doing a ref-counting thing. By storing duplicates on the listener list, it doesn't need to keep track of which stylesheets its child nodes are using. Given that it therefore will see duplicate events, there is probably some performance optimisation opportunities here. In MasterPageObserver::Implementation::RegisterDocument, we seem to be getting called multiple times with the same SdDrawDocument, so just check if we've been registered already before calling StartListening() In SvxShape::impl_initFromSdrObject, do the same thing we do elsewhere in this class, i.e. only call StartListening() if the model has changed. Change-Id: I7eae5c774e1e8d56f0ad7bec80e4df0017b287ac Reviewed-on: https://gerrit.libreoffice.org/41045 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-16tdf#107480 RTF import: fix HTML automatic spacing in stylesMiklos Vajna2-0/+23
\htmautsp changes the meaning of \sbauto and \saauto, but the auto keywords may appear early in style definitions before \htmautsp arrives. This wasn't a problem before commit 1be0a3fa9ebb22b607c54b47739d4467acfed259 (n#825305: writerfilter RTF import: override style properties like Word, 2014-06-17), as there the right auto keyword interpretation was repeated as direct formatting. So fix the regression by not deduplicating these keywords, which brings back the correct layout. A larger rework is necessary in the future to delay the parsing of the stylesheet table, that would be a cleaner approach. Change-Id: I783d2175483bc80ead0a511ad15c4b75e4ab663c Reviewed-on: https://gerrit.libreoffice.org/41187 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-08-15tdf#111767 Make the Input Field dialog less confusingAdolfo Jayme Barrientos1-57/+42
The first field isn’t editable, so show it visually. Make the actual editable box have the default focus. Drop the unnecessary heading. Change-Id: Icf0d5fc3ddb9b9af6d04045899d9e8476a217bba
2017-08-15tdf#109319 writerfilter: set DropCap.DistanceJustin Luth1-0/+6
Change-Id: I3ec06e9a196897c095f227e9f765243c6c188898 Reviewed-on: https://gerrit.libreoffice.org/41185 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2017-08-15tdf#109318 writerfilter: don't increment DropCap linesJustin Luth2-0/+16
I have no idea why the original implementation used ++nLines when setting aDrop.Lines. Unchanged since mass import from OOo in 2008 commit 614f53dda31f14fe89303dc1809fc29350c1ba29. Change-Id: If427dcea815e91d2cccb2c11044cdb393bff09e3 Reviewed-on: https://gerrit.libreoffice.org/41184 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org>
2017-08-15loplugin:redundantcast, find more functional castsNoel Grandin10-27/+27
In the enum types that caused the problem look like this when I dump then: EnumType 0xdb45770 'enum SvxFrameDirection' `-Enum 0xdb456d8 'SvxFrameDirection' SubstTemplateTypeParmType 0xdb61200 'enum SvxFrameDirection' sugar |-TemplateTypeParmType 0xd7518f0 'EnumT' dependent depth 0 index 0 | `-TemplateTypeParm 0xd7518a8 'EnumT' `-EnumType 0xdb45770 'enum SvxFrameDirection' `-Enum 0xdb456d8 'SvxFrameDirection' Change-Id: Id8fedabe43b7a27df61a2320a9acbf54d2dc7882 Reviewed-on: https://gerrit.libreoffice.org/41169 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-15sw: prefix members of SwOLENodeMiklos Vajna2-48/+48
Change-Id: I2b79ae40afad8c392f219f1798ce44b41649e5b9 Reviewed-on: https://gerrit.libreoffice.org/41163 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-08-15remove redundant SvxFrameDirection castsJochen Nitschke2-6/+7
and replace remaining C-style casts Change-Id: Ie83e2706391c05946ab46dfd7d26059101579153 Reviewed-on: https://gerrit.libreoffice.org/41143 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-15sw RTF export: indentation fixesMiklos Vajna1-2/+2
Change-Id: I33e20b23430483ce318c98a43bde07200802a4d6
2017-08-14Removing unused SetVersionMap from swVarun Dhall3-112/+0
Change-Id: I453efd9fd93941dcdf193b461de1377b76506cde Reviewed-on: https://gerrit.libreoffice.org/41099 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-08-13cppcheck: really remove the memsetJulien Nabet1-2/+0
Change-Id: Ic84e5ca6175d718548e9ee4f9f406ffc899f791a Reviewed-on: https://gerrit.libreoffice.org/41121 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-13cppcheck: Using 'memset' on struct that contains a 'std::unique_ptr'Julien Nabet1-23/+27
+ use constructor initialization Change-Id: I52cb85bf7102dd3f8cf2105fc1c23229b76f28bc Reviewed-on: https://gerrit.libreoffice.org/41107 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-13cppcheck: variableScopeJochen Nitschke1-24/+26
Change-Id: I4dfbd80cf06acb4968556a78d3eaf394757073dc Reviewed-on: https://gerrit.libreoffice.org/41110 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-12tdf#107197: Replace relationship URIChristian Barth1-2/+2
Replaced URIs in sw/source/filter Change-Id: If73c30e9d590742568a3009a6d593f1b3249a5a4 Signed-off-by: Christian Barth <Christian.Barth@zoho.com> Reviewed-on: https://gerrit.libreoffice.org/41055 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-12Removed duplicated includeAndrea Gelmini1-1/+0
Change-Id: I68286aaf7bce262cfc6d371490221e910a3ba7c6 Reviewed-on: https://gerrit.libreoffice.org/41040 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-11tdf#89409 Render ruby inside the grid in standard mode.Mark Hung2-11/+16
In standard mode the text grids are rectangle and do not have dedicated space for ruby text. The ruby text either overlap with base text of the last line or clipped ( after scrolling ). Move ruby text inside the grid in standard mode as if there is no grid, and algin text to the center to keep the original text-to-text alignment behavior. Change-Id: Ia75ee016f9d492e4e73da6d7245aaeff40cbe1f3 Reviewed-on: https://gerrit.libreoffice.org/40632 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Hung <marklh9@gmail.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-12-14 12:28:17 +0000