summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)AuthorFilesLines
2021-03-14tdf#141011: Postpone SwFieldDBPage::Reset to tab activationMike Kaganski2-0/+5
This way, it will only ask for password when dialog is switched to that tab. Change-Id: Ie2a453b0b6867ceb1ef3728a8565de4f6cbf4757 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112469 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-14tdf#141012: do not try to expand the node if RequestingChildrenHdl failedMike Kaganski1-1/+12
Just select the database node itself, so that it's still obvious which database is associated with this document. After selecting this node when initializing the tab, another call to SwDBTreeList::Select will be made, so make sure to handle empty table and column names. Change-Id: Ie1d1bd445e18d5900910c780a24102b4dde5c787 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112467 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-14tdf#141015: Show Mail Merge toolbar when DBData has data sourceMike Kaganski1-1/+3
Change-Id: I74ea06b47d851d979103599526ae970035854dae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112465 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-14check for quit when calling Yield in loopNoel Grandin1-1/+1
so we don't get stuck threads when the main application quits Change-Id: Id36e99267ceb4154873b6ef8ef494622fff6c19a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112409 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2021-03-14loplugin:unusedmethodsNoel2-11/+0
Change-Id: I851eba4ca80eac9ee5896df53fbcd0f5ad125763 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112433 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-13merge the various SetPointFont via DefaultDevice callsCaolán McNamara2-4/+4
Change-Id: I769bb95c588c7222ff0dc6c4b845dfc3f0d7cbc0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112390 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-13tdf#128469 add extended tooltip for "Reset to Parent"Seth Chaiklin1-1/+1
Change-Id: If5aabfc5b677cbeb375745d5c1902848cf48c13f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112414 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-03-13Drop duplicate methodMike Kaganski8-19/+7
Change-Id: Ib9401c695a48673545d0adeac2bad24c7579e424 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112419 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-13add PixelFormat enum that replaces bit count in Bitmap/BitmapExTomaž Vajngerl1-8/+8
Bit count for the image is a numeric value (sal_uInt16) but only a handful of values make sense - namely 1,4,8,24 and 32. This replaces the numeric value with an enum, which only accepts those values and checks the correct values are used at compile time. Change-Id: I0fc137c62bce3b0d021f05019a1648da628521bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112408 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-03-13update pchesJulien Nabet4-22/+41
Change-Id: Id6dfae9fb97fbe3fc89b9f2e083d7a3d5c1d36d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112411 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-03-13tdf#135774 Char highlight: partial revert tdf#114799Justin Luth1-0/+4
...DOCX import: fix missing numbering highlight from 7.0 commit 315d56582f8a56d8f2d3ea6cda63ea4832249608. If the numbering had a specified w:highlight in numbering.xml, then that character background should apply to the bullet point. However, SetDiffFnt automatically clears the highlight, the same as it does with mxBackColor (fixed in earlier commit). So a special step is needed to check if the font has a highlight, and since that direct formatting has priority, re-apply it after SetDiffFnt has finished. This is slightly different from mxBackColor - which is an optional attribute. Highlight is reset to COL_TRANSPARENT. If a RES_CHRATR_HIGHLIGHT exists explicitly setting a COL_TRANSPARENT, then any overrides should have been removed from pCleanedSet, and so it never needs to SetHighlightColor(AUTO). Change-Id: Id9d88054254563706b9aee90a1d257b467139334 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112410 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2021-03-12tdf#135774 Char highlight: numbering: don't clear existing mxBackColorJustin Luth1-0/+8
If the numbering had a specified w:shd in numbering.xml, then that character background should apply to the bullet point. However, SetDiffFnt automatically clears mxBackColor (and I'm not sure why - but that has been true since way back to original import). Well, in this section the paragraph marker properties should only apply if the numbering doesn't have direct formatting already. So a special step is needed to check if the font has an mxBackColor, and since that direct formatting has priority, re-apply it after SetDiffFnt has finished. (P.S. This had been done earlier for GetHighlightColor, but it was reverted in 7.0. From my testing, I haven't seen an example where it was needed, but it too is reset to null - only it isn't optional.) Again, a unit test will be challenging here, since this is a visual change only. Change-Id: I2be129b11b6f746ba11c19d69bf01f3174c1b64b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111675 Tested-by: Jenkins Tested-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2021-03-12CppunitTest_sw_ooxmlexport: clean up testEffectExtentMarginMiklos Vajna7-5/+5
The shape had line information, but the intent was to test what happens when the shape has some non-zero effect extent, line information is not needed for that. And do the same for a bunch of other tests: a test document should ideally have line information only if it's relevant for a test. Change-Id: I9ea1f38841a30e7e61088d347443e37948b1a9d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112401 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-03-12sw bibliography, refer to a page: make the biblio field clickableMiklos Vajna9-6/+94
- add support for this in SwWrtShell::ClickToField() - restrict this to ctrl-click by default (similar to hyperlinks) - ignore empty URLs - extend the tooltip to hint the URL - change pointer to hint that the field is clickable - downgrade the assert to SAL_WARN in SwAuthorityFieldType::RemoveField(), that currently fires every time a biblio field is de-selected Change-Id: I3b4a12d8a7661f7d8d41804f104505c7594debd6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112400 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-03-12tdf#140977 drop possible table-cursor before setting the new oneCaolán McNamara1-0/+3
Change-Id: I3d278af77886af3413b4a15464c8a52caa9a8e02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112391 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-12tdf#124176 Use pragma once in sw/source/uibase/incViswaasLP1-4/+1
Change-Id: I74c85b0327005ba7b2d07169f052a903381eb1f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112373 Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-03-12we just use the OutputDevice api for SwViewOption::InitCaolán McNamara2-3/+2
Change-Id: I36a52d0e02d6a2fa900abc579d7d1018fc5381f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112388 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-12drop PNGReader and use only PngImageReaderLuboš Luňák1-4/+2
PNGReader is a home-made PNG reader that does not use libpng, so it's more code, presumably less optimized and it apparently also doesn't always map colors properly. The only two features it has that PngImageReader doesn't are explicit chunk reading (used only for reading Microsoft's GIF in PNG, I implemented that for PngImageReader in a previous commit), and it loads paletted images as BitmapEx with a palette instead of converting to direct-color 24/32bpp or 8bpp-gray. The latter is even questional if nowadays that's feature or a misfeature, as it saves memory at the expense of speed. I can implement that if somebody misses it. I had to adjust some tests: - CVE-2016-0952-1.png - invalid CRC of the PNG header, neither Gimp nor Gwenview can display that, it should fail - afl-sample-Z_NEED_DICT.png - failure while decompressing data, but the loader considers that only a partially broken image since the header is correct, so it "passes" (like in Gimp or Gwenview) - SdImportTest::testTdf134210() and testPictureWithSchemeColor::Load_Verify_Reload_Verify() need the colors tested changed, because apparently gamma correction or something is now applied correctly, and it wasn't before (again checked the loaded images with Gimp) Change-Id: Id46f8d8a01256daf48ca64264b47c4e609183837 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112042 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-03-12Revert "tdf#114076: Expand ClipRange to next PixelBound" ...Xisco Fauli1-51/+1
and "tdf#124272 use ClipRegion's geometry if not a rectangle" This commit reverts c1230cede19ae3633e51c7ca780cb34d9dbaa20f and 362c1cf2bd580f6dc8bf27bdcd79174111bc1b5c tdf#114076, or any of its duplicates, is not reproducible in master if c1230cede19ae3633e51c7ca780cb34d9dbaa20f ("tdf#114076: Expand ClipRange to next PixelBound") is reverted. (Tested on Linux and Windows) So, if we revert it, we no longer need 362c1cf2bd580f6dc8bf27bdcd79174111bc1b5c ("tdf#124272 use ClipRegion's geometry if not a rectangle"), which was a follow-up fix for a regression introduced by the first commit. This also fixes tdf#129085 and all the duplicates, which were introduced by the follow-up commit. I plan to add the unittests in a different commit Change-Id: Ie4328c15b24b521127c1b653bd621bfc92ac39cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112340 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-12Revert "merge sw::hack::Position and SwFltPosition"Caolán McNamara4-13/+40
This reverts commit 4f35958c64d5e63c30e67434936c3a0352f57698. (which was an attempt at groundwork at fixing ofz#31538) because ooo46246-1.doc fails to load in crashtesting Change-Id: I334fc4ff1d1a934d92fe69eae63206c0a480e55e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112359 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-12tdf#128469 rename "Standard" to "Reset to Parent" plus tooltipSeth Chaiklin1-2/+2
Change-Id: I73ad5450450c328911d8464924a163faaba9b70c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112301 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2021-03-12Drop some unused includesMiklos Vajna1-1/+0
Change-Id: Ic79d81387867f028eb8dc9553fb87f5961d6c771 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112364 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-03-12Use range-based for; mention similar method in commentsMike Kaganski2-6/+6
Change-Id: I2659faf75e88eecccfdb33368393c140563030e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112304 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-11TransferableDataHelper::CreateFromSelection doesn't use its argumentCaolán McNamara1-1/+1
Change-Id: Id43995411d850ae051d1d803bcea2745e1dc17a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112331 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-11remove some unneeded vcl/window.hxx includesCaolán McNamara2-48/+0
Change-Id: I2b716371e2bebe7390e7f0c7b747140d9f4bdec6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112330 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-11use some forward declares to reduce includesCaolán McNamara1-0/+1
Change-Id: Ic3a6d9a9569f909a7480d9da09709dbd60259e97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112323 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-11remove intermediate containers in sidebarsCaolán McNamara31-347/+191
tested extension sidebars of: a) Wollmux extension sidebars b) Analog Clock Extension demo https://wiki.openoffice.org/wiki/Sidebar_for_Developers#Example:_Analog_Clock_Extension Change-Id: If9729e20526681928137989f01a8ae733a9b0cb5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112035 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-11tdf#140845 labelling improvements for List Styles in ContainsSeth Chaiklin2-4/+3
move hard-coded formatting of liststyle out of sw/source/uibase/utlui/attrdesc.cxx and into sw/inc/strings.hrc, so that translators can customize as needed. In sw/inc/strings.hrc: * "Numbering" -> "List Style: (%LISTSTYLENAME)" * "no numbering" -> "List Style: (None)" (to be consistent with setting in "List Style" control and to keep consistent appearance in Contains) Thanks to Mike Kaganski for assistance. Change-Id: I9d2b6507082fea06665d0d8a3465c314a5d894c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112213 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Tested-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2021-03-11tdf#140934 update annotation menubutton bg when comment color changesCaolán McNamara2-20/+31
Change-Id: Ia4d10a8f19c039655dbe28c5f612061ce3755afa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112278 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-11use strong_int for item ids in vcl::ToolBoxNoel8-33/+29
(*) fix bug in SfxToolBoxControl::StateChanged where it was using the slot id instead of the toolbox item id (*) I left the logic in SbaTableQueryBrowser alone, but it looks suspicious, casting slot ids to toolbox ids Change-Id: Ied229164c27fb4456b0515c6fdcbd1682766a1a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112186 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-11rename GrafikCtor to GraphicCtorNoel6-13/+13
Change-Id: Ib9f4665a9b77e0d90070060f635466a046058431 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112266 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-11tdf#136841: sw_ooxmlexport16: Add unittestXisco Fauli2-0/+17
Change-Id: I951adefaf60e4c0c5d751ac1a886a9c746989a68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112282 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-11tdf#114441: Convert use of sal_uLong to better integer typesBayram Çiçek1-2/+2
Change-Id: Ibb432c3db6d99343514c412c4c1b968808b733c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110886 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-03-11Revert "uitest: sw: re-enable test to see if it still fails"Xisco Fauli1-0/+2
This reverts commit 3d2ed830d63f0d1adcb0404ad979d5fcf9706ca2. Jenkins still fails with this test. See https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/82317/console Meanwhile, sw/qa/uitest/writer_dialogs/openDialogs.py:20 doesn't fail Change-Id: I19d3fc2993e8d7a5a0c031f30d258d57a9cda114 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112321 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-11rename SfxChildWindowContext::GetFloatingWindow to what it doesCaolán McNamara1-4/+4
Change-Id: I0a8e1be2c64d054e6af1e9826f993d3b219e854b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112245 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-11register navigator individually in each module that it exists inCaolán McNamara3-43/+41
instead of globally. This makes the navigators the same as everything else and easier to deal with. Change-Id: I882612e73d36485b84161a2d3fbc1188f734c0fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112244 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-11tdf#140590 Crash in Save-As dialog in Tools>Chapter NumberingNoel Grandin1-1/+1
This would only affect assert builds. The assert condition here did not match the condition in createFastChildContext several lines below. Bug since this code was introduced in commit 1535f39388223de53e4b923c6f7bb71ee32c1858 Date: Fri Nov 7 19:11:11 2014 +0100 sw: store Outline Numbering as ODF fragment instead of SfxPoolItems Change-Id: I3f6a0b91e3c17f4ca358a75116481fc38c01e94e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112233 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-10tdf#139667 change position of Lists submenu in Format menuSeth Chaiklin1-6/+6
Change-Id: I4edc1f2d27be973cd2c892d94f1cb5812435ef9a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112077 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2021-03-10use BitmapEx for testing bitmap contents, not DIBLuboš Luňák2-10/+7
The weirdo that tested the bitmap using the format-specific way was ... me, in 2014. Change-Id: I2cf96ba42da7099f2ce0b80ac53261c67321ef0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112041 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-03-10sw: DOCX export: put fly before fieldmark start into its own runMichael Stahl4-4/+92
If a fly starts at the same position as a CH_TXT_ATR_FIELDSTART, it is anchored before the field, and written in OutFlys() before the field is written in EndRun(), but the DOCX export reorders things in confusing ways. StartField_Impl() and CmdField_Impl() will actually end the current run (after putting the field char in it) and start a new one. So do something similar in this situation and create a new run if flys have been processed. Restrict this extra run to when there is actually a fly, because otherwise a dozen tests break; this requires a new FLY_NONE result for OutFlys() because FLY_PROCESSED is returned even if there are no flys. Change-Id: Id469c53d07eacad3992c7c0e451ab3756e02c8fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112267 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-03-10tdf#140597 DOCX import: fix missing tblPrEx borderLászló Németh2-0/+13
of first table cells, caused by the workaround for tdf#138612. Now property set of a new cell is a copy of the table exception property set of the table row, as needed for the import of the table style inheritance. Regression from commit f319d6b543c2367546bc80d138e56ed03731e265 (tdf#138612 DOCX import: fix lost part of split table cell). Change-Id: Iaf6637e757fbfeef7651a4300a7f65a23615f5c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112247 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2021-03-10tdf#140661: sw: Add UItestXisco Fauli2-0/+61
Change-Id: I637bcd2c8dbe215aa40b0eea69e559935a6d5eaa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112205 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-10tdf#40427: use node index as position, not Y position on screenMike Kaganski3-19/+123
As mentioned in comment to SwContent::nYPosition in sw/source/uibase/inc/swcont.hxx: some subclasses appear to use this for a tools/gen.hxx-style geometric Y position, while e.g. SwOutlineContent wants to store the index in its subtree Abusing the nYPosition to store vertical position *on screen* gives wrong results when a following section is positioned on screen higher than a previous section - e.g., when multiple-page view is active. So just use the section's node as Y position of the Navigator entry. When the section is inside a fly frame, use the frame's anchor node. Change-Id: I6caf26aeb19d845129dc837138c37f42bbc18655 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112197 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-09sw: add UNO API to find the closest doc model position based on pixel positionMiklos Vajna3-0/+76
The use-case is drag&drop: if an UNO API client registers its drag&drop listener, then it gets a DropTargetDropEvent and has to decide if it wants to handle that event or allow Writer to handle it. In case it decides to handle the event, it would be good to able to e.g. insert a string at the point where the Writer UI indicates it to the user. But DropTargetDropEvent only exposes a pixel position and Writer requires you to have an XTextRange when inserting content. Fix the problem by introducing a new createTextRangeByPixelPosition() which first does a pixel -> logic coordinate conversion (this is window-specific, in case you have multiple windows), then picks the doc model position which is the closest to a logic coordinate. Change-Id: I6a8e69e3c39b9d99209342469653c0e0bd99bf53 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112201 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-03-09Add missing comments as per TEMPLATE.SOURCECODE.HEADERMike Kaganski1-0/+5
Change-Id: I6a8ed8598690795d5e23fb461db50f7f7852912a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112216 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-09tdf#128469 add "Apply" tooltip for all style dialogsSeth Chaiklin1-1/+1
Change-Id: I37c6ffe85da6d68fff89480a589a358624c047fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112091 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2021-03-09tdf#140674 sw change tracking: fix :emoji: replacementLászló Németh2-2/+37
Regression from commit 2951c96bcb673a260a09e2c6eb92ca0f99bf0c18 (tdf#83419 sw change tracking: clean-up autocorrect). Note: only :snowman: -> ☃ was added to the test autocorrect file acor_en-GB.dat. Change-Id: Ic3013e969ab937a5f9e5b6d1a6fac2f533b541f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112166 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2021-03-09fetch/set/clear primary selection without intermediate vcl::WindowCaolán McNamara1-2/+2
the intermediate layer doesn't do anything useful Change-Id: I00564f43db8914445ea4013c6f387c7d7c783427 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112170 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-09Related tdf#140849: "Apply and Edit changes" from AutoCorrect crashes LO writerJulien Nabet1-1/+2
This patch only fixes the assertion here: 3 0x00007f4d0ae82662 in __GI___assert_fail (assertion=0x7f4cef73d9d1 "SAL_N_ELEMENTS(RID_SHELLRES_AUTOFMTSTRS) == STR_AUTOFMTREDL_END", file=0x7f4cef73d961 "/home/julien/lo/libreoffice/sw/source/uibase/utlui/initui.cxx", line=186, function=0x7f4cef73d99f "void ShellResource::GetAutoFormatNameLst_() const") at assert.c:101 4 0x00007f4cef2514b8 in ShellResource::GetAutoFormatNameLst_() const (this=0x747f430) at sw/source/uibase/utlui/initui.cxx:186 Regression from da64ec8c8a91db6a6ec9657898f081d5ee67e739 author László Németh <nemeth@numbertext.org> 2020-06-01 19:31:38 +0200 committer László Németh <nemeth@numbertext.org> 2020-06-02 18:40:06 +0200 commit da64ec8c8a91db6a6ec9657898f081d5ee67e739 (patch) tree 2bd7d3ddf24ce6c5adeb3c29dd46ead2e1215c0a parent 2d6395b87218cbf3512aa9b54807a859205006f0 (diff) tdf#133589 AutoCorrect: transliterate to Old Hungarian Change-Id: Ib606ffcf5f0d6921c41dcb256af12ff54017a590 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112118 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-03-09Drop "32" from names of SbxArray methods taking 32-bit indicesMike Kaganski2-13/+13
... a leftover from times when there were methods for 16-bit as well as for 32-bit indices. 16-bit indices were removed in commit 62f3f3d92aa204eaaa063b30d7ade44df501b997. Change-Id: Idf8b1160e68e8b303cf75ea79dd7dbb3bd00275d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112187 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-12-05 00:38:19 +0000