summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)AuthorFilesLines
2021-02-01sw: prefix members of FormatLevel, SwNumberPortion, SwPostItsPortion and ...Miklos Vajna7-53/+53
... SwRubyPortion See tdf#94879 for motivation. Change-Id: I24bb59ea921cdea2888d5a1009db5030e4ee897a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110239 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-02-01use symbolic names for outline content visibility menu items idsJim Raykowski1-19/+31
Change-Id: Ic0b5d6c59cf601b21a8bedd9b9cab17014ea25b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110189 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2021-01-31drop call to SetQuickHelpText() with empty stringCaolán McNamara1-1/+0
because the QuickHelp is never set to anything non-empty. Before commit commit c230e962ca2c876187a028fa14426210b5746a0f Date: Tue Jan 12 10:43:45 2010 +0100 sw33a11y01: #i88070# refactoring of sidebar window code used for visualization of comments/annotations SetQuickHelpText was called with a non-empty string in one branch so SetQuickHelpText cleared it again, but now its always empty Change-Id: If4635e899b27ce16fd0aa25254f33415142f9718 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110165 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-30tdf#134619 docxexport: don't skip font properties in NumberingLevelJustin Luth3-4/+18
This partially reverts LO 6.4.5 commit 598ca431de96d8bfcf18fa2945e9e30f98387474 The output set can contain more than just the font name. Things like colour and fontsize were being lost when the "else" clause was added. Since it looks like the main intent of the else clause was to avoid specifying a font name twice, erase that from the property set before writing out the rest of the font properties. There is a unit test that enforces that. (I was not able to reproduce the original problem that this was trying to fix. The entire commit is hard to revert, and I will assume that the rest of the commit is useful/accurate, so just fix up a careless portion of the commit.) Change-Id: I772e40e8bd75c0589f3308d4d7470229855aed8f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110034 Tested-by: Jenkins Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de> Reviewed-by: Justin Luth <justin_luth@sil.org>
2021-01-30don't scroll to cursor during GetSurroundingTextCaolán McNamara1-0/+12
lock against scrolling to cursor if the IM requests the surrounding text around the cursor seen on launching a menu from a sidebar comment's menubutton in writer if the cursor is a scroll-off page position in the main document Change-Id: I325004987f576df65188629bf6fb63e0ed0be9bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110153 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-30loplugin:finalclasses in swNoel80-141/+127
Change-Id: Ib939c1f34ae79abfc077080d2c2561ee0ee4a4fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110156 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-29remove SwCache bookkeeping from SwModifyBjoern Michaelsen14-144/+146
- only very few classes (SwNode, SwFormat) are the "owners" of SwBorderAttrs in the SwCache - this bookkeeping should not be in such a fundamental class of writer - also: encapsulate most of the interaction with the cache in the new sw::BorderCacheOwner. This is mostly to protect the innocent user: * As interacting with the SwCache directly is very errorprone, because its glorious idea of using void* of the "owners" as keys to the entries. * In C++, reinterpret_cast<void*>(this) might be different along the class heirachy. This might easily slip under the radar of a casual user. Change-Id: I0da774b47885abf52f63aab8d93ebbf41dcf8040 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110112 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2021-01-29sw: don't repaint all text frames on turning off a bullet for bullet numberingsMiklos Vajna2-1/+37
This is similar to the text node deletion case, but here no text is deleted, just a text node with bullet numbering is turned into one without a numbering. Again, it is not necessary to repaint all text frames of the numbering, since the bullet char is the same for all nodes (unlike e.g. Arabic numbering). Change-Id: Ieb071031ca5ce0421c4120c4c89089af6c811848 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110125 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-01-29tdf#75923 "Always Correct" to "Add to AutoCorrect" in Spelling dialogSeth Chaiklin1-3/+4
* improve choices for accelerator keys + add tooltip for "Add to AutoCorrect" + add missing extended tip for "Add to Dictionary" * change "Always correct to" to "Always AutoCorrect to" in Spelling context menu. + add tooltip for "Always AutoCorrect to" Change-Id: I54428fcd03ed7205a503935c77a7e08f9682bb1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109809 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-01-29loplugin:stringviewparam extend to new..Noel1-1/+1
O[U]StringBuffer methods Change-Id: I0ffbc33d54ae7c98b5652434f3370ee4f819f6f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110090 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-28sw: fix SwTOXMgr::UpdateOrInsertTOX() for user-definedMichael Stahl1-13/+4
The main problem is that when editing an existing user-defined index, the "Create From" changes aren't applied, because it does pCurTOX->SetCreate() and not pNewTOX->SetCreate(). But that wasn't obvious as the function is obviosly very confused about its 3 different TOX variables. pTOX is just used at the end, so just move it there. pCurTOX can be const. Then there is an odd condition on pSh->HasSelection() which ends up doing DelRight() but fortunately it's dead code since commit e9da29679bce3b544add9233a4aca2b19b78da1a #i97572# cleared the selection already. The pNewTOX = pCurTOX there seems pointless because pNewTOX is already a copy of *pCurTOX. Change-Id: I1e9c8178e314a188a50272410fbe566e4a566742 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110021 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-01-28sw: don't repaint all text frames on text node delete for bullet numberingsMiklos Vajna2-9/+98
The intention of the InvalidateNumRule() call is probably to make sure that generated number portions in e.g. Arabic numbering are up to date. But this is not necessary for bullets and causes not needed invalidations. Change-Id: Iad555727e5e2b069bbffae0e7650fb8c75a56770 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110079 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-01-28simplify code, use more subView()Noel6-9/+9
Change-Id: I569c7f34acbdf8451cd5c9acf1abd334637072d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110051 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-28tdf#64690: sw: Add UItestXisco Fauli1-0/+79
Change-Id: I5fb9c630cb4c7e51add571c1fe24b1e5f14cffba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110045 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-01-28uitest: sw: close document at the endXisco Fauli1-0/+2
Change-Id: Ic07b3eac1b4e3a5555da5a54d2ce1fa4d284d886 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110047 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-01-28TopLeft().Y() -> Top() etc.Caolán McNamara1-1/+1
TopLeft().X() -> Left() BottomLeft().X() -> Left() TopRight().X() -> Right() BottomRight().X() -> Right() TopLeft().Y() -> Top() TopRight().Y() -> Top() BottomLeft().Y() -> Bottom() BottomRight().Y() -> Bottom() Change-Id: I5050f619bf92cfc59b6f8dfe7c9f98ef1453c294 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110022 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-28add string_view variants of methods to O[U]StringBufferNoel3-8/+8
and update the stringview loplugin to detect cases where we can use these new methods. Change-Id: I998efe02e35c8efcb3abfb4d7186165bbe6dfb2c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110046 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-27Improve loplugin:stringliteralvarStephan Bergmann5-71/+58
...to also consider O[U]String ctors taking pointer and length Change-Id: Iea5041634bfbf5054a1317701e30b56f72e940fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110025 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-01-27sw_fieldmarkhide: adjust SwPaM::HasReadonlySel() to the fact that...Michael Stahl1-3/+5
... there is, in fact, an else branch. D'oh. (regression from f8da730bd66d5d6d3e49935573b3223c06baffbe) Change-Id: I378b0a78a4ccc9a0e7fa9a6bf2e1ecb456133bed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110012 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-01-27tdf#138907 sw TitlePageDlg: Goto correct (inserted) pageJustin Luth3-21/+228
Especially with inserted-in-the-middle pages, until the layout was re-calculated, the new pages were not recognized. This patch should bring this format option into pretty good shape. I made a couple of decisions: 1.) Insert an additional content page when adding to end of document (otherwise the last index page turned into content). 2.) Ensure that index pages don't inherit page-renumbering This CalcLayout could take a fair amount of time on a huge document. I tested on a document that took over a minute to load. It inserted pages in about 10 seconds. The experience seemed reasonable to me given the known slowness of the document. make UITest_writer_tests5 UITEST_TEST_NAME=\ titlePageWizard2.tdf138907.test_tdf138907 Change-Id: I6d7763ab10b46b5a459e9b62ed96b0194b2258b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109830 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-01-27Removed duplicated includesAndrea Gelmini2-2/+0
Change-Id: Idabfa3c710cd9286d73ad61d4e9209769c57a5c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110000 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2021-01-26Fix typoOlivier Hallot1-1/+1
in GtkLabel 'numdist' Change-Id: I33f2b6649c9e49be1a8eb28631f9e1bf4b3dd541 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109842 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-26tdf#139147 sw outline UI: allow clearing of custom list formatJustin Luth1-1/+8
Since LO 6.4.5, primarily for DOCX support, numbering can have a custom format that ignores the suffix, prefix etc. Well, the UI has no way to see or edit that. So allow the UI to throw that away and go back to the normal prefix/subLevels/suffix model. Change-Id: I84f93d37c95dabb18facf9140bf8f85b4bac5006 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109839 Tested-by: Jenkins Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de> Reviewed-by: Justin Luth <justin_luth@sil.org>
2021-01-26tdf#137803 sw: fix AutoSize and Wrap of textboxesAttila Bakos (NISZ)6-5/+118
When autosize (AutoGrowHeight) turned on the textbox fell apart. After changing the text of the textbox the positions still were different for the shape and the textframe. Now this fix solves, if the text changes, the positions (with the size what worked only before) synchronized so the textboxes are kept together. Also Wrap text inside the shape now works like the editeng text did, except in the case of empty text boxes. Note: this fixes only editing (without positioning the textboxes by the mouse before or after the setting), but not import/export, yet. The ooxmlimport test has been restored to its original state, because the fix for the tdf#135198 is fixed by this commit. To start the unit test just give the following command: $ (cd sw && make UITest_writer_tests7 UITEST_TEST_NAME="tdf137803.tdf137803.test_tdf137803" SAL_USE_VCLPLUGIN=gen) Change-Id: Ie13a7a1e81e4099cd8540edd7e008118e58134bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107515 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-01-26tdf#108124: sw: Move UItest to CppUnitTestXisco Fauli3-42/+48
Change-Id: I130ec18719c6ae959df8cb2c923fef634d17eaf4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109925 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-01-26tdf#137655 DOCX table import: fix zero para top marginLászló Németh2-0/+8
when only w:beforeAutospacing=0 was specified, but not PARA_TOP_MARGIN (see default_spacing = -1 in processing of LN_CT_Spacing_beforeAutospacing). Follow-up of commit 61821277ed4974debd05af89cb7284602512088f (tdf#104354 writerfilter: rewrite Autospacing). Change-Id: I5fff7a8b62450ebaf8ef6b552ecbb2b1cfb24381 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109914 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2021-01-26tdf#134605 DOCX export: fix unexpected loss of footer marginMiklos Vajna3-0/+21
Regression from commit 51534ac2b9747975945acb6a1e1ba5cc6d73f5c2 (tdf#127778 DOCX import: fix unexpected heading on non-first page ..., 2020-05-11), which replaced an import fix with an export fix. What was missed there is the import fix handled both headers and footers, while the export fix only handled headers. Fix the problem by doing the same mapping for footers: if a follow page style has no footer, but the first page style has, then take the margin from that one. The import side did the opposite of this already. Change-Id: Ibb191db4136bce0ad5e4bf14dcea15f5955bd298 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109927 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-01-26loplugin:passstuffbyrefNoel5-6/+6
Change-Id: I330e0ab6c9955939dad313f9d472f93e39dbd313 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109924 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-25tdf#139830: keep the right context for chart after view switch (writer).Tamás Zolnai2-0/+53
Change-Id: Id4829e4bf8f52e2348ebd7874c77e245b18a2bb9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109812 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109899 Tested-by: Jenkins
2021-01-25tdf#138780: sw_ooxmlexport12: Add unittestXisco Fauli2-0/+16
Change-Id: I439abf01e753d64fa61bf1fc776d579e1e006d73 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109893 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-01-25sw: prefix members of SwBidiPortion, SwDoubleLinePortion, ...Miklos Vajna6-140/+140
... SwGrfNumPortion and SwSaveClip See tdf#94879 for motivation. Change-Id: Iade32e16fa36555aacbfe794895d015bee0226de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109866 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-01-25Revert "sw: DOCX export: don't export numPr to style from outline numrule"Justin Luth1-4/+3
This reverts 7.1 commit 9e455724e50bf512683b1cddfeb7493e047c19ae. to fix regression bugs tdf#138780 and tdf#139089 Change-Id: I2a5bbcd990a6648667342cc989160582e0367f09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109864 Tested-by: Justin Luth <justin_luth@sil.org> Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-01-25SwFntCache: move down from SwFormat to SwTextFormatCol where possibleBjoern Michaelsen4-44/+48
Change-Id: Ia5dcc3b1145c6bd65253577499da3bb80d82e926 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109659 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2021-01-24Dont double clear cachesBjoern Michaelsen1-6/+0
- NumRuleChg calls sw::BroadcastMixin::CallSwClientNotify - which always calls SwModify::CallSwClientNotify - which always clears caches Change-Id: Iaf00e90bb7db9bd20ec08718043ce5b4025abecc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109153 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2021-01-24tdf#139136 Style Inspector: "true" and "false" now localizableshivam-511-4/+4
Change-Id: Ib223e941ca4285a0eeae9127edc161311f56aa36 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109709 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-01-24Use ContainerType().swap and avoid local variablesMike Kaganski1-4/+2
Change-Id: I773555180758a97aff37f9bc27de83c355d71521 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109761 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-01-23tdf#135590: sw: Add UItestXisco Fauli1-0/+80
Change-Id: I89b1b7fef33cfd6960af4da38112199f3874d9fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109828 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-01-22tdf#135590 MapUnit::Map100thMM fallback is inappropiate for writerCaolán McNamara1-0/+1
which uses MapUnit::Twip so directly after insert, envelope, ok the new document sidebar was using MapUnit::Map100thMM to lookup paper sizes instead of MapUnit::Twip giving inconsistent results against format, page Change-Id: I6a92fddedfe9fef8ad7532ad00b2b38b9741bb69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109782 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-22tdf#138899 DOCX import: fix removing last para of sectionLászló Németh2-0/+7
Fix regression from commit 39090afac268f9ae985832c2f08863b41e6c06f2 (tdf#120336 DOCX import: fix page break after tracked deletion), limiting the condition only for *empty* section starting paragraphs with tracked deletion. Change-Id: I020c8b0edf5d4a37a9150cccec8c25fce50327d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109779 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2021-01-22tdf#121669 ww8 export: use the "we have equal columns" flagJustin Luth4-11/+24
If the columns are marked as AutoWidth, then there is no need to go to the remarkably poor layout code to determine if the columns should be exported as equal. In this case, it appears as if the layout engine hadn't really identified the full width, or evaluated the wish values of each column. This fixes DOCX, DOC, and RTF. Change-Id: I1a1193b65d01e654b3bfbfaee7d8c02a683ae2c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109762 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-01-22Fix typoAndrea Gelmini1-2/+2
Change-Id: I5bea6423a3c3bbe933ae5160ac02923ddea5c408 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109777 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-01-22tdf#138546 sw PageDialog: fix bad reset of colwidthJustin Luth4-9/+55
The presence of border padding was causing the algorithm to reset the overall width, which in page style triggered an even redistribution of the columns. That should only happen when the number of columns changes, or else one of the 5 predefined column choices is selected. My first python unit test is included. make UITest_writer_tests4 \ UITEST_TEST_NAME=tdf138546.tdf138546.test_tdf138546 Change-Id: I650e429568f2ab794649cc557998a809479b6e82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108210 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-01-22Fix typoAndrea Gelmini1-1/+1
Change-Id: Id6594ea397f08e1b460d8ba94cb05e674dfa2ba0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109757 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2021-01-21remove deprecated [x|y]align property for CheckBoxes and RadioButtonsCaolán McNamara72-352/+0
the gtk default is left aligned, change the vcl one to match and drop the deprecated and unnecessary [x|y]align Unfortunately on load glade's inline preview shows centered alignment, though its "true" preview tool shows left alignment and unsetting and resetting draw-indicator will update the preview to show the alignment which will be used: https://gitlab.gnome.org/GNOME/glade/-/issues/502 See https://gitlab.gnome.org/GNOME/glade/-/merge_requests/110 for my stab at making glade do the right thing. Change-Id: If454e9ce8462e6b271d2423fe7e8a55788e01fac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109487 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-21rename grid8 to ddedependJim Raykowski1-1/+1
fixes missed rename in commit 83de497ae90f69118c35121bc228f15fbb5c5623 Change-Id: Ib344c7a5bb41f063ee5efc13a935b34c82a742d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109729 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-21_yes -> _YesCaolán McNamara2-2/+2
Change-Id: Ie85ea2b8a2620d0a62f39b39ebbb2ac41ab85d61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109756 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-21lok: fix incorrect invalidate cursor positionHenry Castro1-6/+6
When the comment is created and it's shown in the "Writer" application, it creates an initial output area: mpOutlinerView->SetOutputArea( PixelToLogic( tools::Rectangle(0,0,1,1) ) ); Unfortunately, it causes that send to client side cursor position and scroll to the beginning of the document. Change-Id: I13e21c71328b7f05781e7cdeed082d6cc2b9d679 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109371 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 4618849a1cbba4e249ee13c3b6412337160a2816) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109732 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2021-01-21tdf#138907 sw TitlePageDlg: Goto correct (existing) pageJustin Luth2-14/+116
If the starting page for the new Title pages is beyond the end of the document, then insert the new pages after the last page. Also, handle the "physical" blank pages which threw off calculations for Index pages. 1.) It was wrongly inserting before the last page. 2.) Cap InsertPosition() to document-end. 3.) An odd/even blank filler page would cause missing or mis-applied styles. NOTE: The wizard is still completely useless when adding pages, because GotoPage does not recognize that the document has inserted pages, and so it goes by pre-wizard page coordinates. This is just the first step in correcting the overall problem (which I don't know how to do). make UITest_writer_tests5 UITEST_TEST_NAME=\ titlePageWizard.tdf138907.test_tdf138907 Change-Id: Ie138c4ab3126bc6d3fae16028b41a80bda329f1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108332 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-01-20tdf#116757 sw ChangesInMargin: add "Show Insertions in Margin"László Németh21-14/+243
layout mode to allow to show the original text inline, i.e. only deletions, while insertions are showed in margin (opposite of the Show Deletions in Margin mode). Add a menu to the Show Changes icon on the Changes toolbar with menu items for the 3 layout modes "All Changes Inline", "Deletions in Margin" and "Insertions in Margin" with the following behavior: – Selecting a menu item turns on also the Show Changes mode to show the result immediately; – Disabling Show Changes mode always show the final text, i.e. only insertions. Enabling Show Changes mode again shows the changes according to the last Show Changes mode selected in the menu. – The new "Insertions in Margin" mode is intended to be only a run-time option, i.e. it's not possible to set it as a default Show Changes mode in Options, unlike "Deletions in Margin". Change-Id: Ie4dc9fe3b4b201fa9976ef04877af649e242ab46 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109649 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-01-20ofz#29691 revert throw SvStreamEOFExceptionCaolán McNamara13-48/+41
reasonably sane code like s.ReadUInt32(a).ReadUInt32(b).ReadUInt32(c).ReadUInt32(d); if (s.good()) // use a, b, c d; stopped working. FWIW on a short read we retain whatever was in the variable before the read, rather than overwrite it with new random data, so sal_uInt32 a(0xdead); s.ReadUInt32(a); assert(s.good() || a == 0xdead); the msoffice ppt/escher/xls/doc filters especially speculatively parse and rely on a variables preinit value in the case of a short read. commit b345a2bab0d6f981049951a86b172ce49ce7d4c2 cid#1470786 Uncaught exception commit 71aec4726a94dcde1169fd293dbecfeb0e840e6d ofz#29528 uncaught exception commit bed03603f6cae264abb9e5b58aa2ab00448d92ff ofz#29414 uncaught exception commit 684885a99a1eb7ad943e9736166d4bb1468663be ofz#29443 uncaught exception commit 93574ac7768d247ed754ecda322e54e4bd447e43 ofz#29251 Abrt commit 413db68d95bd39d34e6a6b81a7c5c9478ced0514 ofz#29152 short read commit f400e883044143f999c460375a293647b4a57244 ofz#29151 short read commit 96ea80a725dfe4ef38993f78917c243f13e3beb5 ofz#29129 Abrt on uncaught exception commit 646a635efe6eecbc3d1dd3a7cbb02a278c6f3be5 ofz#28931 Indirect-leak commit b0e573f18629d28fe3179c12d0d434653f92fc93 ofz#29030 Abrt in xlsfuzzer commit 95407c39168d186ee44e67b1a6a4bcf592c58b84 ofz#28902 uncaught exception commit 45175d655ad3773df1c006182108cf25e87b1091 oss-fuzz: tgafuzzer doesn't pass sanity check commit b82fc702bae9d6190bda1b4818a47cfa197df6d8 oss-fuzz: psdfuzzer doesn't pass sanity check commit e7c76d604a4694e6568bf10c2a06a786f1096319 oss-fuzz: epsfuzzer doesn't pass sanity check commit 901e5e7c9170184e286ea3e46fce406136aa9572 oss-fuzz: xlsfuzzer doesn't pass sanity check commit 127bfab61c297df06fd8e71e709bc4362cb89d21 oss-fuzz: pngfuzzer doesn't pass sanity check commit 77387ae00ae27e3f8bcdf7bccf97fb2db8f196b7 oss-fuzz: mtpfuzzer doesn't pass sanity check commit 974ffa79b0fef4ca76558bb8b16bce84af3aaf6c oss-fuzz: xlsxfuzzer doesn't pass sanity check commit 6d6d104cbb382d0045e1f04b12d268992fa5c624 oss-fuzz: bmpfuzzer doesn't pass sanity check commit a7d1d107ec58d3b00b4019c89edddcff71ca6ff3 oss-fuzz: qpwfuzzer doesn't pass sanity check commit 898993aa62276f59480df8af1da4bad530829b56 oss-fuzz: pcxfuzzer doesn't pass sanity check throw/catch parts of commit 8c9a4ff511a3b1d84a7a6d08a1b153c07f164abb throw exception in SvStream when reading past end of file Change-Id: Ic49c249768b17b64d8e868655dbc05b31906c2e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109621 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-11-28 01:35:35 +0000