summaryrefslogtreecommitdiff
path: root/sw/source
AgeCommit message (Collapse)AuthorFilesLines
4 hoursAvoid new string allocations, when only checking if emptyMike Kaganski1-2/+2
Change-Id: I35a44dedd27b5c3470ed035e64ec0461d8d0cbdf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177074 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
10 hourstdf#162195: use SwFrame::IsHiddenNow when building indexMike Kaganski2-30/+52
Before commit 0c96119895b347f8eb5bb89f393351bd3c02b9f1 (tdf#159565 prerequisite: make hidden sections have zero-height frames, 2024-02-15), the hidden sections were absent from layout, so didn't appear in the SwTOXBaseSection::Update* functions. Now they are zero-height, but present, so their visibility must be taken into account explicitly. Change-Id: I95cc72b383a99e1f65152579c5458e253a3f60ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177079 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
10 hoursUse specific SvtModuleOptions::Is*Installed for clarityMike Kaganski9-22/+17
Change-Id: Ibe64b9fcccf33471d96bb0fb1aa896cb456657f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177069 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
13 hourstdf#163486: PVS V1028 Possible overflow. Consider casting operands,Aron Budea1-1/+1
...not the result. Change-Id: I4ba8afa5989aea906000bb9c4059855015055002 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177042 Tested-by: Jenkins Reviewed-by: Aron Budea <aron.budea@collabora.com>
23 hourscid#1634864 avoid Missing move assignment operatorCaolán McNamara2-3/+3
and cid#1634866 Missing move assignment operator Change-Id: Iaf588bdd9185da6afeee26eea0607e72a9792bab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177045 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
27 hoursPVS: V547 Expression 'bComplete' is always true.Xisco Fauli1-7/+2
Since commit 47527821f32f9b5890b39b4031f5962f5cb46646 Author: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org> Date: Mon Nov 16 22:17:07 2020 +0100 SwGrfNode: Remove graphic arrived hack Change-Id: I7c0a3b0208d2da06781be6b69e04e9958b762870 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177036 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
27 hourssw: do not paint hidden frames' bordersMichael Stahl1-0/+5
SwFrame::PaintSwFrameShadowAndBorder() is called by upper's SwFrame::PaintSwFrameBackground() so it needs another check. (regression from commit ff7f1b59e22092d8548459e75fe912db852f056f) Change-Id: Ic7ac28e4af8e0abf4970d87edb40a79ad4d25156 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177032 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
27 hoursPVS: V1048 The 'bRet' variable was assigned the same valueXisco Fauli1-3/+1
Change-Id: Idbd94e0eb49819f737a90bcb161cd3dd88f24221 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177014 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
29 hourssw: no need to pass a bool as a referenceXisco Fauli5-31/+14
Change-Id: I62aabd66d368856959be032d866888b82b018dd9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177018 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
29 hoursPVS: V1048 The 'bTestAllowed' variable was assigned the same value.Xisco Fauli1-4/+1
Change-Id: I8322b68ce93adedbcb5ae2462b5ed1868d3552db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177013 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
29 hoursPVS: V547 Expression 'bNoDictionaryAvailable' is always falseXisco Fauli1-1/+1
Since commit a50a2bf8e8c6084aeacb8d2db42e21f528410742 Author: Szymon Kłos <szymon.klos@collabora.com> Date: Thu Jan 24 11:22:22 2019 +0100 tdf#86731 Don't show 'start from beginning' when dictionary is missing Change-Id: Ib71051ddbb3318c74fb5020ec27560f1c6f73893 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177017 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
30 hourscrashtesting: invalid iterator on load of forum-de-1233.odt docx exportCaolán McNamara1-2/+4
although the actual order doesn't change there is a Delete/Insert of the object in case the order should change. ::Insert will check if sorted and resort if not anyway, so presumably if we just skip the middle-men and resort here if we need to then that is equivalent, but without the invalidation for the already sorted case. #0 SwSortedObjs::Remove (this=0x510ed40, _rAnchoredObj=...) at core/sw/source/core/layout/sortedobjs.cxx:243 #1 0x00007fffce0af130 in SwSortedObjs::Update (this=0x510ed40, _rAnchoredObj=...) at core/sw/source/core/layout/sortedobjs.cxx:282 #2 0x00007fffcdf32c40 in SwAnchoredObject::UpdateObjInSortedList (this=0x51123c0) at core/sw/source/core/layout/anchoredobject.cxx:661 #3 0x00007fffcdf8fc38 in SwFlyFrame::SwClientNotify (this=0x5112260, rMod=..., rHint=...) at core/sw/source/core/layout/fly.cxx:859 #4 0x00007fffcdf9d1bf in SwFlyAtContentFrame::SwClientNotify (this=0x5112260, rMod=..., rHint=...) at core/sw/source/core/layout/flycnt.cxx:112 #5 0x00007fffcd65bca8 in SwModify::CallSwClientNotify (this=0x4e68da0, rHint=...) at core/sw/source/core/attr/calbck.cxx:311 #6 0x00007fffcd65bd71 in sw::BroadcastingModify::CallSwClientNotify (this=0x4e68da0, rHint=...) at core/sw/source/core/attr/calbck.cxx:316 #7 0x00007fffcd65b42f in SwModify::SwClientNotify (this=0x4e68da0, rHint=...) at core/sw/source/core/attr/calbck.cxx:302 #8 0x00007fffcd66771b in SwFormat::SwClientNotify (this=0x4e68da0, rHint=...) at core/sw/source/core/attr/format.cxx:300 #9 0x00007fffcdf4448a in SwFrameFormat::SwClientNotify (this=0x4e68da0, rMod=..., rHint=...) at core/sw/source/core/layout/atrfrm.cxx:2843 #10 0x00007fffcd65be1e in sw::ClientNotifyAttrChg (rModify=..., aSet=..., aOld=..., aNew=...) at core/sw/source/core/attr/calbck.cxx:325 #11 0x00007fffcd66948e in SwFormat::SetFormatAttr (this=0x4e68da0, rSet=SfxItemSet of pool 0x1bcebe0 with parent 0x4e68e68 and Which ranges: [(88, 141), (159, 159), (1014, 1034)] = {...}) at core/sw/source/core/attr/format.cxx:597 #12 0x00007fffce649a2c in SwXFrame::setPropertyValue (this=0x5e47b90, rPropertyName="Size", _rValue=uno::Any("com.sun.star.awt.Size": ...)) at core/sw/source/core/unocore/unoframe.cxx:1867 #13 0x00007fffcdc4d7ea in SwTextBoxHelper::syncProperty (pShape=0x4dce770, nWID=89, nMemberID=0 '\000', rValue=uno::Any("com.sun.star.awt.Size": ...), pObj=0x0) at core/sw/source/core/doc/textboxhelper.cxx:995 #14 0x00007fffcdf2e2d7 in SwAnchoredDrawObject::GetObjBoundRect (this=0x4e69dd0) at core/sw/source/core/layout/anchoreddrawobject.cxx:757 #15 0x00007fffcdf320ca in SwAnchoredObject::GetObjRectWithSpaces (this=0x4e69dd0) at core/sw/source/core/layout/anchoredobject.cxx:575 #16 0x00007fffcdf31eaa in SwAnchoredObject::InvalidateObjPosForConsiderWrapInfluence (this=0x4e69dd0) at core/sw/source/core/layout/anchoredobject.cxx:400 #17 0x00007fffcdf32be5 in SwAnchoredObject::UpdateObjInSortedList (this=0x510e530) at core/sw/source/core/layout/anchoredobject.cxx:654 #18 0x00007fffcdf8fc38 in SwFlyFrame::SwClientNotify (this=0x510e3d0, rMod=..., rHint=...) at core/sw/source/core/layout/fly.cxx:859 #19 0x00007fffcdf9d1bf in SwFlyAtContentFrame::SwClientNotify (this=0x510e3d0, rMod=..., rHint=...) at core/sw/source/core/layout/flycnt.cxx:112 #20 0x00007fffcd65bca8 in SwModify::CallSwClientNotify (this=0x4e364a0, rHint=...) at core/sw/source/core/attr/calbck.cxx:311 #21 0x00007fffcd65bd71 in sw::BroadcastingModify::CallSwClientNotify (this=0x4e364a0, rHint=...) at core/sw/source/core/attr/calbck.cxx:316 #22 0x00007fffcd65b42f in SwModify::SwClientNotify (this=0x4e364a0, rHint=...) at core/sw/source/core/attr/calbck.cxx:302 #23 0x00007fffcd66771b in SwFormat::SwClientNotify (this=0x4e364a0, rHint=...) at core/sw/source/core/attr/format.cxx:300 #24 0x00007fffcdf4448a in SwFrameFormat::SwClientNotify (this=0x4e364a0, rMod=..., rHint=...) at core/sw/source/core/layout/atrfrm.cxx:2843 #25 0x00007fffcd65be1e in sw::ClientNotifyAttrChg (rModify=..., aSet=..., aOld=..., aNew=...) at core/sw/source/core/attr/calbck.cxx:325 #26 0x00007fffcd66948e in SwFormat::SetFormatAttr (this=0x4e364a0, rSet=SfxItemSet of pool 0x1bcebe0 with parent 0x4e36568 and Which ranges: [(88, 141), (159, 159), (1014, 1034)] = {...}) at core/sw/source/core/attr/format.cxx:597 #27 0x00007fffce649a2c in SwXFrame::setPropertyValue (this=0x4a86e10, rPropertyName="Size", _rValue=uno::Any("com.sun.star.awt.Size": ...)) at core/sw/source/core/unocore/unoframe.cxx:1867 #28 0x00007fffcdc4d7ea in SwTextBoxHelper::syncProperty (pShape=0x4dc65f0, nWID=89, nMemberID=0 '\000', rValue=uno::Any("com.sun.star.awt.Size": ...), pObj=0x0) at core/sw/source/core/doc/textboxhelper.cxx:995 #29 0x00007fffcdf2e2d7 in SwAnchoredDrawObject::GetObjBoundRect (this=0x4e3a0d0) at core/sw/source/core/layout/anchoreddrawobject.cxx:757 #30 0x00007fffcdf320ca in SwAnchoredObject::GetObjRectWithSpaces (this=0x4e3a0d0) at core/sw/source/core/layout/anchoredobject.cxx:575 #31 0x00007fffcdf815b3 in (anonymous namespace)::IsNextContentFullPage (rThis=...) at core/sw/source/core/layout/flowfrm.cxx:217 #32 0x00007fffcdf81002 in SwFlowFrame::IsKeep (this=0x4e5a630, rKeep=..., rBreak=..., bCheckIfLastRowShouldKeep=false) at core/sw/source/core/layout/flowfrm.cxx:259 Change-Id: If2191e8b99d1b0347bab54a704013ce0a9a19410 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176992 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
32 hoursReqIF: avoid 'type' attribute in 'ul' elementsMike Kaganski1-16/+19
Change-Id: I028737cac0b89344be5df55f9b60046230603979 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176987 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2 dayssw: fix hiding/unhiding section via conditionMichael Stahl1-1/+3
The problem was that when un-hiding a section, table rows that contained only empty paragraphs were not reformatted and remained at height 0. It turns out that the table row that became visible did so because the cells had a VertOrientation different from NONE and so SwContentNotify::ImplDestroy() invalidated the cells' printarea. However, the real problem isn't in the layout code at all, as it then turns out that the reason why anything is reformatted at all is that there are docinfo fields on the same page as the section and also in the paragraphs at the start of the section, and these get invalidated somehow after unhiding the section. Unhiding the section didn't actually invalidate anything in the layout because in ImplSetHiddenFlag() no change is detected, and that is because the section was first hidden by removing its (false) condition, which calls SwSection::SetSectionData() and that didn't call ImplSetHiddenFlag(), again relying on docinfo field update to trigger the relayouting. Change-Id: Ie5d9e4d5a0467c17c662f20f8d54aa6b22b382da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176914 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2 dayssw: layout: fix unhiding section containing multiple page breaksMichael Stahl1-4/+7
With multiple page breaks in a hidden section, the following frames were only moved on the first break, and with the second break the frames go out of order in SwSectionFrame::SwClientNotify(). Also handle multiple columns there. (regression from commit a97e245ba11598050e1800fde9ace796d20e9df2) Change-Id: I4120e72bf083f3bed75f9305fbd757efd55f0b3d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176773 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2 daysdocx: export empty GrabBag elements as self-closing xml tags - 2Andras Timar1-1/+6
In 6cb711645b8d8f3cee0d3454e193cc7bf1cad305 the condition was not good, because there is a special element called "attributes" which is not a child element but contains attributes of the current element. In the condition we should check for 0 elements that are not "attributes". Change-Id: I1d6995e13f288902c1cce85ac3b7d4e0da213df8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176900 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2 daysRelated: cid#1634864 can use member list initialization hereCaolán McNamara1-4/+3
Change-Id: I39c56e381fda147b5dac885f95e93648c366225d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176901 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2 dayssw: layout: fix crash in SwSectionFrame::MakeAll()Michael Stahl1-0/+4
sectfrm.cxx:854: Assertion `moveBackPos == &GetPrecede()->GetFrame()' failed. Because the section has columns, and GetPrevSctLeaf() apparently returns the body frame in a column. (regression from commit c60ad7e0fbf3cc86af167f5e98b38c25620ada7e) Change-Id: I16fcd7a42b24e54873cde0aa0087c7aa56b0a8e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176738 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2 dayscid#1634865 Uninitialized scalar fieldCaolán McNamara1-0/+1
since: commit 43b9ab55a3b6ac1497bcadd6a71a5a133ece4d3d CommitDate: Tue Nov 19 01:15:00 2024 +0100 tdf#163956 calculate line height differently in FORMTEXT Change-Id: Ic0e6e78f77b1adf6f5ca9fe7a48e113bd8592552 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176898 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
3 daysResolves tdf#163856 - Disentangle boundaries optionsHeiko Tietze9-116/+114
* Boundary toggles removed from app colors * Object boundaries completely removed (color replaced with DOCBOUNDARIES; Impress placeholder on/off now an expert option) * Toggle options added under formatting aids * Individual UNO commands marked deprecated * New command added to show all boundaries * Frames follow sections now in state and color * Kind of wrapping doesn't matter anmymore Change-Id: I7bbec20831dcb95abef6523884d84b05a1a7df0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176242 Tested-by: Jenkins Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
4 daysconsider VndSunStarExpand an exotic protocolCaolán McNamara1-1/+2
and generally don't bother with it when fetching data from urls Change-Id: I51a2601c6fb7d6c32f9e2d1286ee0d3b05b370b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176645 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
4 dayssw: unused returnXisco Fauli1-4/+2
Change-Id: I18a5665609b3e15a98bb88e6d307e9f18be967e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176778 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
4 daystdf#160621 tdf#162702 Variable field dialog page resizeOliver Specht1-0/+6
Reduce the size of the upper boxes to get more space for the field value input. Fixes also tdf#162702 by setting the size also to the number format list box. Change-Id: I96cc38b30fa7afccf6ca009aad3b15f1f051d381 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176106 Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
4 daysdocx: export empty GrabBag elements as self-closing xml tagsAndras Timar1-10/+17
Although <tag></tag> and <tag/> are syntactically equivalent, we got a report that some 3rd party tool could not process a docx file produced by LibreOffice. In styles.xml there was <w14:ligatures w14:val="standardContextual"></w14:ligatures> instead of <w14:ligatures w14:val="standardContextual"/> This patch is meant to fix this, to mimic what Word does anyway. Change-Id: Iea409981d2a2eac40c460bdae4d3dc7e8b0c33ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176680 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Jenkins
5 daysimprove loplugin passparamsbyrefNoel Grandin18-28/+28
I think I managed to disable this when I converted it to use the shared plugin infrastructure. So fix that, and then make it much smarter to avoid various false positives. Change-Id: I0a4657cff3b40a00434924bf764d024dbfd7d5b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176646 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
5 daystdf#163340 pasting paragraphs with lists changed againOliver Specht2-11/+24
Pasting paragraph with a list into an empty or completely selected paragraph with lists has been changed: If the pasted paragraph(s) are all formatted with a list from the paragraph style then this list will be preferred. If some the pasted paragraphs including the first one are formatted with a hard list then these attributes will be preferred. If all paragraphs have a hard list or no list at all the list at the target position will be preferred. Change-Id: I5aa6834d32f7c69b2eb9f8330b282c0ae6fca559 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176478 Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Tested-by: Jenkins
5 daystdf#163956 calculate line height differently in FORMTEXTOliver Specht4-5/+21
Lines containing EN_SPACES only ignore character height while calculating line height. In FORMTEXT fieldmarks the character height of the default EN_SPACES is not ignored. Change-Id: I8a89f13875f61ed287ce1697a91b42f20bd17192 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176147 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Tested-by: Jenkins
5 daystdf# 162326 reset paragraph list attributes on style applyOliver Specht3-9/+9
Follow-up to a593c27e8897280871dc310184ff568bf34a6ebe. If Ctrl key is presseed then remove list attributes of the paragraph, too. Change-Id: I29ea97ff08f45061d532b11cb981c534cc786f0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174977 Tested-by: Jenkins Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
5 daystdf#163486: PVS: dereferencing of a potential null pointerXisco Fauli1-2/+5
V522 There might be dereferencing of a potential null pointer. Change-Id: I23e4eba0399243ca67ecaa3101a327eece825687 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176722 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
5 dayscid#1606638 silence Overflowed integer argumentCaolán McNamara1-0/+3
and cid#1608572 Overflowed integer argument cid#1607772 Overflowed integer argument cid#1607196 Overflowed integer argument cid#1606568 Overflowed return value cid#1607573 Overflowed return value Change-Id: I9a701b19026572127399712c3b660094f2a0bd40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176740 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
5 dayscrashtesting: crash on import of rtf exported from forum-en-32886.odtCaolán McNamara1-10/+17
see: git diff -w Change-Id: Id50e45e53b7b433d6c468038a7de14441f4ee560 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176707 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
6 dayscid#1607919 Overflowed constantCaolán McNamara1-2/+5
Change-Id: I842357000f3282521aa927921a5598fddaef5dee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176686 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
6 dayspNew is only possible if there is a pRedLineCaolán McNamara1-6/+11
so we can move this inside the other conditional Change-Id: I63259598d5165e3aafbf0c1cfef70ccb1b16bb38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176685 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
7 dayscid#1371295 avoid Missing move assignment operatorCaolán McNamara1-2/+6
Change-Id: I27cca1b737c441a9f31ed6aa0fc462190ca818da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176682 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
7 dayscid#1557644 COPY_INSTEAD_OF_MOVECaolán McNamara1-1/+1
Change-Id: I63510464b74e72f8fc73899e963e20891cdf0f12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176644 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
8 daystdf#163486: PVS: fix assertXisco Fauli1-1/+1
V547 Expression '!"unknown reference mark type"' is always false. Change-Id: I7f984c0e008924b23e3a2384c2e36390bf76cfec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175252 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
9 daystdf#163486: PVS: Identical branchesBogdan Buzea1-11/+2
V1037 Two or more case-branches perform the same actions. Check lines: 931, 941 Change-Id: Id5be5973b9b3141576d82f64e5fc46acd926b81e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175228 Reviewed-by: David Gilbert <freedesktop@treblig.org> Tested-by: Jenkins
9 dayscool#9992 lok doc sign, hash extract: add signatureTime parameterMiklos Vajna1-21/+3
Execute getCommandValues('Signature') on the same document twice, you get different hashes, because the content includes a timestamp, which changes, so it's not possible to know if the hash is stable or not. Also, working with a provided timestamp will needed for <https://docs.eideasy.com/electronic-signatures/api-flow-with-file-hashes-pdf.html#_4-add-the-signature-to-the-pdf-file> anyway. Fix the problem by adding a signatureTime parameter and this way we can have a test that makes sure we get the same hash if the time is provided. With this, the hash extraction part is meant to be ~complete. Change-Id: If5e1e5bcf84c3b777f26b2ded24dcca48ea9ad94 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176601 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
9 daystdf#163486: PVS: redundant nullptr checkXisco Fauli1-2/+1
V668 There is no sense in testing the 'pUndo' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error. Change-Id: I3eeff673f5c0862e0b3c7f0a5338ddb0882ab31d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176594 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
9 dayscid#1634638 Use of auto that causes a copyCaolán McNamara1-9/+11
and cid#1634639 Missing move assignment operator Change-Id: Icfc8f958dccae87fd646404c3a5a3772362bcc13 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176573 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
9 dayscid#1634806 Logically dead codeCaolán McNamara1-1/+1
Change-Id: If8de961277c3f1a29d2f2ab58261abd8145d4316 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176572 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
9 daystdf#163486: PVS: Expression is always falseXisco Fauli1-1/+1
V560 A part of conditional expression is always false: pTable == nullptr. Change-Id: Id6f9a8ff3943fecbe77a4d339b3ca76e27a86605 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176585 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
9 daystdf#163486: PVS: Expression is always trueXisco Fauli1-1/+1
V560 A part of conditional expression is always true: pFlyFormat. Change-Id: I9cc68a314dcdf98857eaf39aacf613d6fa67b720 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176584 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
9 daystdf#163486: PVS: Expression is always falseXisco Fauli1-4/+0
V560 A part of conditional expression is always false: pPap. V560 A part of conditional expression is always false: pSty. Change-Id: I37a2cce02f303b9a3944c232d57f89b9087375ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176586 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
9 daystdf#163486: PVS: Expression is always trueXisco Fauli1-1/+0
Since commit 9cddf9da7fb256418e1bc3b4719abb55e3b0604c Author: Vladimir Glazounov <vg@openoffice.org> Date: Tue May 22 15:33:44 2007 +0000 INTEGRATION: CWS chart2mst3 (1.1.2); FILE ADDED V560 A part of conditional expression is always false: (!(pTableFormat && pUnoCursor)). V560 A part of conditional expression is always true: pTableFormat. V560 A part of conditional expression is always true: pUnoCursor. Change-Id: Id690161e2a64a82f94530142879bf291bd8df743 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176583 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
9 daystdf#163486: PVS: Expression is always trueXisco Fauli1-1/+1
V560 A part of conditional expression is always true: pFormatItem. Change-Id: I82009191496573e7f9dd1a6ab7f19df2243a30b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176582 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
9 daysImprove loplugin:dyncastvisibility to check for non-inline key functionsStephan Bergmann1-0/+2
This would have caught the issue discussed in 709b1f3ddb87303a2dec6155dbe0106369c151ed "Make sure VCLXPopupMenu has unique RTTI". (The commit message talks about RTTI there, while what Clang actually compared for an optimized implementation of a dynamic_cast to a final class is vtable pointers, but the overall picture remains the same. Both RTTI and vtables are emitted along the key function, and if that is missing or inline, they are emitted for each dynamic library individually, and as internal symbols on macOS.) This commit also addresses all the issues found by the improved loplugin:dyncastvisibility on Linux. See the newly added TODO in compilerplugins/clang/dyncastvisibility.cxx and 86b86ac87ea0cc90249f156494c98c3c93e4f3fc "Give DocumentEventHolder (aka EventHolder<DocumentEvent>) a key function" for an issue with key functions for class template instantiations. Change-Id: Ia19155efb1d23692c92b9c97ff17f18ae7a1f3ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176576 Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Tested-by: Jenkins
10 daysSwNavigator: Improve the page change controlJim Raykowski1-6/+6
The intent of this patch is to address an issue with the Writer Navigator page change control reported at https:// ask.libreoffice.org/t/writer-display-single-page/111050 "I have selected View > Normal and View > Whitespace and View> Zoom> Entire Page. On the bottom right, I’ve chosen the single page icon." ... "It is odd that the page number displayed as you click the [Navigator Page control spin button] up and down arrows does not change.." The patch changes the function used by the page control to determine the page number of the page in the view to that used by the status bar page control. It also disables page tracking by the control when the view is set to Multiple-page view or Book view. Change-Id: I439bb4493061528f87eaeca3c08a33095adb8192 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173888 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
10 daystdf#163486: PVS: variable was assigned the same valueXisco Fauli1-1/+0
Since commit 1847211c00612b4d0c0cb0700aeecd4881a0e01b Author: Sander Vesik <svesik@openoffice.org> Date: Wed Apr 21 11:25:53 2004 +0000 INTEGRATION: CWS loadenv01 (1.27.22); FILE MERGED V1048 The 'm_bViewCreated' variable was assigned the same value. Change-Id: I2c5fe19dcbc0524f6a4bf9baf774cc5ef0c2e793 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176545 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
10 daystdf#163486: PVS: variable was assigned the same valueXisco Fauli1-6/+0
V1048 The 'm_bDelete' variable was assigned the same value. Change-Id: Ib324ee9473de6b8ce8d4e6e073265580c8a3ba68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176546 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
generated by cgit v1.2.3 (git 2.39.1) at 2024-11-23 18:49:46 +0000