summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)AuthorFilesLines
2024-10-23tdf#163486: PVS: Expression is always trueXisco Fauli1-3/+2
V560 A part of conditional expression is always true: pItem. Change-Id: I4ae18820dc7ec3232bccb099e56dd0da2b4f59eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175456 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-10-22cid#1555259 COPY_INSTEAD_OF_MOVECaolán McNamara2-3/+3
and cid#1555264 COPY_INSTEAD_OF_MOVE cid#1555280 COPY_INSTEAD_OF_MOVE cid#1555303 COPY_INSTEAD_OF_MOVE cid#1555313 COPY_INSTEAD_OF_MOVE cid#1555314 COPY_INSTEAD_OF_MOVE cid#1555323 COPY_INSTEAD_OF_MOVE cid#1555333 COPY_INSTEAD_OF_MOVE cid#1555338 COPY_INSTEAD_OF_MOVE cid#1555349 COPY_INSTEAD_OF_MOVE cid#1555364 COPY_INSTEAD_OF_MOVE cid#1555379 COPY_INSTEAD_OF_MOVE cid#1555398 COPY_INSTEAD_OF_MOVE cid#1555410 COPY_INSTEAD_OF_MOVE cid#1555411 COPY_INSTEAD_OF_MOVE cid#1555416 COPY_INSTEAD_OF_MOVE cid#1555429 COPY_INSTEAD_OF_MOVE cid#1555434 COPY_INSTEAD_OF_MOVE cid#1555441 COPY_INSTEAD_OF_MOVE cid#1555446 COPY_INSTEAD_OF_MOVE cid#1555480 COPY_INSTEAD_OF_MOVE cid#1555490 COPY_INSTEAD_OF_MOVE cid#1555524 COPY_INSTEAD_OF_MOVE cid#1555527 COPY_INSTEAD_OF_MOVE cid#1555531 COPY_INSTEAD_OF_MOVE cid#1555578 COPY_INSTEAD_OF_MOVE cid#1555581 COPY_INSTEAD_OF_MOVE cid#1555591 COPY_INSTEAD_OF_MOVE cid#1555614 COPY_INSTEAD_OF_MOVE cid#1555619 COPY_INSTEAD_OF_MOVE cid#1555633 COPY_INSTEAD_OF_MOVE cid#1555654 COPY_INSTEAD_OF_MOVE cid#1555707 COPY_INSTEAD_OF_MOVE cid#1555712 COPY_INSTEAD_OF_MOVE cid#1555746 COPY_INSTEAD_OF_MOVE cid#1555763 COPY_INSTEAD_OF_MOVE Change-Id: Ibcc1a3649c5663328e60474c06e51902aa74db52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175407 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-10-22tdf#163284: Diagonal/criss-cross borders for tables is only implemented in CalcJulien Nabet1-7/+13
Change-Id: I645fd2a6fafb2607d94607599366d9442b4423fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175199 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2024-10-22tdf#163486: PVS: Identical branchesBogdan Buzea1-4/+0
V1037 Two or more case-branches perform the same actions. Check lines: 1048, 1053 Change-Id: I24f2b4698ff8c0d57aa81b57b42a847caa6c1aeb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175360 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-10-22cid#1545605 COPY_INSTEAD_OF_MOVECaolán McNamara3-4/+4
and cid#1545841 COPY_INSTEAD_OF_MOVE cid#1554682 COPY_INSTEAD_OF_MOVE cid#1554686 COPY_INSTEAD_OF_MOVE cid#1554715 COPY_INSTEAD_OF_MOVE cid#1554750 COPY_INSTEAD_OF_MOVE cid#1554759 COPY_INSTEAD_OF_MOVE cid#1554770 COPY_INSTEAD_OF_MOVE cid#1554779 COPY_INSTEAD_OF_MOVE cid#1554794 COPY_INSTEAD_OF_MOVE cid#1554800 COPY_INSTEAD_OF_MOVE cid#1554826 COPY_INSTEAD_OF_MOVE cid#1554836 COPY_INSTEAD_OF_MOVE cid#1554862 COPY_INSTEAD_OF_MOVE cid#1554865 COPY_INSTEAD_OF_MOVE cid#1554872 COPY_INSTEAD_OF_MOVE cid#1554883 COPY_INSTEAD_OF_MOVE cid#1554906 COPY_INSTEAD_OF_MOVE cid#1554921 COPY_INSTEAD_OF_MOVE cid#1554926 COPY_INSTEAD_OF_MOVE cid#1554946 COPY_INSTEAD_OF_MOVE cid#1554956 COPY_INSTEAD_OF_MOVE cid#1554970 COPY_INSTEAD_OF_MOVE cid#1554986 COPY_INSTEAD_OF_MOVE cid#1554991 COPY_INSTEAD_OF_MOVE cid#1555013 COPY_INSTEAD_OF_MOVE cid#1555037 COPY_INSTEAD_OF_MOVE cid#1555050 COPY_INSTEAD_OF_MOVE cid#1555057 COPY_INSTEAD_OF_MOVE cid#1555066 COPY_INSTEAD_OF_MOVE cid#1555067 COPY_INSTEAD_OF_MOVE cid#1555083 COPY_INSTEAD_OF_MOVE cid#1555097 COPY_INSTEAD_OF_MOVE cid#1555135 COPY_INSTEAD_OF_MOVE cid#1555140 COPY_INSTEAD_OF_MOVE cid#1555146 COPY_INSTEAD_OF_MOVE cid#1555148 COPY_INSTEAD_OF_MOVE cid#1555149 COPY_INSTEAD_OF_MOVE cid#1555155 COPY_INSTEAD_OF_MOVE cid#1555157 COPY_INSTEAD_OF_MOVE cid#1555168 COPY_INSTEAD_OF_MOVE cid#1555195 COPY_INSTEAD_OF_MOVE cid#1555196 COPY_INSTEAD_OF_MOVE cid#1555237 COPY_INSTEAD_OF_MOVE Change-Id: I90531c19c28dca77fe99c72efdfc0972c311da98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175377 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-22no need to cache GraphicAttr in SdrGrafObjNoel Grandin2-44/+21
just retrieve the data when we need it, avoids marking this object dirty unnecessarily Change-Id: Ic3455e782365e8f2d3b89d8e5052da9d7bdaba2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175371 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-10-22We don't need a virtual hereCaolán McNamara1-5/+0
Only known SdPages need this Change-Id: Id504cd1ec318fa8cce43d11f03c628e7457f7634 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175369 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-10-22move vcl::DeleteOnDeinit to toolsNoel Grandin4-8/+8
so we can fix a shutdown use-after-free in sot. Change-Id: I32f83bd94627d72d7bee7ea2ebd6ab77a7f78435 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175335 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-10-21tdf#145161: Change image compression dialog stringAditya Sahu1-1/+1
Since image compression does not always reduce image resolution, change the misleading label from "reduce image compression" to "change image compression". Change-Id: I9d2ab6c1d6409cdad32d4bf801a33f26cbba2f5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175260 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
2024-10-21drop StyleSheetCreatedNoel Grandin1-7/+1
the only place that references it, effectively ignores it. I cant find anything that really uses it, as far back in the git history as commit 59bb5ba445352f88e3ac2d00a5dc3f9bb872326a Author: Vladimir Glazounov <vg@openoffice.org> Date: Wed Apr 11 18:36:28 2007 +0000 INTEGRATION: CWS hedaburemove01 (1.1.2); FILE ADDED when it was introduced. Removing this removes a bunch of expensive broadcast operations. a similar mega-master-page scenario as reported in tdf#158773 20s -> 17s Change-Id: I84ee269aa0ea96e9f77601b01d4795edd3294044 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175175 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-10-21tdf#163486: PVS: Identical branchesBogdan Buzea1-13/+0
V1037 Two or more case-branches perform the same actions. Check lines: 194, 200 V1037 Two or more case-branches perform the same actions. Check lines: 796, 800 V1037 Two or more case-branches perform the same actions. Check lines: 804, 810 Change-Id: Icef65820f99405ca78d31dc9e1afc0a9d5c6b355 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175279 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-10-21Support FixedCellHeight in SdrAutoFitTextPrimitive2DArmin Le Grand (allotropia)4-6/+25
That was missing with the result that for some cases the painted text (where it was missing) differed from the text in EditEngine mode (was set there). Change-Id: I23ddf8e90be2335c56e5a485308c753dfe72a878 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175127 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2024-10-21svx: prefix members of Viewport3DMiklos Vajna2-44/+44
See tdf#94879 for motivation. Change-Id: Ice9c1353d3411146f11d4ca34eb6369403cd4094 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175294 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-10-21Make tools::Time ctor taking sal_Int64 privateMike Kaganski1-2/+2
This ctor is meant to set the value of nTime directly; and that value is not nanoseconds, but an encoded value, using SEC_/MIN_/HOUR_MASK. But in some places, this ctor was misused for setting of nanoseconds, which would only accidentally work for values less than one second. All places that initialized tools::Time with 0, now use EMPTY. This makes the ctor private; and for the very few cases where really the encoded value of nTime is stored / restored, fromEncodedTime is introduced. Change-Id: I1f1994bd9aab1b51a41b1de637619049fe820da4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175283 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-10-21vcl: move bitmap filter headers into vcl/bitmap global header directoryChris Sherlock3-26/+26
Use #pragma once instead of header guards Change-Id: Iba43f2103628ed184933cf2611991e7aef9f0173 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173369 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins
2024-10-20tdf#75280 Convert sal_uIntPtr to size_t a more appropriate integer typeChizoba ODINAKA1-1/+1
Change-Id: Ia4bb455877a2c8c8c125c643c3ea6e4c162dea20 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175248 Reviewed-by: David Gilbert <freedesktop@treblig.org> Tested-by: Jenkins
2024-10-20tdf#163486: PVS: identical sub-expressionsXisco Fauli1-2/+2
Since commit 78010a4db197ac44fb729a122464847931ee0e5b Author: Caolán McNamara <caolanm@redhat.com> Date: Thu Oct 4 15:37:14 2018 +0100 Resolves: tdf#106340 resize dialog when search/replace labels are shown/hidden V501 There are identical sub-expressions '!m_xReplaceAttrText->get_visible()' to the left and to the right of the '||' operator. V501 There are identical sub-expressions '!m_xReplaceAttrText->get_visible()' to the left and to the right of the '||' operator. Change-Id: Ib62557af291679c253162e3d72a39659691ef0b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175285 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-20cid#1606920 Overflowed integer argumentCaolán McNamara1-2/+3
Change-Id: I6fc6a12e611a974e8feaecd398242226ab9ad930 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175246 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-17tdf#159007 Revert "optimization to skip SdrObject::GetViewContent()"Caolán McNamara3-41/+4
This reverts commit 313be607903a381830600c0a60b2e299fcaec685. Change-Id: I2dc7489ecc302473edd763fd0e4d6784fadc9bb4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175094 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-17tdf#34804 sw: enable keyboard shortcut for CharColor and CharBackColorJustin Luth2-3/+4
The result of this patch is that a keyboard shortcut can now set the font fore-/back-ground color using the color shown in the toolbar/sidebar. This is now possible thanks to Maxim's work in 7.6.2 tdf#154270 Sync toolbar button recent colors and Andreas Heinisch's 24.8 commit 8c822b764b35a0116a0865e991a87c8315e0 tdf#72991 - Remember last used color depending in cui This patch does 3 things: 1. SetRecentColor when the app initializes 2. Uses SID_ATTR_CHAR_COLOR's recentColor for .uno:FontColor if no pItem was provided (i.e. a keyboard shortcut called it) 3. Uses SID_ATTR_CHAR_BACK_COLOR's recentColor for .uno:CharBackColor if no pItem was provided (Note that without a selection, CharBackColor isn't so useful for a keyboard shortcut, since it turns the drag-and-drop template on.) Setting the recent color right away is critical for user acceptance. Otherwise, it would only function after they first modified the color in the toolbar/sidebar. make CppunitTest_sw_uiwriter9 CPPUNIT_TEST_NAME=testTdf34804 Unfortunately, I can't reliably know if this request came from an awt::KeyEvent or not, because in that case we could just avoid CharBackColor's template altogether. [While there is rReq.GetModifiers() as a good hint, it is not a guarantee (in case assigned to a function key, or CTRL held while clicking the toolbar, etc.)] Change-Id: I7377f087dcdf7011205af005cd0d172100bade2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174804 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2024-10-16loplugin:unusedmethodsNoel Grandin1-1/+0
Change-Id: I6ba4b4046190b701d4a15c6fa90b6009ecf4ab1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175014 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-10-15svx: check SfxObjectShell::Current()Xisco Fauli1-3/+3
Change-Id: Ie8e504491d350d582620a5c421d6243239d437d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174976 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-10-15svx: prefix members of Camera3DMiklos Vajna1-26/+26
See tdf#94879 for motivation. Change-Id: I87d734dbfffb2335fb5e4d69c1ad753b52256ab1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174961 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-10-15tdf#163397 svx: Use field color for WeldEditView bgMichael Weghorn1-1/+1
Use field color instead of the window color for the WeldEditView background. This is consistent with the color used for the other text edit controls like the VCL Edit, see Edit::ApplySettings. While field and window color are the same color for e.g. gtk3 or gen, they're different colors for macOS and Qt-based VCL plugins, at least when using the Breeze style that's default on KDE Plasma. With this commit in place, the background color becomes white for macOS and Linux with the qt5 VCL plugin with the Breeze style. For the latter, this had changed to light grey with commit 9dd26d7a2cc6b314dcc0b52000e0475bb4ced57d Date: Thu Sep 5 01:37:44 2024 +0530 Libreoffice Theme Part 0: Read correct colors from qt based VCL_PLUGINS Change-Id: I42232fd07891046b18cc7f112118cac673e2090d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174890 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-10-14Reorder to avoid useless assignments immediately reassignedMike Kaganski1-5/+4
Change-Id: Ia89e8d0ca5da12fdecc82f174d04f365ba682fea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174796 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-10-14Dereference before nullptr checkMike Kaganski1-2/+2
After commit 2c8c436c4a8546276e285dd18f3f7ded091a2c4e (tdf#152992: for Impress/Draw add horizontal hit tolerance for quick text edit, 2023-07-21). Change-Id: Ia19bca115f95c53851dc63cdc7e4336f0289d731 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174793 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-10-14cid#1554844 COPY_INSTEAD_OF_MOVECaolán McNamara7-11/+11
and cid#1554878 COPY_INSTEAD_OF_MOVE cid#1554907 COPY_INSTEAD_OF_MOVE cid#1555082 COPY_INSTEAD_OF_MOVE cid#1555224 COPY_INSTEAD_OF_MOVE cid#1555301 COPY_INSTEAD_OF_MOVE cid#1555378 COPY_INSTEAD_OF_MOVE cid#1555395 COPY_INSTEAD_OF_MOVE cid#1555452 COPY_INSTEAD_OF_MOVE cid#1555466 COPY_INSTEAD_OF_MOVE cid#1555514 COPY_INSTEAD_OF_MOVE cid#1555566 COPY_INSTEAD_OF_MOVE cid#1555753 COPY_INSTEAD_OF_MOVE cid#1555782 COPY_INSTEAD_OF_MOVE cid#1555825 COPY_INSTEAD_OF_MOVE cid#1555842 COPY_INSTEAD_OF_MOVE cid#1555891 COPY_INSTEAD_OF_MOVE cid#1555917 COPY_INSTEAD_OF_MOVE cid#1555961 COPY_INSTEAD_OF_MOVE cid#1556021 COPY_INSTEAD_OF_MOVE cid#1556055 COPY_INSTEAD_OF_MOVE cid#1556307 COPY_INSTEAD_OF_MOVE cid#1556349 COPY_INSTEAD_OF_MOVE cid#1556436 COPY_INSTEAD_OF_MOVE cid#1556665 COPY_INSTEAD_OF_MOVE cid#1556696 COPY_INSTEAD_OF_MOVE cid#1556718 COPY_INSTEAD_OF_MOVE cid#1556775 COPY_INSTEAD_OF_MOVE cid#1556835 COPY_INSTEAD_OF_MOVE cid#1556877 COPY_INSTEAD_OF_MOVE cid#1556994 COPY_INSTEAD_OF_MOVE cid#1557010 COPY_INSTEAD_OF_MOVE cid#1557074 COPY_INSTEAD_OF_MOVE cid#1557111 COPY_INSTEAD_OF_MOVE cid#1557142 COPY_INSTEAD_OF_MOVE cid#1557163 COPY_INSTEAD_OF_MOVE cid#1557164 COPY_INSTEAD_OF_MOVE cid#1557214 COPY_INSTEAD_OF_MOVE cid#1557254 COPY_INSTEAD_OF_MOVE cid#1557322 COPY_INSTEAD_OF_MOVE cid#1557327 COPY_INSTEAD_OF_MOVE cid#1557492 COPY_INSTEAD_OF_MOVE cid#1557565 COPY_INSTEAD_OF_MOVE cid#1557663 COPY_INSTEAD_OF_MOVE cid#1557798 COPY_INSTEAD_OF_MOVE Change-Id: I2ae9c184dcc18d44a65437e18c49e16b27f4d81d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174893 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-12cid#1608328 Overflowed constantNoel Grandin1-30/+28
Change-Id: I2a69dd73ee915299f803efae891cbbd991f43b2c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174772 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-10-08cid#1632259 COPY_INSTEAD_OF_MOVECaolán McNamara1-5/+5
and cid#1632258 COPY_INSTEAD_OF_MOVE cid#1632257 COPY_INSTEAD_OF_MOVE cid#1632256 COPY_INSTEAD_OF_MOVE cid#1632255 COPY_INSTEAD_OF_MOVE cid#1632254 COPY_INSTEAD_OF_MOVE cid#1632253 COPY_INSTEAD_OF_MOVE cid#1632252 COPY_INSTEAD_OF_MOVE cid#1632251 COPY_INSTEAD_OF_MOVE cid#1632250 COPY_INSTEAD_OF_MOVE cid#1632249 COPY_INSTEAD_OF_MOVE cid#1632248 COPY_INSTEAD_OF_MOVE cid#1632247 COPY_INSTEAD_OF_MOVE cid#1632246 COPY_INSTEAD_OF_MOVE cid#1632245 COPY_INSTEAD_OF_MOVE cid#1632244 COPY_INSTEAD_OF_MOVE cid#1632243 COPY_INSTEAD_OF_MOVE cid#1632242 COPY_INSTEAD_OF_MOVE cid#1632241 COPY_INSTEAD_OF_MOVE cid#1632240 COPY_INSTEAD_OF_MOVE cid#1632239 COPY_INSTEAD_OF_MOVE cid#1632238 COPY_INSTEAD_OF_MOVE cid#1632237 COPY_INSTEAD_OF_MOVE cid#1632236 COPY_INSTEAD_OF_MOVE cid#1632235 COPY_INSTEAD_OF_MOVE cid#1632234 COPY_INSTEAD_OF_MOVE cid#1632233 COPY_INSTEAD_OF_MOVE cid#1632232 COPY_INSTEAD_OF_MOVE cid#1632231 COPY_INSTEAD_OF_MOVE cid#1558073 COPY_INSTEAD_OF_MOVE cid#1557945 COPY_INSTEAD_OF_MOVE cid#1557916 COPY_INSTEAD_OF_MOVE cid#1557898 COPY_INSTEAD_OF_MOVE cid#1557808 COPY_INSTEAD_OF_MOVE Change-Id: Ibf417c154255fe3b0598127df5b5805ed543c8d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174660 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-07svx: prefix members of SvxNumberingPreviewMiklos Vajna1-35/+35
See tdf#94879 for motivation. Change-Id: I75e86d37a88ce9c71c0c8886bf782666d23fd6dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174568 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-10-05Use good old string literals in assertXPath and friendsMike Kaganski4-127/+118
These are only sent to an external API expecting char*-like strings, or for comparison. Having every assertXPath having three of _[ou]str is too much syntactic noise, making the unit tests almost unreadable. Change-Id: Ic004a36ea75e7bfe0b96f405c40f926a957b51cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174416 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-10-04support setting writer comment contents from simple-htmlCaolán McNamara1-2/+8
Change-Id: I42002c1b1ade940603ca6d2ca0f6072f1672cce8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174471 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-03cid#1606754 Thread deadlockNoel Grandin1-4/+9
Change-Id: I51985e5ac573aa42c011730b73848ab55a4b2130 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174410 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-10-03simplify SvxShapeCollection::disposeNoel Grandin1-37/+25
Change-Id: Idb1605b27995cbf9eccb2710f74f6ccb37547646 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174409 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-10-01No broadcast on ObjectChange when in destructionArmin Le Grand (allotropia)1-1/+1
Saw that on a stack on gerrit, checking if that is okay for the rest of functionality, should be Change-Id: Ifa61a54edb46b0c98afc59b77674e3686fa29a59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174311 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2024-10-01loplugin:constantparamNoel Grandin1-3/+1
Change-Id: Ibf1f8b8c01333f87f8e8cd73ccb0d62f30fbcd2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174303 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-10-01loplugin:constantparamNoel Grandin1-2/+2
Change-Id: I81c9647ec7166ba429f6f58e3bd86b3a5ee4848f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174302 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-09-30svx: prefix members of SdrSnapViewMiklos Vajna2-32/+32
See tdf#94879 for motivation. Change-Id: I898a1c638258397a1964e409db413b00ba3f149f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174212 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-09-29Related: tdf#161826 - A bit more accurate Glow effect for texts in shapesBalazs Varga1-2/+2
With a more accurate exponentiation function the text glow effect, maybe can be more accurate comaparing to the MSO. follow-up commit: 3eac847927a0cdfa40c3fea38c473ed2ad7faecc and 5bb5a7ea60c4496d7ad21ad81a0f37f6f5fd2288 Change-Id: I82d6fae0564b8d9f5b519408b54a0937a674c643 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173980 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2024-09-23svx: prefix members of SdrPolyEditViewMiklos Vajna1-16/+16
See tdf#94879 for motivation. Change-Id: Ib50e86f1ec207de37074f953eb062c2c46c3a2f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173784 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-09-21Make replacement graphic management more atomicMike Kaganski4-8/+11
Commit 8872f7121b4ae4dd0b51820366d3510a88f7aac2 (crashtesting: crash on exporting kde274105-6.docx to .rtf, 2024-03-27) added some safety code in EmbeddedObjectRef::GetReplacement. It mentioned, that there are likely some bugs in the management of the graphic. This tries to fix this management, avoiding the intermediate states, and only changing the graphic when all the data is ready. This also reverts the changes of the mentioned commit, obsoleted now; and of commit 8780fa41dcd164af244742461f4e57a4bcf4c7a4 (svtools: fix lost replacement grpahic when updating it via OLE fails, 2018-10-30); but keeps commit 24231f2a336c50eac5e6a1621c57e60ebe1e1cf4 (svtools: fix lost replacement non-rendered graphic when updating it fails, 2022-02-17). This has revealed that the second part of unit test for tdf#143222 ("Check export of embedded worksheet in slide"), introduced in commit 92a407b7f90a98704a238c5ffa3a3491eaf3263a (tdf143222 Handle alternate content of graphicData element., 2021-07-08), has never really worked: the "pGraphic != nullptr" check would never fail; in fact, that used to always return an empty graphic. The problem was filed as tdf#163064, and the test was modified accordingly. Commit 5d997c029e53c31a3651a08f5012645097cec48f (sw XHTML export: improve dummy OLE object handling, 2018-08-30) made ReqIF export handle missing replacement graphic. However, it had assumed that SwOLENode::GetGraphic always returns a valid pointer even for the missing data. That is fixed here in OutHTML_FrameFormatOLENodeGrf. Other places, where the pointer was dereferenced unconditionally, were fixed (keeping current behavior). Change-Id: Ica97a691ecc11b856bdb003f89467ea3392684bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173716 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-09-18cid#1607355 silence Overflowed constantCaolán McNamara1-1/+1
and cid#1607426 Overflowed constant cid#1608151 Overflowed constant cid#1608163 Overflowed constant cid#1608208 Overflowed constant cid#1608228 Overflowed constant cid#1608299 Overflowed constant cid#1608549 Overflowed constant cid#1607982 Overflowed constant cid#1608078 Overflowed return value Change-Id: Id4ccc03b610f4dcf7912c239c7c079da1aef4ba2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173615 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-17cid#1608289 silence Overflowed constantCaolán McNamara1-2/+4
Change-Id: Ia42be7ae929767dbb02cecd0f87d6b3a994b8f90 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173517 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-16svx: prefix members of XPolygonMiklos Vajna1-87/+87
See tdf#94879 for motivation. Change-Id: I7541248dbdc911d07167b0041ec571d877c9572f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173429 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-09-16cid#1606823 silence Overflowed constantCaolán McNamara1-0/+2
Change-Id: I0ca0556b75e258ba89271c3cb428b267976bfb09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173423 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-14use more concrete UNO types in svxNoel Grandin7-18/+13
Change-Id: I55fd67a66067f0c4f43ef182101c8d72a22fe3f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173325 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-09-13Resolves: tdf#162455 svg->curve causes text in objects to disappearCaolán McNamara2-42/+55
Rather than assuming there is a uniform unchanging MapMode scaling, follow the same pattern as SVGWriter and map positions/sizes back relative to the original MapMode. Examples of #i119125#, tdf#162455 and tdf#160625 work Change-Id: I8229cebee6173fa4905828afb3b973c80ede3315 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173126 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-12tdf#156543 sw: Added base text mono feature to Asian Phonetic GuideJonathan Clark2-9/+155
This change adds a new button, Mono, to the Asian Phonetic Guide. Clicking on this button will automatically separate each base text character into its own base text run. Change-Id: I973e2c3259918db59e46dc7b89cb7e8ee4f45469 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173276 Tested-by: Jenkins Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
2024-09-12no need to dynamic_cast so much in AccessibleTableShapeImplNoel Grandin2-29/+21
when we know the underlying object is a sdr::table::TableModel unfortunately this reveals that the underlying object does not, in fact, implement XSelectionSupplier Change-Id: I29336a7cf945dcec1a8d7aecc78f793e95bae259 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173245 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-09-12use less dynamic_cast in svx table stuffNoel Grandin10-59/+63
we already statically know the types of all these objects Change-Id: I976dbf2b150fcd2176df18a07c2e9f21b1d2fe65 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173214 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
generated by cgit v1.2.3 (git 2.39.1) at 2024-11-29 16:56:56 +0000