summaryrefslogtreecommitdiff
path: root/svx/source
AgeCommit message (Collapse)AuthorFilesLines
2018-06-14loplugin:unusedfieldsNoel Grandin7-93/+13
Change-Id: I7d9966d11f8272034523d9804ecf76e119552780 Reviewed-on: https://gerrit.libreoffice.org/55796 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-14loplugin:unusedmethodsNoel Grandin1-275/+0
Change-Id: Ibd9f4757ec26da7acc645f33573ace3280e84834 Reviewed-on: https://gerrit.libreoffice.org/55788 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-14tdf#100894 freeze when editing calc file with bazillions of cond formattingNoel Grandin1-6/+6
This does not fix the root cause of this problem, which is simply that the document has a bazillion style sheets. Either the program which exported this document is broken, or our importer is not correctly de- duplicating the imported stylesheets. Anyhow, I made performance improvements until I realised that it was simply going to be impossible to display that many stylesheets in our UI. But still, this bug was useful in flushing out some performance issues. The improvements, in order of decreasing importance are: (*) Use SfxStyleSheetIterator in SvxStyleToolBoxControl::FillStyleBox to avoid an O(n^2) situation where the pool repeatedly marks all the stylesheets as not-used, and then walks the document finding out if a stylesheet is used. Which is a waste of time because we're searching the documents pool, so of course they are all used. (*) Add a virtual method to avoid dynamic_cast (*) return raw pointers instead of returning rtl::Reference by value to avoid unnecessary reference counting. SfxStyleSheetIterator Change-Id: I15ff9c1846d3ed3e6f5655fa44c762f7619d547a Reviewed-on: https://gerrit.libreoffice.org/55751 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-13weld SvxCharPositionPageCaolán McNamara3-3/+911
Change-Id: I2084702798e5b01eae5905dc54ad8413e6d5fae6 Reviewed-on: https://gerrit.libreoffice.org/55759 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-13tdf#118110 - Mouse wheel should work with the shapes deskheiko tietze2-4/+1
scrollwindow removed Change-Id: Id38dd75120effe63314fb3665417c728f3822712 Reviewed-on: https://gerrit.libreoffice.org/55748 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-06-12crashtesting: asserts on empty fill patternsCaolán McNamara1-1/+4
since... commit d46c32140fdb05758c039dd27552b1788faac104 Date: Thu Jun 7 12:37:33 2018 +0200 assert in BitmapInfoAccess if bitmap is empty or we can't read from it Change-Id: Ic54e1d2511f2089eda9e0941f45135ae5e6f084d Reviewed-on: https://gerrit.libreoffice.org/55686 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-12weld SvxTransparenceTabPageCaolán McNamara1-0/+149
Change-Id: If8c8a6cf74664f9acd360d877c57e8dd9de2f2b5 Reviewed-on: https://gerrit.libreoffice.org/55683 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-12loplugin:constantparamNoel Grandin3-6/+5
Change-Id: Ia769b3176aea287cd57414d7ce8e88c6da43883e Reviewed-on: https://gerrit.libreoffice.org/55622 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-12simplify calls to *DialogFactory::Create methodsNoel Grandin13-417/+349
we don't need to check for nullptr here, it's never null. Change-Id: I3cc5337a8f4dec6747821679e39ccba3cec20f56 Reviewed-on: https://gerrit.libreoffice.org/55114 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-11loplugin:unusedfieldsNoel Grandin1-1/+0
Change-Id: I42a55562747e6097c1193e285da67235f5364bea Reviewed-on: https://gerrit.libreoffice.org/55610 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-11loplugin:unusedmethodsNoel Grandin3-94/+0
Change-Id: I26a0da1ec9cda9030371977596053a45303756a0 Reviewed-on: https://gerrit.libreoffice.org/55609 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-11loplugin:useuniqueptr in FmEntryDataListNoel Grandin4-33/+26
Change-Id: I7c9ec3bb26c6c329c66d684437bf934b9c2ad0e5 Reviewed-on: https://gerrit.libreoffice.org/55519 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-11loplugin:useuniqueptr in FmFilterNavigatorNoel Grandin2-4/+4
Change-Id: I9a674cc87dc6aae4419389a7309304815ceb22ef Reviewed-on: https://gerrit.libreoffice.org/55518 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-11loplugin:useuniqueptr in AccessibleCellNoel Grandin2-4/+3
Change-Id: I8502e7695ad9d28d57d1cb5c7f01c7bacd4a69aa Reviewed-on: https://gerrit.libreoffice.org/55517 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-11loplugin:useuniqueptr in Svx3DWinNoel Grandin1-9/+9
Change-Id: I529a486b7b60306293089b776202810f84ab0126 Reviewed-on: https://gerrit.libreoffice.org/55516 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-11loplugin:useuniqueptr in GraphCtrlNoel Grandin1-18/+12
Change-Id: I47299326467e31b72094a4fa7de6dbe8dd3ced7e Reviewed-on: https://gerrit.libreoffice.org/55515 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-10Remove unused member aPrefVisiLayersRegina Henschel1-3/+0
The only users were removed 18-Nov-2011 in commit ddb1d5eb, Felix Zhang. Change-Id: I3843d278881203f63f5daf24a3acf27b7d1f4aa9 Reviewed-on: https://gerrit.libreoffice.org/55562 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-09Fix typosAndrea Gelmini4-4/+4
Change-Id: Icc2923f023ec4e3219d1641f8c9d983c526bd0a8 Reviewed-on: https://gerrit.libreoffice.org/54811 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-06-09remove cargo cult OSL_ENSURE(pFact, "ScAbstractFactory create fail!"(Noel Grandin11-25/+0
Possibly this was useful once upon a time, but now it's just noise. If it failed, we're going to crash on the next line when we call a method on that pointer anyway. Change-Id: Ic601f0c3344f6895f8a6ffb3bc6f8bcb45d00a92 Reviewed-on: https://gerrit.libreoffice.org/55082 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-08Fix typosAndrea Gelmini2-3/+3
Change-Id: Iaadbdee429dcb1d15824858e422eacfaedf9a4f4 Reviewed-on: https://gerrit.libreoffice.org/55442 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org>
2018-06-08look for unnecessary calls to Reference::is() after an UNO_QUERY_THROWNoel Grandin5-22/+10
Since the previous call would throw if there was nothing to be assigned to the value. Idea from tml. Used the following script to find places: git grep -A3 -n UNO_QUERY_THROW | grep -B3 -F 'is()' Change-Id: I36ba7b00bcd014bdf16c0455ab91056f82194969 Reviewed-on: https://gerrit.libreoffice.org/55417 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-06-07svx: fix loplugin errorsAshod Nakashian1-7/+6
Change-Id: Ic13bc488f2c8137eae3687d72732533ba5542998
2018-06-07svx: don't re-declare pdfium structsAshod Nakashian3-18/+26
They aren't needed when fpdfview.h is included and clang reservedid plugin complains of the double-underscores. Also, wrap the PDFium importer class in HAVE_FEATURE_PDFIUM to avoid build failure when PDFium is missing. Change-Id: Ibc285aea575acf72541866c534ef943e0bb89466
2018-06-07vcl: svx: misc improvements to pdfium importingAshod Nakashian3-7/+7
Change-Id: I58f2fd973a731b148f40b37139cd74bac097a7d2
2018-06-07svx: set the font name of imported PDF textAshod Nakashian1-1/+16
Change-Id: I79dde3c8983a70311de2d2a46093fac2722fb372
2018-06-07svx: update PDFium patch and codeAshod Nakashian2-4/+5
Change-Id: I07c6a7c65d5631b70da64927a35d7a3b371eff25
2018-06-07svx: cleanup pdfium importerAshod Nakashian2-299/+25
Change-Id: Id925ba7734a2c73270e40f19d3fc50552441c34e
2018-06-07svx: transform PDF text rectangles while importingAshod Nakashian2-11/+69
Change-Id: I7675a183bfb691a8783950f33dc34826f91cb768
2018-06-07svx: support no fill and no stroke paths in PDF importAshod Nakashian1-12/+25
Change-Id: Ida5daa71d469805fd52e08e804fb9fa182d7d008
2018-06-07svx: support sub-paths in PDF importAshod Nakashian1-10/+25
Change-Id: Ibcfd30383db6846e791aea7609ab196c4f3f2da4
2018-06-07svx: import processed PDF textAshod Nakashian2-17/+24
Some PDFs don't include spaces in the text. Instead, they rely on the explicit positioning of each character to render visually separated words. Latex seems to be prone to this approach, though not exclusively. Luckily, PDFium does process text and inserts "generated" spaces where necessary, which is what we retrieve and use as the text string while importing. Change-Id: Ic21fe6c8416ecaba66f06b6260f1d6b040ff12af
2018-06-07svx: correctly possition form objects from PDFAshod Nakashian2-13/+92
Change-Id: I7d216ca61b8a10219628877db7dd593a4987ef60 (cherry picked from commit 81f16107c1b0b5315537f38a9830cf967e4abb68)
2018-06-07svx: support importing forms from PDFsAshod Nakashian2-29/+48
Still missing the context matrix transformations. Change-Id: Id9457c6475463127d3bc444f36fa373a6ec8fcb6 (cherry picked from commit 08e2c68e99151c70d06581261bbc137f80967d9e)
2018-06-07sd: support breaking any PDF pageAshod Nakashian2-8/+9
Change-Id: Ifa5f58163bef209a988fc0f88e2b609b1973e0d4
2018-06-07svx: path line width is given as full thickness in PDFAshod Nakashian1-0/+1
Change-Id: I728d962ea65ad1671e3b4c76034d396bee84228e
2018-06-07svx: support color text for imported PDFsAshod Nakashian1-17/+25
Change-Id: I01cba9456b37bd7a63c823bbe332d686f7ede389 (cherry picked from commit 26e37f98b08ce59a0feb93a8d2a8fbc982cfc103)
2018-06-07svx: more accurate PDF imported text sizeAshod Nakashian2-5/+12
Change-Id: I22880afdd9d36d9096003d86bba15098b465e0b3
2018-06-07svx: correct the positioning of PDF Paths and the stroke widthAshod Nakashian1-3/+9
Change-Id: I5b150721cc1b61b028f282062c1466ef6a67fcae (cherry picked from commit 37a40d8025ac70f84937de2b1d0f596d08088cbd)
2018-06-07svx: improved text importing from PDFAshod Nakashian1-39/+45
Change-Id: I9a2fc2c8511655c1aa362c1a03a5e82ae3ba697e (cherry picked from commit d057cf3d9184cc5d96af9c957411911f5e788f4d)
2018-06-07svx: improve path importing from PDFAshod Nakashian1-11/+28
Change-Id: I8e63b2a35d841e065ef32fea95c0a5f22ca6f049 (cherry picked from commit 819d11b7ae198a6a8e864852a3654ddbed389ecb)
2018-06-07svx: support Paths in PDFs while importingAshod Nakashian2-1/+92
Change-Id: Idba294cf5a3a8dd00988f94786715b110039e000 (cherry picked from commit b1083c119832c32d722a4e81415ef7a02c23d4aa)
2018-06-07svx: support PDF text colorAshod Nakashian1-2/+5
Change-Id: I7fa675c6560504e4fc7917e19cac3cceb2700d8e (cherry picked from commit 3c02b52fdad9c5a34d4bfb7623e04c4e85875a89)
2018-06-07svx: more informative loggingAshod Nakashian2-15/+14
Change-Id: Ia9f2fa1fbb24ad3466bd082b778244f451c90745
2018-06-07svx: import PDF images as BGRAAshod Nakashian1-2/+2
This makes it trivial to support all sort of odd bit-format and 8-bit paletted images. Change-Id: I4555794eccd0ee2906f9a39bd93957ad3775432c
2018-06-07svx: refactor PDF text importingAshod Nakashian2-61/+60
Change-Id: Ibe8d794c1d457936c9272bb664a5478d78654dd4
2018-06-07svx: share PDF stream when saving imported PDF as imagesAshod Nakashian1-0/+11
Still needs work, incomplete. Change-Id: Ide0c3f0792e816d64a81922a653a8afd77c7511a
2018-06-07svx: more accurate PDF text importingAshod Nakashian1-1/+62
Change-Id: If37119510cbc091dc86cb5f699984186167745c7 (cherry picked from commit 7dc905d1e9b561bb71f58881190bb6f590d09d80)
2018-06-07svx: import PDF text using PDFiumAshod Nakashian2-52/+89
Change-Id: I7c75477f5257931f5182b8d65e898857526bf555
2018-06-07svx: import PDF images at correct possition and scaleAshod Nakashian2-37/+101
Change-Id: Idb447b99143ad326294f2748f4d5154432fc328a
2018-06-07svx: import images from PDFAshod Nakashian2-78/+125
Change-Id: If0765aac9f47df73f1021664e13afa15ebf0f9ee
generated by cgit v1.2.3 (git 2.39.1) at 2024-12-05 02:35:33 +0000