summaryrefslogtreecommitdiff
path: root/svtools
AgeCommit message (Collapse)AuthorFilesLines
2016-10-06I can't see any evidence of any remaining magenta mask using image resourcesCaolán McNamara3-5/+0
Change-Id: I12865d743daa3e6479edb60584d5bd01f88e818d
2016-10-06ImageList just reads and discards the MaskColor, so drop itCaolán McNamara2-7/+0
Change-Id: I243e739fea28e3f38b91534182cc54c2aa660f0e
2016-10-06these other IMAGE_STDBTN_COLOR defines do nothingCaolán McNamara1-4/+0
Change-Id: If35bd52f973dc89b05afd283a4a89998c491b862
2016-10-05convert the last two lonely FixedInfos to FixedTextCaolán McNamara2-29/+0
Change-Id: Ia6ed5f71931a6141efb3d5e5eb329149d6850342
2016-10-05Split some stuff from ToolbarMenu to a base classMaxim Monastirsky2-66/+63
i.e. implement "todo: move to new base class that will replace SfxPopupWindow" Change-Id: I1b300e1e0c6423bf27d9dae7d75703b988afb154
2016-10-05PopupWindowController: Tearoff supportMaxim Monastirsky1-11/+59
Change-Id: I2baaaa13f3d127dc1619c971b66091d3326fafbc
2016-10-05PopupWindowController: Small cleanupMaxim Monastirsky1-28/+0
Change-Id: Iedbc8ddaf97f515fecc012322f0c1621317de076
2016-10-05PopupWindowController: Use ImplInheritanceHelperMaxim Monastirsky1-23/+1
Change-Id: I82b9ebf69b6b35b3a5e1e8a5dc5bb84eff1feb19
2016-10-05convert MapUnit to scoped enumNoel Grandin27-162/+162
I left a prefix on the names "Map" so that I would not have to re-arrange each name too much, since I can't start identifiers with digits like "100thMM" And remove RSC_EXTRAMAPUNIT, which doesn't seem to be doing anything anymore. Change-Id: I5187824aa87e30caf5357b51b5384b5ab919d224 Reviewed-on: https://gerrit.libreoffice.org/29096 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-05Remove _TYPED suffix from tools/link.hxx macrosStephan Bergmann61-186/+186
...which was introduced with 3ead3ad52f9bb2f9d1d6cf8dfc73a0a25e6778ed "Gradually typed Link" to distinguish the new, typed versions from the old, untyped ones, but is no longer necessary since 382eb1a23c390154619c385414bdbe6f6e461173 "remove untyped Link<>" removed the old versions. Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
2016-10-01Fix typosAndrea Gelmini2-2/+2
Change-Id: I9701cc93a9f4315e71c133237fdd96ef6964c8ff Reviewed-on: https://gerrit.libreoffice.org/29438 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-01svtools: don't store "vcl" Graphic as a pointerTomaž Vajngerl2-39/+41
Change-Id: Icf8a5fa72ef66659bbc9c70355d430ff6bf545fc Reviewed-on: https://gerrit.libreoffice.org/29412 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2016-09-30loplugin:constantparamNoel Grandin1-2/+2
Change-Id: Idbe8c8e6b3d44cacce296ec8c79b2b244281057c Reviewed-on: https://gerrit.libreoffice.org/29321 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-29fix the buildMarkus Mohrhard1-1/+1
Change-Id: I95d98ec792c8741ee9d22ff174b388bb59cc7638
2016-09-29add introspection support for SvSimpleTableMarkus Mohrhard3-0/+56
This is the second part of the UI test tutorial. The tutorial shows how to add introspection support to a new vcl::Window based UI object. Change-Id: I2b3ed68d313749787869c7e85f2e27c9d01fff4a
2016-09-23perf: eliminate SfxSimpleHint and move to SfxHint, tdf#87101 relatedEike Rathke4-13/+7
There were over 150 places in *::Notify() functions that did some dynamic_cast<SfxSimpleHint*> of which ~98% were unnecessary because the base class SfxHint passed was an SfxSimpleHint anyway. dynamic_cast operations come with quite some cost, so avoid if possible. Specifically for ScFormulaCell::Notify() that created a bottleneck in scenarios where cells were notified that already handled a previous notification. In mass operations doing the dynamic_cast before it could be decided whether having to act on it or not this made 2/3 of all time spent in the Notify() call. To get rid of that rename/move SfxSimpleHint to SfxHint and let classes derive from SfxHint instead of SfxSimpleHint. This comes only with a slight cost that an additional sal_uInt32 is transported in such hints, initialized to 0, but this is neglectable compared to the huge gain. For the rare cases where a Notify() actually expects both, an SfxHint (formerly SfxSimpleHint) and a derived hint, this changed order of the dynamic_cast involved so the simple SfxHint::GetId() is handled last. Modules using such combinations can further optimize by treating the simple SfxHint::GetId() first once verified that none of the other derived hints use an ID not equal to zero respectively none of the ID values the simple hint uses. Change-Id: I9fcf723e3a4487ceb92336189d23a62c344cf0ce Reviewed-on: https://gerrit.libreoffice.org/29205 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-09-22loplugin:unusedmethods in chart2..svxNoel Grandin1-1/+0
Change-Id: Ifb6045885049733415895f58cdd911256f48323c Reviewed-on: https://gerrit.libreoffice.org/29187 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-22Remove NumberFormatCodeWrapperMaarten Bosmans1-1/+0
This class only adds a level of indirection, without any useful functionality. Change-Id: I806e1b9241caf025c62c12c93aad3101daac874a Reviewed-on: https://gerrit.libreoffice.org/29134 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-20loplugin:unusedfieldsNoel Grandin1-4/+1
Change-Id: I852e98b16fdcb88b04e39d11e3101d502c918c24 Reviewed-on: https://gerrit.libreoffice.org/29078 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-16loplogin:singlevalfields in include/Noel Grandin2-42/+22
Change-Id: I27842162fcf82120ecb811ee8e89e187430931fc Reviewed-on: https://gerrit.libreoffice.org/28931 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-15Make sure some history is preserved for posterityTor Lillqvist1-1/+1
Change-Id: Ie74f12ee6fda9f8bcba540d52ce7ec53236998bf
2016-09-15Make OGenericUnoDialog::destoryDialog non-virtualStephan Bergmann1-27/+18
...it is only ever called: * either from dtors, where the virtual-ness doesn't acutally help (and would trigger loplugin:fragiledestructor if that were enabled) * or, in module filter, from executeDialog members of (final) classes directly derived from OGenericUnODialog without overriding destroyDialog Change-Id: If9a7370385a27952189423e5632b3f01e18ddbb5
2016-09-14cid#1372878 modulo by zeroNorbert Thiebaud1-2/+4
Change-Id: I37ed251597f44d382fde96c39ff9d07e4d14c50a Reviewed-on: https://gerrit.libreoffice.org/28859 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2016-09-13tdf#74377 Keyboard shortcuts for context menusMaxim Monastirsky1-1/+47
Configurable through the options dialog. The default behavior depends on the current vclplug (hide for gtk2/3 and OS X, show otherwise). Menus currently affected by this change: - SfxDispatcher based context menus - chart2 context menus - vcl's Edit control context menu - Several MenuBarManager based toolbar dropdowns. Change-Id: Iad9fb99dc90e01c17cba9c07c1a2b262b920e11d Reviewed-on: https://gerrit.libreoffice.org/28849 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
2016-09-13loplugin:dllprivateStephan Bergmann1-3/+3
Change-Id: I1fe70a39c50aba8b84c117653185fc37dbbfeab0
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann49-69/+69
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-13try to avoid the deadlock around the clipboard, tdf#56818Markus Mohrhard1-4/+0
This deadlocks in the case that we have an external process communicating with LibreOffice as the SolarMutexReleaser allows a connection to be processed while the normal code has just released the SolarMutex. If the external call code now goes down the same code path we deadlock on the SolarMutex together with other mutexes in the clipboard code. Change-Id: I18fd6953c9566452a31b1a4c32c68494ec7a52ac Reviewed-on: https://gerrit.libreoffice.org/27251 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-09-10typo fix: oue -> ourAndras Timar3-3/+3
Change-Id: I4c592f467017cc88cd7deb124f9859e0ff515009 Reviewed-on: https://gerrit.libreoffice.org/28775 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2016-09-09loplugin:constantparam in svtoolsNoel Grandin11-51/+37
Change-Id: I04caae0c9ae621c55e16d3bdc014a4729617feb3 Reviewed-on: https://gerrit.libreoffice.org/28757 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-09-07loplugin:constantparam in vclNoel Grandin1-5/+2
Change-Id: I0cae8e5de1170dec4c82df7f1f5377143a079876 Reviewed-on: https://gerrit.libreoffice.org/28686 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-09-05tdf#100442 use unordered_set for GraphicManager's maObjListAron Budea2-14/+10
Speeds up ImplCheckSizeOfSwappedInGraphics. maObjList didn't seem to depend on it being a vector. Change-Id: I0028186b5c4f53ae198b9b33a31c51f0b2e5eb45 Reviewed-on: https://gerrit.libreoffice.org/28439 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-09-05convert ToolBoxButtonSize to scoped enumNoel Grandin1-24/+33
Change-Id: I365b0e34361eb339b04e5f4792f54eff5bf582a5
2016-09-05convert LineStyle to scoped enumNoel Grandin1-1/+1
Change-Id: I30cfa5a0649b806604c443f55683d1f2a430983d
2016-09-05convert RasterOp to scoped enumNoel Grandin4-5/+5
Change-Id: I136423c105316c9b5b18e64d04a248fd7ac5590b
2016-09-05convert OutDevSupportType to scoped enumNoel Grandin1-1/+1
Change-Id: I7a1e4448dfff0ea6909149533d228829d980796c
2016-09-02boost::intrusive_ptr->tools::SvRefCaolán McNamara1-1/+1
Change-Id: I4c913dc62efe3f3747e78670f4efb0216d95c4ad Reviewed-on: https://gerrit.libreoffice.org/28585 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-09-01std::list<sal_uInt16> -> vectorNoel Grandin2-25/+24
Change-Id: Ic08ac3fcb750ceff1f5b3201d4a3151ad567aa1f
2016-08-31Resolves: tdf#98100 no valueset tooltips with extended tips...Caolán McNamara1-1/+1
and no offline help available. I feel this was the original (day-0-checkin) intent of the code, otherwise why bother with the "| HelpEventMode::BALLOON" as that makes no difference to the existing logic. And this per-item help is what other similiar widgets do. Change-Id: Idda130450db322acefd9ecc13986067790f9a614
2016-08-30Translate some German comments and messagesMaarten Bosmans1-1/+1
Change-Id: Id15e1afd991f3476e260ba40a8c45c7261113577 Reviewed-on: https://gerrit.libreoffice.org/28493 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-08-30loplugin:stringconstant: adapt to improved OUStringLiteral1 (svtools)Stephan Bergmann4-4/+4
Change-Id: Ifdfc684ea894e637617de845facbad645ed6331c
2016-08-30Let OUStringLiteral1 take its arg as ctor arg, not template argStephan Bergmann2-6/+6
...which makes it more flexible, can now also be used on non-const arguments. The drawback of the argument no longer being a compile-time constant is remedied by making the ctor constexpr. Change-Id: Ia4903a2cc86791fece92eac0cb8406b6659dd19d
2016-08-29name it Hungarian Rovas, tdf#97406 follow-upEike Rathke1-1/+1
Change-Id: I62d5a503b199922b82e7cec3e0ef971bbbd43d09
2016-08-29Adapt loplugin:stringconstant to improved OUStringLiteral1Stephan Bergmann1-1/+2
Change-Id: Ibc5128df8bcf8cb5f2f09551c0de6dfdb46bdee0 Reviewed-on: https://gerrit.libreoffice.org/28447 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-08-29coverity#1371317 avoid unnecessary copiesCaolán McNamara2-129/+30
and coverity#1371211 Change-Id: I65e277c4af70a86f1513749de4eb116d929e858f Reviewed-on: https://gerrit.libreoffice.org/28448 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-08-27put StreamMode masks in scope of enum classJochen Nitschke3-4/+4
Change-Id: I77682f7e289a59b986bb84edf014029a20266470 Reviewed-on: https://gerrit.libreoffice.org/28420 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-26add Old Hungarian (Hungarian Rovas) [hu-Hung-HU] to language list, tdf#97406Eike Rathke1-0/+1
Change-Id: I1804a08c69d496d6d1a7a8bb657b65fbfc24beb3
2016-08-26remove SvLBoxBmp classJochen Nitschke1-43/+0
not used by anything Change-Id: I35d12bdd29c5aef43296ce4709e69b29f4685acc Reviewed-on: https://gerrit.libreoffice.org/28398 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-26convert SV_ITEM_ID_LBOX defines to scoped enumJochen Nitschke7-54/+53
and remove unused SV_ITEM_ID_EXTENDRLBOXSTRING Change-Id: Ic84d9341d0225b01b9ef46814483c66b1af307b5 Reviewed-on: https://gerrit.libreoffice.org/28397 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-25tdf#100726 - Improve readability of OUString concatanationsGökhan Gurbetoğlu3-26/+22
Improved readability of OUString concatanations. Also removed unused OUStrings "sColor" and "sEntry" from the code. Change-Id: Ie9792f499cd880be72229f8a8c71f05ff8e258b6 Reviewed-on: https://gerrit.libreoffice.org/28375 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-08-22tdf#89329: use unique_ptr for pImpl in roadmapArnold Dumas2-3/+3
Change-Id: I1683b258d72c1ec4b29110203e8af7ff2596ebb0 Reviewed-on: https://gerrit.libreoffice.org/28283 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-11-25 22:46:01 +0000