summaryrefslogtreecommitdiff
path: root/svtools
AgeCommit message (Collapse)AuthorFilesLines
2014-02-07sal_Bool -> boolStephan Bergmann1-5/+5
Change-Id: Ifc80202e0865b59931af6e50d3d60f5021f8b52e
2014-02-06typo fixes in commentsAndras Timar1-2/+2
Change-Id: Idd49478d59cd062118fbf8e99d1c8bc5250013fc
2014-02-06fdo#54938 Convert oox, sc, vcl, svtools... to cppu::supportsServiceAlexandre Vicenzi1-9/+1
Change-Id: I6268bc57417d53b9810c81071fbcd604e2a19507 Reviewed-on: https://gerrit.libreoffice.org/7886 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Marcos Souza <marcos.souza.org@gmail.com>
2014-02-05Doxygen warnings correctedChris Sherlock1-1/+1
* Doxygen spits out a lot of warnings about not being able to find match function signatures, etc. This is because in some headers we have a using namespace statement, in others it gets confused between ::Window and Window (!). * Wrong use of tags: + Lots of @seealso - should be @see + Wrong usage of @overload - corrected with the right function signature + HTML tags that doxygen doesn't recognize removed Change-Id: I1c2eed941619b8764dbfcfc5ab38027518cdf261
2014-02-04convert specialised SvStream::operator>> methods to ReadXXX methodsNoel Grandin4-14/+16
as preparation for converting the SvStream::operator>> methods on primitive types Change-Id: I62f134bced15c687d6e0d46924f56e8d1c3d95b9 Reviewed-on: https://gerrit.libreoffice.org/7798 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-02-04fdo#73263: Change the default color for reference border to non-red.Kohei Yoshida1-1/+1
See the referenced bug report for the reason behind it. Change-Id: I4284807adaf82ae9581208a13ebd5071d36be5c7
2014-02-04C2872: ´Pair´ : ambiguous symbolCaolán McNamara1-1/+1
Change-Id: Ia9c86914319cd8342d04e9a9efb23aa18d1e94df
2014-02-04Change Application::SystemSettingsChanging to OverrideSystemSettingsChris Sherlock1-2/+1
The name Application::SystemSettingsChanging implies that the app is being notified that system settings are being changed. This is not what the function does - in fact, SystemSettingsChanging overrides a settings object with user defined settings Change-Id: Ibbf821ff3c7ec5b38e2e79751058494c749b6428 Reviewed-on: https://gerrit.libreoffice.org/7629 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2014-02-04-Werror,-Wunused-private-fieldStephan Bergmann1-1/+0
Change-Id: Ib7d8fd7ff8a4f44dc699bc0b72a8c438acebc0ec
2014-02-04convert link database dialog .uiCaolán McNamara1-2/+18
Change-Id: Ide66c2f088616b1677d03bad9095fa5829c4ffb7
2014-02-03MultiSelection::GetRangeCount() returns size_tMatteo Casalin1-2/+2
Change-Id: Ief072cef486556c9b43364e108a021510781f7c6
2014-02-03ensure selected calc sheet tab is always visible, and we use space sensibly.Michael Meeks1-1/+15
Change-Id: I0f935f324ba31784185959a4a4d2c306d4b592d8
2014-02-03remove GraphicObject::SetSwapStreamHdl() timeout parameterMichael Stahl1-1/+41
Every call to SetSwapStreamHdl uses the same timeout now so move the function that determines that to svtools. Change-Id: Ib7395d43dd132a9e14e7a7862ff2c2279f319536
2014-02-03xub_StrLen and tools/string.hxx final strawNorbert Thiebaud1-4/+4
Thre is still some 0xffff limit left and possibly some less than gracefully handled overflow/error cases Change-Id: I00957ee3a30b02f73918ea49d7353056263dc638 Reviewed-on: https://gerrit.libreoffice.org/7787 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-01-30Introduce com.sun.star.ui.theModuleUIConfigurationManagerSupplier singleton.Matúš Kukan3-5/+5
Change-Id: I7b503e5d49865c9ff287bf72eaff1995ce871790
2014-01-30Resolves: #i124085# disabled CF_DIBV5...Armin Le Grand2-11/+20
(no advantages but some problems), increased png support (cherry picked from commit c991f7cae8dcb306cb0d1f32bc5fcd8ea0a1ea81) Change-Id: I52bef1295b32eb3692a0428c96edd0c55287f34a
2014-01-29bool improvementsStephan Bergmann1-1/+1
Change-Id: I0dc09b7a6ee2849bd0c2ffc31be45f81cd2c15ee
2014-01-28bool improvementsStephan Bergmann21-104/+104
Change-Id: I23e29995bc7af791067de4996923b6279f7f8892
2014-01-28Introduce com.sun.star.frame.theUICommandDescription singleton.Matúš Kukan2-3/+3
Change-Id: Ic88cca3722d555ba48d7da8c176556fa1ff90650
2014-01-28coverity#440831 Dereference before null checkCaolán McNamara1-1/+1
Change-Id: If19c17088bfbc43e5079d88a3110491e56805749
2014-01-27coverity#1079289 : Uninitialized scalar fieldNorbert Thiebaud1-9/+13
Change-Id: I4663e3d0c5f0fe4288fba1ba4203e2de5ba4e986
2014-01-24coverity#708304 Uninitialized scalar fieldCaolán McNamara1-0/+1
Change-Id: If82964036862e309dc1c90036df59942a24fd7d6
2014-01-24coverity#1158253 Dereference before null checkCaolán McNamara1-7/+3
Change-Id: If653cc6dc0b53f66728500d779460ee352924947
2014-01-23coverity#1158464 Uninitialized scalar fieldCaolán McNamara1-6/+7
Change-Id: I73fc73421ab1abcc801bb4372e9584fcbf381bcf
2014-01-22Only allow approved border styles in cell borders.Kohei Yoshida1-6/+3
Line styles such as inset, outset, embossed etc are not supportable in Calc. So, don't show them in the UI. Change-Id: Ie7be74193d01e13a79132a979e2d9a2e4d06de3f
2014-01-22remove SvStream::operator<< methodsNoel Grandin2-8/+8
.. and convert the last few places still using those methods. Change-Id: Id2cd8f9c0dd281df43af439d4fef65881f34a6fd Reviewed-on: https://gerrit.libreoffice.org/7495 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-01-22convert more SvStream::operator<< callsNoel Grandin4-64/+64
.. to more explicit SvStream::Write* calls This was done using another run of the clang rewriter, and then a lot of hand tweaking to fix all the places where the rewriter did not play nice with various macros. Change-Id: I7bcab93851c8dfb59cde6bc76290c6484d88fb18 Reviewed-on: https://gerrit.libreoffice.org/7494 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-01-22Introduce static inline cppu::acquire(), and make use of that.Jan Holesovsky8-42/+23
This is much better approach compared to the callback function, as it allows passing arguments to the c++ constructor directly, while still allowing some additional initialization after having acquired the instance. Change-Id: I5a0f981915dd58f1522ee6054e53a3550b29d624
2014-01-22bool improvements (related to mixing bool/sal_Bool in &=, |=, ^=)Stephan Bergmann2-4/+4
Change-Id: I9869d9709f28b68ef7b518527175589d80644668
2014-01-21Change _get_implementation()'s not to do initialization directly.Jan Holesovsky8-17/+36
Many of the initalizations (in eg. framework) have to be done on an acquire()'d object, so instead of doing the initialization directly, return the initialization member function back to the createInstance() / createInstanceWithContext() / ... and perform the initialization there. As a sideeffect, I belive the calling initialize() from servicemanager is not that much a hack any more - whoever converts the implementation to be constructor-base has the choice to provide the callback, or still initialize through XInitialization, where the callback is preferred by servicemanager when it exists. Change-Id: I8a87b75c54c1441ca0f184967d31ff4902fc4081
2014-01-21bool improvementsStephan Bergmann7-10/+10
Change-Id: Id1a0df17a28372f9d7c3a88424cf7656fed46f9a
2014-01-21bool improvementsStephan Bergmann4-7/+7
Change-Id: I85faf4e3fcab6763af11eb6a4082820e88bea1ca
2014-01-21boradcast->broadcastCaolán McNamara1-2/+2
Change-Id: I96720843f815bf6d499eb424c3e4ff579c2bbe23
2014-01-21Fix bogus mass-conversion equalsAsciiL -> startsWithStephan Bergmann1-6/+6
3af99e4d59d89c343965a928681a30f36b1007d2 "convert equalsAsciiL calls to startsWith calls" should rather have converted to oprator ==. Change-Id: Id4a8836c5d6d570e54661c40be7214632e202b21
2014-01-20Removed unused solar.h reference in svtoolsAlexandre Vicenzi2-22/+0
Change-Id: Ic1dc7c32bb749888bc8751d4d488ba76e46b155f Reviewed-on: https://gerrit.libreoffice.org/7517 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-01-20Better pixelization of dashed lines for screen rendering.Kohei Yoshida1-0/+10
Now the dashed lines are evenly placed on screen. For now, horizontal lines only. I'll work on vertical lines later. Change-Id: I474e9c8214e5f079ea2cfca12b35381d8fcf2ae1
2014-01-20Revert "svt: Use constructor feature for FilePicker and FolderPicker..."Jan Holesovsky5-17/+168
It does not make a real sense to use constructor for implementations that act as a trampoline; instead, we should do a constructor for the real implementations that hide behind it. This reverts commit 2fbb47156773b2e300fc987efc2da85c66e567d1. This reverts (part of) commit 58ea27124af27bfac21a796b0d13d72354bd0dd3. This reverts (part of) commit 194bdbde25dd70988c94ff5e1af43b530d47d94b. This reverts (part of) commit df002e39f7518036ae1c1d2afec7a525ef902327. This reverts (part of) commit eb89c6f7dcd613cda6a9eee6f7897225e0334a25. This reverts (part of) commit bdeb57c23973f3ef79020847b2fe39f312cf3c0b. This reverts (part of) commit 4337a0664f4fb73f9e1be74f2a632847871da402. Change-Id: Ibd9b1066f3b6ea215d8da9f491d5f026cd75b029
2014-01-20Minimize the constructor functions to a bare minimum.Jan Holesovsky8-24/+8
Most of the constructors are supposed to be only a call of new TheInstance(arguments) or an equivalent; so let's just change the constructor caller accordingly, to accept unacquired new instance. If there are exceptions that need to do more heavy lifting, they do not have to use the constructor feature, or there can be a wrapper for the real implementation, doing the additional work in their (C++) constructor. Change-Id: I035c378778aeda60d15af4e56ca3761c586d5ded
2014-01-20Remove unused Window parameter from SystemSettingsChangingChris Sherlock1-1/+1
This took a bit of code archaelogy for me to track down. It turns out that as part of an effort to optimize startup, the line of code in this function was commented out, presumably to be rewritten later. This happened in commit ee3351d78c in July 2001 (!). About three years later, in February 2004, the function was rewritten in commit 189c2388d80. As it turns out, the only two functions that used the Window parameter were vcl/source/window/window.cxx (which passed itself in, but of course this did nothing) and vcl/source/window/winproc.cxx. Furthermore, winproc only ever passed in the first frame, so it didn't really do anything either. Consequently, the function as it stands *now* only notifies the application that system settings have been changed. It doesn't care which window it tells. Therefore, I have excised this parameter from the function. I don't think it made sense when it was implemented anyway, so there is no net loss. After removing the unneeded parameter, I was also able to remove the Window parameter from winproc.cxx's ImplHandleSalSettings function as it was only ever used to set the top level window, which is now irrelevant. Change-Id: I84f2c5c5ff8969387da3af81e4a9c7f9ac6237e1 Reviewed-on: https://gerrit.libreoffice.org/7541 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2014-01-20Related: #i56998# use FUNIT_PERCENT on fields that allow relative valueTsutomu Uchino1-2/+1
(cherry picked from commit fc6fc5b576b972a8ea0551091cc57aa1cfe1334d) Conflicts: svtools/source/control/ctrlbox.cxx svx/source/dialog/relfld.cxx Change-Id: Ic8f0f550dbbcab0678fbeb9bf45a478b0cea642d
2014-01-18Unify ctor functions for component implementations.Matúš Kukan4-19/+17
There is no need to use different styles for writing the same thing. It also makes it easier in future to use search & replace. But of course, there are also some more complicated functions. Change-Id: I773da20378af0e0d5a27689d3903df7063fb8ac0
2014-01-18Window::PreNotify should return boolStephan Bergmann16-45/+45
Change-Id: Ic9903fd887f2c3fab2630ebeb20df39392177c8d
2014-01-17Revise the line patterns further. Now they look satisfactory to my eye.Kohei Yoshida1-4/+4
Change-Id: I27f4e11bceac25c10de28a866bdcec9576027582
2014-01-17Apply dashing without consulting current map unit.Kohei Yoshida1-105/+68
Using scaling is sufficient. Change-Id: If976bec3940772432d814a77681170d7c99306d2
2014-01-17More fine-tuned stroke patterns.Kohei Yoshida1-17/+22
Only the pixel map mode is visually inspected. Change-Id: Ia8ac978a0d3049d7e7162f1157822b85d475dfdf
2014-01-17Remove STYLE_* and use css::table::BorderLineStyle instead.Kohei Yoshida1-6/+8
Change-Id: I187511dbf85ecdfe0c5d05c6f77cf4ac93363051
2014-01-17Window::Notify should return boolStephan Bergmann13-23/+23
Change-Id: I72081b1022582c8b6f95a611e21d9c78f7581efe
2014-01-17removed some unused code (svx, svtools, unotest)Petr Vorel1-6/+0
Change-Id: I1250581d69423030bd0a93a1529458b8d424ce3e Reviewed-on: https://gerrit.libreoffice.org/7329 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-17Pass initialize arguments directly into ODocumentCloser' ctor.Matúš Kukan1-51/+22
Change-Id: I1bcfe6d59230a4137b0f78d072c895e596ff6f15
2014-01-16fdo#71511: reload ColorConfig after tweaking relevant a11y settingsBjoern Michaelsen2-1/+8
note that the autodetect HC option is somewhat broken anyway: it resets the icon theme hard, so there are not simple roundtrips enableing/disabling it for that, but those havent been there before either. Change-Id: Ia35a41717224dfb7437054bb885c61d7e0b189d7