summaryrefslogtreecommitdiff
path: root/svl
AgeCommit message (Collapse)AuthorFilesLines
2016-02-08loplugin:unusedmethodsNoel Grandin1-278/+0
using an idea from dtardon: <dtardon> noelgrandin, hi. could you try to run the unusedmethods clang plugin with "make build-nocheck"? that would catch functions that are only used in tests. e.g., i just removed the whole o3tl::range class, which has not been used in many years, but htere was a test for it... <noelgrandin> dtardon, interesting idea! Sure, I can do that. Change-Id: I5653953a426a2186a1e43017212d87ffce520387 Reviewed-on: https://gerrit.libreoffice.org/22041 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-05Fix typosAndrea Gelmini1-1/+1
Change-Id: Ice72f8d9971e15dd6ef365e64cd567b8581a92d3 Reviewed-on: https://gerrit.libreoffice.org/21797 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-31OSL_THIS_FUNC is a rip-off of BOOST_CURRENT_FUNCTION so we can use thatCaolán McNamara1-1/+0
as a direct drop in I guess Change-Id: I3add63f1459f4e659019bd6db54da2f5431958ce Reviewed-on: https://gerrit.libreoffice.org/21941 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-01-25InterfaceContainer2 with vector instead of SequenceNoel Grandin5-8/+8
create an InterfaceContainer2 class to replace InterfaceContainer. It uses a std::vector instead of a Sequence for the mutable listener list, which provides far better performance. Switch all our internal use-sites to the new class. Change-Id: I6b56cfa511ded2395faa22e68fab3b2f16c3cb88
2016-01-20loplugin:unusedmethodsNoel Grandin2-86/+0
Change-Id: Ib2dc804f55d1a96ae01f2cf31b7d55956040a72e Reviewed-on: https://gerrit.libreoffice.org/21603 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-14grml.. stupid oversight..Eike Rathke1-1/+5
Change-Id: I95b27000adfd0a29ed6e462f972340eee31d3a0b
2016-01-14it's unnecessary to buffer the string to create a string from it againEike Rathke1-19/+10
... just in case there was a negative number and a minus to be inserted. doubleToUString() does it already. Change-Id: I0052d7bc91b48efb5f14f2f6f5a7c672a1e50ea9
2016-01-14do it right and remove then superfluous mumbo-jumboEike Rathke1-28/+13
... that worked around cases where it went wrong. Change-Id: Icdd4bddfb341a3d0abe4183cf788c546dcddbd00
2016-01-14loplugin:unusedmethods unused return value in store,svlNoel Grandin2-14/+9
Change-Id: I369b3ae84af046242430977cec7d5c5e69fc27e7
2016-01-13-Werror=unused-but-set-variableStephan Bergmann1-2/+1
Change-Id: I01c18a1b8193f491a82988426ac4e673dd68897a
2016-01-13tdf#97077: So ppStaticDefaults can be null after allStephan Bergmann1-26/+27
...at least in Base, and the assumption in 43de9a5b0f68a77a10595b3f69c6145cd9be05b6 "What these SAL_INFO probably want to tell us..." was wrong Change-Id: Ic9377b72f35c130ecd34dbf76c1f6a0f4b235c69
2016-01-13loplugin:unusedmethods unused return value in include/svlNoel Grandin8-39/+16
Change-Id: I759fe8769daccea07c2157bfb5912df8ba285534
2016-01-10Fix typosAndrea Gelmini5-6/+6
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-06What these SAL_INFO probably want to tell us...Stephan Bergmann1-51/+46
...given the oldest incarnation of the code still available is HACK( "fuer Image, dort gibt es derzeit keine Statics - Bug" ) if ( ppStaticDefaults ) and HACK( "fuer Image, dort gibt es derzeit keine Statics - Bug" ) if ( ppStaticDefaults ) from cf7e1f9cc99e7c260cfab823f2c47f56035bdbd0 "INTEGRATION: CWS visibility03: #i45006# Moved from svtools/source/items/ (for svl/items1.lib)"... ...is that ppStaticDefaults should really be non-null, but "Image" (Draw? Impress?) needed a temporary (?) hack there. Test that assumption by asserting that ppStaticDefaults is non-null. Change-Id: I2a75547618da1d211c44176e4593f6951a0e0298
2016-01-06Revert "This probably is not worth displaying a warning about"Tor Lillqvist1-0/+1
It might be a useful warning. This reverts commit d202f851717bb5a8fe5fed98f747a1fd164d3225.
2016-01-05This probably is not worth displaying a warning aboutTor Lillqvist1-1/+0
Change-Id: Ic14af2992fa020f93329573354616d5b781af111
2016-01-05tdf#96708: don't modify document while copying to clipboardMike Kaganski1-3/+1
I.e., don't try to create auto-layout for clipboard pages which don't contain one; don't resize objects to text. Also, don't invalidate items that are equal to defaults, because explicitly set items are not the same as absent items: pasting an object without an item makes the property to inherit new target's default, while when the item is present, the default doesn't apply. Also, don't consider selected state of the page while stringifying - this makes selected page string to differ from not-selected clipboard page. Change-Id: I172e03e1a8c428e5fcae3a116cc9ad8de79f1a87 Reviewed-on: https://gerrit.libreoffice.org/20871 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2015-12-21crashtesting: post NPAPI removal crash fixingCaolán McNamara1-0/+2
Change-Id: I99d79735c375f3d632382a8efa0202517a293b1f
2015-12-15...and this looks like a memory leak, tooStephan Bergmann1-0/+6
Change-Id: I5e203fe8b58d687c0c294c75e385f0bbc858ba07
2015-12-15Memory leakStephan Bergmann1-1/+3
Change-Id: I99da487f0bed527eaacf47642884ae25fb0ae8b1
2015-12-15Bin unused function DbgCheckItemSetTor Lillqvist1-33/+0
Change-Id: Ia08e7ea3381cd450d2dadd8add723574634124e0
2015-12-15Bin silly 'STATIC DATA' commentsTor Lillqvist3-8/+0
Change-Id: I50e3772b7b479d2cf1eb644c7334d0f987874ccb
2015-12-03uno::Sequence->std::vector in SfxIntegerListItemNoel Grandin1-14/+10
Change-Id: Icdbb361feea2ebee74f9d0a906bdd3c2882443e8
2015-11-30loplugin:unusedfieldsNoel Grandin1-3/+0
Change-Id: Icac4ac1a2614e72bc9ff070819533e09eeb1a864
2015-11-28-Werror,-Wmicrosoft-enum-valueStephan Bergmann1-2/+2
Change-Id: I50aaeb264c901146c119192cbd961b20117788e1
2015-11-28Missing includeStephan Bergmann1-0/+1
Change-Id: I62fd53d6f39349405865783bc44edbb7929664a1
2015-11-27introduce SvNumberFormatter::GetFormatStringForExcel()Eike Rathke1-0/+56
Taking implementation from sc/source/filter/excel/xestyle.cxx GetNumberFormatCode(), slightly modified to ensure valid conversion and force en-US locale data. Also don't unnecessarily convert if format is for system locale and system locale is en-US. Change-Id: I9223eaa655132b4106a35c94cb0005559d7575b1
2015-11-27use proper case "General" keywordEike Rathke1-0/+2
... Excel doesn't seem to care though. Change-Id: I3697a808d8fee2417f0b0e03dba2b94ceea133dd
2015-11-27introduce SvNumberFormatter::FillKeywordTableForExcel()Eike Rathke1-0/+14
... to conflate the places that do this on their own. Change-Id: Idde2173780e0515ad982b4be46fc4df23a7577ad
2015-11-24nitpick, use 'b' prefixEike Rathke1-3/+3
Change-Id: I9a0d92dee7cebecfb7b204628738f716b901771a
2015-11-24nitpick, reduce to one string insertionEike Rathke1-3/+2
Change-Id: I546ae14d49bb64fb069a4a5d7dc7685e823ea3c3
2015-11-23tdf#95677 Force sign to exponent for Excel exportLaurent Balland-Poirier1-0/+5
Change-Id: I7896d1d064cd92fd45a6b32ac64f534f68213169 Reviewed-on: https://gerrit.libreoffice.org/20064 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-11-23loplugin:unusedfields in svl/Noel Grandin1-194/+165
Change-Id: Iae589bc1e0333c8e4cf89a3d061ba10094874520
2015-11-19use comphelper::containerToSequenceNoel Grandin2-35/+6
in chart2, we remove a local equivalent of the method Change-Id: I25129a3d1ea1dd724eb9cd38a57be37a78b3d100
2015-11-18svl: replace some legacy SFX_ASSERT in SfxItemPoolMichael Stahl1-35/+27
Almost all of these look obviously disastrous. Change-Id: I30e4e3039bafb10eaff4f2413b7a4aaae1f584c1
2015-11-18use unique_ptr for pImpl in svl/Noel Grandin9-16/+5
Change-Id: Ieef897314ac0f056c0a09a5182ca59800fd58f41
2015-11-16use initialiser list for Sequence<OUString>Noel Grandin2-6/+2
Change-Id: Ia5e47261d1fc6fac2d046656c05a1c5eedb07e02 Reviewed-on: https://gerrit.libreoffice.org/19978 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-15Fast PCH generator and optimized PCH filesAshod Nakashian1-145/+50
Ported update_pch.sh to Python with improved performance and features. The new script is invoked from the same update_pch.sh which calls it for each library in parallel, although it can be invoked directly. The ported script (update_pch) updates all PCH files in ~15 seconds where the old script took ~4500 seconds. In addition, the new script supports 3-tiered headers (system, module, and local) and is very flexible to support other improvement. It has a per-library optimal configuration settings that can be updated using another new scripts (update_pch_autotune.sh) which finds optimal per-PCH settings. PCH files have been generated using the new scripts which builds significantly faster (2-3x, depending on module and configuration) and the intermediate binaries are noticably smaller (by several GBs). The new script stamps each generated PCH file with the command that generated it to make it trivial for users to update them, and also adds the command to invoke another script (update_pch_bisect) that helps find missing headers or conflicting headers that may break the build after updating the PCH. Finally update_pch has built-in unit-tests for makefile parsing and other core functionality. Change-Id: Ib933b50e50374d7e2e7e3e95ba8799b0cc8a27fa Reviewed-on: https://gerrit.libreoffice.org/19965 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-11-15use initialiser for Sequence<OUString>Noel Grandin2-16/+6
using variations of: git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)' | xargs perl -0777 -pi -e "s/Sequence<OUString> (\w+)\(1\)\; \s*OUString\* pArray.*; .*\[0\]\s*=\s*(\S+)\;/Sequence<OUString> \1 { \2 };/g" Change-Id: I03c64334ff30ee14dce0d17b67f5122a3893bbe3 Reviewed-on: https://gerrit.libreoffice.org/19971 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-15use initialiser for Sequence<OUString>Noel Grandin2-6/+3
replaced using: git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)' | xargs perl -0777 -pi -e "s/Sequence<\s*OUString\s*> (\w+)\(\s*1\s*\); .*\[0\] = (\S+);/Sequence<OUString> \1 { \2 };/g" Change-Id: I20ad0489da887a9712982531c3b127339bb8b3b9 Reviewed-on: https://gerrit.libreoffice.org/19969 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-15use initialiser syntax for Sequence<OUString>Noel Grandin3-6/+3
replaced using the script: git grep -lP 'Sequence.*OUString.*\(1\)' | xargs perl -0777 -pi -e "s/Sequence< OUString > (\w+)\(1\); .*\[0\] = (\S+);/Sequence< OUString > \1 { \2 };/g" Change-Id: I23688a91562051a8eed11fc2a85599545c285c34 Reviewed-on: https://gerrit.libreoffice.org/19967 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-11fix svl buildCaolán McNamara1-1/+1
Change-Id: I23a8b3a86ecbab4f1e5b6ae6405279fabcbdb7e3
2015-11-115th step to remove tools/rtti.hxxOliver Specht31-55/+49
tools/rtti.hxx removed completed the interface of some Sdr.* Items and removed pseudo items Change-Id: I0cdcd01494be35b97a27d5985aa908affa96048a Reviewed-on: https://gerrit.libreoffice.org/19837 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann51-373/+373
Change-Id: I0f2f81dae91f62639e79799b1bed1b2df1fd79ab
2015-11-06loplugin:stringconstant: elide explicit ctor usage (automatic rewrite)Stephan Bergmann4-8/+8
Change-Id: I3f4a2ffd9c7d2bce54a553913e1310e25ab0135e
2015-11-05use uno::Reference::set method instead of assignmentNoel Grandin5-23/+21
Change-Id: I6cb508e392d5e194c80fc6d0927c86414e4ab05b
2015-11-02cppcheck: noExplicitConstructorCaolán McNamara1-1/+1
Change-Id: I06186e8f0bbc8522f538e8639a68e816093becc2
2015-10-30svl: remove mostly superfluous abstraction of vectorMichael Stahl1-71/+6
If only we could call the member vector's reserve method then copying would be faster, oh actually we could also use std::copy to get rid of the loop, ... why not just call the copy constructor? Change-Id: I59bb331e6157d692cb62f44f1fd4e8318bf92902
2015-10-30svl: replace boost::ptr_vector with std::vectorMichael Stahl2-21/+21
Change-Id: I7377f9e99b0567a942cdb36f6964ffedacce6a68
2015-10-30svl: replace boost::ptr_map with std::mapMichael Stahl2-26/+15
Change-Id: I87863482a5331b47e71b3e8c9de6e58347aacf24