summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)AuthorFilesLines
2020-09-13Unify the code used to get object shell for componentsMike Kaganski8-116/+34
and their parents across the codebase. Change-Id: Ifb37fb940d285f81c1724a912204533e8c3b0044 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102546 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-09-11convert IMAP_OBJ to scoped enumNoel Grandin1-12/+12
Change-Id: Id265c098a173b2daf581568779d99c7574f067c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102406 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-10micro-optim we just want to remove all urls after m_nCurPos (sfx2)Julien Nabet1-4/+3
Change-Id: Ib27386baa81ee912ebb5112d721610c5fc3c708b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102287 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-10remove image_position top from GtkButtonandreas kainz1-1/+0
Change-Id: Ib7a8eb77b31a8abb08be501b1e0ce8d480f163c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102340 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2020-09-10Remove some unused includesMiklos Vajna1-1/+0
Change-Id: I296597faa21c995c02f68726abd507d0d46c7f86 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102335 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-09-09tdf#75280: Convert inappropriate use of sal_uIntPtr (sfx2)Julien Nabet2-4/+4
Change-Id: Ie034109eb1d199d0f856f19ade7b479b66867f2c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102282 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-09-07Make the OUString ctors taking raw sal_Unicode pointer/non-const array explicitStephan Bergmann1-1/+1
...and in turn add OUString::operator = and OUString::operator += overloads that take a std::u16string_view. Without making the ctors explicit, the operator overloads would have caused ambiguities when called with raw sal_Unicode pointers/non-const arrays, as those can convert to both OUString and to std::u16string_view. But the std::u16string_view operator overloads will generally be useful when changing OUStringLiteral similarly to 4b9e440c51be3e40326bc90c33ae69885bfb51e4 "Turn OStringLiteral into a consteval'ed, static-refcound rtl_String", at which point many existing uses of OUStringLiteral will be replaced with uses of std::u16string_view. Implementing this change turned up a need for an operator = overload for OUStringNumber, which has thus been added. No such need turned up for a corresponding operator += overload, but which can easily be added when the need arises. It also revealed that the operator == overloads between an OUString and a raw sal_Unicode pointer/non-const array were implemented rather inefficiently, creating a temporary OUString from the raw argument. Those have been improved. Preceding commits have already taken care of many dubious or simply unnecessary implicit uses of the now-explicit OUString ctors. This commit makes explicit the few remaining reasonable uses. (And in some cases needed to change variable initialization syntax from using parentheses to using curly braces, to avoid the most vexing parse issue. And needed to explicitly add OUString ctors from char16 const[2] string literal lvalues in a conditional expression in writerfilter/source/ooxml/OOXMLFastContextHandler.cxx that are only necessary because MSVC apparently still insists on doing array-to-pointer decay there.) All of this only affects LIBO_INTERNAL_ONLY. Change-Id: I7ce31162e9be1c3ff3c0bd184a34b535ec56be9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102098 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-09-04tdf#118148 Extended tips for simpress/ and sdraw/Olivier Hallot1-0/+5
Change-Id: I7472b2aaa60d554fd9b2d4c9212917661228d929 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102061 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-09-04TabPage no longer needs to inherit from VclBuilderContainerCaolán McNamara1-3/+2
Change-Id: Iaab26ade1109daf732e58a2f3741cc43243e374c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102023 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-04tdf#118148 Extended tips for HC2/swriterOlivier Hallot1-2/+47
Change-Id: I523bd35ae359d8c5d18e9a553ef101dda0a1e2dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101894 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-09-02remove some unused methodsCaolán McNamara1-5/+0
Change-Id: Ie86cc069b9c69087012b15597e548d1d745d6e2e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101941 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-02drop some unused methodsCaolán McNamara4-44/+0
Change-Id: I4da391591d30db9e51c1dd543bcf128f2e8621c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101914 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-02remove SfxCommonTemplateDialog_Impl vcl::Window memberCaolán McNamara3-19/+7
Change-Id: Ib1ab0e76cb56c909f1e16f58b61ce29d1a70a893 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101911 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-02lok: send state updates for shape editing commandsSzymon Kłos1-0/+6
Change-Id: I0fcb8ef76df89723ee74aa96a003e0d49d558872 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100081 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101520 Tested-by: Jenkins
2020-09-01Fix typo in codeAndrea Gelmini2-3/+3
It passed "make check" on Linux Change-Id: I8e36c4204ae9a2e2968f8006fd6830cd1f6d3905 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101786 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-31Remove remains of private:image/ via ImageIdentifier addon propertyMaxim Monastirsky1-14/+1
This is broken since commit 5c39b28a87060f80404079ab77604f664addb063 ("tdf#96059 Replaced imageproducer with CommandInfoProvider") but so far no one complained (maybe because the usefulness of such internal images from extensions is questionable at least). Given also that the whole ImageIdentifier feature (even its still working part) is obsolete since OOo 2.0.3 (according to the OOo dev guide), and that the availability of a particular image from an internal hardcoded image list by a particular numerical id is more an implementation detail, let's just remove the broken code instead of fixing it. In the meantime, the code was also copied into the newly introduced notebookbar addon code, so I handled it there too. There are also the registry schema and a sdk example that mention this feature, and need to be adjusted. Interesting that the particular example used there - private:image/3216 is actually broken since 2011 with commit 2559cab126f81375197051fb5b07ba6abb9efc77 ("FDO#42454 - EasyHack: remove code associated with unused icons"). Change-Id: I968b4fb8c5b207654476dd92c57d8db0815520ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101529 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2020-08-30Goodbye O[U]StringView, welcome O[U]String::ConcatStephan Bergmann1-2/+2
O[U]StringView had an odd mixture of uses. For one, it was used like std::[u16]string_view, for which directly using the latter std types is clearly the better alternative. For another, it was used in concatenation sequences, when neither of the two leading terms were of our rtl string-related types. For that second use case introduce O[U]String::Concat (as std::[u16]string_view can obviously not be used, those not being one of our rtl string-related types). Also, O[U]StringLiteral is occasionally used for this, but the planned changes outlined in the 33ecd0d5c4fff9511a8436513936a3f7044a775a "Change OUStringLiteral from char[] to char16_t[]" commit message will make that no longer work, so O[U]String::Concat will be the preferred solution in such use cases going forward, too. O[U]StringView was also occasionally used to include O[U]StringBuffer values in concatenation sequences, for which a more obvious alternative is to make O[U]StringBuffer participate directly in the ToStringHelper/O[U]StringConcat machinery. Change-Id: I1f0e8d836796c9ae01c45f32c518be5f52976622 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101586 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-28Change OUStringLiteral from char[] to char16_t[]Stephan Bergmann11-63/+63
This is a prerequisite for making conversion from OUStringLiteral to OUString more efficient at least for C++20 (by replacing its internals with a constexpr- generated sal_uString-compatible layout with a SAL_STRING_STATIC_FLAG refCount, conditionally for C++20 for now). For a configure-wise bare-bones build on Linux, size reported by `du -bs instdir` grew by 118792 bytes from 1155636636 to 1155755428. In most places just a u"..." string literal prefix had to be added. In some places char const a[] = "..."; variables have been changed to char16_t, and a few places required even further changes to code (which prompted the addition of include/o3tl/string_view.hxx helper function o3tl::equalsIgnoreAsciiCase and the additional OUString::createFromAscii overload). For all uses of macros expanding to string literals, the relevant uses have been rewritten as u"" MACRO instead of changing the macro definitions. It should be possible to change at least some of those macro definitions (and drop the u"" from their call sites) in follow-up commits. Change-Id: Iec4ef1a057d412d22443312d40c6a8a290dc6144 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101483 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-28LOK: send status of the sidebarPranam Lashkari1-1/+2
sidebar button did not show status initially similarly view->sidebar did not show checked/unchecked initially and same problem can be seen in notebookbar Change-Id: Ie5fdf298d343435514954efaaebfdc628d4a90fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101182 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101509 Tested-by: Jenkins Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2020-08-27remove some unused includes and update pchesCaolán McNamara1-1/+5
Change-Id: I786548bef39fa711aabcff32b592b3fdc4a6f9fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101486 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-27add a DisableCycleFocusOut flag for an all-welded hierarchyCaolán McNamara3-3/+3
so we can differentiate the case of embedded welded widgets co-sharing the tab-cycle sequence with vcl widgets vs the case its all welded widgets Change-Id: I5c57b4e98d2f5c543522a72e31d554a67c259307 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101485 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-27LOK: send state of FreezePanesPranam Lashkari1-1/+2
Change-Id: I817117d05f7f0f75f65c8e6dbf6105d120ab275d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101031 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101372 Tested-by: Jenkins Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2020-08-27tdf#136133: AppendInfoBar can return nullJulien Nabet1-11/+16
2 cases: 1) When set Donate property to false value in /org.openoffice.Office.UI.Infobar/Enabled and LastTimeDonateShow with 1 in /org.openoffice.Setup/Product (Expert Configuration) See https://bugs.documentfoundation.org/attachment.cgi?id=164702 2) GetInvolved = false and LastTimeGetInvolved = 1 See https://bugs.documentfoundation.org/attachment.cgi?id=164703 Change-Id: I2da22616fb6f3fb4e42bf6b5e5c29cc094dc2fd6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101391 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-27Fix typosAndrea Gelmini1-1/+1
It passed "make check" on Linux Change-Id: I5f39984f1c30fcde46ed411faac3f8d637d10d6f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101449 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-26Better use std::string_view than OUStringLiteral hereStephan Bergmann1-9/+8
Change-Id: Id62324beaa108d9421711989ee4fa09e4c7798ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101407 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-26weld OApplicationSwapWindowCaolán McNamara2-7/+47
Change-Id: I71d24494b5fe7dd2949876944ab9aff41330ad50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101027 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-26ThumbnailViewItem not guaranteed to measure with the font it will draw withCaolán McNamara1-0/+3
Change-Id: Ie590a6d7ffc619b1ac5f9b766582a8088e6b8d02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101370 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-25tdf#135334 Add keyboard shortcut to launch SIShivam Kumar Singh1-0/+34
Change-Id: Id4e911e36527395eb0ed5f29a089a66e0908e882 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100835 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-08-25make drawing item border optionalCaolán McNamara1-14/+18
Change-Id: I8310f77c9e90f3f95a519069709a9d465268eb55 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101026 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-25move thumbnailviewitem.hxxCaolán McNamara9-145/+8
Change-Id: I151a98e34f7ae31dfe6a21fc1e9d0e7aa944248e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101025 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-25Derive ActiveColor as a brighter HighlightColorCaolán McNamara2-6/+8
and use it opaque in thumbnail views so the selected item is always Highlighted but appears brighter when hovered over, leaving the non-selected items using transparent Highlight Change-Id: If0cbc05b779d230332e821aa7fac68a08ac40c41 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101184 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-24tdf#118148 Extended tips from HC2/shared/Olivier Hallot10-15/+213
These extended tips are extracted from <ahelp> in Help files Only for ui files, where dialogs/widget pair could be determined. Other forms of <ahelp hid=".."> such as .uno:.. and *HID* ... will be addressed elswhere. Change#1 Removed extended tips from GtkMenu of svx/.../acceptrejectchangesdialog.ui Change#2 Some empty ET's slipped in cui/macroselectdialog.ui Change-Id: Ic8dc62734143f621fcd3c4156fc004f585630277 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101186 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-23Fix typo in codeAndrea Gelmini1-2/+2
Change-Id: I546bd10f5b7e69f82252cf147c5fcc5756d77a78 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101212 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-23Fix typo in codeAndrea Gelmini1-3/+3
Change-Id: I9061af75ef5d89bf15010f14ede074ec1739a61c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101210 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-23Fix typo in codeAndrea Gelmini1-1/+1
Change-Id: I2598723397edba3ae0d447d3f5dd327a38467741 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101211 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-21grab focus on mouse button downCaolán McNamara1-0/+2
Change-Id: Iac2194e806a514f008e87e04bc528e007eab853d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101145 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-21tdf#118148 All extended tips for shared/optionenOlivier Hallot1-1/+106
Extended tips extracted from <ahelp> in all remaining shared/optionen help pages Change-Id: Id35ce9d51ebf0f7fbe1b399ccabbf85a2c145f6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99825 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2020-08-21Fix typo in codeAndrea Gelmini1-1/+1
Change-Id: Icbe489976053571825aac7a95fdb53eae4907ec7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101112 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-20use HighlightTextColor from Settings for thumbnailviewitem HighlightTextColorCaolán McNamara2-6/+9
so if an icon is selected, typically with a blue background, that the text is rendered with a matching color, typically white foreground Change-Id: I3397924ccf657a9d2bd3c03c51c339685c27d5ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101024 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-19sd signature line: preserve current page after signingMiklos Vajna6-1/+166
Once the user adds a visible signature to a PDF file, we reload the document, so what you see on the screen matches what's in the file (and you can add a next signature). Make sure that in case the signature is not on the first page, the current page state is preserved. Change-Id: Ia1780ce5602ee350855b6dec8340a65e63bf2d4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100999 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-08-19Fix typosAndrea Gelmini1-1/+1
Change-Id: Ibe3cd52117f7f47e1806bde76114cb1644d78763 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100969 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-08-18remove dead codeNoel Grandin1-10/+0
since commit 5be98eba1fddb559194066c511b53412009c2d5d Date: Thu Mar 27 10:29:38 2003 +0000 MWS_SRX644: migrate branch mws_srx644 -> HEAD found by loplugin:unusedvarsglobal Change-Id: I0184e9157caaa7d7d9d58ff20fb8d9293ab0d604 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100925 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-18loplugin:unusedvarsglobalNoel Grandin1-3/+2
tackle some read-only vars. Mark some of them const to make it obvious they are not really used, and to make the constantparam plugin see more data. Change-Id: Ia25927745866746aa1aa9d5affd5857ad9f9ee24 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100895 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-18weld OAppDetailPageHelperCaolán McNamara1-1/+1
Change-Id: I0fa9f21c30bba8f781178b0811f3f7d755af1bb3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100627 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-16loplugin:unusedfieldsNoel Grandin1-6/+0
Change-Id: I61fe1c43f4235eddfca80f2a8392c58d4b1380e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100818 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-15remove constructor with plain Bitmap from Graphic, use BitmapExTomaž Vajngerl1-1/+1
Change-Id: Ie429a10a8f54c6779d437ee4bc75a5ea0c427848 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100727 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-08-14loplugin:simplifybool moreNoel Grandin3-4/+6
look for expressions like !(a && !b) which can be expanded out Change-Id: I72515a9638762b050f9a258c08da39ebfa2ef8e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100579 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-14One toolbar generic controller is enoughMaxim Monastirsky1-3/+4
The one from framework is more feature complete, so use that one. Change-Id: I499f0ae1d20c588cfc04beebc643819559325882 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100726 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2020-08-13use unique_ptr in SfxAppData_ImplNoel Grandin10-88/+63
and simplify the destruction - we only ever called ReleaseInterface on destruction, so no need to bother with that, and risk touching pointers that might be nullptr Specifically, the problem is this code pImpl->pSlotPool.reset(); which triggered the path ~SfxSlotPool -> ~SfxInterface -> SfxGetpApp()->GetAppSlotPool_Impl() which crashes because the pSlotPool pointer is null at that point Change-Id: I8577760d09be598926623d6eb5500969e07dd6f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100624 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-13simplify memory management in SfxInPlaceClient_ImplNoel Grandin1-13/+10
no need for the impl class to hold a reference to itself Change-Id: I4ee3fc46df93d9ba087590af33d78834a454161f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100619 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>