summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)AuthorFilesLines
2017-01-05Don't exclude a var from loplugin:salbool merely because of use in >>=Stephan Bergmann1-2/+2
Change-Id: I1b8a3dfa1dc6b351ab0903a74eae19dfa6d0888d
2017-01-04follow up remove unused autohide leftoversCaolán McNamara1-7/+0
Change-Id: Ic7281e915075519c300a330557399111838d7d34
2017-01-04drop AutoHide codeCaolán McNamara1-3/+1
only used from reportdesign and that appears to be overlooked from an earlier eradication program Change-Id: I196fd7ccbc909c935daf534d55e6b39de8510f23
2017-01-03Hold SfxInfoBarWindow by VclPtrStephan Bergmann4-13/+11
In SfxInfoBarContainerWindow::removeInfoBar, disposeAndClear is already called on the removed member (once found), so the ScopedVclPtr (also calling disposeAndClear when going out of scope) should not be necessary. Change-Id: Ibf4d19ebd5f1a6217e1d18ef0458c9b865667898
2017-01-03Move documentation for parameter of SfxObjectShell::GetTitle() to include fileTor Lillqvist1-41/+1
A re-design of this API would be a good idea. Is this function ever called with some specific max length that would not be one of the magic values? Probably the sanest would be to turn the magic value constants into a normal (scoped) enum, and have two separate functions: One that takes no parameter and returns the whole title (and then let the caller take care of truncating as necessary), and one that takes such an enum and returns a correspondingly mangled title. The less magic and defaulted parameters the better. Change-Id: I9e3aa95fae981c5ed48300b753556fa9074c1166
2017-01-01Bump copyright year to 2017Adolfo Jayme Barrientos1-1/+1
Change-Id: I26ddcdd7bb9616c0599eec9101603d4be1ea4147
2017-01-01remove recently unused imagelist pointersCaolán McNamara1-7/+1
since commit e3203ad42dd57d546ab8cd002b8fcbe54c9bcd11 Author: Caolán McNamara <caolanm@redhat.com> Date: Wed Dec 21 10:07:41 2016 +0000 remove newly unused SfxModule::GetImageList_Impl, etc Change-Id: Ibb1430d2b6c7994b2425d686cf206d168530faef Change-Id: Ib2acaf66f513c4f7d6f74b790929df9e0a0a7038
2016-12-31tdf#105011, tdf#104795: copy string until its end if there's no commaJulien Nabet1-2/+4
5 0x00002aaab055f81e in rtl::OUString::copy (this=0x7fffffff29d0, beginIndex=3, count=-4) at /home/julien/lo/libreoffice/include/rtl/ustring.hxx:2223 6 0x00002aaab070acd2 in (anonymous namespace)::GetContentPart (_rRawString="CN=timur.davletshin@gmail.com", _rPartId="CN") at /home/julien/lo/libreoffice/sfx2/source/dialog/dinfdlg.cxx:748 7 0x00002aaab070dd85 in SfxDocumentPage::ImplUpdateSignatures (this=0x55555ca2e0b0) at /home/julien/lo/libreoffice/sfx2/source/dialog/dinfdlg.cxx:901 so do the same as GetContentPart from uui/source/secmacrowarnings.cxx (I suppose we should avoid the redundancy but that's another story) Change-Id: Ief3ce1cce7035fb572778bdee02a1073b7dfe1c1 Reviewed-on: https://gerrit.libreoffice.org/32530 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-12-30cleanup tailing backslashesJochen Nitschke3-6/+6
Change-Id: Idb4bfc97e7d758c58118742affd9a9345c7a99f2 Reviewed-on: https://gerrit.libreoffice.org/32491 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-26use std::vector instead of naked array in SfxItemPoolNoel Grandin1-8/+7
Change-Id: I2d4ac010ff5818e673567cee05700872588918e4 Reviewed-on: https://gerrit.libreoffice.org/32384 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-12-24fix some whitespace formatttingCaolán McNamara1-21/+6
Change-Id: I5b89aa3dbaab81df0c092fb64d2a26410390cefc
2016-12-22drop imglstCaolán McNamara1-4/+4
Change-Id: Iff88349acf3fc0f474cff0a882346a6d8496aec1
2016-12-21unwind RID_STYLE_DESIGNER_IMAGELIST ImageListCaolán McNamara4-24/+21
Change-Id: I8fd69aa8acc8aa2bb1705b3819cf089e618464b5
2016-12-21convert VclButtonsType to scoped enumNoel Grandin11-21/+21
Change-Id: I9b91108c18e190060dc71546977aa8a3c11f06e1 Reviewed-on: https://gerrit.libreoffice.org/32285 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
2016-12-21remove newly unused SfxModule::GetImageList_Impl, etcCaolán McNamara1-27/+0
Change-Id: Ibb1430d2b6c7994b2425d686cf206d168530faef
2016-12-21remove newly unused SfxImageManagerCaolán McNamara7-322/+0
Change-Id: If68637fe49b5d252ad4ec5d63d56261113be6a7c
2016-12-21convert EnumContext::Context to scoped enumNoel Grandin4-5/+5
Change-Id: I16ec63beb801073e5d604d852892c2fd6e8d8fc3 Reviewed-on: https://gerrit.libreoffice.org/32272 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-21convert EnumContext::Application to scoped enumNoel Grandin3-32/+32
Change-Id: Ia289a7b63bf8797085315218785e2a2a4c45d232 Reviewed-on: https://gerrit.libreoffice.org/32230 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-20tdf#97361: Changed naming in sfx2 python testskerem2-66/+66
Change-Id: Iabacaff8fd7f282a903885954a7d725ceb6f6c16 Reviewed-on: https://gerrit.libreoffice.org/32118 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2016-12-20Downgrade SAL_WARN -> SAL_INFOJulien Nabet1-3/+3
Change-Id: I2f0957ee2ce7156e8ea9ce376787d2898e517fbf Reviewed-on: https://gerrit.libreoffice.org/32252 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2016-12-20tdf#94576 handle esc keypress on templatemanagerdialogTibor Móger1-0/+21
SfxTemplateManagerDlg now overrides behaviour of ModalDialog on EventNotify by checking if the pressed key was esc and the searchFilter is not empty and it was focused. In this case instead of letting ModalDialog close the modal it clears the searchFilter Change-Id: I90d91a3b152f68b6c8780963d1b95258d9ccf23a Reviewed-on: https://gerrit.libreoffice.org/31736 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2016-12-20Don't use 'this' in ctorStephan Bergmann2-8/+18
Change-Id: I405160743609aae92a37b2359bea5aa42ee66519
2016-12-20Result of css::ui::ContextChangeEventMultiplexer::get cannot be nullStephan Bergmann3-14/+10
Change-Id: I00fba6c2a79404c824feaa5bb302d37c4158f9a3
2016-12-20convert SFX_EVENT constants to scoped enumNoel Grandin13-78/+64
SFX_EVENT_CLOSEAPP and SFX_EVENT_TOGGLEFULLSCREENMODE are never generated, so remove them and delete the code that receives them Change-Id: I2d003ba73fff0b02120ba29ff58e1d2399dedf00 Reviewed-on: https://gerrit.libreoffice.org/32168 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-19tdf#104622 Add duplicate node entry to elements in emoji.json databaseGaurav Dhingra2-349/+698
Add boolean field "duplicate": true Change-Id: I8e45ed4694bfc75b18c2405146e5eaa142559c1b Reviewed-on: https://gerrit.libreoffice.org/31997 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com>
2016-12-19loplugin:unreffunTor Lillqvist2-7/+7
Change-Id: I4663de7eb81b7af39b5a24581667fd7fcfb829cd
2016-12-19no need to wrap calls to SAL_INFO in #ifdef DBG_UTILNoel Grandin7-38/+8
Change-Id: Ic373a8f145f3f78c3f109e36a9c1dd9156f0dd75 Reviewed-on: https://gerrit.libreoffice.org/32034 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-16-Werror=maybe-unintializedCaolán McNamara1-3/+3
Change-Id: I73eb58e44c00d5e1cfcabe71f2ba946a81a62fa7
2016-12-16lok: Fix state feedback for ToggleMergeCellsPranav Kant1-2/+13
Now it broadcasts "disabled" to disable the command and true/false to tell the status of the command which automatically means "enabled" Change-Id: I3314da77fb2b84d97f64b9832d65791b84fcd7df Reviewed-on: https://gerrit.libreoffice.org/32086 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2016-12-16lok: Sort ascending/descending is enabled/disabled statePranav Kant1-4/+4
... and not true/false Change-Id: Ie9ae6cbf70c1934dda1002deabda23c9f461c8b1 Reviewed-on: https://gerrit.libreoffice.org/32085 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2016-12-16coverity#1397200 Unchecked return valueCaolán McNamara1-1/+1
and coverity#1397201 Unchecked return value coverity#1397202 Unchecked return value Change-Id: I73cc6e3b08e6a44b27be2093ba568d46ebe0659a
2016-12-15teach sallogareas plugin to catch inconsistenciesNoel Grandin11-36/+36
Change-Id: I8bcea5ffc74d48148bea78da8c17744e288c069a Reviewed-on: https://gerrit.libreoffice.org/32004 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-14SafeMode: s/LibreOffice/%PRODUCTNAME/, small UI changesKatarina Behrens1-2/+1
nouns are written Upper Case only in German also Cancel button looks odd as secondary Change-Id: Id1b051cbb86ab69ea88c7b1da2cda3eb19f063de Reviewed-on: https://gerrit.libreoffice.org/31971 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-12-13That's probably not meant to be a C++ reference to a uno::ReferenceStephan Bergmann1-1/+1
...as introduced with e75f6e549eb825c310d16d11babf0fba5ee7fd7a "sfx2: make SfxClassificationHelper not require a full doc shell". Made CppunitTest_sfx2_classification crash now when dereferencing m_xDocumentProperties in SfxClassificationHelper::Impl::pushToDocumentProperties, when built with a recent Clang trunk build. Change-Id: Id0b7fa0627b9642f748f07d7dfa05353114225fa
2016-12-13tdf#95416 Fix an include for sfx2Adam Kasztenny5-4/+4
This .hrc file was used in multiple places. Change-Id: I603c6d35da2e870d8586f081ccd2672065ade5db Reviewed-on: https://gerrit.libreoffice.org/31928 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-12-13SafeMode: Restart goes into safe mode againSamuel Mehrbrodt1-5/+30
Looks like the XRestartManager keeps all command line arguments when restarting, so it also keeps --safe-mode. Solution is to add a flag file when restarting from safe mode, to prevent going into safe mode again. Change-Id: I9820d3ccbddf98b0bf6132f254c989f52ea5e808 Reviewed-on: https://gerrit.libreoffice.org/31913 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-12-12remove useless Mutex guardsNoel Grandin1-1/+0
Change-Id: Ib1edb681b47ce98e2e810d15111932002786aa51 Reviewed-on: https://gerrit.libreoffice.org/31875 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-11OSL_TRACE -> SAL in sfx2..svxNoel Grandin15-117/+69
Change-Id: I78cf8058a5682baa3d7b00a25feeb2d28fb3e66e Reviewed-on: https://gerrit.libreoffice.org/31799 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-09Related: rhbz#1397939 crash with null pSidebarControllerCaolán McNamara1-2/+2
Change-Id: I7627ff30564b2de61669c71dafd15e7b1778b5c6
2016-12-08convert SFX_HINT to scoped enumNoel Grandin18-58/+52
Notes (*) In SC, BULK_DATACHANGED was or'ed into the hint id. Replaced with a dynamic_cast check. (*) In SC, removed the hint id field from ScIndexHint, no point in storing the hint id twice (*) Fold the SfxStyleSheetHintId enum into the new SfxHintId enum, no point in storing two different hint ids (*) In some cases, multiple #define's used to map to the same SFX_HINT value (notably the SFX_HINT_USER* values). I made all of those separate values. Change-Id: I990e2fb587335ebc51c9005588c6a44f768d9de5 Reviewed-on: https://gerrit.libreoffice.org/31751 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-07convert VCLEVENT constants to scoped enumNoel Grandin5-19/+21
Change-Id: Ic8ccb0a9715ec05182dacddab2c015b0de6a0fba Reviewed-on: https://gerrit.libreoffice.org/31675 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-06loplugin:unnecessaryoverrideStephan Bergmann1-1/+0
Change-Id: Ifa46b0eb0fb8f288acbcf19f7090a62c6a1ecef3
2016-12-06Convert TextView to unique_ptrMark Page1-0/+1
The destructor contains reset to the unique_ptr's because it is not clear of the importance of the destruction order Change-Id: Ifbbb4fe8352cb3b50f18cebd60cf00af010c086a Reviewed-on: https://gerrit.libreoffice.org/31673 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-06loplugin:unnecessaryoverrideStephan Bergmann1-5/+0
Change-Id: Iac074bd6f59d2fc890459b45801d0a6143c3eb9e
2016-12-05tdf#97361 remove = None assignments in sfx2 python unit testskerem2-4/+0
Change-Id: Iba3926d1b044ade69e1306941ed70b644dc577d6 Reviewed-on: https://gerrit.libreoffice.org/31602 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-12-05convert FSysStyle to o3tl::typed_flagsNoel Grandin4-4/+4
Change-Id: I58a63a0e6f619442f21827064644ecd8ca57b8ff
2016-12-05convert DecodeMechanism to scoped enumNoel Grandin37-178/+178
Change-Id: I5c56634b1bca8e37fa73d02d2428645301b6c547
2016-12-05convert INetURLObject::EncodeMechanism to scoped enumNoel Grandin6-30/+30
Change-Id: I50ea17c7779c7b5cacddf548f1773fd7d6c8bade
2016-12-05loplugin:unnecessaryoverride (dtors) in sfx2Stephan Bergmann20-108/+4
Change-Id: Ic086a22bccd267824e68df6c963df8da76e6df2c
2016-12-02usageinfo causes one of our more frequent fedora 25 crashesCaolán McNamara1-2/+10
https://retrace.fedoraproject.org/faf/problems/bthash/?bth=17ba9a57f40d5ca29778866a9f96c1c0dfc7593c&bth=2f1801e44e9cb0be2b013624521fb0959dc2c73a&bth=5e8a1e07503f53b13b3a6779084f8b0637aaf5a7&bth=8033013a2ce586bccc23245583fa86ef4a761dce&bth=975271167132418534cb07336601efb5b0c711f0&bth=de75c2ad7917bc889d6307b152f79d34e79ce74d Change-Id: Ie93afa476eca9fdbf7ea17ff0189fbaa493a5531
generated by cgit v1.2.3 (git 2.39.1) at 2024-12-04 22:11:58 +0000