summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)AuthorFilesLines
2018-03-26sfx2 store: avoid rename() for files with >1 hard link countMiklos Vajna2-1/+59
Rename would break the hard link; in practice e.g. Online's 'make run' debug feature depends on not breaking hardlinks. Change-Id: Id3ac19493b6b473274b7ed53a4ca06fc34bc1668 Reviewed-on: https://gerrit.libreoffice.org/51858 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-26use boost::optional in OutDevStateNoel Grandin1-1/+4
Change-Id: I83fb85fcba6cd2a5dc4f99fdfd3238d72afb7bc2 Reviewed-on: https://gerrit.libreoffice.org/51770 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-25Remove useless checkMike Kaganski1-1/+1
Change-Id: I9cfb8e7865e31b5c69e0b4b99426e96c7444224f Reviewed-on: https://gerrit.libreoffice.org/51820 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-03-22set parent for password dialogCaolán McNamara2-5/+5
Change-Id: I3276cdc1a9f94aead260706cb378e278000081be Reviewed-on: https://gerrit.libreoffice.org/51728 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-20drop unnecessary includesCaolán McNamara29-29/+1
Change-Id: I1a817d5575bbd57ecaa874a27158b9218e4210cc Reviewed-on: https://gerrit.libreoffice.org/51603 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-20tdf#116494: Don't ask parent if no help textMuhammet Kara1-0/+5
And add/use an IsHelpInstalled() method to SfxHelp. Change-Id: Ib87573067d6c44fa5adb22253c1a51a78580acf6 Reviewed-on: https://gerrit.libreoffice.org/51584 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-03-20Show start centre thumbnail indicating the file is encryptedKatarina Behrens1-12/+68
Change-Id: Ie46096b3198852c6ef70960b22652767c09d4779 Reviewed-on: https://gerrit.libreoffice.org/51532 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-03-19coverity#1430074 Uncaught exceptionCaolán McNamara1-5/+11
and coverity#1430066 Uncaught exception coverity#1430095 Uncaught exception Change-Id: Idca2e12d3911e3ea768a2a9fb8e7f3b03a2c887f Reviewed-on: https://gerrit.libreoffice.org/51567 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-19lokdialog: Set parent for AutoCorrect Options... so that it can be tunneled.Jan Holesovsky1-1/+2
To get this dialog: Right-click on a mis-spelled word, and it's in the tunneled context menu. Still it should be converted to async though. Change-Id: Ia8f2aaf0d04f144c74999107de98e52cd51876e7 Reviewed-on: https://gerrit.libreoffice.org/51441 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk> (cherry picked from commit 7b83827d7b5d07401878fe552c421331629a7880) Reviewed-on: https://gerrit.libreoffice.org/51548 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-03-19coverity#1430073 silence Unchecked return valueCaolán McNamara1-1/+1
Change-Id: I3c40f0679fea99b22489fedb5af17982c1502a86 Reviewed-on: https://gerrit.libreoffice.org/51560 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-19coverity#1430090 Uninitialized scalar fieldCaolán McNamara1-0/+4
Change-Id: I612642fdd09b2427aede1ef7b90b36b7c27682e1 Reviewed-on: https://gerrit.libreoffice.org/51540 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-19tdf#115806: Remember last active deck also on context switchKatarina Behrens2-1/+10
within 1 application Change-Id: Icab6dea9f9a7895732c41e6d96b9d4546cf0001f Reviewed-on: https://gerrit.libreoffice.org/51530 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-03-19set parent window for interaction dialogs for pdf export (etc)Caolán McNamara1-1/+6
Change-Id: I6a1df74d4737c5fe040c0131f3c8149ef81e8410 Reviewed-on: https://gerrit.libreoffice.org/51520 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-19remove unused ucbstreamhelper includesJochen Nitschke8-6/+2
and a few vclunohelper includes Change-Id: I4803605766d155fe5044c2a65c0444631146831c Reviewed-on: https://gerrit.libreoffice.org/51496 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-18add id column support to tree viewCaolán McNamara2-4/+4
Change-Id: I11702f58e488bcf3fcd49c45c11b5059298f81fd Reviewed-on: https://gerrit.libreoffice.org/51512 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-18unify the message dialogs with extra widgets casesCaolán McNamara2-13/+1
Change-Id: I9ad3573b15d24c3d1737b9f450792952ae20a31b Reviewed-on: https://gerrit.libreoffice.org/51476 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-17Removed duplicated includeAndrea Gelmini1-1/+0
Change-Id: I967e67d08b22dc3c56fe860bea49f301b75b4ff9 Reviewed-on: https://gerrit.libreoffice.org/51463 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-03-17lok: notify clients of clipboard changesAshod Nakashian1-5/+11
Change-Id: I93d8eacc0defb1176ec5d767f49356812cf90ff6 Reviewed-on: https://gerrit.libreoffice.org/50327 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2018-03-16First cut at annotating 'exotic' filters.Michael Meeks4-1/+121
The idea being that we can improve security by warning for these. Change-Id: I7d993417bfb6a8fe868bc3e07ccbcfe71bf285ff Reviewed-on: https://gerrit.libreoffice.org/50387 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2018-03-16use digit width instead of char widthCaolán McNamara2-2/+2
its the same across backends Change-Id: I37c83cbf1139babcd014c7cfdee06a13bea845c7 Reviewed-on: https://gerrit.libreoffice.org/51423 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-16use more TypedWhichId in sfxsidsNoel Grandin2-11/+9
Change-Id: I136427319ce2f1117501517efec2f03019bbf71e Reviewed-on: https://gerrit.libreoffice.org/51339 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-14tdf#116305 Add timeout to help Windows bring browsers to the frontSamuel Mehrbrodt3-31/+62
Adding a timeout seems to help Windows a lot to actually bring the browser into the front, especially when it was closed before. Still no 100% success rate, but much improved now. Change-Id: I62affee4b837e0a60b1aac2a20be6fe7c3f9d2e0 Reviewed-on: https://gerrit.libreoffice.org/51132 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-03-14loplugin:constantparamNoel Grandin1-2/+2
Change-Id: I3ce653c0d9e517229dbbe32cc8d3ec3c206e364d Reviewed-on: https://gerrit.libreoffice.org/51273 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-14enable column search for welded treeviewsCaolán McNamara2-3/+3
Change-Id: I017dc2e5270d86b2168faf3f9240eeded1fc3533 Reviewed-on: https://gerrit.libreoffice.org/51272 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-14Moving XSAXDocumentBuilder2 to use XFastDocumentHandler:Mohammed Abdul Azeem1-1/+7
This is used in parsing of meta Contexts across different modules. This also involved moving to XFastParser for parsing xml filters in sw, sd, starmath. Change-Id: Ic663aaac6cb20ee8ce5b97cae87c93220f5a2929 Reviewed-on: https://gerrit.libreoffice.org/42989 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-14tdf#116296 remove produt version from help pathOlivier Hallot1-8/+12
Part one. Part 2 is in helpcontent2 module Remove product version from offline help path but keep in online help. Test for existence of old offline help is done now checking the presence of the file help/<lang>/err.html Test for new (html) offline help is done now checking the existence of the folder help/<lang>/text Change-Id: I1d00a4eac6746f0ace5a40db56910803a5e0d6f4 Reviewed-on: https://gerrit.libreoffice.org/51127 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-14tdf#115565 Change tab key behavior to navigate out of gotopage controlJim Raykowski1-1/+5
...in Writer Sidebar Navigator deck helper toolbox Change-Id: Ieeabcb30f421aa0ce2a5f841e45fff5f57358215 Reviewed-on: https://gerrit.libreoffice.org/50295 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-03-13tdf#91106 sfx2: Stylist hierarchical: sort the Default Style firstMichael Stahl1-0/+4
(regression from 41af2a9e26f3ee6b505b343120d5df3617ba5c49) Change-Id: I47377447dd1e04a44033dea27ce7307a65821737
2018-03-13weld insert table dialogCaolán McNamara1-0/+5
Change-Id: I17bdbba38a74ea05b0d6869ee04f01f870a3b17b Reviewed-on: https://gerrit.libreoffice.org/51219 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-13set welded enties to activates-defaultCaolán McNamara3-0/+7
cause the vcl ones are equivalent to this so less change Change-Id: I60d9ba5faab6c133242b002b81fa8e4747a92383 Reviewed-on: https://gerrit.libreoffice.org/51220 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-13SDI: don't #define/#undef names of actual classes for slot headersMike Kaganski5-6/+5
Visual Studio 2015/2017 cannot handle that correctly, and emits a lot of intellisense errors. So, just prepend the define with "ShellClass_" Change-Id: I473ceb7e0a88e114b92e6342fd4ae63015cafd3e Reviewed-on: https://gerrit.libreoffice.org/51135 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-03-13tdf#116117 sfx2 store: don't inherit temp file permissions when renamingMiklos Vajna2-0/+56
This has to be handled explicitly, otherwise the tempfile permissions (which intentionally don't respect umask()) would be preserved on rename(). Change-Id: I0a2681dbf06986e73f6e12d294e35e87b93b4f8a Reviewed-on: https://gerrit.libreoffice.org/51169 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-03-12tdf#115853: save current custom property when adding lineJulien Nabet1-1/+16
by reloading current lines before adding a brand new one indeed the info are deleted by ClearCustomProperties each time SfxDocumentInfoItem destructor is called Change-Id: Id1e2e652e90c720f00b8612aa9afbfa91b784d1d Reviewed-on: https://gerrit.libreoffice.org/50070 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-03-12loplugin:redundantfcast look for redundant copies in return statementsNoel Grandin1-1/+1
Change-Id: I5f416c865dfe1c36018784246a8007452eb42008 Reviewed-on: https://gerrit.libreoffice.org/50996 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-11weld color pickerCaolán McNamara2-3/+4
Change-Id: I487b9a0cc13b2b60a0f1e28667773b5d3b5c66cc Reviewed-on: https://gerrit.libreoffice.org/51001 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-09Remove unused HIDsGabor Kelemen1-2/+0
These were no longer used in the code. This should help me in identifying obsolete and missing HIDs in helpcontent. Found by this somewhat sophisticated method: for mod in $(find -name helpids.h) ; do echo $mod; for i in $(grep ^#define "$mod" | cut -d " " -f2 ) ; do if [ $(git grep -c "$i" $(echo "$mod" | cut -d "/" -f 2 ) | wc -l) -eq 1 ] ; then echo "$i"; fi ; done done Change-Id: Iaf8179322419ce51175bc5a42fedec0add8c5241 Reviewed-on: https://gerrit.libreoffice.org/50680 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2018-03-09inherit welded dialogs from a common ancestorCaolán McNamara11-45/+22
Change-Id: Ifa6c871a134cf89bfba71b1049a115cf7c953c42 Reviewed-on: https://gerrit.libreoffice.org/50936 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-09Let sysadmins disable individual file format filtersAndras Timar3-4/+20
It makes sense to disable a filter, as a temporary security measure, when there is a 0-day vulnerability in it. E.g., when 0-day found in AbiWord filter, this config snippet disables it: <item oor:path="/org.openoffice.TypeDetection.Filter"> <node oor:name="Filters"> <node oor:name="AbiWord"> <prop oor:name="Enabled" oor:finalized="true"> <value>false</value> </prop> </node> </node> </item> Change-Id: I8b84250c7e4aac3555877d23f58ed13a2210ebfc Reviewed-on: https://gerrit.libreoffice.org/50961 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2018-03-09loplugin:redundantfcast look for unnecessary temporariesNoel Grandin2-2/+2
when calling methods that take a const& Change-Id: Idf45dfd9fea0de6fae0b1f89550f2f7fc302aa15 Reviewed-on: https://gerrit.libreoffice.org/50970 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-08loplugin:constantparam in linguistic..sfx2Noel Grandin7-21/+14
Change-Id: I0e8c506df0beb0b05d9c32723876b11b6577280a Reviewed-on: https://gerrit.libreoffice.org/50938 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-08loplugin:constantparam in canvas..comphelperNoel Grandin1-1/+1
Change-Id: Ia666cb46c409852a13789389c032f0ce4377c0d5 Reviewed-on: https://gerrit.libreoffice.org/50927 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-08loplugin:unusedmethodsNoel Grandin1-9/+0
Change-Id: Id6b4edd265cb6bef31c72e2a0a440211d51c7c33 Reviewed-on: https://gerrit.libreoffice.org/50900 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-07weld SfxNewFileDialogCaolán McNamara3-284/+225
Change-Id: I28b1aff90407bce7d04f10eed6a227c0970f9c0a Reviewed-on: https://gerrit.libreoffice.org/50878 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-07make all the .ui message dialogs explicitly modalCaolán McNamara4-0/+5
Change-Id: I1e197fbec92d5369394f036171af9018afea7f15 Reviewed-on: https://gerrit.libreoffice.org/50910 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-07preview of empty page ends up with negative sizeCaolán McNamara1-1/+1
in load templates, i.e. SfxPreviewWin_Impl, with an empty writer template selected. Change-Id: I7194def1dacb25e39416532ed91addc1de0c1d39 Reviewed-on: https://gerrit.libreoffice.org/50877 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-07Resolves: tdf#116116 vertically center line in allocated heightCaolán McNamara1-0/+1
Change-Id: Iee4cd859cdc52a2272f5b01c3e4a57336cc336a4 Reviewed-on: https://gerrit.libreoffice.org/50881 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-07use more Color in sfx2..svtoolsNoel Grandin3-8/+8
Change-Id: Idd951841ce7e9c4b4e5229bc24efe5c7b8042617 Reviewed-on: https://gerrit.libreoffice.org/50817 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-05Resolves: tdf#116188 set min version on all .ui files to 3.18Caolán McNamara44-44/+44
which is already the min for the runtime Change-Id: Ifebe099f1f94a36f65a31989689400327a823dcd Reviewed-on: https://gerrit.libreoffice.org/50776 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-05weld SfxSaveAsTemplateDialogCaolán McNamara4-77/+149
Change-Id: Ia663102a2d871fdca093c0d33e5af5a79deebeb5 Reviewed-on: https://gerrit.libreoffice.org/50775 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-05We now use Unicode with MAPISendMailW, so no need for thisMike Kaganski1-4/+0
Change-Id: I6f03b4212a3434cb5feae8da29107c5f411218e3 Reviewed-on: https://gerrit.libreoffice.org/50759 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-11-29 19:20:26 +0000