summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)AuthorFilesLines
2023-07-30Send Calc pivot table command state changes to LOKAron Budea1-0/+3
Change-Id: I0d9e04b0a0452f66cb9703d9f34fe6cb44d724c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154506 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Aron Budea <aron.budea@collabora.com> (cherry picked from commit b62f9f484a0fc9215e34153daac4a8bdb9698d4b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155034 Tested-by: Jenkins
2023-07-28Added possibility to set password on save through argumentsJaume Pujantell1-1/+17
Change-Id: I579ed7487f87515a21d83912d9c0d12e9edc5eea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154415 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-07-28SfxMedium::GetItemSet never returns nullptrMike Kaganski20-316/+296
Change-Id: Ibfc98a49022aa09ebf5315e5d3328308c1e51d66 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154997 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-07-26lok: sfx2: fix change state "SheetRightToLeft" 2nd attemptAron Budea1-10/+4
This reverts commit 71e5f7e43471cc479ea1e818c813170a389964e6, and adds SheetRightToLeft in a different place. Change-Id: Id7001d06b247713de2e4dfe5076d156988e932d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152808 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Henry Castro <hcastro@collabora.com> (cherry picked from commit f44aed75f1c1f64c07651376fd2f638f61e0c3b1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154928 Tested-by: Aron Budea <aron.budea@collabora.com> Reviewed-by: Aron Budea <aron.budea@collabora.com>
2023-07-25keep gtk3->gtk4 automigration rulesCaolán McNamara1-11/+0
Change-Id: Ie66f1343dffce441836beaf5a779b32b92e3bbc0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154898 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-07-25Convert internal vcl bitmap formats transparency->alpha (II)Noel Grandin1-1/+1
(Second attempt at landing this) Image formats and graphics APIs use alpha, not transparency, so change our internal formats and data structures to work directly with alpha, so we don't need to modify data before we push it to graphics APIs. Add a couple of new Color constants to make the intention of the vcl code clearer. Notes (*) On macOS, tweaking the logic in CreateWithSalBitmapAndMask to more accurately reflect the requirements of the CGImageCreateWithMask function seems to fix some tests. (*) The vcl code does not properly support gradients with transparency. So the previous code was wrong, and this change is going to result in slightly different wrongness. Change-Id: I9e21c2e98d88ecfdc5f75db13bd1ffff7c38db98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114168 Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@neooffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-07-24Regression: eliminate white lines in infobar's close buttonPatrick Luby1-4/+5
When drawing the close button's background, the right and bottom need to be extended by 1 or there will be a white line on both edges. Change-Id: I67dcad422c0f33af3035621cd624c1ddafc89d00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154871 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@neooffice.org>
2023-07-24tdf#92620 - Adjust error message about exceeding legacy module sizeAndreas Heinisch3-4/+4
Adjusted the error message about exceeding legacy module size and removed the code for saving image version 11. Modules using image version 11 still can be loaded. Saving modules always result in an image version higher than image version 11 depending on the size of the module. In addition, some minor performance issues (construction of the error message and the correct list of modules) were fixed. Change-Id: I3bde9fcc1596b63446193c836fa7b5cb06eb7d97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149687 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-07-23tdf#147911 Implement set_item_help_id for context menu itemsRafael Lima2-0/+18
This patch adds the method set_item_help_id for weld::Menu (similarly to what we already have for weld::Toolbar). This way, it is possible to define help IDs for each entry in context menus that are created during runtime. This is necessary to fix various bug tickets that request F1 to redirect to the corresponding help page when a context menu item has focus. This currently works for context menus created from XML files, but fails for context menus created during runtime. Besides implementing the new method, this patch fixes bug 147911 (see changes in file templatedlglocalview.cxx) to showcase how set_item_help_id can be used. NOTE: Pressing F1 in context menus only work with "gen" and "win"... unfortunately it does not work in kf5 and gtk3 due to a separate bug (see bug 156376). Change-Id: Ic9bb1bca3e646cb4d0b879d8672c5dcc9c19c4c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154699 Tested-by: Jenkins Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-07-23vcl: Use GetTextArray() when drawing mnemonicsKhaled Hosny1-3/+4
Instead of using a different function to get the character width, use the same function used for getting the character widths elsewhere. Change-Id: I21428f34bb0f3a60fa17f5e8ecc3420545356337 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154609 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-07-22merge SetOptions_Nbc and SetOptionsNoel Grandin2-8/+2
since the Nbc variant is no longer necessary Change-Id: I4a846dcdbe68116dd511e45f018af2cdc5fbcf48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154725 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-07-22SfxItemSetHint is deadNoel Grandin1-5/+0
since commit 519876dffdc8c93710af543cc11332dab9a50c14 Author: Mike Kaganski <mike.kaganski@collabora.com> Date: Tue Jul 18 23:45:47 2023 +0300 Cleanup SfxApplication::Get/SetOptions, and drop unused SIDs Change-Id: I8d306bf6792630cfdaa0a0ac8b77730e1e1f0070 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154724 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-07-21Related: tdf#155708 Clean-up - Fix validity dialog closesBalazs Varga1-1/+1
Do not close Validation window if click on another Calc sheet. Follow-up of commits: 1 - a5c61b143d53bb10430b8a486874856c16a2d86c 2 - efaa065eb7053954242c83760f897e7dba2e9fe8 Change-Id: I5352ee869f3e8a93b49abec863089f57cdf0aeba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154369 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-07-20split GetWindowExtentsRelative asunderNoel Grandin1-1/+1
sometimes it returns a relative position, sometimes an absolute position. Rather have two different methods with names that match what they return. Change-Id: Ie1e73c6be1c797fd59934c96866d1fef1f972b35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154653 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-07-19Cleanup SfxApplication::Get/SetOptions, and drop unused SIDsMike Kaganski2-190/+3
The removed stuff was never used elsewhere; e.g. all uses of GetOptions use Which Ranges that don't include the removed identifiers. Elements removed from SetOptions weren't passed to that function from anywhere. Change-Id: Id81b57014b82f89538a46a609f3e4b328864bbcf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154604 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-07-18tdf#68565 autosave: add option to store backup in document's folderJustin Luth3-3/+23
Creating a backup copy became the default in LO 7.6. Allow the user to choose whether to store this previous version of the file beside the original file (in the same folder). The historical (and still the default) action is to store it in a special backup folder instead. The problem with the backup folder is that it overwrites files that happen to have the same name (because the originals reside in different directories), which is not uncommon. Adding this option allows the user to overcome that limitation. However, I do not want this new option to become the default, because it effectively doubles the number of documents stored in the document folder. I think that is very messy, and previous versioning is best left to dedicated backup tools - which would not appreciate doubling the number of documents they preserve. Plus I've worked with enough novice users to know that people are easily confused when multiple documents have (essentially) the same name. Change-Id: I503f656af91807019587e3d7b0d82b661f1eb437 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154489 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-07-18[API CHANGE] tdf#144512: keep autosave interval separately for each documentMike Kaganski1-10/+34
Maybe this would make a better UX, as the request suggests ... or maybe not. css::document::XDocumentRecovery2 is introduced for this, allowing to query the document dirty state duration. Change-Id: I25997788bc5da261f7e4131616ab8d4a245de380 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154505 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-07-18[API CHANGE] Drop unused AutoSavePrompt config keyJustin Luth1-8/+0
Never been used since prior to 2004 AFAICS git grep -i -C20 "auto.*save.*prompt" A git log -S AutoSavePrompt indicates that a seemingly superfluous use of it was removed with commit 1507e3b63b80b541a241d0ce1c977abb45cbeef8 Author: Rüdiger Timm on Fri Nov 26 13:37:09 2004 +0000 INTEGRATION: CWS recovery04 (1.52.36); FILE MERGED and the superfluous function itself was removed with commit 36a665a6754bbc4bb0a2d612a15b1b8413af3721 Author: Caolán McNamara on Wed Jul 27 22:09:03 2011 +0100 callcatcher: remove various unused methods This was probably all obsoleted by // functionality moved to new AutoRecovery Service! Change-Id: Iedc48a1913a09f8c22a4476f2e8441cff448f06b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154568 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-07-18Drop aSendSetMike Kaganski1-13/+5
... which was never used, since its introduction in the initial import. Change-Id: If962e24663a53911977992e4d60fa8abe5b6ff75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154461 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-07-18Revert "Revert "tdf#126006 sc SID_RELOAD: restart notebookbar""Justin Luth1-2/+16
This reverts commit d0bbc16b1715a3711d872a36c7e525e8d3811669. My laptop is failing to complete UITests all the time, so likely this patch wasn't to blame after all. Change-Id: I3fa9fbb8ffc8df1fd9e45f8bcb6489594a8c0c46 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154199 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-07-17Simplify a bitMike Kaganski1-359/+183
Change-Id: I6c20a9809ee8cae27e8894c91266d82ea04540f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154534 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-07-17tdf#156308: Restore use of /org.openoffice.Office.Recovery/AutoSaveMike Kaganski1-6/+6
... instead of respective values from /org.openoffice.Office.Common/Save/Document The history of the problem: d0f9685d2cfc3927add412b276c804dcc20cb6a5 (2004-11-26) made SvtSaveOptions use org.openoffice.Office.Recovery/AutoSave, *in addition* to org.openoffice.Office.Common/Save/Document/*, as "forward AutoSave/AutoSaveTime to new config location" part of i#27726; at this point, org.openoffice.Office.Recovery/AutoSave/* took precedence (they were read last). 8e6031e126782ced6d7527b19cf817395e9b63e4 (2004-11-26) implemented autorecovery.cxx, already reading org.openoffice.Office.Recovery/AutoSave/* d5b9283985633fdb423269cab961bba2acc3539e (2021-07-25) made SvxSaveTabPage and SfxApplication::SetOptions_Impl use officecfg::Office::Common::Save::Document::* instead of SvtSaveOptions. 134f40136a9bea265d8f2fedfdb41a1e65d81b49 (2021-07-25) dropped SvtSaveOptions_Impl::ImplCommit, and its saving of officecfg::Office::Recovery::AutoSave::* (which likely detached officecfg::Office::Recovery::AutoSave from officecfg::Office::Common::Save::Document, making UI edits not stored to the former). aeb8a0076cd5ec2836b3dfc1adffcced432f995f (2022-05-23) made AutoRecovery::implts_readAutoSaveConfig read officecfg::Office::Common::Save::Document::* instead of proper officecfg::Office::Recovery::AutoSave::*. This change restores the intended use, and deprecates corresponding values in /org.openoffice.Office.Common/Save/Document. Change-Id: I33d48e3945326c80d356bfc930ed8a7f042c982b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154500 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-07-17Remove leftover debug codeHossein1-1/+0
This fprintf was leftover from 1653bb9bffaa84a40b7d81a8277e887ea28df4e4 which came up with attachment 94167 from tdf#75059 in terminal output with just opening and closing in the official 7.5.1.2 binaries. Change-Id: Ib04b5f6dd3426e97a14b3c6f38b68481f1bf85b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154518 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2023-07-14tdf#143038: preserve extension on backup fileJustin Luth1-1/+3
This allows knowing what kind of backup this is, as well as allowing the same named document for every kind of file format to be retained in backup. Change-Id: Iff22802d73adad351cb129b402db7567f0af7c7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154407 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-07-13lok: sidebar: send full update only when changed panelsSzymon Kłos3-7/+19
we only need to send update when: - we switch to other deck - panels were hidden, shown, created this helps to avoid full updates in navigator when clicking on images, what causes context change Change-Id: If1bca6167cdc3e9294eb5aefb923e92bc9043edc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153401 Reviewed-by: Attila Szűcs <attila.szucs@collabora.com> Tested-by: Attila Szűcs <attila.szucs@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154360 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-07-06loplugin:unusedfields all-can-be-privateNoel Grandin1-2/+1
these fields can be private Change-Id: I74423a9ae2ef0263a28c8a716ab1c55861e453d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154092 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-07-06sfx2: disable setting password on text documentsAshod Nakashian1-0/+10
Since we can't preserve the password in a plain-text file, we should disable the ability to set/change it. Otherwise, it's misleading to users. Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk> Change-Id: I3176243ddd2826eb07def1ff5ab251e33cb7125e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153917 Tested-by: Jenkins Reviewed-by: Jaume Pujantell <jaume.pujantell@collabora.com>
2023-07-05WriterInsertDoc constant is unusedNoel Grandin1-2/+0
ever since it was added in commit d157c1bd70d630a58db33910d550bb8dee9fe62e Author: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> Date: Thu Jul 8 05:50:25 2021 +0200 tdf#126665 Remember last used file picker directory Change-Id: I49764ab44d6ca37efeafaf9e02a25b6d7d9a8eb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154050 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-07-05tdf#155708 Fix validity dialog closes when moving focus to another windowBalazs Varga1-6/+15
Do not close Validation window if click on another Calc sheet. Change-Id: I75569cbb91ebd445ac57f7a52d914297c21349e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153930 Tested-by: Balazs Varga <balazs.varga.extern@allotropia.de> Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-07-05Fix typoAndrea Gelmini1-1/+1
Change-Id: I72e6b45ab5ddd974c8f93633c5df511ca7cfdaf8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154025 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-07-05Make sure views get new themes on .uno:ChangeThemeParis Oplopoios2-2/+24
It would be that sometimes .uno:ChangeTheme would not load the new scheme because it was using EditableConfig::GetCurrentSchemeName which uses a static name - normally great except for when you need different views to have different color schemes in tiled rendering Change-Id: I5b149bd1a4776337f76753c6de98d5386a899d34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153939 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Paris Oplopoios <parisoplop@gmail.com> (cherry picked from commit 77f5b9259864798b6efc213f6dfa685cd440f71a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154001 Tested-by: Jenkins
2023-07-05loplugin:constantparamNoel Grandin2-7/+4
Change-Id: I1925234e3f82adfa1f82755e9cef7e3e3bc00d04 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153981 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-07-04tdf#154270 Sync toolbar button recent colorsMaxim Monastirsky3-0/+20
As the last used color is stored per button instance, these will go out of sync with several buttons being visible (e.g. a toolbar and a sidebar, or a toolbar overflow popup), and will reset whenever the toolbar resets (e.g. change in selection, switch from print preview, or customization). Fix that by storing the last colors per-document, and notifying other buttons on changes. Keep the last color also stored per-button for now, as a fallback for reportdesign (which isn't sfx2 based). Change-Id: I866f1de5c8ff6f56c47dc4b6b5acf52957d4e6c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153943 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2023-07-04sfx2: fix crash in SfxViewShell::StartPrintXisco Fauli1-2/+5
See https://crashreport.libreoffice.org/stats/signature/SfxViewShell::StartPrint(com::sun::star::uno::Sequence%3Ccom::sun::star::beans::PropertyValue%3E%20const%20&,bool,bool) Change-Id: I3d10414d4cfd027bf80ceaf6692bb7f92269f6c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153965 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-07-01Revert "tdf#126006 sc SID_RELOAD: restart notebookbar"Justin Luth1-16/+2
This reverts 24.2 commit 0211c88f884065aa179725bd2eb846edd4c5bb6b. Although it passed on Jenkins, my own computer seems to hang on UITests - both Writer and Calc. Change-Id: I57e8a176cce55a514490db81f211582c0ad86675 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153829 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-07-01tdf#126006 sc SID_RELOAD: restart notebookbarJustin Luth1-2/+16
Change-Id: Icca41461d203615be58f9cf1214b82d70ee55ccb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153818 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-06-30Drop SfxStyleSheetBasePool::SetParentMaxim Monastirsky1-1/+2
Use SfxStyleSheetBase::SetParent directly instead. The base class was just calling it anyway, while the SwDocStyleSheetPool override was mostly a copy & paste of its override in SwDocStyleSheet. Change-Id: I18d8208ed2d079e0f2ce4f13a5dbdda6fe4730e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153773 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2023-06-29m_aMouseClickHdl is deadNoel Grandin1-5/+0
It was added in commit c706fde1c4ecc6974bcf32ce33aacf3093355ae1 Resolves: tdf#156067 merge special char dialog/popup logic But is never assigned a useful value Change-Id: I476b00a96c53298414239509b2ca5452f0bf08c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153743 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-29loplugin:unusedmethodsNoel Grandin1-5/+0
Change-Id: I95ab7581dec35b113cb657ce8e5ee27c89c73593 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153746 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-29loplugin:unusedfields make it a little smarterNoel Grandin2-3/+1
around dealing with operator[] on map data-types Change-Id: Idd6654948ae2d03d634fcf30a8d98530a78ab4ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153740 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-29set->unordered_setNoel Grandin1-1/+2
which is more efficient, and we don't need ordering here Change-Id: I1af4412d94680f4449a2eb00168f6c4cef20bd06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153741 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-28tdf#148416 saveas: preserve loadreadonly with passwordJustin Luth1-1/+4
If a document is set to load readonly, and that setting is password protected, then at least suggest using a password on save-as. Change-Id: I788da43733470e56af988e7c4b9f2cae01573e50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153726 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-06-28tdf#146547 sfx2: preserve modified state from read-only to editableMichael Stahl1-0/+3
SfxViewFrame::ExecReload_Impl() calls DoSaveCompleted() which resets the modified state, but in this case the document wasn't actually saved. Change-Id: I54f6508a652cc42a127bc59058c5b435dd1a25a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153676 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-06-28Drop i18nutil::SearchOptionsMike Kaganski1-2/+0
It was mostly unused by now, only remained in a couple of function arguments, where callers actually passed SearchOptions2, and where internally it was converted back to SearchOptions2. Change-Id: Ib188ec3bf0de6d1f70a04eb90fb3a577df8b3d98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153687 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-06-28Resolves: tdf#156067 merge special char dialog/popup logicCaolán McNamara3-106/+354
there was some cut and paste done to create the popup at some point, so put it back together and reuse the "delete recent" etc which is missing from the popup case Change-Id: Idc33d83ea04b46b0255e77bcecf565dc8174e426 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153647 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-06-27loplugin:stringstatic look for more stringsNoel Grandin2-2/+2
that can be initialised at compile-time instead of runtime Change-Id: I08d516fdc13a3a79f93c079f89ac44cbc7a1ed71 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153620 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-27lok: only publish MEDIA_SHAPE to selecting viewAshod Nakashian1-9/+0
We now publish the url for the media shape in the LOK_CALLBACK_GRAPHIC_SELECTION message. This has many advantages, most notably that it only sends the URL to the view selecting the media. Also, it is now easier to handle the message as there is no need for both a LOK_CALLBACK_GRAPHIC_SELECTION and a LOK_CALLBACK_MEDIA_SHAPE. However, the latter is still defined as we might still use it at some point. Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk> Change-Id: I8d4b8794d8e590628630f2b0bfbfb5debe02515f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146848 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153009 Reviewed-by: Pranam Lashkari <lpranam@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153369 Tested-by: Jenkins Reviewed-by: Aron Budea <aron.budea@collabora.com>
2023-06-26LOK: send state of DataFilterAutoFilterPranam Lashkari1-1/+2
Change-Id: Ib71dcdb6b02f3c1e9e1c552a718cb03e7cd9a4b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153532 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Aron Budea <aron.budea@collabora.com> (cherry picked from commit 0407d4290617dc717abed3ea48f1abf3cf1d750f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153602 Tested-by: Jenkins
2023-06-26new loplugin:constexprliteralNoel Grandin10-36/+36
OUStringLiteral should be declared constexpr, to enforce that it is initialised at compile-time and not runtime. This seems to make a different at least on Visual Studio Change-Id: I1698f5fa22ddb480347c2f4d444530c2e0e88d92 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153499 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-24Change LocaleDataWrapper::getDuration() parameter to tools::DurationEike Rathke1-4/+6
... instead of tools::Time Change-Id: I8e49de43a1870541d75add34089eec67b7a8be31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153533 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
generated by cgit v1.2.3 (git 2.39.1) at 2024-11-28 21:15:59 +0000