summaryrefslogtreecommitdiff
path: root/sdext
AgeCommit message (Collapse)AuthorFilesLines
2017-06-06cppcheck: knownConditionTrueFalseJochen Nitschke1-2/+1
Change-Id: I231113eaf3117e13ed18de906e3787643abe9335 Reviewed-on: https://gerrit.libreoffice.org/38423 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-05Improved loplugin:redundantcast, const/static_cast combinations: sdextStephan Bergmann5-5/+5
Change-Id: I253b0481f3ca9c2d9c45453acfa3d1702e6d701a
2017-05-26sdext: coverity#1409900 Uncaught exceptionMichael Stahl1-1/+8
Change-Id: I45e277440718b9d173f164eaaa3112f4c474aa3a
2017-05-24rhbz#1425304 sdext: join TimerScheduler thread before shutdownMichael Stahl6-9/+101
Use a osl::Condition to interrupt the waiting thread, and join it. Change-Id: I638a2495afd082446c39faf9362578bd0f758d04
2017-05-21cleanup unused css/animations/ and css/presentation/ includesJochen Nitschke5-9/+0
Change-Id: Iafd106d431869d80f664bd540092bee4f10e14b5 Reviewed-on: https://gerrit.libreoffice.org/37862 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-20cleanup unused css/script/ includesJochen Nitschke5-5/+0
but keep exception includes in headers for now Change-Id: I826828675a2d14b906e57068cbced2e790e12bce Reviewed-on: https://gerrit.libreoffice.org/37846 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-16loplugin:unusedfields improve write-only analysisNoel Grandin6-21/+4
by whitelisting a couple of methods we know only write to their parameters Change-Id: Id7aef9c03c23d10c27707b21eb9a0db4a6c2757c Reviewed-on: https://gerrit.libreoffice.org/37647 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-15Resolves: tdf#107812 add check for -ObliqueCaolán McNamara1-12/+18
and move checks for -BoldOblique and -LightOblique before -Bold and -Light Change-Id: I59b59a10c6e92c6a6dc269aad616b9eb9e185ccd Reviewed-on: https://gerrit.libreoffice.org/37652 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-14tdf#107823: missing buttons in Presentation MinimizerJulien Nabet1-1/+1
Regression from https://cgit.freedesktop.org/libreoffice/core/commit/?id=5d0e485e827057eee9fb2c997685690b710e7f34 Change-Id: I1864e7f7ac73fc13af82237f4f7d4dbaaa5733f5 Reviewed-on: https://gerrit.libreoffice.org/37584 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-05-12remove unused uno::Reference varsNoel Grandin4-15/+3
found by temporarily marking Reference as SAL_WARN_UNUSED. Change-Id: I18809b62654467f890016adcc92576980ced393b Reviewed-on: https://gerrit.libreoffice.org/37511 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-09cleanup osl/diagnose.h includesJochen Nitschke3-3/+0
with command > git grep -l osl/diagnose.h *.cxx | xargs grep -L -w 'OSL_\w*' | xargs sed -i '/#include *\(<\|\"\)osl\/diagnose.h\(>\|\"\).*/d' headers need more work Change-Id: I906519ebbd47a04703b4fa5943b2f7abea7a97ab Reviewed-on: https://gerrit.libreoffice.org/37350 Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-05-09make loplugin constantparam smarter about string paramsNoel Grandin2-4/+1
Change-Id: Id3df69b38fd35f46735246a6d307a89aa10d4294 Reviewed-on: https://gerrit.libreoffice.org/37426 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-09remove unnecessary empty OUString fields and varsNoel Grandin1-2/+1
Change-Id: I940120087a0bc6b1b0abc30a3e7727ce22b7d9a7 Reviewed-on: https://gerrit.libreoffice.org/37394 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-08teach loplugin:constantparam about simple constructor callsNoel Grandin8-25/+6
Change-Id: I7d2a28ab5951fbdb5a427c84e9ac4c1e32ecf9f9 Reviewed-on: https://gerrit.libreoffice.org/37280 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-07revert OSL_ASSERT changesChris Sherlock25-94/+94
Change-Id: I365d140446bd2a62cf8256acbfdd53fe72987380
2017-05-07tdf#43157: convert sdext codebase away from OSL_ASSERT to assertChris Sherlock25-94/+94
Change-Id: If60f3585f202aabf42582239840aa87c96ae7842
2017-04-28loplugin:salunicodeliteral: sdextStephan Bergmann1-3/+3
Change-Id: Ibcfe4cec41a18ab3fb79cb0545c71a21200c0f2c
2017-04-28loplugin:cppunitassertequals: sdextStephan Bergmann1-46/+46
Change-Id: I9c00bed21ae2ca49d1be60fe2161271cb7aa334d
2017-04-27sdext: fix loplugin:stringconcat warningMiklos Vajna1-1/+1
Change-Id: I1e9aa0826d8692819fb05d2f572cf3c4e976fe00
2017-04-27can detangle the sdext graphic resource nowCaolán McNamara3-5/+24
Change-Id: I2992b859bbebfa4bfae3ea5bfe76e8aa62193f69
2017-04-27tools: move errcode.hxx to the vcl moduleChris Sherlock1-1/+1
Change-Id: I17e5a033de5f0aeb0a726744f7b464cdab6e2ee3 Reviewed-on: https://gerrit.libreoffice.org/36854 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-25tools: svstream.hxx needs only errcode.hxx & not errinf.hxxChris Sherlock2-0/+2
Change-Id: Ia28e35ae5af4f601e9a586a3deffbcd61702b0ca Reviewed-on: https://gerrit.libreoffice.org/36896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-21gbuild: Remove MSVC 2013 legacy codeDavid Ostrovsky2-5/+0
Uwinapi is discontinued. Change-Id: I063b4d0d8fab2d60de168e960a63b8181158ac01 Reviewed-on: https://gerrit.libreoffice.org/23198 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Tested-by: David Ostrovsky <david@ostrovsky.org>
2017-04-21remove unnecessary explicit linefeeds from end of SAL and OSL log callsNoel Grandin1-1/+1
Change-Id: I3fa363c8e76e6cfb297f4ec346e3f031c09d6fbf Reviewed-on: https://gerrit.libreoffice.org/36727 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-12no need to use OUStringToOString in SAL_INFONoel Grandin2-5/+5
Change-Id: I707e0d72aba89b7e644def6f4c251e14f6599ad2 Reviewed-on: https://gerrit.libreoffice.org/36451 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-06Improved loplugin:redundantcast, static_cast on arithmetic types: sdextStephan Bergmann1-1/+1
Change-Id: Ib9d4c9ee077ffe7e3625818d2468658ee00b9c77
2017-04-03use actual UNO enums in reportdesign..svtoolsNoel Grandin2-2/+2
Change-Id: Idcd916382b87f8542dc6b5cdcb5ecb01d6947203 Reviewed-on: https://gerrit.libreoffice.org/36043 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-25Fix typosAndrea Gelmini2-3/+3
Change-Id: I35d4a7648566105b176eb39f6a1db44ca91d4f4c Reviewed-on: https://gerrit.libreoffice.org/35643 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-23Remove unused #include <ctype.h>Stephan Bergmann1-1/+0
Change-Id: I8bf3e30687e20151a9e1936e69362abfe9b3a99d
2017-03-08just make the VirtualDevice a parser memberCaolán McNamara1-5/+5
rather than over complicating things Change-Id: Ife65207dab8ddfedb6a9cbe111adf13fd03b5b3b
2017-03-02Fix typosAndrea Gelmini1-1/+1
Change-Id: If5e709c9d6e3a4fbb568bdc261cccd214dd0cbd3 Reviewed-on: https://gerrit.libreoffice.org/34784 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-28loplugin:sallogareasStephan Bergmann1-2/+2
Change-Id: Ida8a58bd95164cd651934dbf8be0923ac2c08a8e
2017-02-28new loplugin unoanyNoel Grandin4-45/+45
Change-Id: I5d6c4a67cb2a09e7cd5bd620c6b262d188701b89 Reviewed-on: https://gerrit.libreoffice.org/34714 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-27loplugin:loopvartoosmallStephan Bergmann2-8/+5
Change-Id: Id2771f413798ed9ceb76e9c4dd3113633d4e481e
2017-02-24fix crash in pdfimportMarkus Mohrhard1-3/+10
Found by the crashreporter: http://crashreport.libreoffice.org/stats/crash_details/2eaeda85-849d-4098-b215-a8e64fe82089 Change-Id: I113f4dfc4a4f45511102c417d39fe15db6050daa Reviewed-on: https://gerrit.libreoffice.org/34628 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-02-24vector::data seems more natural than &vector::frontCaolán McNamara1-1/+1
Change-Id: I0ce48075ad186cf1f9bd3e13fa76269fa9819af1
2017-02-23change intervall -> intervalDavid Tardon4-18/+18
Change-Id: Ib211619428f16304603d9c0a9fce0b22dde2a617
2017-02-21loplugin:subtlezeroinit: sdextStephan Bergmann3-5/+5
Change-Id: Idaf62b25bba7328e5f7942619df14d0fff4014e6
2017-02-17PaneDescriptor::mbNeedsClipping is never readStephan Bergmann2-3/+0
Change-Id: If8e5f5dca0927b961685af7339fd1d982314a6d7
2017-02-15remove unused Right from Anchor enumNoel Grandin2-2/+1
Change-Id: I7943a37407481305d28e526840caf320e7ff6bf2
2017-02-12"Unicode" is a proper noun and should not be used in pluralTor Lillqvist1-4/+4
The 16-bit things that make up the UTF-16 encoding are called "code units". Change-Id: Iab2b83323783e518198c1a0553f7b053fc415985
2017-02-06Add missing #includesStephan Bergmann4-0/+4
...and remove some unncessary using directives/declarations, in preparation of removing now-unnecessary #includes from cppumaker-generated files, post e57ca02849c3d87142ff5ff9099a212e72b8139c "Remove dynamic exception specifications". Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
2017-01-31teach lolugin:stringconstant about calling constructorsNoel Grandin9-18/+18
so we can remove unnecessary calls to the OUString(literal) constructor when calling constructors like this: Foo(OUString("xxx"), 1) Change-Id: I1de60ef561437c86b27dc9cb095a5deb2e103b36 Reviewed-on: https://gerrit.libreoffice.org/33698 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-28tdf#105536: PDF image should be v-flipped unconditionallyMike Kaganski3-2/+21
Unit test included Change-Id: Id0d054a6b9922666daf4f36908f97ed6e65fb6c7 Reviewed-on: https://gerrit.libreoffice.org/33649 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-01-28loplugin:stringconstant check for unnecessary OUString constructor..Noel Grandin11-18/+12
..calls when creating exceptions Change-Id: I3bc58a5aa4dc6f0508ecb88b3a843b96b8c7ebfe Reviewed-on: https://gerrit.libreoffice.org/33617 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-26Remove dynamic exception specificationsStephan Bergmann64-1009/+378
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-25loplugin: unnecessary destructor scaddins..sdextNoel Grandin9-46/+0
Change-Id: I6ae02ad25863ec7e0f780020dbc69c9a99488c24 Reviewed-on: https://gerrit.libreoffice.org/33511 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-24tdf#105382 Set URL-decoded default filename for minimized presentationTakeshi Abe2-18/+10
See mailing-list thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076702.html> for a discussion on the original presentation file's URL. Change-Id: I51ccd7672513118f39518c4ed21902de16b2298f Reviewed-on: https://gerrit.libreoffice.org/33261 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-01-19New loplugin:dynexcspec: Add @throws documentation, sdextStephan Bergmann15-6/+15
Change-Id: Id01b4012d2ac3cf479a96ed496eff3d97e5c80c5
2017-01-17new loplugin: useuniqueptr: sdextNoel Grandin4-22/+22
Change-Id: Iae1dfc7f566d2f5bd1652f170218b502b5663126 Reviewed-on: https://gerrit.libreoffice.org/33205 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit v1.2.3 (git 2.39.1) at 2024-11-23 19:05:50 +0000