summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)AuthorFilesLines
2024-08-29cid#1607212 Check of thread-shared field evades lock acquisitionCaolán McNamara1-1/+4
it changed to this at: commit 0c876d497dd3320cbc06cf21b7b14ab859755bac AccessibleEventNotifier AccessibleSlideSorterObject (sd) Change-Id: I8b272b8466a05f817eb9cad5673920b54b599a37 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172614 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-29tdf#161826 - Add uniform Glow effect for texts in shapesBalazs Varga8-0/+94
- Add new text Glow effect properties for shapes - Using TextGlowPrimitive for rendering uniform text glow in shapes - Add/allow new UI Glow Effect for texts in shapes on sidebar (Only for Impress/Draw and Calc) - Import/Export ooxml files with Glow effect on texts in shapes (Only PPTX/XLSX) - Import/Export odf files with Glow effect on texts in shapes - Add unit test for glow text attributes in ODF - Add uni tests for OOXML import/export Note: Also this patch effects on tdf#144061 - Effects: Allow GLOW to apply to Text (as we have for shapes) Change-Id: I16586c01654f197f532129e4e06aa2ef9f214395 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172216 Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2024-08-28cid#1607037 silence Overflowed constantCaolán McNamara1-4/+10
and cid#1606925 Overflowed constant cid#1606695 Overflowed constant Change-Id: I2162e9b5da1f31ea1dfc603d6e60b96d98f82be1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172509 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-28GetMainViewShell is not trivialNoel Grandin8-23/+33
Change-Id: I86eec22a6ebb8957d983f63d37bf11b8bfa1a2bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172475 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-08-27GetMainViewShell is not trivialMike Kaganski1-2/+3
Change-Id: Ida2c1ec4f55c95c2a880a6d7cda46058c877a92a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172410 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-08-26a SdrPage* is sufficient, don't need to case to SdPage*Caolán McNamara1-1/+1
Change-Id: I1bbbf5f885dffecae071a06e313e1a91f5a9a776 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172403 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-08-23tdf#158556 make SfxGrabBagItem hashableNoel Grandin1-2/+2
Change-Id: I0af373e9c5c93a82eb37437ac365677700d45853 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172311 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-08-22null deref seen in SdXImpressDocument::getPostItsCaolán McNamara1-2/+3
Change-Id: Idb222476c6d2a6bb8e3ffea528ec4bed0c869ac8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172252 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-22read count doesn't need to be a class memberCaolán McNamara2-12/+10
Change-Id: Icac6d1ea5659d875551b7b218fc47235fec34dc7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172223 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-22cid#1608175 Structurally dead codeCaolán McNamara1-2/+1
trivial, no real change here Change-Id: I0e93412c930d60d94a9e9406579226026f449897 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172222 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-22tdf#162004 crash after notes pane loses focus in impressNoel Grandin2-72/+29
I cannot reproduce this at all, but from the debugging traces supplied it looks like mpTextObj ends up pointing at something that has already been freed. To prevent that, instead of caching mpTextObj, fetch it every time we need it. Change-Id: Ia8000f8f0b65fbe7c4ac4850179708a025af3cd4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170970 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-08-22ONLINE: Insert slide to specific positionGülşah Köse2-2/+2
Online was appending new slides at the end. With this change we can handle position argument. Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com> Change-Id: I8d5ff041b7dc4c4bbe6bcfe43d842f8ca87ae2e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172113 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2024-08-21tdf#162283 PPT export: fix regression...Tibor Nagy3-2/+69
...was made by: Iefb9d97e0eb10a04c39b515b11e549aeb7be8f25 This regression occurred because there is a feature in MSO that allows the shape of a placeholder to be changed. In this case, the placeholder is converted into a custom shape after the import and saving custom shape from .pptx to .ppt didn't work. Change-Id: I85305b65742da8b4966d4956b9141c59b4563973 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172091 Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de> Tested-by: Jenkins
2024-08-20Explicitly request antialiasing in a testMike Kaganski1-0/+1
See commit a8d677035a6565ebc051375206786dab3a353578 (Make sure to anti-alias fonts on Windows, when required, 2024-08-19). Change-Id: I67f863b61002da883a91ca09aa432162985c755b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172042 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-08-19cid#1557694 COPY_INSTEAD_OF_MOVECaolán McNamara1-1/+1
and cid#1557162 COPY_INSTEAD_OF_MOVE cid#1556896 COPY_INSTEAD_OF_MOVE cid#1556893 COPY_INSTEAD_OF_MOVE cid#1556873 COPY_INSTEAD_OF_MOVE cid#1556872 COPY_INSTEAD_OF_MOVE cid#1556789 COPY_INSTEAD_OF_MOVE cid#1556570 COPY_INSTEAD_OF_MOVE cid#1556519 COPY_INSTEAD_OF_MOVE cid#1556516 COPY_INSTEAD_OF_MOVE cid#1556451 COPY_INSTEAD_OF_MOVE cid#1556396 COPY_INSTEAD_OF_MOVE cid#1556237 COPY_INSTEAD_OF_MOVE cid#1556113 COPY_INSTEAD_OF_MOVE cid#1556094 COPY_INSTEAD_OF_MOVE cid#1555991 COPY_INSTEAD_OF_MOVE cid#1555982 COPY_INSTEAD_OF_MOVE cid#1555885 COPY_INSTEAD_OF_MOVE cid#1555702 COPY_INSTEAD_OF_MOVE cid#1555610 COPY_INSTEAD_OF_MOVE cid#1555450 COPY_INSTEAD_OF_MOVE cid#1555327 COPY_INSTEAD_OF_MOVE cid#1555145 COPY_INSTEAD_OF_MOVE Change-Id: I38cc1a38e8cb2c33f33e0fc3afd34a0fb39e5ec1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172028 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-19cid#1616524 COPY_INSTEAD_OF_MOVECaolán McNamara1-1/+1
Change-Id: Idb3775f795056ec848b01b666cc258604eda7588 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172023 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-19pAttr is always dereferenced, use a reference hereCaolán McNamara7-11/+11
Change-Id: I183a522704d0fbe2ba2907e75e8794621e94c178 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172022 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-08-19cid#1616525 COPY_INSTEAD_OF_MOVECaolán McNamara1-1/+1
Change-Id: I508df311ec1785be11077c1f657be57b84ed8cfa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172021 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-18LOKit: Enable the "Interaction..." command for Impress.Hubert Figuière3-4/+18
Also enable the dialog for JSDialogs Fix the layout of the dialog. Signed-off-by: Hubert Figuière <hub@collabora.com> Change-Id: I4581da34921eb355ce8f59d7bfdf2f7d5d7493f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171961 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-18cid#1557699 COPY_INSTEAD_OF_MOVECaolán McNamara2-2/+2
and cid#1557435 COPY_INSTEAD_OF_MOVE cid#1557307 COPY_INSTEAD_OF_MOVE cid#1557209 COPY_INSTEAD_OF_MOVE cid#1557192 COPY_INSTEAD_OF_MOVE cid#1557184 COPY_INSTEAD_OF_MOVE cid#1557183 COPY_INSTEAD_OF_MOVE cid#1557171 COPY_INSTEAD_OF_MOVE cid#1557150 COPY_INSTEAD_OF_MOVE cid#1557148 COPY_INSTEAD_OF_MOVE cid#1557123 COPY_INSTEAD_OF_MOVE cid#1557118 COPY_INSTEAD_OF_MOVE cid#1557116 COPY_INSTEAD_OF_MOVE cid#1557103 COPY_INSTEAD_OF_MOVE cid#1557078 COPY_INSTEAD_OF_MOVE cid#1557075 COPY_INSTEAD_OF_MOVE cid#1557071 COPY_INSTEAD_OF_MOVE cid#1557070 COPY_INSTEAD_OF_MOVE cid#1557067 COPY_INSTEAD_OF_MOVE cid#1557049 COPY_INSTEAD_OF_MOVE cid#1557046 COPY_INSTEAD_OF_MOVE cid#1557042 COPY_INSTEAD_OF_MOVE cid#1557036 COPY_INSTEAD_OF_MOVE cid#1557030 COPY_INSTEAD_OF_MOVE cid#1557024 COPY_INSTEAD_OF_MOVE cid#1557012 COPY_INSTEAD_OF_MOVE cid#1557009 COPY_INSTEAD_OF_MOVE cid#1557008 COPY_INSTEAD_OF_MOVE cid#1557004 COPY_INSTEAD_OF_MOVE cid#1556999 COPY_INSTEAD_OF_MOVE cid#1556992 COPY_INSTEAD_OF_MOVE cid#1556987 COPY_INSTEAD_OF_MOVE cid#1556984 COPY_INSTEAD_OF_MOVE cid#1556981 COPY_INSTEAD_OF_MOVE Change-Id: Id2687aa282f4e2d4b8053b73c7aa1a74a9516b16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171974 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-18Revert "Workaround a non-antialiased output on one of Windows buildbots"Mike Kaganski1-15/+5
This reverts commit 7a08c89b5af8f98045ad825ace6be2f035ad91af. Reason for revert: the cause of the failures on tb88 was low quality of RDP connection settings, which is fixed now. The bug that it affects the export still needs a separate fix. Change-Id: I36aece47108781abc3578092d5fb479a56fce050 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171986 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-08-17impress/draw: make the SdActionDlg (Interaction...) dialog asyncHubert Figuière4-56/+116
Make SdAbstractSfxDialog_Impl support async for all. Signed-off-by: Hubert Figuière <hub@collabora.com> Change-Id: I9e2df8369f8f1fde252d079464a188c155a26057 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171781 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-08-17Support for non-AA text on WindowsMike Kaganski1-0/+41
In commit 3ecd8f19a91ed7141304a2080fb11612b5ff30b3 (vcl cairo text renderer: support non-AA text, 2018-07-26) and its follow-up commit e6538f5bdd876911ea30f84a6512c03908e620fd (tdf#118966 vcl: add a flag to determine if AA of fonts is used from the system, 2018-07-28), non-antialiased text got supported in bitmap export using cairo. This change makes that support available on Windiws, including Skia. Change-Id: I1fae726539347f826e2d62246d35315e7954cf83 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171967 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-08-16feat(invert): Allow inverted background on initSkyler Grey1-0/+11
Previously for Online there was no way to save the background invert state and reload it. Worse, when someone changed the state it would become the default for new document loads. This patch allows Online to specify whether it wants the background to be inverted, which should allow smooth tab refreshes while also avoiding mingling state from different people. There is a change to online to support this here: https://github.com/CollaboraOnline/online/pull/9652 Change-Id: I8c22c03d3b4589736d48509004f7789dd5166389 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171955 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-08-16Workaround a non-antialiased output on one of Windows buildbotsMike Kaganski1-5/+15
Seen as C:/cygwin64/home/tdf/jenkins/workspace/gerrit_windows/sd/qa/unit/PNGExportTests.cxx(1006) : error : Assertion Test name: testTdf162259::TestBody greater assertion failed Expected greater than: 350 Actual : 271 See e.g. https://ci.libreoffice.org/job/gerrit_windows/183201/consoleFull#-530547713d893063f-7f3d-4b7e-b56f-4e0f225817cd Change-Id: I0042138a728e1ca08c2b142db7f97635bffd7d79 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171777 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-08-16tdf#161741 tdf#161705 undo: delay ClearRedo until Undo finishesJustin Luth1-0/+2
I know NOTHING about the intricacies of Undo/Redo. However, this is my feeble attempt to add some sanity to it. It should not be the responsibility of the caller to know when they are allowed to call ClearRedo. This patch reverts commit 0cd000bb83719982c1fd2265ea040c82af5bf98e author Daniel Arato (NISZ) on Mon May 10 15:41:28 2021 +0200 tdf#141613 sw: avoid possible crash when undoing header creation which was not a sufficient hack. I hope this patch lays a better framework to handle future similar issues. vvv NAIVE OPTIMIST ALERT vvv mbDoing was added with commit 9cb53122e9e098bc8a6bf53c14b18415e369dd6d Author: Frank Schoenheit on Fri Oct 22 15:00:39 2010 +0200 undoapi: more I/SfxUndoManager changes in preparation of new Undo API features and has been untouched since then AFAICS, and there was never any mechanism to change mbDoing. In other words, it has been sitting there doing NOTHING. So, I am taking it over and using it how I imagine it was intended, and how it is documented. Change-Id: I7aa355cc6458ac8ba34ddb9ee73fc850dcbca702 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170793 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-08-13cid#1557699 COPY_INSTEAD_OF_MOVECaolán McNamara2-2/+2
and cid#1557696 COPY_INSTEAD_OF_MOVE cid#1557695 COPY_INSTEAD_OF_MOVE cid#1557690 COPY_INSTEAD_OF_MOVE cid#1557671 COPY_INSTEAD_OF_MOVE cid#1557661 COPY_INSTEAD_OF_MOVE cid#1557626 COPY_INSTEAD_OF_MOVE cid#1557624 COPY_INSTEAD_OF_MOVE cid#1557622 COPY_INSTEAD_OF_MOVE cid#1557618 COPY_INSTEAD_OF_MOVE cid#1557617 COPY_INSTEAD_OF_MOVE cid#1557607 COPY_INSTEAD_OF_MOVE cid#1557559 COPY_INSTEAD_OF_MOVE cid#1557538 COPY_INSTEAD_OF_MOVE Change-Id: I8bcd61f21e6b5284d641ff8c6bd09008c2458baf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171837 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-12tdf#156857: sd ooxml import: fix shape size if spAutofit is setBalazs Varga4-8/+8
and the size of the shape from ooxml file is different then the inew calculated by TextAutoGrowHeight. Furthermore, no need to check and resize the shape size during the spell checking. Change-Id: Iffd15e02579942d4f5f20db73f2194f8298c0838 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171621 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-08-11cid#1558088 COPY_INSTEAD_OF_MOVECaolán McNamara6-7/+7
and cid#1558080 COPY_INSTEAD_OF_MOVE cid#1558077 COPY_INSTEAD_OF_MOVE cid#1558055 COPY_INSTEAD_OF_MOVE cid#1558043 COPY_INSTEAD_OF_MOVE cid#1558039 COPY_INSTEAD_OF_MOVE cid#1558015 COPY_INSTEAD_OF_MOVE cid#1558014 COPY_INSTEAD_OF_MOVE cid#1558009 COPY_INSTEAD_OF_MOVE cid#1558002 COPY_INSTEAD_OF_MOVE cid#1557998 COPY_INSTEAD_OF_MOVE cid#1557996 COPY_INSTEAD_OF_MOVE cid#1557990 COPY_INSTEAD_OF_MOVE cid#1557986 COPY_INSTEAD_OF_MOVE cid#1557980 COPY_INSTEAD_OF_MOVE cid#1557971 COPY_INSTEAD_OF_MOVE cid#1557968 COPY_INSTEAD_OF_MOVE cid#1557967 COPY_INSTEAD_OF_MOVE cid#1557961 COPY_INSTEAD_OF_MOVE cid#1557959 COPY_INSTEAD_OF_MOVE cid#1557958 COPY_INSTEAD_OF_MOVE cid#1557956 COPY_INSTEAD_OF_MOVE cid#1557953 COPY_INSTEAD_OF_MOVE cid#1557949 COPY_INSTEAD_OF_MOVE cid#1557947 COPY_INSTEAD_OF_MOVE cid#1557940 COPY_INSTEAD_OF_MOVE cid#1557931 COPY_INSTEAD_OF_MOVE cid#1557930 COPY_INSTEAD_OF_MOVE cid#1557915 COPY_INSTEAD_OF_MOVE cid#1557913 COPY_INSTEAD_OF_MOVE cid#1557910 COPY_INSTEAD_OF_MOVE cid#1557886 COPY_INSTEAD_OF_MOVE cid#1557884 COPY_INSTEAD_OF_MOVE cid#1557880 COPY_INSTEAD_OF_MOVE cid#1557875 COPY_INSTEAD_OF_MOVE cid#1557871 COPY_INSTEAD_OF_MOVE cid#1557862 COPY_INSTEAD_OF_MOVE cid#1557847 COPY_INSTEAD_OF_MOVE cid#1557845 COPY_INSTEAD_OF_MOVE cid#1557844 COPY_INSTEAD_OF_MOVE cid#1557843 COPY_INSTEAD_OF_MOVE cid#1557838 COPY_INSTEAD_OF_MOVE cid#1557835 COPY_INSTEAD_OF_MOVE cid#1557834 COPY_INSTEAD_OF_MOVE cid#1557828 COPY_INSTEAD_OF_MOVE cid#1557823 COPY_INSTEAD_OF_MOVE cid#1557817 COPY_INSTEAD_OF_MOVE cid#1557813 COPY_INSTEAD_OF_MOVE cid#1557812 COPY_INSTEAD_OF_MOVE Change-Id: I55d4a920daa2d148683419169eb828325fd3c757 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171732 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-11Resolves tdf#61242 - Customization of comment background colorHeiko Tietze1-28/+26
* COL_AUTHOR<1..>_DARK/LIGHT/NORMAL removed Author1..9 added * dark variants calculated from light with 50% brightness * light does In/DecreaseLuminance(30) and dark (sd) resp. anchor (sw) In/DecreaseLuminance(80) depending on GetUseDarkMode() * sw: font color depends on outline background, which now picks up DOCCOLOR; this does not work for dark colors in light mode, for example * sd does not update on changes and requires a restart Change-Id: I773793de8cfbdc0d23124db790604b93030375c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171523 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
2024-08-10Resolves: tdf#162392 Impress Sidebar 'Animation' deck text overlapsJim Raykowski1-10/+23
by reworking the custom animation list entry item custom rendering layout a bit. Change-Id: I1c71dd5ef40de5369890b0b9aea1294baa3be120 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171659 Tested-by: Jenkins Reviewed-by: Vernon, Stuart Foote <vsfoote@libreoffice.org> Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2024-08-09fix(invert): Use separate view IDs when invertedSkyler Grey1-0/+2
Previously in Online the document background inversion was tied together such that if someone inverted the background, everyone in dark theme would end up with an inverted background. By adding whether the document background is dark to the view render state, we can create a new view when the background is inverted, and avoid everyone getting an inverted view. Change-Id: I0aed702185e642f631854b1f8234355c9e69ff6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171664 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-08-09cid#1616089 COPY_INSTEAD_OF_MOVECaolán McNamara2-9/+12
and cid#1616088 COPY_INSTEAD_OF_MOVE Change-Id: I9af46a95aadb7574a32e0542b7e4ed4a8495da5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171651 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-08-08cid#1607356 COPY_INSTEAD_OF_MOVECaolán McNamara1-2/+2
and cid#1607117 COPY_INSTEAD_OF_MOVE cid#1607089 COPY_INSTEAD_OF_MOVE cid#1606977 COPY_INSTEAD_OF_MOVE cid#1606899 COPY_INSTEAD_OF_MOVE cid#1606785 COPY_INSTEAD_OF_MOVE cid#1606769 COPY_INSTEAD_OF_MOVE cid#1606740 COPY_INSTEAD_OF_MOVE cid#1606738 COPY_INSTEAD_OF_MOVE cid#1606675 COPY_INSTEAD_OF_MOVE cid#1606533 COPY_INSTEAD_OF_MOVE cid#1558100 COPY_INSTEAD_OF_MOVE cid#1558098 COPY_INSTEAD_OF_MOVE cid#1558083 COPY_INSTEAD_OF_MOVE cid#1558077 COPY_INSTEAD_OF_MOVE cid#1558074 COPY_INSTEAD_OF_MOVE Change-Id: Ica17dec2c2102ef85283fd883a0a4e64aec307c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171620 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-08-08slideshow: change transition drawing view to icon viewJaviya Vivekkumar Dineshbhai3-167/+132
Signed-off-by: Javiya Vivekkumar Dineshbhai <vivek.javiya@collabora.com> Change-Id: I109d2268824d3be233c5c7b560c1777b95aa4276 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171385 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2024-08-06cid#555593 COPY_INSTEAD_OF_MOVECaolán McNamara2-4/+4
and cid#1555849 COPY_INSTEAD_OF_MOVE cid#1555936 COPY_INSTEAD_OF_MOVE cid#1555951 COPY_INSTEAD_OF_MOVE cid#1555955 COPY_INSTEAD_OF_MOVE cid#1555960 COPY_INSTEAD_OF_MOVE cid#1555964 COPY_INSTEAD_OF_MOVE cid#1555965 COPY_INSTEAD_OF_MOVE cid#1555975 COPY_INSTEAD_OF_MOVE cid#1555979 COPY_INSTEAD_OF_MOVE cid#1555987 COPY_INSTEAD_OF_MOVE cid#1555990 COPY_INSTEAD_OF_MOVE cid#1555991 COPY_INSTEAD_OF_MOVE cid#1556002 COPY_INSTEAD_OF_MOVE cid#1556008 COPY_INSTEAD_OF_MOVE cid#1556011 COPY_INSTEAD_OF_MOVE cid#1556015 COPY_INSTEAD_OF_MOVE cid#1556017 COPY_INSTEAD_OF_MOVE cid#1556023 COPY_INSTEAD_OF_MOVE Change-Id: I8ab99d8e52a1780173a4272c59d408432c29de9f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171572 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-06Simplify a bitMike Kaganski1-40/+12
Change-Id: Iffc22c60572f230e3c13d6e4de89856d50244eec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171521 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-08-06cool#7710: Make Slide Properties Dialog in Impress AsyncSven Göthel2-162/+161
How to reproduce the synchronous dialog: - Build in debug mode - Click on 'Format' menu, then sub-menu 'Slide Properties' - The sync-dialog warning shows up This commit updates the dialog from synchronous to asynchronous processing. How to manually test the asynchronous dialog: - Apply patch - Build in debug mode - Click on 'Format' menu, then sub-menu 'Slide Properties' - The 'Slide Properties' modal dialog box opens and is functional. Tested manually within COOL 24.04 (online) with - Changing aspect-ratio and background color FuPage's lifecycle is extended by wrapping itself into rtl::Reference<FuPage> and passing a copy to the async-action lambda-capture, as it is being called from FuTemporary and managed as rtl::Reference<FuPoor>. Otherwised resources are passed to the async-action simply using std::shared_ptr<>. Signed-off-by: Sven Göthel <sven.gothel@collabora.com> Change-Id: I692204403e8a6ee526e7b463c8bf8a41c1416489 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171393 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171508 Tested-by: Jenkins
2024-08-06cid#1555415 COPY_INSTEAD_OF_MOVECaolán McNamara1-1/+1
and cid#1555430 COPY_INSTEAD_OF_MOVE cid#1555497 COPY_INSTEAD_OF_MOVE cid#1555542 COPY_INSTEAD_OF_MOVE cid#1555543 COPY_INSTEAD_OF_MOVE cid#1555564 COPY_INSTEAD_OF_MOVE cid#1555593 COPY_INSTEAD_OF_MOVE cid#1555602 COPY_INSTEAD_OF_MOVE cid#1555610 COPY_INSTEAD_OF_MOVE cid#1555667 COPY_INSTEAD_OF_MOVE cid#1555693 COPY_INSTEAD_OF_MOVE cid#1555719 COPY_INSTEAD_OF_MOVE cid#1555757 COPY_INSTEAD_OF_MOVE cid#1555795 COPY_INSTEAD_OF_MOVE cid#1555826 COPY_INSTEAD_OF_MOVE cid#1555847 COPY_INSTEAD_OF_MOVE cid#1555851 COPY_INSTEAD_OF_MOVE cid#1555863 COPY_INSTEAD_OF_MOVE cid#1555865 COPY_INSTEAD_OF_MOVE cid#1555867 COPY_INSTEAD_OF_MOVE cid#1555869 COPY_INSTEAD_OF_MOVE cid#1555879 COPY_INSTEAD_OF_MOVE cid#1555890 COPY_INSTEAD_OF_MOVE cid#1555893 COPY_INSTEAD_OF_MOVE cid#1555900 COPY_INSTEAD_OF_MOVE cid#1555922 COPY_INSTEAD_OF_MOVE cid#1555925 COPY_INSTEAD_OF_MOVE Change-Id: I5d362a09e80eecd282e63c745bfe26eac2631a0d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171492 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-08-05tdf#162065 Fix format paintbrush in draw/impressOliver Specht1-3/+10
With tdf#160069 the format paintbrush was disabled outside of text selection and with tdf#160069 target selection was reduced to text only. The change of tdf#160069 is mostly undone with this patch. Change-Id: I8e23ef56206c6749913e2c95870537c3e378f946 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170672 Tested-by: Jenkins Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-08-04cid#1556583 COPY_INSTEAD_OF_MOVECaolán McNamara1-2/+2
and cid#1556585 COPY_INSTEAD_OF_MOVE cid#1556588 COPY_INSTEAD_OF_MOVE cid#1556593 COPY_INSTEAD_OF_MOVE cid#1556597 COPY_INSTEAD_OF_MOVE cid#1556605 COPY_INSTEAD_OF_MOVE cid#1556617 COPY_INSTEAD_OF_MOVE cid#1556635 COPY_INSTEAD_OF_MOVE cid#1556790 COPY_INSTEAD_OF_MOVE cid#1556792 COPY_INSTEAD_OF_MOVE cid#1556796 COPY_INSTEAD_OF_MOVE cid#1556799 COPY_INSTEAD_OF_MOVE cid#1556815 COPY_INSTEAD_OF_MOVE cid#1556836 COPY_INSTEAD_OF_MOVE cid#1556840 COPY_INSTEAD_OF_MOVE cid#1556842 COPY_INSTEAD_OF_MOVE cid#1556859 COPY_INSTEAD_OF_MOVE cid#1556860 COPY_INSTEAD_OF_MOVE cid#1556866 COPY_INSTEAD_OF_MOVE cid#1556869 COPY_INSTEAD_OF_MOVE cid#1556870 COPY_INSTEAD_OF_MOVE Change-Id: I3df8698a4aecbb03999c084517e37e12ff46ee97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171435 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-02Fix typoAndrea Gelmini1-1/+1
Change-Id: Ia72c18614df83479a89d1d03d7a548346adf11c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171439 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-08-02cid#1556472 COPY_INSTEAD_OF_MOVECaolán McNamara1-2/+2
and cid#1556481 COPY_INSTEAD_OF_MOVE cid#1556486 COPY_INSTEAD_OF_MOVE cid#1556491 COPY_INSTEAD_OF_MOVE cid#1556507 COPY_INSTEAD_OF_MOVE cid#1556515 COPY_INSTEAD_OF_MOVE cid#1556518 COPY_INSTEAD_OF_MOVE cid#1556519 COPY_INSTEAD_OF_MOVE cid#1556533 COPY_INSTEAD_OF_MOVE cid#1556536 COPY_INSTEAD_OF_MOVE cid#1556559 COPY_INSTEAD_OF_MOVE cid#1556577 COPY_INSTEAD_OF_MOVE cid#1556581 COPY_INSTEAD_OF_MOVE Change-Id: I2ad2f2194e2a89c7246e8742b2fc8be7580e38c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171394 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-02tdf#162259: correctly handle font width on WindowsMike Kaganski2-0/+76
Unlike other platforms, on Windows, the font width is not relative to font height, but to average width of font's glyphs. This is mentioned in LogicalFontInstance::GetScale. 1. In VclProcessor2D::RenderTextSimpleOrDecoratedPortionPrimitive2D, when calculating the correction for width / height (introduced in commit cc3663bbaed4f65d64154e5f9abb51a5f622f710, 2024-04-20), the already applied X scale is now calculated using unscaled font's width. 2. Commit 8557ea84c9336ba8061246f1f46ddb6e02f413a1 (Exclude getHScale from DirectWrite font rendering, 2024-04-08) was effectively reverted, because I was wrong assuming that the code there was unnecessary. 3. Commit 2092df2a9044f1c2ae4379f48a3201e5867575a8 (tdf#161154: pass "scaling is done externally" information down the stack, 2024-05-18) was also reverted. Change-Id: I8cff39b67a6efd380f7807f5655f401bdb62cc3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171382 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-08-02Fix wrong / misleading uses of fTools::(more|less|equal) with literal 0Mike Kaganski5-7/+7
These will never compare with tolerance (the zero is a special case in rtl_math_approxEqual used internally), so the calls like those don't do what they appear to do in these cases. Change-Id: I495ac92b7f45637e118e4fdc04bb6fad6fff31ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171391 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-08-02cid#1556086 COPY_INSTEAD_OF_MOVECaolán McNamara1-1/+1
and cid#1556087 COPY_INSTEAD_OF_MOVE cid#1556093 COPY_INSTEAD_OF_MOVE cid#1556094 COPY_INSTEAD_OF_MOVE cid#1556105 COPY_INSTEAD_OF_MOVE cid#1556121 COPY_INSTEAD_OF_MOVE cid#1556184 COPY_INSTEAD_OF_MOVE cid#1556399 COPY_INSTEAD_OF_MOVE cid#1556405 COPY_INSTEAD_OF_MOVE cid#1556419 COPY_INSTEAD_OF_MOVE cid#1556421 COPY_INSTEAD_OF_MOVE cid#1556444 COPY_INSTEAD_OF_MOVE cid#1556448 COPY_INSTEAD_OF_MOVE cid#1556457 COPY_INSTEAD_OF_MOVE cid#1556468 COPY_INSTEAD_OF_MOVE Change-Id: I1f352682daebd4e3ed2e7fe669aa0943dcc33edd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171372 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-07-31cid#1555587 COPY_INSTEAD_OF_MOVECaolán McNamara1-2/+2
and cid#1555589 COPY_INSTEAD_OF_MOVE cid#1555593 COPY_INSTEAD_OF_MOVE cid#1555596 COPY_INSTEAD_OF_MOVE cid#1555602 COPY_INSTEAD_OF_MOVE cid#1555608 COPY_INSTEAD_OF_MOVE cid#1555610 COPY_INSTEAD_OF_MOVE cid#1555620 COPY_INSTEAD_OF_MOVE cid#1555623 COPY_INSTEAD_OF_MOVE cid#1555625 COPY_INSTEAD_OF_MOVE cid#1555626 COPY_INSTEAD_OF_MOVE cid#1555634 COPY_INSTEAD_OF_MOVE cid#1555638 COPY_INSTEAD_OF_MOVE cid#1555667 COPY_INSTEAD_OF_MOVE cid#1555682 COPY_INSTEAD_OF_MOVE cid#1555686 COPY_INSTEAD_OF_MOVE cid#1555702 COPY_INSTEAD_OF_MOVE cid#1555710 COPY_INSTEAD_OF_MOVE cid#1555750 COPY_INSTEAD_OF_MOVE cid#1555752 COPY_INSTEAD_OF_MOVE cid#1555761 COPY_INSTEAD_OF_MOVE cid#1555762 COPY_INSTEAD_OF_MOVE cid#1555771 COPY_INSTEAD_OF_MOVE cid#1555772 COPY_INSTEAD_OF_MOVE cid#1555784 COPY_INSTEAD_OF_MOVE cid#1555785 COPY_INSTEAD_OF_MOVE Change-Id: Ib9724230c05b2027b4edf64e6a0bb5e22a270a88 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171274 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-31reduce number of GetItem callsNoel Grandin7-40/+35
if we already call GetItemState, we can use that call to fetch the item Change-Id: I736dec9bb56ad3bd66bb53e1cef2cf1e3092821d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171269 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-07-31cid#1555417 COPY_INSTEAD_OF_MOVECaolán McNamara1-1/+1
and cid#1555423 COPY_INSTEAD_OF_MOVE cid#1555430 COPY_INSTEAD_OF_MOVE cid#1555436 COPY_INSTEAD_OF_MOVE cid#1555440 COPY_INSTEAD_OF_MOVE cid#1555443 COPY_INSTEAD_OF_MOVE cid#1555454 COPY_INSTEAD_OF_MOVE cid#1555459 COPY_INSTEAD_OF_MOVE cid#1555461 COPY_INSTEAD_OF_MOVE cid#1555468 COPY_INSTEAD_OF_MOVE cid#1555477 COPY_INSTEAD_OF_MOVE cid#1555484 COPY_INSTEAD_OF_MOVE cid#1555511 COPY_INSTEAD_OF_MOVE cid#1555515 COPY_INSTEAD_OF_MOVE cid#1555519 COPY_INSTEAD_OF_MOVE cid#1555534 COPY_INSTEAD_OF_MOVE cid#1555537 COPY_INSTEAD_OF_MOVE cid#1555544 COPY_INSTEAD_OF_MOVE cid#1555553 COPY_INSTEAD_OF_MOVE cid#1555559 COPY_INSTEAD_OF_MOVE cid#1555561 COPY_INSTEAD_OF_MOVE cid#1555563 COPY_INSTEAD_OF_MOVE cid#1555564 COPY_INSTEAD_OF_MOVE cid#1555568 COPY_INSTEAD_OF_MOVE cid#1555571 COPY_INSTEAD_OF_MOVE cid#1555580 COPY_INSTEAD_OF_MOVE Change-Id: Ia42a78bffddc80d0e82144f4db51dc6e4d2e9a1d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171237 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-30tdf#153040 PDF export: disable export of form fields as PDF forms by defaultMiklos Vajna1-2/+2
Open <https://bugs.documentfoundation.org/attachment.cgi?id=195586>, notice that from "bbb", the middle "b" is bold, export to PDF, none of the "b"s are bold. The reason for this is that by default we map form controls and content controls to fillable PDF forms, which can only contain plain text. Fix the problem by defaulting to not exporting form controls / content controls to PDF forms: most users just want a PDF that is close to what they saw in the edit window -- and the ones who want a fillable PDF form can still opt in. Once the UI checkbox is enabled, we even remember that. Based on <https://gerrit.libreoffice.org/c/core/+/152622>, thanks Justin! Change-Id: Iddb75d1dbd969045321e139154f254c059eebf16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171226 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
generated by cgit v1.2.3 (git 2.39.1) at 2024-11-25 01:50:56 +0000