summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)AuthorFilesLines
2018-03-27tdf#116438:Apps should ask if rotation should be appliedhimajin1000003-1/+22
For Calc,Draw,Impress. Writer already does this. Change-Id: I92512719673fb39a973b8a68378e93f30d82c327 Reviewed-on: https://gerrit.libreoffice.org/51447 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-03-27loplugin:expressionalwayszero improvementsNoel Grandin1-3/+3
Change-Id: I00bdbc58d2295a0be30b47c85eae6b9abfec17b2 Reviewed-on: https://gerrit.libreoffice.org/51868 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-26loplugin:useuniqueptr in OutlineViewShell and ViewShellNoel Grandin5-29/+29
Change-Id: Ia40444b4ba3c8b02d195d979ff6d84cfe4d8b44e Reviewed-on: https://gerrit.libreoffice.org/51845 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-25tdf#116544 crash on unhandled IllegalArgument exceptionCaolán McNamara1-14/+62
Change-Id: I290ba6097d6d91bf4677e7e92c896bd6359cbc49 Reviewed-on: https://gerrit.libreoffice.org/51833 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-23loplugin:useuniqueptr in PPTWriterNoel Grandin5-45/+39
Change-Id: I5c099e97d51808d2dcaf6d1385d1e3cab2e2ddf2 Reviewed-on: https://gerrit.libreoffice.org/51762 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-23loplugin:useuniqueptr in PPTExStyleSheetNoel Grandin2-12/+7
Change-Id: Ib830a1be4f840c06ebda9830351d82ad31706be1 Reviewed-on: https://gerrit.libreoffice.org/51738 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-23Typo: GetSelectItemId -> GetSelectedItemIdSamuel Mehrbrodt9-23/+23
Change-Id: Ieebb50b73f1f341c924693f3966f8cd2b09a136b Reviewed-on: https://gerrit.libreoffice.org/51750 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-03-23Typo: GetSelectLanguage -> GetSelectedLanguageSamuel Mehrbrodt2-4/+4
Change-Id: Ia283812d4e9df87d875559af5366c2e36b19eab2 Reviewed-on: https://gerrit.libreoffice.org/51747 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-03-23loplugin:useuniqueptr in OutlineViewNoel Grandin2-55/+36
Change-Id: I6da98d8634076826cfdbe8d77fa72cb2b99ffe84 Reviewed-on: https://gerrit.libreoffice.org/51672 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-22loplugin:useuniqueptr in DrawDocShellNoel Grandin3-12/+12
Change-Id: I051fb0523622ef2ab93639f0d28b4dc5f4efdbac Reviewed-on: https://gerrit.libreoffice.org/51671 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-22loplugin:useuniqueptr in SdTransferableNoel Grandin5-57/+52
Change-Id: I7ace5ab37ce6df240d3b7fbe8c0fd12618fa3031 Reviewed-on: https://gerrit.libreoffice.org/51669 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-22loplugin:useuniqueptr in DrawViewShellNoel Grandin5-61/+61
Change-Id: I5125e973fbda75b2c7e52e294db74bc3bd5e0bd9 Reviewed-on: https://gerrit.libreoffice.org/51662 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-22loplugin:useuniqueptr in PresenterTextView::ImplementationNoel Grandin1-73/+59
Change-Id: Ie5641d3a4b0791aa4ae4f126afeb3ec6f9760909 Reviewed-on: https://gerrit.libreoffice.org/51661 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-20Exclude a redundant variableMike Kaganski1-10/+6
Change-Id: I0a7d6a7068155259313408e8d8e61f72af705cc6 Reviewed-on: https://gerrit.libreoffice.org/51647 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-03-20drop unnecessary includesCaolán McNamara54-54/+0
Change-Id: I1a817d5575bbd57ecaa874a27158b9218e4210cc Reviewed-on: https://gerrit.libreoffice.org/51603 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-20Speed up SdPage comparisonMike Kaganski1-18/+28
Move trivial comparisons to front; return early on object comparison Change-Id: I4db927ac87dbb165e80b70046ff44a260b8a504b Reviewed-on: https://gerrit.libreoffice.org/51624 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-03-20tdf#115005 Do not remove original vector images from slidesSerge Krot2-0/+22
During calculation of the quality index of the image, we should take into account also SVM vector image type. Its mime type is image/x-vclgraphic. Change-Id: I7c723e99995f73258bb59d976a6c7670c51f7a25 Reviewed-on: https://gerrit.libreoffice.org/51599 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-03-19coverity#1430077 add assert for 'Division or modulo by zero'Caolán McNamara1-0/+2
and coverity#1430076 Division or modulo by zero coverity#1430078 Division or modulo by float zero coverity#1430082 Division or modulo by float zero coverity#1430083 Division or modulo by zero coverity#1430085 Division or modulo by zero coverity#1430102 Division or modulo by zero coverity#1430103 Division or modulo by zero Change-Id: I9d7190f95d19a755c681f1f897a8921105ef7c46 Reviewed-on: https://gerrit.libreoffice.org/51568 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-19tdf#116364: Revert "tdf#113660: show Master Slide label in handout view"Xisco Faulí1-1/+0
This reverts commit 605b01dc591eaa72788be255baf1f9b9dde76414. Change-Id: I99a2de6a425b1ecd2e9059a9867adac3fc75e619 Reviewed-on: https://gerrit.libreoffice.org/51403 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2018-03-19sd: fix incorrect visible center calculationPranav Kant1-7/+1
Don't call PixelToLogic twice. Thanks Ashod for noticing. Change-Id: Id280dad7e310ceaf8678f900e6e70214848dd925 Reviewed-on: https://gerrit.libreoffice.org/51529 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2018-03-19remove unused ucbstreamhelper includesJochen Nitschke6-6/+0
and a few vclunohelper includes Change-Id: I4803605766d155fe5044c2a65c0444631146831c Reviewed-on: https://gerrit.libreoffice.org/51496 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-17tdf#84205 If theme not found, use firstSzymon Kłos3-2/+20
Not a complete fix, workaround. Change-Id: If4d765eaeae3419f4f1deb4e1cfbe0113a71da94 Reviewed-on: https://gerrit.libreoffice.org/51440 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-03-17sd lok: Enable mapmode in case of lok to calculate centerPranav Kant5-31/+26
This reverts the solution in 9fee132c18b658c9ea9fb1114c1fefa56b57532a. Also, calculate center using the new function for chart, image, and text shape insertion. Change-Id: Ie893050b7c875760db0194e7a3f0c2cd3068963b Reviewed-on: https://gerrit.libreoffice.org/51343 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2018-03-17sd lok: Set the view size to full page size + fix unit testsPranav Kant4-2/+46
... such that during insertion of objects when sd calculates the center of the view to place the object, it is the center of the whole slide, not the center of the default rectangle of 800x600. It's also important to hide rulers, scrollbars so that correct center is calculated; we don't need them anyways in LOK. Change-Id: I2d1577bc963d324959b272ed3174571ab197d014 Reviewed-on: https://gerrit.libreoffice.org/51416 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2018-03-16loplugin:useuniqueptr in SvUnoWeakContainerNoel Grandin2-16/+10
just use a std::vector here, these are small objects, no need to allocate them separately Change-Id: Ie9f8df88eb7c291e2c99177d0f5e4bfc1c7ab542 Reviewed-on: https://gerrit.libreoffice.org/51415 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-16weld SvxObjectTitleDescDialogCaolán McNamara7-55/+30
Change-Id: Id08c201ee4377fe84618906725e7699d29dc1160 Reviewed-on: https://gerrit.libreoffice.org/51395 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-16tdf#104789 Export opacity attribute nameSzymon Kłos3-34/+40
Change-Id: Id47ab6b3cb20fbcebb2d7fa589f3b0d7552e2cce Reviewed-on: https://gerrit.libreoffice.org/51369 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-03-16tdf#104786 Don't export empty 'to'Szymon Kłos4-8/+31
Change-Id: I16b573fd6455813c6be5c2f5a0f0a820360a239f Reviewed-on: https://gerrit.libreoffice.org/51359 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-03-16tdf#90627 Don't save empty conditionsSzymon Kłos4-20/+30
Change-Id: I5a953c1b0fff7bf41a59360a8f52596264ddf266 Reviewed-on: https://gerrit.libreoffice.org/51293 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-03-16Revert "sd lok: Set the view size to full page size and hide ruler, scrollbars"pranavk3-26/+2
Pushed by mistake. Let's revert until tests passes This reverts commit 1354bafdc707b87f8db1e89c96382c4f4f460554. Change-Id: I4a8973f4e22332115143319a264fefa68e343dcc Reviewed-on: https://gerrit.libreoffice.org/51386 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2018-03-16sd lok: Set the view size to full page size and hide ruler, scrollbarsPranav Kant3-2/+26
... such that during insertion of objects when sd calculates the center of the view to place the object, it is the center of the whole slide, not the center of the default rectangle of 800x600. It's also important to hide rulers, scrollbars so that correct center is calculated; we don't need them anyways in LOK. Change-Id: I1180541c1b8c8a35f39112ca0a670c9d96d1320b Reviewed-on: https://gerrit.libreoffice.org/51347 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2018-03-16use more TypedWhichId in sfxsidsNoel Grandin12-32/+27
Change-Id: I136427319ce2f1117501517efec2f03019bbf71e Reviewed-on: https://gerrit.libreoffice.org/51339 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-16weld SvxObjectNameDialogCaolán McNamara1-1/+2
Change-Id: I588bdc61cce9a7b4e709fcac612b229c02e734c0 Reviewed-on: https://gerrit.libreoffice.org/51375 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-15tdf#115675: Shape selection was breaking when changing pos/size from sidebar.Jan Holesovsky4-22/+15
Fixes also other potential breakages with the same root cause. Change-Id: I09b3650189f6edb28ab64652cd411b1dca7dca89 Reviewed-on: https://gerrit.libreoffice.org/51342 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-03-15tdf#115453 Remove Master Handout tab from Views Tab BarÁlex Puchades1-8/+0
The Views Tab Bar has had five tabs until now (Normal, Outline, Notes, Slide Sorter and Master Handout). Before this commit, selecting the Master Handout tab and then going back to the Normal or Notes tab showed the Slide/Notes Master instead of the expected behaviour. This commit removes the Master Handout Tab from the Views Tab Bar, with master views remaining accessible through the View Menu. Change-Id: I017af5f29d154386e4f0910151c478956aa0985f Reviewed-on: https://gerrit.libreoffice.org/51320 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-15loplugin:useuniqueptr in SdModuleNoel Grandin3-24/+19
Change-Id: I3b79696f06b33703cf61b73867014e4fd86ee9c7 Reviewed-on: https://gerrit.libreoffice.org/51313 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-15loplugin:useuniqueptr in UndoRemovePresObjectImplNoel Grandin2-12/+6
Change-Id: Ieaaedf6d5815c9dd49dc2f992cfaef7f74c43428 Reviewed-on: https://gerrit.libreoffice.org/51312 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-15loplugin:useuniqueptr in UndoTextAPIChangedNoel Grandin1-11/+3
Change-Id: Id9251ce7e66efe35665619c96e985d5382f0e4a5 Reviewed-on: https://gerrit.libreoffice.org/51311 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-14tdf#115539, tdf#116238: Don't display the notebookbar in presentation modeXisco Fauli1-4/+2
Change-Id: Ifc64d9a3b5c93b83fa238737375e7a58b2ae86db Reviewed-on: https://gerrit.libreoffice.org/51262 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-03-14tdf#116342 Fix label: selectable, not selected is what this meansSamuel Mehrbrodt1-1/+1
Change-Id: Ie9b4fc71c7f262f896b69bbf4747f08e160447d7 Reviewed-on: https://gerrit.libreoffice.org/51275 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-03-14tdf#104792 Double check for target shapeSzymon Kłos2-0/+16
Change-Id: Ibe23377c7752d9ce97c7b100af4b2759b3ce946f Reviewed-on: https://gerrit.libreoffice.org/51241 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-03-14loplugin:constantparamNoel Grandin1-1/+1
Change-Id: I3ce653c0d9e517229dbbe32cc8d3ec3c206e364d Reviewed-on: https://gerrit.libreoffice.org/51273 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-14Moving XSAXDocumentBuilder2 to use XFastDocumentHandler:Mohammed Abdul Azeem1-1/+9
This is used in parsing of meta Contexts across different modules. This also involved moving to XFastParser for parsing xml filters in sw, sd, starmath. Change-Id: Ic663aaac6cb20ee8ce5b97cae87c93220f5a2929 Reviewed-on: https://gerrit.libreoffice.org/42989 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-13SDI: don't #define/#undef names of actual classes for slot headersMike Kaganski13-14/+14
Visual Studio 2015/2017 cannot handle that correctly, and emits a lot of intellisense errors. So, just prepend the define with "ShellClass_" Change-Id: I473ceb7e0a88e114b92e6342fd4ae63015cafd3e Reviewed-on: https://gerrit.libreoffice.org/51135 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-03-13loplugin:useuniqueptr in SdDrawDocumentNoel Grandin4-11/+8
Change-Id: Ia207c25b091923738811aad4f367a76e9e026283 Reviewed-on: https://gerrit.libreoffice.org/51207 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-13sd: remove useage of GraphicURL in PhotoAlbumDialogTomaž Vajngerl1-43/+36
Change-Id: I1ed5d2ad75d4424e93fa6d9761d99ab6e1bee06a Reviewed-on: https://gerrit.libreoffice.org/51107 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-13sd: bullet graphic uses "Graphic" prop. instead "GraphicURL"Tomaž Vajngerl3-26/+20
Change-Id: Iab5b10ae1887c1ea7149bb4ba09ba9e913985398 Reviewed-on: https://gerrit.libreoffice.org/51106 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-11Move (and rename) graphic stuff from svtools to vclTomaž Vajngerl7-2/+8
This is preparing to change how GraphicManager works where it won't base itself around GraphicObject anymore but Graphic. No functional or cosmetic change was made to the classes, only changes that were needed because of the move and rename. The only thing that wasn't moved is the GraphicRenderer as it is not needed in vcl for now (but makes sense to move it in the future to keep graphic stuff together). grfmgr was renamed to GraphicObject as the GraphicManager will be changed a lot and most likely moved out, so the name grfmgr won't make any sense anymore. All the UNO implementations were renamed with a prefix Uno and used the same name as the class name. This is made to be more specific which are the Uno objects (for example graphic.cxx contained the implementation of XGraphic, which is similar to graph.cxx contains Graphic). Change-Id: I54a2fa6c7e997469aaa7770db05244adb9f64137 Reviewed-on: https://gerrit.libreoffice.org/51068 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-11tdf#44774: Parent style's msApiName could yet be empty; use GetApiName()Mike Kaganski2-1/+31
Change-Id: Ie0e218ea83d34aa7ee22fea1f32b2851a942544f Reviewed-on: https://gerrit.libreoffice.org/51069 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-03-10ppt export: fix use of FillBitmap instead of FillBitmapURLTomaž Vajngerl1-1/+1
Change-Id: Ic6add7910753649efd74e9b69557a5f4389b34dd Reviewed-on: https://gerrit.libreoffice.org/51023 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-11-29 12:40:47 +0000