summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)AuthorFilesLines
2017-07-29tdf#109223: PPTX: Vertical flip of child shape is not imported correctlyTamás Zolnai2-0/+34
Group shape level vertical flip is not handled well. Recent handling of group shape's transformation makes it hard to import this attribute, but we can import the right text direction at least. Change-Id: Ib9e39e3dcb28a95fabc61c13152a3f7296fbd4c3 Reviewed-on: https://gerrit.libreoffice.org/40554 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-07-28loplugin:constparams in editengNoel Grandin1-1/+1
Change-Id: Ice32a16d14d0132a19e8209d311bb799fd7ee0c8 Reviewed-on: https://gerrit.libreoffice.org/40526 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-28SmartArt: first unit testGrzegorz Araminowicz2-0/+34
Change-Id: I273847d01a457bf79a9b9182b370ffb58284c952 Reviewed-on: https://gerrit.libreoffice.org/40498 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-07-28loplugin:checkunusedparams more part1Noel Grandin1-4/+2
seems I got one of the checks wrong, and was missing a bunch of stuff Change-Id: I2c662fc4e735f8d6cbe56c6f82906a60a580331b Reviewed-on: https://gerrit.libreoffice.org/40481 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-27make animation loop sal_uInt32 consistentlyCaolán McNamara1-4/+4
all this foo is ultimately animated gifs and the count there is limited to unsigned 16bit Change-Id: Ib6e6dde7355f3619bb7735743e686e6338a235ee
2017-07-26loplugin:unusedmethodsNoel Grandin1-3/+0
Change-Id: I7f26ee112ed89ee3e69c56930260565f66ff145b Reviewed-on: https://gerrit.libreoffice.org/40442 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-26convert SfxGroupId to scoped enumNoel Grandin11-304/+304
in the process I had to teach the idl compiler to cope with identifiers like SfxGroupID::Math, which has the side effect of requiring a space before a ':' in some of the .sdi files. Change-Id: If256599cb8aa1dfc0a33642c5070c5560702f3ba Reviewed-on: https://gerrit.libreoffice.org/40441 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-26tdf#100491 fix DOCX import shape line with arrow markerVasily Melenchuk4-20/+596
Line shape with arrow end markers was rendering rather thick arrow, not connected to main line. Moreover, arrow width should depend on actual line width. Change-Id: I8d9a6e7f5d89a1645dcc5939ecc592e86e6fe34f Reviewed-on: https://gerrit.libreoffice.org/40286 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-07-25convert UNO event ids to scoped enumNoel Grandin1-3/+3
I'm fairly sure there are more simplifications that could be make here. It seems like we have both an ID and a string name for all of these events, and we could probably get by with just one of those, or alternately, centralise the name<->id mapping somewhere Change-Id: I978073822ddbebce94ac5b560fea675bea905a35 Reviewed-on: https://gerrit.libreoffice.org/40392 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-25loplugin:unusedmethodsNoel Grandin4-118/+0
Change-Id: Ia874baf21257e5fe41e104211068a2bcc50446eb Reviewed-on: https://gerrit.libreoffice.org/40391 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-25use more comphelper::InitAnyPropertySequenceNoel Grandin2-13/+11
Found with: git grep -n -A10 'Sequence.*Any' -- *.cxx | grep -B5 -w PropertyValueProvider and: git grep -n 'Sequence.*Any.*( *&' Change-Id: Icb18c98bdd3f8352817e443ff78de5df042859ad Reviewed-on: https://gerrit.libreoffice.org/40389 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-24don't jump back to selected slide on right click context menuCaolán McNamara2-3/+12
i.e. two many slides to fit in slide sorter panel, so scroll bar, select slide one, scroll to the end and right click between slides (or anywhere that isn't a slide) and without this fix the sorter jumps back to make the selected slide 1 visible. The right click menu will offer "new slide", choosing that will insert a slide at the point that was originally clicked, not at the point it was scrolled back to losing focus trigger a (dubious looking) callback to jump to the selected slide, so disable it while context menu is up Change-Id: Ie42bf158258cc38c9b7cfda7672f24d2ac8bfa11 Reviewed-on: https://gerrit.libreoffice.org/40379 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-24SdrGlobalData::aUserMakeObjUserDataHdl is unusedNoel Grandin4-103/+0
ever since commit ddb1d5ebf0a81888001ffa1dbab883df70cdc279 Author: Felix Zhang <fezhang@suse.com> Date: Fri Nov 18 18:23:52 2011 +0800 remove unused Sdr methods removed the SdrObjFactory::MakeNewObjUserData method Change-Id: I95c167b2f20b436bcc0085b6b616406ac210045f Reviewed-on: https://gerrit.libreoffice.org/40363 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-24loplugin:unusedfields readonly fieldsNoel Grandin1-7/+6
Change-Id: I6629926df06f71ff86e9fb23ae4fc1ae73bc9406 Reviewed-on: https://gerrit.libreoffice.org/40360 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-23coverity#1415613 Explicit null dereferencedCaolán McNamara1-1/+1
Change-Id: I000715d694acadb7b8772e6220d540b91f4451bf
2017-07-23Removed duplicated includesAndrea Gelmini59-62/+0
Mainly about "core_resource.hxx" and "strings.hrc". It passed "make check" on Linux. Change-Id: I994420d5e33d02b64929f8a51c548a7322d88a79 Reviewed-on: https://gerrit.libreoffice.org/40311 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-07-21Rename InitAnySequence -> InitAnyPropertySequence, and convert some callers.Jan Holesovsky4-43/+25
Change-Id: I410fef49679360f3308ec0f00bb032a2de0d7931 Reviewed-on: https://gerrit.libreoffice.org/40282 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-07-21sd pptm: Unit tests for the .pptm support.Jan Holesovsky3-3/+38
Change-Id: Ie0d05e70fe2b0869470a1750d5b60566f129247b Reviewed-on: https://gerrit.libreoffice.org/40268 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-07-21sd pptm: Preserve the VBA stream on export.Jan Holesovsky2-1/+37
This actually implements the reading of the VBA stream in Impress too, so the user will get a warning when opening such a file (that the it contains macros). Change-Id: I1638199529196ed217cbd9ebef88eb7c88f2179a Reviewed-on: https://gerrit.libreoffice.org/40197 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk> Reviewed-on: https://gerrit.libreoffice.org/40267 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-07-21sd pptm: Add a separate PPTM filter.Jan Holesovsky4-63/+30
Similarly to commit 697173f6fdfae581022cfdb5ec5171c5a3be58f0, we have to preserve the correct content-type which is not the same for PPTX and PPTM. This commit also changes sdfilt.component to use the constructor feature. Change-Id: I4b334540ec07a53d308e6b9dd6403294842bddf8 Reviewed-on: https://gerrit.libreoffice.org/40195 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk> Reviewed-on: https://gerrit.libreoffice.org/40265 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-07-21loplugin: literaltoboolconversionCaolán McNamara1-9/+9
Change-Id: I675a29185c0401a8462ece17f70db82d188a53c5
2017-07-21loplugin:unusedfields in sdNoel Grandin18-203/+11
Change-Id: I7f89e038f3d9bd0da658c7d3b8faec23d8a593db Reviewed-on: https://gerrit.libreoffice.org/40257 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-21de-hrc various thingsCaolán McNamara30-198/+93
e.g. helpid[s].hrc -> helpids.h and insert include guards where missing move "ordinary" defines into .hxx files remove .hrc entries that are used as arguments to dialog factory when a dedicated method can be added instead Change-Id: I792fb8eb0adfaa63cf354e6e57401fc943e9196e
2017-07-21migrate to boost::gettextCaolán McNamara245-4075/+1713
* all .ui files go from <interface> to <interface domain="MODULE"> e.g. vcl * all .src files go away and the english source strings folded into the .hrc as NC_("context", "source string") * ResMgr is dropped in favour of std::locale imbued by boost::locale::generator pointed at matching MODULE .mo files * UIConfig translations are folded into the module .mo, so e.g. UIConfig_cui goes from l10n target to normal one, so the res/lang.zips of UI files go away * translation via Translation::get(hrc-define-key, imbued-std::locale) * python can now be translated with its inbuilt gettext support (we keep the name strings.hrc there to keep finding the .hrc file uniform) so magic numbers can go away there * java and starbasic components can be translated via the pre-existing css.resource.StringResourceWithLocation mechanism * en-US res files go away, their strings are now the .hrc keys in the source code * remaining .res files are replaced by .mo files * in .res/.ui-lang-zip files, the old scheme missing translations of strings results in inserting the english original so something can be found, now the standard fallback of using the english original from the source key is used, so partial translations shrink dramatically in size * extract .hrc strings with hrcex which backs onto xgettext -C --add-comments --keyword=NC_:1c,2 --from-code=UTF-8 --no-wrap * extract .ui strings with uiex which backs onto xgettext --add-comments --no-wrap * qtz for gettext translations is generated at runtime as ascii-ified crc32 of content + "|" + msgid * [API CHANGE] remove deprecated binary .res resouce loader related uno apis com::sun::star::resource::OfficeResourceLoader com::sun::star::resource::XResourceBundleLoader com::sun::star::resource::XResourceBundle when translating strings via uno apis com.sun.star.resource.StringResourceWithLocation can continue to be used Change-Id: Ia2594a2672b7301d9c3421fdf31b6cfe7f3f8d0a
2017-07-19enhance unusedfields plugin to find readonly fieldsNoel Grandin1-2/+0
Change-Id: I4da97443fc7eb14fd94959a026ab45a9256c055f Reviewed-on: https://gerrit.libreoffice.org/40158 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-18No reason to silently misbehave when these UNO services are missingStephan Bergmann2-0/+2
...which e.g. made it unnecessarily hard to track down 7a23668e4f4e235c7a4e1c99e38506bd9c874be8 "Fix CppunitTest_cppcanvas_emfplus" Change-Id: I2f537fabb067b77e82b900bd2cba30fd65c275aa
2017-07-17tdf#109067 Fix default value of rotWithShapePaul Trojahn2-0/+13
According to the OOXML standard the default value is true, so for the export of gradients and blips it has to be set explicitly to false. Change-Id: I06f6f2a00fca88ec79e2eb956c3c780f037a9d1e Reviewed-on: https://gerrit.libreoffice.org/39973 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-07-17tdf#89926 Fix OOXML gradient angle importPaul Trojahn1-2/+2
The rotation of the shape needs to be added to get the correct angle. Due to this nDmlAngle can be twice as big. The conversion to LO angles needs to be updated to prevent negative results. Change-Id: I3a13cb268af41a55cd8b9df3084d028008aed4f2 Reviewed-on: https://gerrit.libreoffice.org/39648 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-17tdf#104743: Export transparency for bitmap fill/backgroundKatarina Behrens2-0/+27
Change-Id: I951ce974320f2eb5a6d3304b66f89ce71b38982c Reviewed-on: https://gerrit.libreoffice.org/39880 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-07-15improve variable scopeCaolán McNamara1-98/+97
Change-Id: I1207c570c4bceac73b3197e11bcefcf73837d1b3
2017-07-15coverity#1415091 Dereference before null checkCaolán McNamara1-12/+11
Change-Id: If22c6a9d9b312e52b2956fd84618d3e95fda1c3e
2017-07-15coverity#1415090 Unchecked dynamic_castCaolán McNamara1-6/+10
and coverity#1415096 Unchecked dynamic_cast Change-Id: I29a20a0868f8720a7aee60ebd6f55a7dbb76f894
2017-07-15emfplus: create a wmf/emf/emf+ primitive based importerArmin Le Grand4-7/+7
First steps to organize an importer that can read/interpret wmf/emf/emf+ and deliver a primitive representation for the content by parsing it. Use the same mechanisms as already applied for Svg, so to reuse abilities to keep original binary data to allow save again and embedding in files and have an implemented replacement bitmap based representation. For this, unify the used helper classes to handle more than just Svg. For 1st try, add test code and static bool switches Change-Id: I6e0a82943541d811a8f8d65a84115569fcd8cee7
2017-07-14tdf#109107: Sidebar's fontheight field is not updated...Tamás Zolnai3-0/+34
... by moving cursor in an Impress table Table controller handles key and mouse events itself, but can't do the invalidation of the slotids which would lead to update sidebar corresponding widgets. Change-Id: I0d1db58ecb714bb16dfb1b5662f0fba7ce69c06f Reviewed-on: https://gerrit.libreoffice.org/39933 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-07-14 use more OUString::operator== in scaddins..sdextNoel Grandin27-60/+60
Change-Id: I8bc5c925f940283bc54698bbcba77efcca883273 Reviewed-on: https://gerrit.libreoffice.org/39937 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-14Revert "tdf#109067 Fix default value of rotWithShape"Miklos Vajna2-13/+0
This reverts commit 1b08f129677c1109aae1fadc72ae68ebb7df7cb0. The change was Jenkins-verified, but just rebasing it on top of latest master (without getting conflicts) broke the test added in the commit. So let's revert it for now to have time to find out why does the test fail on top of latest master. Change-Id: I3bce24e54fb07df2dd460fb0f01d44516b3fcd0d
2017-07-14tdf#109067 Fix default value of rotWithShapePaul Trojahn2-0/+13
According to the OOXML standard the default value is true, so for the export of gradients and blips it has to be set explicitly to false. Change-Id: I3c9f67787cb11d6d9b58f07377b03167df669ed8 Reviewed-on: https://gerrit.libreoffice.org/39725 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-13Reorganize Scheduler priority classesJan-Marek Glogowski3-4/+0
This is based on glibs classification of tasks, but while glib uses an int for more fine grained priority, we stay with our enum. 1. Timers start with DEFAULT priority, which directly corresponds with the previous HIGH priority 2. Idles start with DEFAULT_IDLE priority instead of the previous HIGH priority, so idle default becomes "really run when idle". As RESIZE and REPAINT are special, and the DEFAULTS are set, there is just one primary decision for the programmer: should my idle run before paint (AKA HIGH_IDLE)? If we really need a more fine-grained classification, we can add it later, or also switch to a real int. As a result, this drops many classifications from the code and drastically changes behaviour, AKA a mail merge from KDE is now as fast as Gtk+ again. Change-Id: I498a73fd02d5fb6f5d7e9f742f3bce972de9b1f9
2017-07-13Drop special idle handlingJan-Marek Glogowski1-2/+2
Idles are just instant timers, which should most time have a low priority, By dropping most special idle handling we'll just schedule by priority. This also reverts SalYieldResult back to a bool, which just indicates if any event was processed. Change-Id: Ia0b91b06dffb77af066f01838d8f9483523bf67d
2017-07-13Move scheduler task into its own headerJan-Marek Glogowski1-0/+1
Change-Id: I54534787b8cfa4c47dc09dde9c38a7893df9d367
2017-07-13loplugin:oncevar: empty strings: sdStephan Bergmann5-22/+11
Change-Id: I94330c65d021c96e79185c8a2d59f1be702c6b61
2017-07-13sd: Use std::unique_ptr<> as SdUndoGroup owns SdUndoActionsTakeshi Abe2-13/+6
Change-Id: Iaba3f3cf91e30b549e1b8ce3e54c0ef50df9f1d4 Reviewed-on: https://gerrit.libreoffice.org/39823 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-07-12EditEngine: Making ODF Format Default for Copy/PasteVarun Dhall1-1/+1
Change-Id: Idfb4dacf4a1595ff974bbca195e419ff6a98418b Reviewed-on: https://gerrit.libreoffice.org/39876 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-07-11loplugin:useuniqueptr in scaddins..svxNoel Grandin2-40/+16
Change-Id: I309f98f6b820103a926e9fe94d67d0aff6eb6476 Reviewed-on: https://gerrit.libreoffice.org/39754 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-11simplify calls OUString::copy in foo.copy(x, foo.getLength() - x)Noel Grandin1-1/+1
Change-Id: I20318c77dcc3bc2a64336541ef5a3f412bfd9483 Reviewed-on: https://gerrit.libreoffice.org/39803 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-11use more range-for on uno::SequenceNoel Grandin2-14/+10
Change-Id: Ifad32425d79be5a22d33d721bdc5fb993f699759 Reviewed-on: https://gerrit.libreoffice.org/39763 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-10sd: fix unitialized "pItem" pointer in SlideBackground::SlideBackgroundMarkus Mohrhard1-4/+6
/sd/source/ui/sidebar/SlideBackground.cxx:176:17: runtime error: downcast of misaligned address 0x00009cf8cd67 for type 'const SvxSizeItem', which requires 8 byte alignment (regression from fba28df77d7e98663d1cf77ac206f8799fce4108) Change-Id: I822efe57f35c851b6f63e1e5489ab2448a19963d Reviewed-on: https://gerrit.libreoffice.org/39753 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-07-10teach unnecessaryparen loplugin about identifiersNoel Grandin10-17/+17
Change-Id: I5710b51e53779c222cec0bf08cd34bda330fec4b Reviewed-on: https://gerrit.libreoffice.org/39737 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-09Added margin feature to the Draw's SideBarpv2k6-1/+447
Change-Id: I53b5430d1563fcceae29418fd5907ac42ea856e7 Reviewed-on: https://gerrit.libreoffice.org/37626 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-07-09Slightly different approach to tdf#106679Katarina Behrens3-44/+19
cowardly avoiding use of DrawViewShell in constructor Change-Id: Ib40406d439403d0e2de270827bf5c2f06cfb18c2 Reviewed-on: https://gerrit.libreoffice.org/39368 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
generated by cgit v1.2.3 (git 2.39.1) at 2024-11-26 00:54:16 +0000