summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)AuthorFilesLines
2014-06-11Change SfxTabPage ctor SfxItemSet param from ref to pointerStephan Bergmann7-25/+25
...and also corresponding param of CreateTabPage function type and corresponding Craete functions. There were some call sites that passed undefined "null pointer references" and SfxTabPage internally uses a pointer member pSet that is checked for null anyway. Change-Id: I4eb3636155eac46c9c9d26e6e6e842e85d7e95af
2014-06-11Change SfxTabPage::Reset param from ref to pointerStephan Bergmann7-34/+34
...there was a call site that passed undefined "null pointer reference" (apparently in a case where the passed argument was actually unused) Change-Id: I663d4264b7a84f44ca69c732f3bc502f614b2b2a
2014-06-10Related bnc#862510: extend handling of txXfrmZolnai Tamás3-21/+23
We don't actually need to check mbAnchorCtr to change text spacing. This txXfrm workaround works only with rectangles, because other shapes' text area can be smaller then the shape size. So add some condition to avoid using it for other shapes. Plus fix typos cause regression introduced in: 53c376d35b7223d53e8c9403390afe53d1f69089 Change-Id: I87917b8e0b2bb97ae1bba773e7dda7f81682736f
2014-06-10Change SfxTabPage::FillItemSet param from ref to pointerStephan Bergmann7-30/+30
...there were a number of call sites that passed undefined "null pointer references" (apparently in cases where the passed argument was actually unused) Change-Id: I19799e90f0cd8e98367782441a5ea9df27b59830
2014-06-10-Werror,-Wundefined-bool-conversionStephan Bergmann1-6/+3
Change-Id: I13f415f1870d385433c4b9e287c2f5bae170c8ee
2014-06-10coverity#1213458 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: I7bfcda3ec7bfe1bdf46ce11e799972a96d9fc3dc
2014-06-10fdo#79676: Initialize with a default chart only from the UI.Kohei Yoshida1-0/+10
When creating an embedded chart object during import, we don't want to create a default chart which would only mess up the chart data. With this change, ChartModel::initNew() is a no-op. Change-Id: Id29659c3885ec1e06bed26d2c851123fb63072cc
2014-06-10coverity#735616 Division or modulo by float zeroCaolán McNamara1-2/+2
Change-Id: I5aaad2cd80e6930cbca57b4df2bfee3a6989ca41
2014-06-10fdo#77987, part 3: use signed ints consistentlyKatarina Behrens1-2/+2
everywhere where snap line coords are manipulated Change-Id: I8de1662680bd6e5dc9d42d633fa591dacc260a9b
2014-06-10fdo#77987, part 2: snap line coordinates can be negativeKatarina Behrens2-4/+4
thus, use signed integers here Change-Id: I8de1662680bd6e5dc9d42d633fa591dacc260a9b
2014-06-10fdo#77987, part 1: set min&max values of spinboxesKatarina Behrens1-0/+14
by attaching adjustments to them. This restores pre-ui behaviour, as without proper initial minimum value, one can't enter values < 0 into the dialog I just copied the numbers as they were in .src file, but they were prolly completely made up (and they're adjusted later anyway according to size/position of workspace) Change-Id: Ic09fdd9e947f04d6f2151e9d7a8714f4f1d29552
2014-06-09de-virtualize these stringify methods, nothing overrides themCaolán McNamara1-1/+1
Change-Id: Id523ae3f50147fd778a1576c2851d01e1ea8c3ae
2014-06-09gbuild: remove config_libraries.h and gb_Helper_generate_config_librariesMichael Stahl3-3/+2
This much ugly complexity, generating a header on every gbuild startup etc. is really not warranted for 6 callers of the generated macros. Also, the Win32 make has problems with the quoting. Change-Id: If945e09c1730e52174a6084677842dc611d66b2f
2014-06-09some remaining sal_uInt16 to sal_Int32 editeng ESelection boundsCaolán McNamara3-5/+5
Change-Id: Ib47dea5c2d965cf613c465e624a1bdd81becb1c2
2014-06-09Related: fdo#78151 force outliners in master view to be read-only textCaolán McNamara10-4/+245
because these contain place-holder text and it doesn't make sense to be able to edit them (unless some-day we support custom place-holder prompts) because they are now read-only add a pair of "show next level" and "hide last level" features so on right clicking the last outline paragraph you can make the next one visible, or make the last one invisible Change-Id: Iea24d810f298156cfe2f32aa53d0515da45e08eb
2014-06-09loplugin: inlinesimplememberfunctionsNoel Grandin68-346/+67
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-06html export: More standard time specification in <meta/>.Jan Holesovsky1-1/+1
Change-Id: I1a62d12531029cc36fb8aeabecb9d92a8af837f7
2014-06-06sd html: Provide some minimal reasonable defaults.Jan Holesovsky1-0/+2
Change-Id: I72b02f7d87cf6075d318c1cc0d7288e27bbe1b9c
2014-06-06sd html: Unit test for the metadata export.Jan Holesovsky1-0/+5
Change-Id: I1e38e28b57e816a0829d1a56f2ffcb32d8f93718
2014-06-06sd html: Implement export of metadata in the single document case.Jan Holesovsky2-6/+35
Change-Id: Icf99c9bcea187e2a3127b97050d6ddb072540b0d
2014-06-06bnc#880763: PPTX import: wrong z-order becuause of wrong import orderZolnai Tamás3-11/+37
importExtDrawings() must be called as soon as possible, before parser starts to parse the next shape. Call it when graphicFrame tag is closed. This tag include the reference to the SmartArt. Plus fix up import tests. Change-Id: I9e8d54c2b1afeb78a1122390dc4982d580c152ae
2014-06-06coverity#704779 Unchecked dynamic_castCaolán McNamara1-1/+2
Change-Id: Ida8bdc0930142ecf602b5aef4414cc6302bfa18b
2014-06-06c++03 vs c++11 enum namespacingCaolán McNamara1-4/+4
Change-Id: I91be0e7d2b013221b1d47a5cd1e4e75eb16c2b67
2014-06-06coverity#705224 Missing break in switch, surely unintentionalCaolán McNamara1-1/+1
Change-Id: I9ebeb373f5ab15220e3d9a4bb57db88d7a8f2714
2014-06-062nd part of bnc#870233: import font color from color fragment for SmartArtsZolnai Tamás2-0/+68
SmartArt import ignores some fragments during import if drawing fragment exists, which seems to be not complete. In this case font style is blank (white) in data (and drawing) fragment and the real value is defined in the ignored color fragment. So first make color fragment parsing work, then apply font color of "node0" style on nodes of the SmartArt. Actually, it's a workaround, because "node0" style label is hardcoded, for a proper solution layout fragment should be parsed too to get the right style label, but it interferes with the drawing fragment by now. Change-Id: I7db89176a07eee928563d42d3896fbd02190dfa8
2014-06-061th part of bnc#870233: wrong list style in shapesZolnai Tamás2-0/+73
Text list styles were copied, without proper copy constructor and operator. It lad to mix up list styles and so text font. Change-Id: Iee7a6c0c1f74322fd7b80e41a262849f948e463a
2014-06-05coverity#1019354 Missing break in switch, assuming intentionalCaolán McNamara1-0/+1
Change-Id: I4dd2f68e8712a2c76797a33c54d1baf69975830f
2014-06-05coverity#705215 Missing break in switchCaolán McNamara1-0/+1
Change-Id: I52cf32e9349e547e3445fbb266a74495d69aaa3f
2014-06-05various: remove SAL_THROW macroNoel Grandin2-5/+2
Change-Id: I9464179a736b91f5bc32eb5e5e89b3b4e3da3494
2014-06-04coverity#1209650 Missing break in switch, probably intentionalCaolán McNamara1-0/+1
Change-Id: Iaa48a39cc86548dd2805703a97a90406663099ba
2014-06-04coverity#705863 Dereference before null checkCaolán McNamara1-4/+2
Change-Id: I0e4d3add3adc2e387c5735b75eb5e3638f24c12b
2014-06-04coverity#705864 Dereference before null checkCaolán McNamara1-4/+2
Change-Id: I69b3ec1c9eef117a55298781d15637b02281ff82
2014-06-04coverity#705867 Dereference before null checkCaolán McNamara1-6/+3
Change-Id: Ia541e6d8f0f0b30dcb67a8693b4dd5d53e929717
2014-06-04coverity#1213293 Dereference before null checkCaolán McNamara1-2/+1
Change-Id: If2dd3cb1c7e18bf0274551950bc33f7521e0f8e1
2014-06-04coverity#705873 Dereference before null checkCaolán McNamara1-1/+1
Change-Id: Ife67ce102df4dfadd3483a3c137bd767c13b3c26
2014-06-04DeInitVCL at end of testsStephan Bergmann3-0/+3
This required some changes to the framework: * Init-/DeInitVCL is no longer done per individual test in BootstrapFixture, but once per CppunitTest invocation in a new vclbootstrapprotector (similarly to the exisiting unobootstrapprotector). CppunitTests that need VCL now need to declare gb_CppunitTest_use_vcl. * For things to work properly, the UNO component context needs to be disposed from within DeInitVCL (cf. Desktop's Application::DeInit called from DeInitVCL). The easiest solution was to introduce an Application::setDeInitHook (where the hook is called from DeInitVCL) specifically for vclbootstrapprotector to call. * PythonTests don't (yet) call DeInitVCL; they still hook into BootstrapFixture's original test_init functionality (to call InitVCL), and do not make use of the vclbootstrapprotector. Change-Id: I4f3a3c75db30b58c1cd49d81c51db14902ed68b2
2014-06-02coverity#1219795 Uncaught exceptionCaolán McNamara2-2/+3
Change-Id: I24f5abd0e0b28c11c22c7871e10f42abb9908775
2014-06-01fdo#68849: Add header guards to all include filesJens Carl5-0/+24
Added header guards to files in directories sc/, sd/, slideshow/, and solenv/ Change-Id: Ib4577761644fe72f5ddb3c5060e629bf94d6e6e2 Reviewed-on: https://gerrit.libreoffice.org/9583 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-05-30Revert "cppcheck: zerodiv"Julien Nabet1-1/+1
This reverts commit c46cc5751b5af4ce180fca63f998fe7eb405f93c. See http://nabble.documentfoundation.org/avoiding-cppunit-zerodiv-correction-td4110788.html for more details
2014-05-30tweak massively complicated html export wizard a bitCaolán McNamara2-222/+212
Change-Id: I1d15780d0128204f063a816df9df251b05ab93d2
2014-05-30Convert DLG_PUBLISHING to .uiPalenik Mihály11-1116/+1999
Change-Id: I0e15b6f7610c7b262a037d6a9ea482112a5bb8b4 Reviewed-on: https://gerrit.libreoffice.org/9532 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-05-30coverity#705222 Missing break in switchCaolán McNamara1-0/+1
Change-Id: Ie127c5238fd2f69f52fb3cbe4090929eb23566f4
2014-05-30coverity#705223 Missing break in switchCaolán McNamara1-0/+1
Change-Id: I7b6f64fccc0fc16dff2d060c035fbad0ebb73335
2014-05-30fdo#76953: cannot start show at selected slideZolnai Tamás2-0/+10
It was worked only in slide sorter view properly. It seems it leads undefined behaviour when a menu item is in the menubar.xml but has no definition in *.sdi file. I experienced that on windows menu item was disabled on linux it was enabled. Change-Id: Iba4dd1cbac60a3b3350604d64d60d10d050a4e2b
2014-05-30bnc#870237: wrong text position in grouped listZolnai Tamás2-0/+22
In grouped list text area does not cover the whole shape but just a part of it at the top. To get the same visual effect modify text distance attribute. Change-Id: I32f30d0afbc1975f940c4562ec65f46596e97060
2014-05-30coverity#704728 Unchecked dynamic_castCaolán McNamara9-25/+30
Change-Id: I2db2d6ffdca1775f21969b523ede56b3fb3fd682
2014-05-30coverity#705871 Dereference before null checkCaolán McNamara1-3/+3
Change-Id: I5e52347ce5cee26dffb4d47fc8d320567a0fea31
2014-05-30coverity#705870 Dereference before null checkCaolán McNamara1-13/+4
Change-Id: Ie4588f8cb0f11b831d091b0f478b78d0472af160
2014-05-30coverity#705861 Dereference before null checkCaolán McNamara1-15/+18
Change-Id: Ia027a5990769413dff323ff0e0b6fd66633b9339
2014-05-30Resolves: fdo#79360 impress hangs on using sidebar new styleCaolán McNamara3-22/+34
because those styles are "pseudo-styles" and a new one cannot be added. The possibility is supposed to be disabled, and it is disabled in the floating stylelist. The old code assumes there can only be one of these stylelists and when a stylelist queries if the "new" should be disabled the callback asks the stylelist what family is selected, but only asks the floating one. So, floating closed, sidebar open, the new is not disabled. Implement the ancient TODO now that we have to. Instead of asking the stylelist what family is selected, query the frame for what is the current SID_STYLE_FAMILY as set by whatever is the active stylelist. What's disturbing is the SID_STYLE_FAMILY values are not SfxStyleFamily, but indexes that have to be mapped to SfxStyleFamily. I bet there are a pile of bugs around that, especially with little islands of different conversion codesites Change-Id: I85c8032d7c26ae6eea245685748f89b2a860e767