summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)AuthorFilesLines
2018-11-06convert some macros to local functionsNoel Grandin1-25/+26
Change-Id: If2c89f0f53615f6200b6cd1fb6267cc9b47df927 Reviewed-on: https://gerrit.libreoffice.org/62884 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-06don't leave empty slots in array in ScXMLExport::GetViewSettingsNoel Grandin1-59/+51
the code was creating 4 entries in the array, but potentially not putting anything there Change-Id: Ia44aea42b3939842f921d30996c5f10e595fd768 Reviewed-on: https://gerrit.libreoffice.org/62894 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-05tdf#112604 Set a maximum width for the Calc Sort dialogRoman Kuznetsov1-1/+2
Change-Id: Ie19a6c158d8d2c324755dfa9ec5eb833721d2daf Reviewed-on: https://gerrit.libreoffice.org/62905 Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-11-05tdf#120703 PVS: V547 Expression is always trueMike Kaganski1-3/+2
Change-Id: I7a863499fdae27afa8a0866fac5cfe227af8aa99 Reviewed-on: https://gerrit.libreoffice.org/62883 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-05Make ScAbstractDialogFactory::Create() do its job also on non-DESKTOPTor Lillqvist1-4/+0
Change-Id: Id97c9ead810f266239898cc559172b841bc6902f
2018-11-05Build the scui library for non-DESKTOP, tooTor Lillqvist1-1/+1
In order to eventually get the Calc-specific dialogs in the mobile app, too. Change-Id: I30b64512b38d37ceab5706851c211ff5cf73764e
2018-11-05We want the function pointer here, but not call it yetTor Lillqvist1-1/+1
We will call it just a few lines later. Change-Id: Id979fb7fdaebd05f2432d8917b921d1b1779d8a7
2018-11-05tdf#42949 Fix IWYU warnings in include/sot/*Gabor Kelemen1-0/+1
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ic5d0dd8c712e74825ed0d0de6bf366568ca48f25 Reviewed-on: https://gerrit.libreoffice.org/62460 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-11-05tdf#105225 new background tab pageJim Raykowski5-6/+16
This patch allows the new background/highlighting tab page and derived from area tab page to work correctly in the same tab dialog. It also provides a cleaner way to use the new background tab page by setting brush item as fill attributes to target set in the background tab page created method. Previously if the new background tab page and the area tab page were used in the same tab page dialog one would affect the other due to the same use of pool fill items. This patch makes a local copy of the attribute item set passed and then passes that set along to the parent class area tab page on each activation/deactivation. Tab page dialogs that use both the background and area tab pages are: Writer Paragraph Styles, Impress Presentations Styles and Drawing/ Graphics Styles, and Draw Drawing/Graphics Styles. All new background tab page merged patches have been reworked in this patch and remaining old background tab pages, with the exception of Report Design, have been replaced by the new tab page. Change-Id: I47f9ae10a0fd967729ff6e83c1a312aa49e1d13c Reviewed-on: https://gerrit.libreoffice.org/57102 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-11-04tdf#120703 PVS: V547 Expression is always true/falseMike Kaganski1-2/+1
Change-Id: I3432afca1ee9bf9e8adce1d55d58d57bf1a09cb4 Reviewed-on: https://gerrit.libreoffice.org/62847 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-03tdf#120703 PVS: V547 Expression is always true/falseMike Kaganski1-2/+2
Change-Id: I27bf92770431f6a1f35e1c8224c0847555a8d43f Reviewed-on: https://gerrit.libreoffice.org/62819 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-03tdf#120703 PVS: V547 Expression is always true/falseMike Kaganski2-35/+19
Let ScEditFieldObj::getData() return reference. Change-Id: I4deed9a1692953088cf6d939508b9045e3e6cb3c Reviewed-on: https://gerrit.libreoffice.org/62816 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-03tdf#120703 PVS: V547 Expression is always true/falseMike Kaganski2-21/+19
Change-Id: I75082c85862b83ed2503900186ce9c70783e54db Reviewed-on: https://gerrit.libreoffice.org/62817 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-03tdf#120703 PVS: V581Mike Kaganski1-3/+1
V581 The conditional expressions of the 'if' statements situated alongside each other are identical. Check lines: 153, 181. Change-Id: Ifcec371bc2207bdd3594e514f0eab1d06dd24c84 Reviewed-on: https://gerrit.libreoffice.org/62820 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-03tdf#120703 PVS: V547 Expression is always true/falseMike Kaganski1-2/+1
Change-Id: I856345576ff5c10a41509a97ad4539272bd55568 Reviewed-on: https://gerrit.libreoffice.org/62803 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-02tdf#119714 Calc Contextmenu: update Pagebreakandreas kainz1-8/+41
Change-Id: Iccef9a2f613e3f4a2e3198bf8bc59f61627b8b75 Reviewed-on: https://gerrit.libreoffice.org/62766 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-11-02tdf#119713 Calc Contextmenu: row and col header updateandreas kainz2-2/+10
Change-Id: I353cc4fff6ea48cf69bf1f25371c9ac70dd9b4c2 Reviewed-on: https://gerrit.libreoffice.org/62765 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-11-02tdf#119713 Calc Contextmenu: sheettab.xml updateandreas kainz1-11/+7
Change-Id: Id5724783be913d81d04bf6de218bc63133adf393 Reviewed-on: https://gerrit.libreoffice.org/62764 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-11-02fix signatures of deleted copy/assign operatorsNoel Grandin1-2/+2
Change-Id: Id1a0749b78a7021be3564487fb974d7084705129 Reviewed-on: https://gerrit.libreoffice.org/62718 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-02tdf#45904 Move _XEnumerationAccess Java Tests to C++Rahul Gurung14-13/+92
Change-Id: Id0aa9f3587fc6427bdbd938293eb3cc564c52bb1 Reviewed-on: https://gerrit.libreoffice.org/61731 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-11-02tdf#115317 Fix empty url representationPaul Trojahn7-29/+29
ScTabEditEngine doesn't override CalcFieldValue, so the function in EditEngine returns a single space as representation. By inheriting from ScFieldEditEngine the representation is calculated correctly. Change-Id: I6f3be8bd2c3936acf9f3d082c25c080bd3cbee76 Reviewed-on: https://gerrit.libreoffice.org/62428 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-11-01Add REGEX() 4th parameter also to Excel import/export, tdf#113977Eike Rathke2-2/+2
Change-Id: I5c849c8646711d3de74b91d804e39cdcc20e30fe Reviewed-on: https://gerrit.libreoffice.org/62743 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-11-01gbuild: rename value OS=IOS to OS=iOSMichael Stahl1-2/+2
This gets rid of the horrible hack in gbuild.mk to accomodate the case-incorrect iOS platform makefiles that cannot be renamed without upsetting git on file systems that sadly lack the case sensitivity feature. Keep the macro defined to IOS though. Change-Id: I1022bfef4900da00e75fc1ccce786b20f8673234 Reviewed-on: https://gerrit.libreoffice.org/62705 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2018-11-01clang-tidy: (WIP) bugprone-too-small-loop-variable findingsTamás Zolnai2-5/+5
Change-Id: Iaa255b39928ac45dec1ed37e368c149d6027f561 Reviewed-on: https://gerrit.libreoffice.org/62701 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-10-31Translate German commentsJohnny_M3-4/+4
Change-Id: I94cdb753d01dfd0d5b8f78ede1819b281b840ab2 Reviewed-on: https://gerrit.libreoffice.org/62669 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-10-31tdf#42949 Fix IWYU warnings in sc/inc; sc/source/filter/inc/Gabor Kelemen20-47/+11
Found with bin/find-unneeded-includes after recent improvements - remove UNO headers from blacklist - remove newly found unneeded fw declarations - fix up some not self contained headers Change-Id: I605656bc98a64640a78d2ff4de9c7c37326033cf Reviewed-on: https://gerrit.libreoffice.org/62264 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-31cppCheck RedundantAssignment variable bRefFoundZdibák Zoltán1-2/+1
Change-Id: I1b8e9d434a682717e09ae1d23470baef55935fe6 Reviewed-on: https://gerrit.libreoffice.org/62664 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-10-31cppCheck RedundantAssignment variable pMergeAttrZdibák Zoltán1-2/+1
Change-Id: I5dc87ec04a7c79359c947ba2786bbe067770904c Reviewed-on: https://gerrit.libreoffice.org/62665 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-10-31cppCheck RedundantAssignment variable pPatternZdibák Zoltán1-2/+1
Change-Id: Iba6eb684366bd60c19e4f28ec76c4d85bd1c4b64 Reviewed-on: https://gerrit.libreoffice.org/62666 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-10-31cppCheck RedundantAssignment variable bRecordingZdibák Zoltán1-2/+1
Change-Id: I2fb7c2ce3581bf6347a5b6ee85d7e603e2b58800 Reviewed-on: https://gerrit.libreoffice.org/62643 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-10-31RedundantAssignment variable aResult1Zdibák Zoltán1-2/+2
Change-Id: I9c8a40389cc9cc18a017f5ab98aa022856ef301d Reviewed-on: https://gerrit.libreoffice.org/62642 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins
2018-10-30tdf#42949 Fix IWYU warnings in include/sax/*Gabor Kelemen2-0/+2
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I8061ef6a7a8c04baf350844fae1f97836ac03554 Reviewed-on: https://gerrit.libreoffice.org/62399 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-304th parameter Flags for REGEX(), tdf#113977Eike Rathke3-7/+42
REGEX( Text ; Expression [ ; [ Replacement ] [ ; Flags ] ] ) REGEX(Text;Expression) extracts the first match of Expression in Text. If there is no match, #N/A is returned. REGEX(Text;Expression;Replacement) replaces the first match of Expression in Text, not extracted. If there is no match, Text is returned unmodified. REGEX(Text;Expression;Replacement;"g") replaces all matches of Expression in Text, not extracted. If there is no match, Text is returned unmodified. Change-Id: I9d26a48f40c64a2704d9d07576c8b1b98b2c7b84 Reviewed-on: https://gerrit.libreoffice.org/62545 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-10-30loplugin:returnconstantNoel Grandin1-2/+1
Change-Id: I5b859de6ccd908eee4356acbe1f12b441ab36df3 Reviewed-on: https://gerrit.libreoffice.org/62539 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-30sc: Fix a wrong reference in a SMALL()'s test caseTakeshi Abe1-1/+1
Change-Id: I6eb5491cb437745a787304bde9f5673e63892773 Reviewed-on: https://gerrit.libreoffice.org/62380 Tested-by: Jenkins Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2018-10-30Rewrite REGEX() to directly use icu::RegexMatcher, tdf#113977Eike Rathke1-20/+47
This not only avoids all the overhead of i18npool's TextSearch and Transliteration efforts (which are useful in the Find&Replace dialog bu we don't use here) that could possibly even get in the way how they are implemented, but also gives us direct control over all possible flags; plus ICU's replace features are more convenient to use and have better error checking to report back and there is the advantage that ICU's regex description can be taken verbatim. Change-Id: Iaa06c26a3ff6882a0057d1ca92b1605073429bca Reviewed-on: https://gerrit.libreoffice.org/62531 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2018-10-30context menu: finish draw and calc context menuesandreas kainz2-2/+2
and update NameGroup arrangement Change-Id: I373229793fa1605e731c04824112118c15e05c29 Reviewed-on: https://gerrit.libreoffice.org/62528 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-10-29uitest for bug tdf#67346Zdeněk Crhonek1-0/+45
Change-Id: I637a9811ac656db46e0e993343e962dc296e360b Reviewed-on: https://gerrit.libreoffice.org/62527 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-10-29uitest for bug tdf#54197Zdeněk Crhonek3-0/+59
Change-Id: Iaa6039f9ebabdd4b17e044a82b4e047506addf79 Reviewed-on: https://gerrit.libreoffice.org/62522 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-10-29calc: sync calc popupmenu and toolbare files with writerandreas kainz10-35/+48
Change-Id: I0cd058974f879166d2205dd7f26e0fd867db4c47 Reviewed-on: https://gerrit.libreoffice.org/62487 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-10-29sc: fix: range/step calculation for progress barSerge Krot6-25/+88
Change-Id: I733e4003b65b410d44d9a1132be4e9e10ac24c3e Reviewed-on: https://gerrit.libreoffice.org/62305 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-10-29loplugin:oncevarNoel Grandin2-24/+12
Change-Id: Iba892694acb378887a1d15ab59104c55f591f0bd Reviewed-on: https://gerrit.libreoffice.org/62498 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-29tdf#42949 Fix IWYU warnings in sc/source/ui/inc/[f-p]*Gabor Kelemen54-112/+60
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ie40401e8706dda219b8578d180983811114cabed Reviewed-on: https://gerrit.libreoffice.org/62208 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-29Notebookbar: add context-Printpreview to calc tabbed NBandreas kainz2-0/+18
Change-Id: I9b63a515c407692f5632cb5e1f391593cfd68736 Reviewed-on: https://gerrit.libreoffice.org/62433 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-10-29tdf#120703 PVS: V547 Expression is always true/falseMike Kaganski3-155/+142
Change-Id: I0516dc68cf7d451eafc044be8e50a66d2bddf15f Reviewed-on: https://gerrit.libreoffice.org/62484 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-28drop unnecessary requires lib="LibreOffice"Caolán McNamara1-1/+0
Change-Id: I5444e5076ca69e8f6f8d28e36f4e744721cf43ef Reviewed-on: https://gerrit.libreoffice.org/62445 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-28update old 'interface-requires' comments to <requires> tagCaolán McNamara9-13/+13
Change-Id: If7533650ae543f9d43a3a50fdfc137141fa64586 Reviewed-on: https://gerrit.libreoffice.org/62444 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-28tdf#120703 PVS: V547 Expression is always true/falseMike Kaganski1-218/+211
Change-Id: Iaa1a1811b638aadfe6b06b3465a182cb675031b5 Reviewed-on: https://gerrit.libreoffice.org/62476 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-28tdf#120703 PVS: V547 Expression is always true/falseMike Kaganski2-42/+27
Change-Id: I2b2ea62ff4ed3e16cd4fa2a5e588d001d21121cb Reviewed-on: https://gerrit.libreoffice.org/62465 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-28tdf#120703 PVS: V547 Expression is always true/falseMike Kaganski2-112/+103
Change-Id: I1e5098e11f1e5e2f7c5518ea05c57512f58b585b Reviewed-on: https://gerrit.libreoffice.org/62464 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-11-28 08:25:31 +0000