Age | Commit message (Collapse) | Author | Files | Lines |
|
Refactored ScTable::GetNextPos() and ScTable::GetNextMarkedCell()
methods in table1.cxx for dynamic column container.
Change-Id: I5dfe9e5b2236e6ede68119f4e1252610990e498b
Reviewed-on: https://gerrit.libreoffice.org/38599
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
|
|
Change-Id: I672785b273eaa8862f43112d7f25ae495b65b0c7
|
|
Change-Id: I20a71f66154675de9c2c47ff32e859c899fe9103
Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/37424
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
|
|
Change-Id: I173a29fd1ee889127369d2bc2fce8e010b89ca65
Reviewed-on: https://gerrit.libreoffice.org/38633
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Regression from https://cgit.freedesktop.org/libreoffice/core/commit/?id=4e3ff19b33c84557fd20e68960499933b4e52638
tdf#84834 sc: stricter type detection for dBASE files
Log test file from tdf#84834 still opens in Writer as expected
Change-Id: Ibf5a0f586e3a132455d2363e61e5cc7ea249002d
Reviewed-on: https://gerrit.libreoffice.org/38660
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: I0a7565e2cc666151440d9fdb0a0e7b90263a88e5
|
|
which in turn triggered some loplugin:useuniqueptr
Change-Id: I0c38561fc9b68dac44e8cf58c8aa1f582196cc64
Reviewed-on: https://gerrit.libreoffice.org/38281
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I81740a3ff9474e971556e9e7d4aa245151163d0e
Reviewed-on: https://gerrit.libreoffice.org/38608
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
This reverts commit 9fe9685627c51926459a897594ead9f64deee579.
Will propose a new fix
Change-Id: I5c4eb38453251d2c2243ee1bae8841428c8780bf
Reviewed-on: https://gerrit.libreoffice.org/38658
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I66f912cfc88a0122c6c23f149040277b738d9d78
Reviewed-on: https://gerrit.libreoffice.org/38636
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Don't consider RTL_TEXTENCODING_IBM_850 as RTL_TEXTENCODING_DONTKNOW
partially reverts https://cgit.freedesktop.org/libreoffice/core/commit/?id=b00c4ec0967f8712d721b31ccb2dd0778c9e973b)
Indeed DBaseImport method is only called from ScDocShell::ConvertFrom (sc/source/ui/docshell/docsh.cxx)
it calls it with "ScGlobal::GetCharsetValue(sItStr)"
sItStr is initialized with these lines:
1272 if ( pSet && SfxItemState::SET ==
1273 pSet->GetItemState( SID_FILE_FILTEROPTIONS, true, &pItem ) )
1274 {
1275 sItStr = static_cast<const SfxStringItem*>(pItem)->GetValue();
1276 }
1277
1278 if (sItStr.isEmpty())
1279 {
1280 // default for dBase import (from API without options):
1281 // IBM_850 encoding
1282
1283 sItStr = ScGlobal::GetCharsetString( RTL_TEXTENCODING_IBM_850 );
1284 }
In our case, Calc asks for encoding and we provide RTL_TEXTENCODING_IBM_850
so we're not even sure sItStr could be empty after the first if
Change-Id: I023b89a98d6430300ac147353ad6cbed1f2d3410
Reviewed-on: https://gerrit.libreoffice.org/38620
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Refactored ScTable::FindNextVisibleColWithContent() and
ScTable::FindAreaPos() for dynamic column container.
Change-Id: I5afdbe98d4f0eb69f42b56308b57b87777861740
Reviewed-on: https://gerrit.libreoffice.org/38556
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Change-Id: Ie833716fcde0b82dcaa2e5b66deb2952ee912b7f
|
|
Change-Id: I3959d67bd206f68ba1d20499d919838773b2e7df
|
|
Change-Id: I82767a92d1f816cb7fa8ef4f96d694ca5658dfc0
|
|
Change-Id: Id016d56f4ce36f07c86cf7d028f5e6beaafd3dff
|
|
To cover different code paths and use of sc::ParamIfsResult::mfCount
Change-Id: I7d0cfa9de3ac5460822c4d5075de54791f7abff8
|
|
Change-Id: I7b2680898dbfc49185fb949349d81f4ac615a470
Reviewed-on: https://gerrit.libreoffice.org/38593
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I72d7b13a23ce306b752b39187a0e9fbb7028643a
Reviewed-on: https://gerrit.libreoffice.org/38606
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I5318ab8bb4d896f3c936ec8d04eba3908b59861a
|
|
Change-Id: Ic514a4fe34b2f9658bae61ecb4cc5c3c8361669b
|
|
Change-Id: Ia5dc32fbcd8ad738d5ec0f20cc233b58fcadc882
|
|
... so formula expressions using it actually get the ranges highlighted.
Change-Id: Ibb0d2b49101e62b1f219a14d1669a501a450aaf4
|
|
Change-Id: Ic648fd2b0a1424aa5ae5d924b29dfd2cb8dddbf9
|
|
Change-Id: I40acd32229faa9a4ec9941592a4a952b7d05ef01
Reviewed-on: https://gerrit.libreoffice.org/38464
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: If81494b9279d3c1f2c3887097f1b0036c18cab78
|
|
Change-Id: I94b8054cc978c04ae994380ea0c564a4b16de26d
|
|
Change-Id: I70e3bd1129da76e11b5f71b1b56d79898eb3d5be
|
|
Change-Id: Ib7f9b3961a3885be8c39ec5a20e7f383ecc9cc37
|
|
We guarantee that all references are of same size.
Change-Id: I61888a257691f902cb958741f6b63779d9744e10
|
|
..."tdf#45904 Move java XCellSeries test to c++".
For one, the XCellSeries tests needed to be removed from
qadevOOo/objdsc/sc/com.sun.star.comp.office.ScTableSheetObj.csv, now that those
tests are done in C++. (Plus some clean-up in
qadevOOo/tests/java/mod/_sc/ScTableSheetObj.java and
sc/qa/unoapi/knownissues.xcl that was missing from
f1454b474d9248d7ef2cb84f396a974184e5167e.)
But for another, qadevOOo/objdsc/sc/com.sun.star.comp.office.ScCellCursorObj.csv
and qadevOOo/objdsc/sc/com.sun.star.comp.office.ScCellRangeObj.csv still list
XCellSeries tests (which apparently have not been superseded with C++ tests),
so partially revert f1454b474d9248d7ef2cb84f396a974184e5167e to get back
qadevOOo/tests/java/ifc/sheet/_XCellSeries.java needed by those tests.
Change-Id: I09f756fb804dafee3064947abcfb796db4797b32
|
|
Change-Id: Ia9bf97f10771dad5ecf1c3a9638384a80b65b181
|
|
Change-Id: Ia4e02589d2fe79a27b83200a0e7a528a2c806519
Reviewed-on: https://gerrit.libreoffice.org/38508
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
As documented at
<https://msdn.microsoft.com/en-us/library/office/ff192986.aspx>.
Change-Id: I390c22e75c8cfb41034287848f92578ad67e724f
Reviewed-on: https://gerrit.libreoffice.org/38524
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
As documented at
<https://msdn.microsoft.com/en-us/library/office/ff197557.aspx>.
Change-Id: I4ffa74293978e4642e043a9cda80a7b4a9b5512c
Reviewed-on: https://gerrit.libreoffice.org/38523
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
As documented at
<https://msdn.microsoft.com/en-us/library/office/ff839402.aspx>.
And also extend ov::excel::XInterior with a ThemeColor property, as
documented at
<https://msdn.microsoft.com/en-us/library/office/ff820778.aspx>;
implementation is just a stub for now.
Change-Id: I05f1490cdc366f5db127d340cab5f51efcafa862
Reviewed-on: https://gerrit.libreoffice.org/38522
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
If a drop-down list has a valid entry that is an empty string,
it should be acceptable as a data entry value, instead of just
ignoring it and leaving the old value in the cell.
Yes, the other simpler option is to just hit delete, but anyone using
the UI will get confused, and if not paying attention will have
incorrect data entry since it doesn't work as expected.
In the bug tested here, the selection dropdown was created with
data validation. Unsure of other times that create the grid...
Change-Id: I3b49c34d01079d4c1ec9e140e2c51123408b10a6
Reviewed-on: https://gerrit.libreoffice.org/38124
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Change-Id: Iedc1023b67138727061c2da13bebdb75af370ec6
Reviewed-on: https://gerrit.libreoffice.org/38105
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Change-Id: I88689f19d5a25e87a02d330ed4a3bc7d78dfdbe5
Reviewed-on: https://gerrit.libreoffice.org/38536
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Make FetchStreamFromURL::aBuffer a pointer to prevent the crash that
happens because of it.
Add ExternalDataMapper::StopImport() method.
Add a few member functions in CSVFetchThread that help in sync the
line fetch and writing.
Introduce a WriteToDoc() method that iterates over the the range to
apply whatever value or string needs to be applied.
Change-Id: I9baa053fa6d91bdf758a9b035888af50a40674eb
Reviewed-on: https://gerrit.libreoffice.org/32964
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Change-Id: Ia2db1835e56d683769d8c3972fb0c73ba2eae2c6
|
|
Change-Id: I70988724367b0ee798ccfee35c94e280b1015b36
|
|
Change-Id: I7134ce5c2d6d8fdc081410dcbc2b36c9db68839e
|
|
Change-Id: I2d68513664200349574446e68efcfacda1604f86
|
|
Change-Id: Id7f22d2d00e7c3ec79ec2dd886dce72be8692ac5
|
|
Change-Id: I8af9204e93608d7f63a502ddcc0b05e6f191343f
|
|
Change-Id: Ieb807769c64d38d8100c6c4bf0e7a0a2913d8e7b
|
|
Change-Id: I5dfae10ec9df7e5b450c9a105ecc76c5d36970c3
|
|
Change-Id: I53531cb2e0ecf5972cb6c016b4395ded66622e9a
|
|
Change-Id: Idcbb0ebdf284568dc552c0edf5ae130ba7aaeafe
|