summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)AuthorFilesLines
2024-09-27tdf#85976 [RFE] Add a "Remove Duplicate Records" commandSahil Gautam13-0/+1022
Add a "Remove Duplicate Records" entry under Calc > menu Data to remove duplicate records from a rectangular selection of cells in Calc. Change-Id: Ic8340d7f1e19461ef3666fd2ef65294b73577d5c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160685 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
2024-09-27tdf#160062 Uno API to set solver settings at the sheet levelRafael Lima13-4/+1339
This patch creates the API necessary to create solver models via macros, so that the model is visible in the Solver dialog, and the model is saved to the file. This patch also includes a comprehensive unit test in scsolverobj.cxx. Visit the bug ticket for a file with some examples of such macros. Change-Id: Ib9cfbbdaab8243cd6b901a2bcd99e46c27be97e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171769 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-09-25tdf#163091: check rParam.mnX before passing it to RowInfo::cellInfoMike Kaganski1-2/+2
When moving to the left, the RowInfo may have e.g. cells 21 to 41, and rParam.mnX may be 15, which is outside of the RowInfo data. It seems that in this case, when we handle the data outside of the visible area, setting clip marks may be safely skipped anyway. Change-Id: I2f507dc166468c44e34645bc34c827456f1ab1ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173857 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-09-24prefer the per-ViewShell rendering data for default document bg colorCaolán McNamara1-3/+10
Change-Id: Ie67d6317641d63524c20a3001179ad958ebce300 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173866 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Pranam Lashkari <lpranam@collabora.com> (cherry picked from commit 927fd9820bcdbed35b34c7bb7081a19535aa041b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173795 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-24Resolves tdf#142120 - Respect app color for text with lines breaksHeiko Tietze1-0/+1
Change-Id: I33ebfc1d542da06bd9d69f8e9a57797b8541a7f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173856 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
2024-09-20tdf#161562 Sluggish scrolling after saving and changing text colorNoel Grandin1-58/+14
This reverts commit eb13c889c760cfe153d5b41188e218bdda797d52. "Speed up scrolling through large document with lots of patterns" Which seems (according to buovjaga testing) to be a pessimisation now. I can't reproduce this either way, so lets just revert it for now. Change-Id: I6b7f95173eb875d215f1192b3a7ca44014c50886 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173641 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-09-19Fix typoAndrea Gelmini1-1/+1
Change-Id: Ib2f0d76465482663c7fd388ef065539c5ab2b330 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173673 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-09-19cid#1607067 Overflowed constantCaolán McNamara1-2/+3
Change-Id: I039c80f489657cc4f47727af2e95b095592d6946 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173668 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-19ofz: Timeout in schtmlfuzzerCaolán McNamara1-0/+2
use same fuzzing rowspan limit as xml import Change-Id: Id75d8cb8859bb2a6494d6aea160905cc6b75cb46 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173645 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-19tdf#162955 PDF export: avoid the popup rectangle with zero sizeTibor Nagy3-2/+50
Change-Id: I9a3cdda4d1dfa0b23a3ea6dd99341cb17ca47490 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173580 Tested-by: Jenkins Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>
2024-09-19tdf#162963 export property TotalsRow to ODFRegina Henschel12-6/+1115
DatabaseRange has got the property TotalsRow with UI and UNO. But this property was not written to ODF. The patch adds this as attribute calcext:contains-footer to <table:database-range> element. Related is issue OFFICE-4169 at OASIS. Change-Id: I99a51198585b9b7dfb840217bdf1312f2462c9bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173612 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2024-09-19use more concrete UNO types in scNoel Grandin3-21/+18
Change-Id: I5b70733fb5be0a4f9a51e48197454ff0452770bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173611 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-09-19pull some code out of hot loopNoel Grandin1-4/+5
Change-Id: Ic19888296d1a7be7c691714b0353f18a1ea074f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173591 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-09-18tdf#162760 Fix solver crashing with unset parametersRafael Lima4-6/+26
This patch fixes 2 related issues: 1) Solver engines may crash internally and we need to catch these exceptions and inform the user instead of letting Calc crash entirely. 2) When initializing solver settings, we only set the default values for the first engine; we need to set the defaults for all engines. Change-Id: Ia598f7c17c25b5d6277f2ce24d2f4d552f897fe0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172955 Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com> Tested-by: Jenkins
2024-09-17sc: use SAL_RET_MAYBENULL() in GetViewBindingsXisco Fauli1-1/+1
Change-Id: I67e3e7921869a22d2bf6ce713fd581a9c3881aa6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173521 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-09-17Only call GetViewBindings onceMike Kaganski1-2/+2
Change-Id: I172937f7f2dd6a9a5b128777ea95271c565f3ae5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173437 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-09-17Check return value of GetViewBindingsMike Kaganski1-1/+2
... as done in all other places where it's called Change-Id: Ic941cf433e96bb8bfa6ea81c52c044cc424100eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173436 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-09-17tdf#162987: check return value of GetViewBindingsMike Kaganski1-3/+5
Change-Id: Iaeec22ed07e18aa59f2ab87b2ea7d8a0c7ae1467 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173435 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-09-16cid#1619429 Dereference null return valueCaolán McNamara1-2/+4
Change-Id: I831952ac99f94296485f8bfaa9aaa84540f86a89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173418 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-16use more concrete UNO types in scNoel Grandin8-18/+19
Change-Id: I2da6016abf4c7302a725fa4e3b413296a70035a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173413 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-09-15cid#1607343 silence Overflowed constantCaolán McNamara1-1/+2
and cid#1607447 Overflowed constant Change-Id: If9be20f1e6a42343844c887c1e16d4c066ff3949 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173365 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-09-14Resolves tdf#33714 - Option to disable "only active sheet"Heiko Tietze15-8/+324
Based on work by Martin van Zijl in I5f5b65b132d91beb24aa6e9282390dead235d849 Change-Id: Ie4543a2fc4b52715b5d87783a57e982c20274114 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173220 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2024-09-13sc: fix revert conflictXisco Fauli1-1/+0
After 27be65a7d5326608f75839e3964ac322e88224a1 "tdf#162938: Revert "tdf#61313 Replace the static ">="..." I saw it right after I clicked the submit button :| Change-Id: I8a1abf583714c288e6d6ed2c42615d333527e6d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173328 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-09-13Fix regression from 27be65a7d5326608f75839e3964ac322e88224a1^!Julien Nabet1-0/+1
Crash when: - open https://bugs.documentfoundation.org/attachment.cgi?id=196417 - select a cell with icon - Format/Conditional/Icon Set... => popup dialog with message which at the end proposes "No" or "Yes" - Click "No" => Crash with bt: 0 0x00007f35e28acb66 in ScIconSetFrmtDataEntry::SetFirstEntry (this=0x55b37f0244d0) at /home/julien/lo/libreoffice/sc/source/ui/condformat/condformatdlgentry.cxx:1357 1 0x00007f35e28ad4cc in ScIconSetFrmtEntry::IconSetTypeHdl (this=0x55b37ee14940) at /home/julien/lo/libreoffice/sc/source/ui/condformat/condformatdlgentry.cxx:1422 2 0x00007f35e28ad1ac in ScIconSetFrmtEntry::ScIconSetFrmtEntry (this=0x55b37ee14940, pParent=0x55b37ad5a4e0, pDoc=0x55b37ae30350, rPos=..., pFormat=0x0) at /home/julien/lo/libreoffice/sc/source/ui/condformat/condformatdlgentry.cxx:1391 3 0x00007f35e289185d in ScCondFormatList::init (this=0x55b37ad5a4e0, rDoc=..., pFormat=0x0, rRanges=..., rPos=..., eType=condformat::dialog::ICONSET) at /home/julien/lo/libreoffice/sc/source/ui/condformat/condformatdlg.cxx:117 4 0x00007f35e2894ef0 in ScCondFormatDlg::ScCondFormatDlg (this=0x55b37eed53b0, pB=0x55b37ae6fd50, pCW=0x55b37ef0eb00, pParent=0x55b37af94cc8, pViewData=0x55b37b17c160, rItem=std::shared_ptr<ScCondFormatDlgData> (use count 2, weak count 0) = {...}) at /home/julien/lo/libreoffice/sc/source/ui/condformat/condformatdlg.cxx:479 Change-Id: Ifd79edd1fe04ebbf50fd736989e5dd787cf91aa3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173338 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-09-13tdf#161444 sc a11y: Send focused event when switching sheetsMichael Weghorn1-1/+1
When switching to another spreadsheet table in Calc (e.g. using Ctrl+Tab or Ctrl+PageUp), send an `AccessibleEventId::STATE_CHANGED` for the `FOCUSED` state of the newly active/focused sheet before sending an `ACTIVE_DESCENDANT_CHANGED` event for the currently active cell in that sheet. Call `ScAccessibleSpreadsheet::GotFocus` instead of `ScAccessibleSpreadsheet::FireFirstCellFocus` to achieve that, which takes care of both events. With that in place, the corresponding events when using the gtk3 VCL plugin now are shown as expected in Accerciser's event monitor: 86.3 object:children-changed:remove(0, 0, [table | Sheet Sheet2]) source: [document spreadsheet | Untitled 1 - LibreOfficeDev Spreadsheets] application: [application | soffice] 86.3 object:children-changed:add(0, 0, [table | Sheet Sheet3]) source: [document spreadsheet | Untitled 1 - LibreOfficeDev Spreadsheets] application: [application | soffice] 86.3 object:state-changed:focused(1, 0, 0) source: [table | Sheet Sheet3] application: [application | soffice] 86.3 object:active-descendant-changed(212998, 0, [table cell | G14]) source: [table | Sheet Sheet3] application: [application | soffice] This however still doesn't make Orca as of commit 6f6e0f79ff5d8669591c7c19ecdaca5ec45ab67d, i.e. the commit prior to the Orca-side workaround [1] commit 4ead75fdaebdde60535cfbadca108ccaeeeb9401 Author: Joanmarie Diggs <jdiggs@igalia.com> Date: Thu Sep 12 19:56:48 2024 +0200 Hack around https://bugs.documentfoundation.org/show_bug.cgi?id=161444 Because removing workarounds is regressing the end user experience, add the following hack: When we receive an active descendant event from LO, and the event source is not an ancestor of the current focus: 1. Silently set the locus of focus to the parent of the event source. Otherwise we'll be super chatty in response to the next item. 2. Non-silently set the locus of focus to the event source. This will cause us to present the sheet name. 3. Allow the default script to do its thing which will set the locus of focus to the cell with the common ancestor being the table and thus it will not be double-spoken. speak the newly active sheet before announcing the cell, but still requires further changes on Orca side, s. discussion in tdf#161444 and attached Orca diff there. [1] https://gitlab.gnome.org/GNOME/orca/-/commit/4ead75fdaebdde60535cfbadca108ccaeeeb9401 Change-Id: I699258ba395dd212fa45c7d1546b26a7c241db97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173331 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-09-13tdf#162938: Revert "tdf#61313 Replace the static ">="...Xisco Fauli7-96/+41
... with a dropdown of different operators" Why was this patch submitted in the first place? It added a call to convertToOldCondFormat in testTdf101104, testComplexIconSetsXLSX and testTdf64401 to make those tests pass but the issue was already reproducible with those files This reverts commit fcc5770dd1e33dcb4f4f0c28683569af5d1d8368. Change-Id: Ifd8904de26d39d23e52ec2188d917bec34ad93b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173310 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-09-12null pattern deref seen in ScViewData::SetEditEngineCaolán McNamara1-0/+6
warn and use the default pool pattern if this happens #0 WhichRangesContainer::getOffsetFromWhich (this=this@entry=0x38, nWhich=nWhich@entry=129) at libreoffice/svl/source/items/itemset.cxx:1895 #1 0x00007fe0179fa4ac in SfxItemSet::Get (this=0x10, nWhich=129, bSrchInParent=<optimized out>) at libreoffice/svl/source/items/itemset.cxx:1152 #2 0x00007fe00736aa2e in ScPatternAttr::GetItem (nWhichP=129, this=0x0) at libreoffice/sc/inc/patattr.hxx:71 #3 ScPatternAttr::GetItem<SvxHorJustifyItem> (nWhich=..., this=0x0) at libreoffice/sc/inc/patattr.hxx:73 #4 ScViewData::SetEditEngine (this=this@entry=0x3323c540, eWhich=eWhich@entry=SC_SPLIT_BOTTOMLEFT, pNewEngine=<optimized out>, pWin=pWin@entry=0x32eec4f0, nNewX=nNewX@entry=-1, nNewY=nNewY@entry=-1) at libreoffice/sc/source/ui/view/viewdata.cxx:1613 #5 0x00007fe00731c2f1 in ScTabView::UpdateEditView (this=this@entry=0x3323c538) at libreoffice/sc/source/ui/view/tabview3.cxx:2248 #6 0x00007fe00731c9ae in ScTabView::UpdateFormulas (this=this@entry=0x3323c538, nStartCol=nStartCol@entry=-1, nStartRow=nStartRow@entry=-1, nEndCol=nEndCol@entry=-1, nEndRow=nEndRow@entry=-1) at libreoffice/sc/source/ui/view/tabview3.cxx:2393 #7 0x00007fe007338bc5 in ScTabViewShell::Notify (this=0x3323c330, rBC=..., rHint=...) at libreoffice/sc/source/ui/view/tabvwsh5.cxx:219 #8 0x00007fe017a29bb9 in SfxBroadcaster::Broadcast (this=this@entry=0x2fd10a70, rHint=...) at libreoffice/svl/source/notify/SfxBroadcaster.cxx:40 #9 0x00007fe006f27c3f in ScDocShell::PostDataChanged (this=this@entry=0x2fd10a70) at libreoffice/sc/source/ui/docshell/docsh3.cxx:95 #10 0x00007fe006f17dfc in ScDocShell::SetDocumentModified (this=this@entry=0x2fd10a70) at libreoffice/sc/source/ui/docshell/docsh.cxx:3050 #11 0x00007fe007382e7c in ScViewFunc::DeleteTables (this=this@entry=0x3464aa28, TheTabs=std::vector of length 1, capacity 1 = {...}, bRecord=<optimized out>, bRecord@entry=true) at libreoffice/sc/source/ui/view/viewfun2.cxx:2656 #12 0x00007fe007350825 in ScTabViewShell::ExecuteTable (this=0x3464a820, rReq=...) at libreoffice/sc/source/ui/view/tabvwshf.cxx:910 #13 0x00007fe0175d0cef in SfxDispatcher::Call_Impl (this=0x340a1b70, rShell=..., rSlot=..., rReq=..., bRecord=<optimized out>) at libreoffice/sfx2/source/control/dispatch.cxx:254 #14 0x00007fe0175d8daa in SfxDispatcher::Execute (this=0x340a1b70, nSlot=<optimized out>, nCall=nCall@entry=SfxCallMode::RECORD, pArgs=pArgs@entry=0x7ffe3c51edf0, pInternalArgs=pInternalArgs@entry=0x7ffe3c51ed90, nModi=0) at libreoffice/sfx2/source/control/dispatch.cxx:813 #15 0x00007fe0176166f5 in SfxDispatchController_Impl::dispatch (this=<optimized out>, aURL=..., aArgs=uno::Sequence of length 1 = {...}, rListener=empty uno::Reference) at libreoffice/include/sfx2/ctrlitem.hxx:63 Change-Id: Ib4851414a277a293d6bc44b4ffcd33d332e3c57e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173183 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-12Temporarily skip unit tests on native arm64 buildBalazs Varga1-1/+4
which indicating unit test fails. Change-Id: I2689b0dda888e15e52ca60cc18e1705a1aefe968 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173143 Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> Tested-by: Jenkins
2024-09-11tdf#162899 Accept BYTE and SHORT types in the Solver Options dialogRafael Lima1-1/+2
ScSolverUtil::GetDefaults should also accept values of types BYTE and SHORT. It currently only accepts LONG. As described in the bug ticket, this is important when creating Solver extensions using Python, since pyObject2Any forces small integer numbers to be either BYTE or SHORT instead of LONG. Change-Id: I17c7a344777c31ea333a4d21a2543d2de0b448fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173093 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-09-11cid#1607652 Overflowed constantCaolán McNamara1-1/+3
Change-Id: I624949cf61caa1f4448375208a3d3db2315c43cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173162 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-09-09sc: make SelectRange dialog asyncRashesh4-10/+25
Change-Id: Id1ac622d7a2f15d432fa122b87217c0bfa9a39a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172626 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com> (cherry picked from commit 832eee15118babf772f19a820ef88603fb6e5ccd) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173066 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-09-09lokit: calc: send named ranges as well on calcfunctionlist callbackRashesh1-3/+23
Change-Id: Ib8082d81da0eec54ba201b5958b86770a508ec91 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172099 Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> (cherry picked from commit d805785b2cf7c570fc0bb480100bc50d8fbc5077) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172745 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-09add autofillpreviewtooltip type for LOK_CALLBACK_TOOLTIPBayram Çiçek1-0/+26
- during autofilling of cells, there is a preview shows the cell value before filling - we need to send tooltip text and location info by using LOK_CALLBACK_TOOLTIP Signed-off-by: Bayram Çiçek <bayram.cicek@collabora.com> Change-Id: I9961764007aece9122c03eff7c155e7f3f25d9c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172589 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> (cherry picked from commit 4a8731411bfdc51d042c6df52d0c2391a03ea028) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173023 Tested-by: Jenkins
2024-09-07tdf#161945 increase sensitivity for negative horizontal deltasPatrick Luby1-2/+30
A side effect of the anti-jitter code is that it tends to reduce the sensitivity of horizontal scroll events towards the first column. It is particularly noticeable with horizontal scroll events from a scrollwheel when the view position is in column B or C. This results in a very small delta from the anti-jitter code. So, to balance things out, apply a constant adjustment factor to increase the sensitivity more for small deltas than for large deltas. Also, while the fix for tdf#135478 reduces the horizontal scroll delta applied to the tab view, the horizontal scrollbar is set before that with the original delta. As a result, the horizontal scrollbar is now mispositioned so update the horizontal scrollbar position to match the position of the tab view's visible columns. Change-Id: I4be66c40692d4b92557f31235339ac6c40755ae7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172619 Tested-by: Jenkins Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
2024-09-07tdf#162829: Dereference before null checkXisco Fauli1-4/+3
Regression from: commit 1de1c47471278db2344c986e9d597d6a05e559e9 Author: Gökay Şatır <gokaysatir@gmail.com> Date: Thu Feb 22 13:54:06 2024 +0300 Moving parts of readonly checks from model to view. Change-Id: I8d0ba914df909bc1a13ce7181b6d05cd0216e468 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172978 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-09-05Libreoffice Theme Part 0: Read correct colors from qt based VCL_PLUGINSSahil Gautam1-1/+1
See `QtFrame::UpdateSettings()`, where `StyleSettings::WindowColor` is set to aBase (QPalette::Base) and `StyleSettings::DialogColor` is set to WindowColor in a call to `StyleSettings::BatchSetBackgrounds`. The issue is that without this patch in place, "GetWindowColor()" doesn't return the color of the window, instead it returns the "base color" from QPalette. It had some unintendedd consequences like the "Animation Panel" in the Impress's Animations sidebar not being painted with the correct color, as it was expecting the old WindowColor. This patch also fixes that by changing WindowColor to FieldColor in `SalInstanceWidget::set_stack_background()` https://gerrit.libreoffice.org/c/core/+/168901/comment/0e5201bd_2cae07b9/ Change-Id: I36f8c5efd8c3e87ded19a1efc00ed9c69a7fccf1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171916 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-09-05no need to use dynamic_cast hereNoel Grandin1-1/+2
Change-Id: Icc5ad5972afdad128db19c6b2d6d0aa55da47f0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172880 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-09-05use less dynamic_cast when broadcasting SfxHintNoel Grandin1-11/+8
Change-Id: If4d33cbbf36a9ad495b80a7347b39d0f4bc0405e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172857 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-09-04use less dynamic_cast when broadcasting BulkDataHintNoel Grandin4-9/+8
we never read the hint id that we pass in to the constructor, so drop it Change-Id: I8ec377e51bddbc2a12a2fd226fc1a915afef59e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172862 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-09-04use less dynamic_cast when broadcasting SfxHint in scNoel Grandin23-187/+202
Change-Id: I25ee079b5b14f82012f868ae6b348fa6982571a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172853 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-09-04tdf#157230: Remove redundant Open and Save buttons in notebookbarKira Tubo1-158/+7
In "Tabbed" UI toolbar, remove redundant buttons: - Recent Documents* - Open Remote* - Save As** - Save Remote** *Buttons/functionality already appear in "Open" popup menu **Buttons already appear in "Save" popup menu Affects Writer, Calc, Impress, and Draw toolbars. Change-Id: I0e37adae57333979bfd232e07c772998b91208d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172622 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
2024-09-04make ScAccWinFocusLostHint and siblings final classesNoel Grandin1-0/+8
that all directly extend SfxHint, as a precursor to use more SfxHintId to avoid dynamic_cast Change-Id: I35d908740f4200badd456e1cd5edc9457745c499 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172804 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-09-03tdf#161543 Enhance the searching functionality in FD & FWAhmedHamed3-25/+74
Change-Id: I1a21595228f886c942ae46d90e41705443d31550 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170073 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> Tested-by: Jenkins
2024-09-03ONLINE: Fix multi user dark mode link color problemGülşah Köse3-0/+17
If one user change the theme to dark mode, other user's link color is changed to dark mode link color too. In this commit we prevent that problem. Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com> Change-Id: I65838e106794d649c362cf181ca300045053f169 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169984 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit 1ae9e6fc33bac1ba0ac49a61ca567965dc81a6d6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172668 Tested-by: Jenkins
2024-09-02cid#1608421 silence Overflowed constantCaolán McNamara1-1/+2
and cid#1608468 silence Overflowed constant cid#1608519 silence Overflowed constant cid#1608531 silence Overflowed constant cid#1607216 silence Overflowed constant cid#1606854 silence Overflowed constant Change-Id: I805be34fe58895af3898ff9729aa3b3d3964221e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172770 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-02Add-In CompatibilityName: for "en-US" try the most likely fallback of "en"Eike Rathke1-2/+14
As this needs to be resolved for every occurrence of the function name during export to OOXML and .xls and Add-In authors tend to be lax with en-US vs en-GB, also because function names usually don't differ, and use "en" at least in DisplayName. Change-Id: If0b1b60c4806028c76296e5feaa74e7ddb307bb6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172735 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2024-09-01null deref of pTableView seenCaolán McNamara1-1/+1
#0 ImpEditView::GetOutputArea (this=<optimized out>) at editeng/source/editeng/impedit.hxx:366 #1 EditView::GetOutputArea (this=this@entry=0x0) at editeng/source/editeng/editview.cxx:442 #2 0x00007fc50355663a in ScModelObj::setTextSelection(int, int, int) () at sc/source/ui/unoobj/docuno.cxx:870 #3 0x00007fc51206e910 in doc_setTextSelection () at desktop/source/lib/init.cxx:5653 #4 0x0000000000577c54 in lok::Document::setTextSelection (nY=<optimized out>, nX=<optimized out>, nType=<optimized out>, this=<optimized out>) Change-Id: If30a32b6c365fb7fdcfcfcaa27e08ed39c75116f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172678 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-01cid#1618766 Unchecked return valueCaolán McNamara1-4/+4
Change-Id: I600d536db7069209ffd14fb704b1c02a3ff85121 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172712 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-08-31cid#1608435 Use of auto that causes a copyCaolán McNamara1-1/+1
Change-Id: Iaff34cb1974932baa27b261041a91fd9a2da9fb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172702 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-31cid#1606767 Overflowed constantCaolán McNamara1-1/+2
Change-Id: I9f2db2175da45fc42a14f193700692c069f5cf3e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172698 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-12-04 01:46:04 +0000