summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)AuthorFilesLines
2018-06-25tdf#118296 Grid line color cannot be revertedMaxim Monastirsky3-3/+8
Use same approach as in Tools > Options... > LibreOffice > Application Colors. Change-Id: I5061709222cde2591e2937cdd67bbb5b6ad7f3f8 Reviewed-on: https://gerrit.libreoffice.org/56344 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-06-25Remove obsolete (cargo-cult copied) dependenciesJens Carl1-29/+0
Change-Id: I5dea60a3833802473c133ef3060183c3ed790f6f Reviewed-on: https://gerrit.libreoffice.org/56365 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-06-25tdf#105225 new background tab page for Calc Format Cells dialogJim Raykowski2-2/+10
Change-Id: Iee26630fa47fedcfc134969cc4d3e13d939fbb77 Reviewed-on: https://gerrit.libreoffice.org/55357 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-06-24Changes to orcus for implementing XML data providerVikas Mahato3-7/+7
Change-Id: I70075f4240c75f0f46260bb77b160f0b75d6ae94 Reviewed-on: https://gerrit.libreoffice.org/56354 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-06-23tdf#96099 Remove some trivial std::vector typedefs in scArkadiy Illarionov10-57/+45
Change-Id: Ie54a5ba0af989eabc71781674180a042f4be8bdb Reviewed-on: https://gerrit.libreoffice.org/55949 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-22Fix typoAndrea Gelmini1-1/+1
Change-Id: Iad79c0a4db5a2dd367ad73410075b102efe3f3b3 Reviewed-on: https://gerrit.libreoffice.org/56306 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-06-22uitest for bug tdf#118189Zdeněk Crhonek2-0/+53
Change-Id: I1814d5609e905ab8e940ca8c838f7861cbb7a295 Reviewed-on: https://gerrit.libreoffice.org/56263 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-06-22use ScInterpreterContext in ScValueIteratorLuboš Luňák3-4/+10
Otherwise GetFormatTable() asserts with fdo#74507-1 (and mnOpenCLMinimumFormulaGroupSize disabled). Change-Id: Ic624076bd552a2f8370f942063e8b79ca703d9fc Reviewed-on: https://gerrit.libreoffice.org/56288 Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Tested-by: Luboš Luňák <l.lunak@collabora.com>
2018-06-22disable calc's threading for external referencesLuboš Luňák2-12/+32
Since the code uses ScExternalRefManager, which caches values, so better just disable it. Can be seen e.g. with fdo#78490-1 (and mnOpenCLMinimumFormulaGroupSize disabled). The doc actually asserts in GetFormatTable() called from ScExternalRefManager, but there seems to be no point in fixing just the assert if the whole class is possibly problematic. Change-Id: I4ace488414fd15b4ad0b88da51205b02c561c7a6 Reviewed-on: https://gerrit.libreoffice.org/56289 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Luboš Luňák <l.lunak@collabora.com>
2018-06-22fix debug codeLuboš Luňák1-3/+4
Change-Id: I68d3d3adb691be824ee54ad2147ed5423772a72a
2018-06-22sc: disable UITest_goalSeek for nowMichael Stahl1-1/+2
The solver code is apparently quite unreliable, failures such as: File "/sc/qa/uitest/goalSeek/tdf37341.py", line 43, in test_tdf37341_goalSeek self.assertEqual(get_cell_by_position(document, 0, 4, 6).getValue(), 12879.147) AssertionError: 11751.688982 != 12879.147 or crash on shutdown: 0 in std::unique_ptr<SfxAppData_Impl, std::default_delete<SfxAppData_Impl> >::get() const (this=0x28) at /usr/lib/gcc/x86_64-redhat-linux/4.8.5/../../../../include/c++/4.8.5/bits/unique_ptr.h:234 1 in std::unique_ptr<SfxAppData_Impl, std::default_delete<SfxAppData_Impl> >::operator->() const (this=0x28) at /usr/lib/gcc/x86_64-redhat-linux/4.8.5/../../../../include/c++/4.8.5/bits/unique_ptr.h:228 2 in SfxApplication::GetObjectShells_Impl() const (this=0x0) at /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/sfx2/source/appl/app.cxx:403 3 in SfxObjectShell::GetFirst(std::function<bool (SfxObjectShell const*)> const&, bool) (isObjectShell=..., bOnlyVisible=true) at /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/sfx2/source/doc/objxtor.cxx:450 41bef610: {maData = std::__debug::vector of length -417946822263704711, capacity -485587501518907230 = {<error reading variable> 4 in ScFormulaReferenceHelper::enableInput(bool) (bEnable=true) at /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/sc/source/ui/miscdlgs/anyrefdg.cxx:94 5 in ScFormulaReferenceHelper::dispose() (this=0x32076e0) at /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/sc/source/ui/miscdlgs/anyrefdg.cxx:78 2076c0 6 in ScRefHandler::disposeRefHandler() (this=0x32076c0) at /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/sc/source/ui/miscdlgs/anyrefdg.cxx:823 7 in ScRefHandler::~ScRefHandler() (this=0x32076c0) at /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/sc/source/ui/miscdlgs/anyrefdg.cxx:815 8 in ScRefHdlrImplBase<SfxModelessDialog, true>::~ScRefHdlrImplBase() (this=0x3207390, vtt=0x2b8443074d78 <VTT for ScSolverDlg+24>) at /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/sc/source/ui/inc/anyrefdg.hxx:198 9 in ScRefHdlrImpl<ScAnyRefDlg, SfxModelessDialog, true>::~ScRefHdlrImpl() (this=0x3207390, vtt=0x2b8443074d70 <VTT for ScSolverDlg+16>) at /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/sc/source/ui/inc/anyrefdg.hxx:229 10 in ScAnyRefDlg::~ScAnyRefDlg() (this=0x3207390, vtt=0x2b8443074d68 <VTT for ScSolverDlg+8>) at /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/sc/source/ui/inc/anyrefdg.hxx:232 11 in ScSolverDlg::~ScSolverDlg() (this=0x3207390, vtt=0x2b8443074d60 <VTT for ScSolverDlg>) at /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/sc/source/ui/miscdlgs/solvrdlg.cxx:80 12 in ScSolverDlg::~ScSolverDlg() (this=0x3207390) at /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/sc/source/ui/miscdlgs/solvrdlg.cxx:78 13 in ScSolverDlg::~ScSolverDlg() (this=0x3207390) at /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/sc/source/ui/miscdlgs/solvrdlg.cxx:78 14 in VclReferenceBase::release() const (this=0x3207928) at /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/include/vcl/vclreferencebase.hxx:45 15 in rtl::Reference<vcl::Window>::~Reference() (this=0x2fb0bb0) at /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/include/rtl/ref.hxx:90 16 in VclPtr<vcl::Window>::~VclPtr() (this=0x2fb0ba8) at /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/include/vcl/vclptr.hxx:117 17 in WindowUIObject::~WindowUIObject() (this=0x2fb0ba0) at /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/include/vcl/uitest/uiobject.hxx:102 18 in DialogUIObject::~DialogUIObject() (this=0x2fb0ba0) at /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/vcl/source/uitest/uiobject.cxx:592 19 in DialogUIObject::~DialogUIObject() (this=0x2fb0ba0) at /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/vcl/source/uitest/uiobject.cxx:591 20 in std::default_delete<UIObject>::operator()(UIObject*) const (this=0x32543d8, __ptr=0x2fb0ba0) at /usr/lib/gcc/x86_64-redhat-linux/4.8.5/../../../../include/c++/4.8.5/bits/unique_ptr.h:67 21 in std::unique_ptr<UIObject, std::default_delete<UIObject> >::reset(UIObject*) (this=0x32543d8, __p=0x2fb0ba0) at /usr/lib/gcc/x86_64-redhat-linux/4.8.5/../../../../include/c++/4.8.5/bits/unique_ptr.h:262 22 in UIObjectUnoObj::~UIObjectUnoObj() (this=0x3254370) at /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/vcl/source/uitest Change-Id: I350ad562bbea945711de6e69e82f59ed728ab605
2018-06-22blacklist ocDde and ocWebservice for calc's threadingLuboš Luňák1-1/+3
fdo#35927-1 (with minimal formula size disabled) crashes in LinkManager::CloseCachedComps(). The whole LinkManager class feels thread-unsafe, so just blacklist. Change-Id: Idd7ec6b47f5269c977b600dadfc3a05a5287a86d Reviewed-on: https://gerrit.libreoffice.org/56241 Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Tested-by: Luboš Luňák <l.lunak@collabora.com>
2018-06-22Revert "uitest for bug tdf#93328"Luboš Luňák2-41/+0
This test fails, as adding 1 to 6426.95 rather obviously doesn't make it 6427.89 . I have no idea how this could have passed the gerrit tests, but there's something fishy about this. Also, there's no point testing this as a slow UITest when this can be made as a C++ unittest. This reverts commit 6ed8083ab4124b7469e567d1b24c1471f1688e62.
2018-06-22Avoid member call through null this pointerStephan Bergmann1-1/+1
...as seen with UBSan during newly introduced UITest_goalSeek (where eOldActive is 0 and all four members of pGridWin except for pGridWin[2] are null): > sc/source/ui/view/tabview3.cxx:1814:45: runtime error: member call on null pointer of type 'vcl::Window' > #0 in ScTabView::SetTabNo(short, bool, bool, bool) at sc/source/ui/view/tabview3.cxx:1814:45 (instdir/program/../program/libsclo.so +0xb25dfca) > #1 in ScTabViewShell::DoReadUserDataSequence(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at sc/source/ui/view/tabvwsh4.cxx:500:5 (instdir/program/../program/libsclo.so +0xb2d27a5) > #2 in ScTabViewShell::ReadUserDataSequence(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at sc/source/ui/view/tabvwsh4.cxx:491:9 (instdir/program/../program/libsclo.so +0xb2d245a) > #3 in SfxBaseController::ConnectSfxFrame_Impl(SfxBaseController::ConnectSfxFrame) at sfx2/source/view/sfxbasecontroller.cxx:1368:52 (instdir/program/libsfxlo.so +0x320c974) > #4 in SfxBaseController::attachFrame(com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&) at sfx2/source/view/sfxbasecontroller.cxx:550:13 (instdir/program/libsfxlo.so +0x32055f1) > #5 in (anonymous namespace)::SfxFrameLoader_Impl::impl_createDocumentView(com::sun::star::uno::Reference<com::sun::star::frame::XModel2> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&, comphelper::NamedValueCollection const&, rtl::OUString const&) at sfx2/source/view/frmload.cxx:593:18 (instdir/program/libsfxlo.so +0x319fcdd) > #6 in (anonymous namespace)::SfxFrameLoader_Impl::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&) at sfx2/source/view/frmload.cxx:710:13 (instdir/program/libsfxlo.so +0x319b263) > #7 in framework::LoadEnv::impl_loadContent() at framework/source/loadenv/loadenv.cxx:1148:37 (instdir/program/../program/libfwklo.so +0xfa4cc8) > #8 in framework::LoadEnv::startLoading() at framework/source/loadenv/loadenv.cxx:382:20 (instdir/program/../program/libfwklo.so +0xf9a76a) > #9 in framework::LoadEnv::loadComponentFromURL(com::sun::star::uno::Reference<com::sun::star::frame::XComponentLoader> const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at framework/source/loadenv/loadenv.cxx:168:14 (instdir/program/../program/libfwklo.so +0xf97d15) > #10 in framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at framework/source/services/desktop.cxx:618:12 (instdir/program/../program/libfwklo.so +0x108e918) > #11 in non-virtual thunk to framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at framework/source/services/desktop.cxx (instdir/program/../program/libfwklo.so +0x108e9ca) > #12 in gcc3::callVirtualMethod(void*, unsigned int, void*, _typelib_TypeDescriptionReference*, bool, unsigned long*, unsigned int, unsigned long*, double*) at bridges/source/cpp_uno/gcc3_linux_x86-64/callvirtualmethod.cxx:77:5 (instdir/program/libgcc3_uno.so +0xba96d) > #13 in cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy*, bridges::cpp_uno::shared::VtableSlot, _typelib_TypeDescriptionReference*, int, _typelib_MethodParameter*, void*, void**, _uno_Any**) at bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:233:13 (instdir/program/libgcc3_uno.so +0xb6855) > #14 in unoInterfaceProxyDispatch at bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:420:13 (instdir/program/libgcc3_uno.so +0xb4663) > #15 in binaryurp::IncomingRequest::execute_throw(binaryurp::BinaryAny*, std::__debug::vector<binaryurp::BinaryAny, std::allocator<binaryurp::BinaryAny> >*) const at binaryurp/source/incomingrequest.cxx:236:13 (instdir/program/libbinaryurplo.so +0x209ede) > #16 in binaryurp::IncomingRequest::execute() const at binaryurp/source/incomingrequest.cxx:79:26 (instdir/program/libbinaryurplo.so +0x205f10) > #17 in request at binaryurp/source/reader.cxx:85:9 (instdir/program/libbinaryurplo.so +0x2966d3) > #18 in cppu_threadpool::JobQueue::enter(long, bool) at cppu/source/threadpool/jobqueue.cxx:107:17 (instdir/program/libuno_cppu.so.3 +0x17e863) > #19 in cppu_threadpool::ORequestThread::run() at cppu/source/threadpool/thread.cxx:165:31 (instdir/program/libuno_cppu.so.3 +0x1977bb) > #20 in threadFunc at include/osl/thread.hxx:185:15 (instdir/program/libuno_cppu.so.3 +0x1a0347) > #21 in osl_thread_start_Impl(void*) at sal/osl/unx/thread.cxx:234:9 (instdir/program/libuno_sal.so.3 +0x2e6789) > #22 in start_thread at /usr/src/debug/glibc-2.27-56-g50df56ca86/nptl/pthread_create.c:463:7 (/lib64/libpthread.so.0 +0x7593) > #23 in __GI___clone at /usr/src/debug/glibc-2.27-56-g50df56ca86/misc/../sysdeps/unix/sysv/linux/x86_64/clone.S:95 (/lib64/libc.so.6 +0xfa00e) Change-Id: I23fb29cdec429a1bbdba3c04f3c3c66ad744621e Reviewed-on: https://gerrit.libreoffice.org/56224 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2018-06-21uitest for bug tdf#93328Zdeněk Crhonek2-0/+41
Change-Id: Id20f21153e98e4c724f2fffdb52c7bbb274c53a9 Reviewed-on: https://gerrit.libreoffice.org/56260 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-06-21uitest for bug tdf#118207Zdeněk Crhonek2-0/+60
Change-Id: I40d0917673e602d4e0979249f34937af85caee03 Reviewed-on: https://gerrit.libreoffice.org/56177 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-06-21Do dependency computation checks for OpenCL and...Dennis Francis10-71/+141
software interpreter like in CPU threading. This patch also reworks the cycle detection to make it more robust. Since the dependency computation also does cycle detection, there is no need to disable group-calc(threaded/OpenCL/SW Interpreter) for non-leaf nodes in recursive interpret. The rework of cycle detection ensures that it fixes tdf#95748 correctly. Change-Id: I460addb768eedc0914491a3d24ae7220c3afbb20 Reviewed-on: https://gerrit.libreoffice.org/55665 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins
2018-06-21discard cached cell values if the cell changesLuboš Luňák5-4/+37
FormulaGroupContext is actually a cache of cell results for OpenCL, but the cached values are not always properly discarded. Happens e.g. with testFormulaDepTracking in sc_ucalc fails if OpenCL is forced for it (i.e. with mnOpenCLMinimumFormulaGroupSize disabled), because a SetString() call for a cell doesn't invalidate the cache. This obviously reduces the cache hit rate a bit, but according to my tests it's not that bad (in fact the cache doesn't seem to get used that often, so I even wonder if it's worth it). Change-Id: Ia7ef2214956861d26ca3a42b84f9fecbff8316d0 Reviewed-on: https://gerrit.libreoffice.org/56087 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-06-21loplugin:useuniqueptr in ScChangeTrackNoel Grandin2-12/+8
Change-Id: I98f9263660c6c9cfe03b47f0a71dc92d26aa2859 Reviewed-on: https://gerrit.libreoffice.org/56199 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-21Do not do threaded group calc if...Dennis Francis2-5/+14
the dependency computation resulted in a breach of recursion limit of MAXRECURSION. In such a case, the formula-group we are trying to thread is at the bottom of recursion guard stack and the dependencies (up the recursion guard stack) are yet to be computed, so the formula-group is not safe for threading. This patch fixes a crash in tdf#115034/1 when threading is enabled. Change-Id: I81737d3dd00f4e5cc782e9f030c18e36f6337a1b Reviewed-on: https://gerrit.libreoffice.org/54789 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins
2018-06-21loplugin:useuniqueptr in ScDPObjectNoel Grandin2-47/+38
Change-Id: I6e1f44d4e59ef15f08692e97ad90c3ffc23cdc8c Reviewed-on: https://gerrit.libreoffice.org/56200 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-21Remove obsolete (cargo-cult copied) dependenciesJens Carl1-36/+7
Change-Id: Ifd550df955cc95498949a0907e43ba41f68ba585 Reviewed-on: https://gerrit.libreoffice.org/56216 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-06-21Fix typosAndrea Gelmini2-2/+2
Change-Id: I6a42d683e2d4d2d8887822dc17ab2fd7f51982a5 Reviewed-on: https://gerrit.libreoffice.org/56210 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-06-20Prepare for Excel's dirty circular references iteration behaviourEike Rathke1-4/+30
In which either convergence is detected or N iterations are executed and the result is displayed no matter what. Which would "do N iteration steps" but never detect non-convergence. Enable that only with an additional option where the user specifies s/he doesn't want to be informed of non-convergence errors. Change-Id: I3caba0c200e16514e39ea46d7f899afc05a5a2cc Reviewed-on: https://gerrit.libreoffice.org/56183 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2018-06-20Avoid side effects of additional Interpret() during iterationEike Rathke1-0/+5
... which could alter results if this formula cell again depends on other formula cells in the circular reference(s). Change-Id: I2b56902a71c0f16f9777507402ea004ae609bfbc Reviewed-on: https://gerrit.libreoffice.org/56182 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2018-06-20tdf#66089 tdf#105720: only rely on bPixelToLogicAron Budea1-8/+6
Left-aligned currency symbols were put in preceding cells sometimes, because fill width was calculated incorrectly. Commit 37210da00a9190f7765fa9c1e4a08629d2f4c2c4 fixed the issue for LOK, but the bug was still reproducible in Calc if setting "Use printer metrics for text formatting" was enabled. Change-Id: I6cf90493cbf98c5020acd5faf1d0f3cf2def5c25 Reviewed-on: https://gerrit.libreoffice.org/56172 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-06-20uitest Calc/Goal seek; tdf#37341 ; tdf#43693Zdeněk Crhonek9-2/+163
Change-Id: Ib6416eec6245f22f49687437a466b1e5c6d60efb Reviewed-on: https://gerrit.libreoffice.org/56181 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-06-20tdf#77517 Additions to unit tests.Winfried Donkers2-27/+186
Change-Id: I2b4035ceeb4cb65de811628100efdda7e3c127ae Reviewed-on: https://gerrit.libreoffice.org/56056 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-06-20Related: tdf#117049 treat yet unknown result as initial 0.0Eike Rathke1-1/+8
For the first =A1+B1 in B1 with iterations the result could had been #VALUE! depending on string conversion calculation settings. Change-Id: I8d7a745d67ba7a20f7a66e8aa143642d08ea5111 Reviewed-on: https://gerrit.libreoffice.org/56173 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-06-20Resolves: tdf#117049 do not re-interpret a single circular self-referenceEike Rathke1-5/+10
... to not execute the calculation twice, which added an implicit iteration step. Change-Id: I943f770d32ebe84a8359f2f94c1f0bf5731b6f88 Reviewed-on: https://gerrit.libreoffice.org/56170 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-06-20Fix UITest_solver for --enable-ext-nlpsolverStephan Bergmann1-0/+3
...after <https://gerrit.libreoffice.org/#/c/56121/> "uitest Calc/Solver" was merged (see comments there for details) Change-Id: I6cc0833b353d79a3be3be85078776c44588b5182 Reviewed-on: https://gerrit.libreoffice.org/56163 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-06-20loplugin:useuniqueptr in ScColContainerNoel Grandin5-8/+9
Change-Id: Icb4fffb27535a767b307c1d01e5bc96372c98352 Reviewed-on: https://gerrit.libreoffice.org/56108 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-20tdf#42949 Fix IWYU warnings in sc/inc/[ux]*Gabor Kelemen15-12/+20
Found with bin/find-unneeded-includes Only removal proposals are dealt with here and a bit of fallout management Change-Id: I53d2c5dc9e16a64a143b16316d2aeab05023d866 Reviewed-on: https://gerrit.libreoffice.org/56076 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-06-20menubar scalc: sync with swriter layoutandreas kainz1-5/+5
Change-Id: Iac8cd198b85f83fbd7fa71a228df13f150ef04fc Reviewed-on: https://gerrit.libreoffice.org/56071 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-06-20weld SvxColorTabPageCaolán McNamara1-1/+2
Change-Id: I5dc6f949edcb34aa110dfa9415e2ac886d0dfa4c Reviewed-on: https://gerrit.libreoffice.org/56111 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-20Remove obsolete (cargo-cult copied) dependenciesJens Carl1-35/+6
Change-Id: I73d08a2fa9af0aaed7f748f43a0ffc9b53c79c5f Reviewed-on: https://gerrit.libreoffice.org/56138 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-06-20uitest Calc/SolverZdeněk Crhonek4-0/+86
Change-Id: I6fdef503cdae8cb681f1acfec437c5ab3e7bcc5b Reviewed-on: https://gerrit.libreoffice.org/56121 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-06-20push the data from the temporary storage to the document for XML sourceMarkus Mohrhard1-0/+1
Change-Id: I93d489ef9b3fa105db2d364ad9133a26d5366361 Reviewed-on: https://gerrit.libreoffice.org/56126 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-06-20tdf#118189 : Propagate the state of mbNeedsNumberFormat...Dennis Francis1-1/+1
from source formula-cell to destination while calling SetFormulaCell() on dest formula-cell in CopyByCloneHandler CopyByCloneHandler get called when some data range is pasted to a document, or when data is copied to an undo document. This is a follow-up of the commit 37f6e5de1e72d209b0892734f4de5c4d8a849885 (tdf#114710 : Fixes crash when pasting as GDI metafile) Change-Id: I936310f13080f2de763ebcd5cb046a25d61d978e Reviewed-on: https://gerrit.libreoffice.org/55975 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-06-20tdf#77517 make Calc function COLUMN accept external references.Winfried Donkers1-9/+31
Change-Id: Ife00755586be9a42ac5cf1f9b3debb396db1b45f Reviewed-on: https://gerrit.libreoffice.org/56055 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-06-19Resolves: tdf#118226 yes/no reversedCaolán McNamara1-1/+1
Change-Id: I60f6f0c13e1971e0000698ce71fbbdd7244fb85d Reviewed-on: https://gerrit.libreoffice.org/56113 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-06-19Remove obsolete (cargo-cult copied) dependenciesJens Carl1-29/+0
Change-Id: I2b3a0072925df752f45b3cfaf2062cca842679a8 Reviewed-on: https://gerrit.libreoffice.org/56077 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-06-19avoid race condition in DocumentLinkManager::getLinkManager()Luboš Luňák1-21/+29
Change-Id: Ib8ffcf32e4a4dc80539828611adabb3beef1dafa Reviewed-on: https://gerrit.libreoffice.org/55764 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-06-19move doubleCheckedInit() to a comphelper header fileLuboš Luňák1-29/+8
For further reuse in more source files. Change-Id: I2fcbb98a81725e14d6d433f62622d2c48d146de1 Reviewed-on: https://gerrit.libreoffice.org/55763 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-06-19uitest for bug tdf#76731Zdeněk Crhonek2-0/+73
Change-Id: Id514b43050fec4bb8f1b4aac4cb2cd8e449812c6 Reviewed-on: https://gerrit.libreoffice.org/55970 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-06-18Remove obsolete (cargo-cult copied) dependenciesJens Carl1-30/+0
Change-Id: I53aac7187682533c51bf9c29f77359a39b1bf32b Reviewed-on: https://gerrit.libreoffice.org/55977 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-06-18tdf#105720: lok: sc: currency symbol is displayed in the preceding cellMarco Cecchetti1-2/+11
Change-Id: I6175cfeab3d8bc3a757c8522aa9c7a7e49c4bf2b Reviewed-on: https://gerrit.libreoffice.org/55790 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2018-06-18tdf#42949 Fix IWYU warnings in sc/inc/[Tt]*Gabor Kelemen18-51/+52
Found with bin/find-unneeded-includes Only removal proposals are dealt with here and a bit of fallout management. Change-Id: I347377d7bb2a0cf8acda1ad28b5cc79bb954ab7d Reviewed-on: https://gerrit.libreoffice.org/55726 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-06-18do not make calc's threading depend on openclLuboš Luňák1-1/+1
This should have been part of e0e21f2747c19dae13332f4e59949c717aa114f3. Change-Id: I5942b9a907f876ff7173971b27f72b8a6c97f8dc
2018-06-18tdf#108523 Remove @author annotationsAbhyudaya Sharma2-7/+0
Change-Id: I85e364da59ce70ddd97fdae9bc03a4ea76b007fc Reviewed-on: https://gerrit.libreoffice.org/55263 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
generated by cgit v1.2.3 (git 2.39.1) at 2024-12-02 19:11:28 +0000