summaryrefslogtreecommitdiff
path: root/msicreator
AgeCommit message (Collapse)AuthorFilesLines
2024-07-27comphelper, msicreator, odk: fix issues found by Ruff linterIlmari Lauhakangas2-2/+7
Change-Id: I5ef65baeb0100b9d70b5c59c1d5f6f43ab951a22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171092 Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Jenkins Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2023-11-17createmsi: retrieve file handle explicitely so we can close it at the endJulien Nabet1-57/+58
Seen on https://ci.libreoffice.org/view/tb%20platform%20status/job/lo_daily_tb_win_wix/3/console [build PRL] CustomTarget/instsetoo_native/install/install.phony Exception ignored in: <_io.FileIO name='lo.json' mode='rb' closefd=True> Traceback (most recent call last): File "C:\cygwin64\home\tdf\jenkins\daily_workspace\tb\src_master\msicreator\createmsi.py", line 42, in __init__ jsondata = json.load(open(jsonfile, 'rb')) ResourceWarning: unclosed file <_io.BufferedReader name='lo.json'> Change-Id: I98b7436e4e870f4cbcd31a41a4e9d0e84249f5f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159566 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-28msicreator: fix hardcoded wix toolset pathThorsten Behrens1-1/+1
On a Windows Server, the following installation procedure has the toolset end up below the x86 program dir: * % powershell Install-WindowsFeature Net-Framework-Core * % choco install -y wixtoolset Change-Id: I5e416cd24f51ae84cb0e6ef99b8a962355fb2b22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150828 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-04-22Integrate msicreator into LO and generate installerRakielle2-0/+689
Co-authored-by: Ximena Alcaman <alcamanximena@gmail.com> Change-Id: Iea2ea3b4bddc975a032592403727a4ff00db4a5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146843 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>