summaryrefslogtreecommitdiff
path: root/lotuswordpro
AgeCommit message (Collapse)AuthorFilesLines
2017-05-16loplugin:unusedfields improve write-only analysisNoel Grandin2-17/+1
by whitelisting a couple of methods we know only write to their parameters Change-Id: Id7aef9c03c23d10c27707b21eb9a0db4a6c2757c Reviewed-on: https://gerrit.libreoffice.org/37647 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-12ofz: use our own OString insteadCaolán McNamara3-11/+11
Change-Id: I583a95aea0b29878bf4749a8cb2bb684da6da1e5 Reviewed-on: https://gerrit.libreoffice.org/37535 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-05Fix typosAndrea Gelmini2-2/+2
To complete commit 0ef94e2b559547bc4e906e7f24e57ff5d642e108 and f12096272e684ddcd8ffa4e34dcb0a680cc594c2 Change-Id: Ie86bbfbd58dd728a013bef221e4d5c8fbcaf8e03 Reviewed-on: https://gerrit.libreoffice.org/37199 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-05-04Replace all OUString("") with OUString()Arnaud Versini7-25/+25
Change-Id: Ie14c4d76cb61cfbe0410103adfc1afc8ade0f3e0 Reviewed-on: https://gerrit.libreoffice.org/37146 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-02loplugin:checkunusedparams in hwpfilter..lotuswordproNoel Grandin3-3/+3
Change-Id: I4925a95cc74571c2e0ffd413d7ac8bc162c247d7 Reviewed-on: https://gerrit.libreoffice.org/37143 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-28loplugin:salunicodeliteral: lotuswordproStephan Bergmann2-11/+11
Change-Id: Ib59d33d2b09f979d938d88037d9327b9a927dcd5
2017-04-25ofz#1270 avoid oomCaolán McNamara3-0/+13
Change-Id: Iedf0ffdedea1ccda9276763c9d39924c3ff8943b
2017-04-25LtcBenContainer::GetSize is always BenErr_OKCaolán McNamara3-17/+3
Change-Id: Ic14cbc70358800dab57c1a5ac0a834e257d4951a
2017-04-25tools: svstream.hxx needs only errcode.hxx & not errinf.hxxChris Sherlock19-0/+19
Change-Id: Ia28e35ae5af4f601e9a586a3deffbcd61702b0ca Reviewed-on: https://gerrit.libreoffice.org/36896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-24clang-tidy readability-simplify-boolean-expr in hwpfilter..lotuswordproNoel Grandin13-80/+23
Change-Id: I945d3fe6af5f88937b341dfc3696bf1d36344862 Reviewed-on: https://gerrit.libreoffice.org/36874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-21gbuild: Remove MSVC 2013 legacy codeDavid Ostrovsky2-2/+0
Uwinapi is discontinued. Change-Id: I063b4d0d8fab2d60de168e960a63b8181158ac01 Reviewed-on: https://gerrit.libreoffice.org/23198 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Tested-by: David Ostrovsky <david@ostrovsky.org>
2017-04-21remove unnecessary explicit linefeeds from end of SAL and OSL log callsNoel Grandin2-3/+3
Change-Id: I3fa363c8e76e6cfb297f4ec346e3f031c09d6fbf Reviewed-on: https://gerrit.libreoffice.org/36727 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-11loplugin:inlinefields in lotuswordproNoel Grandin9-74/+31
Change-Id: I1ba5bdd59badd6f1b6562c6284baf05bcfc3d78c Reviewed-on: https://gerrit.libreoffice.org/36402 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-11ofz: loop in lwp layoutCaolán McNamara1-1/+7
Change-Id: Ic0a6a3c77b82e001829d8d9d7163e1b2141d8a0c
2017-04-11loplugin:inlinefields in LwpTextStyleNoel Grandin2-34/+12
Change-Id: I5f5eef91ddfb108a77bfe57e0078f3fc7eb7c446 Reviewed-on: https://gerrit.libreoffice.org/36375 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-07loplugin:redundantcast find cstyle arithmetic castsNoel Grandin1-3/+3
Change-Id: If7c259f0d12a41182f476ddb558f7cb5f76f9577 Reviewed-on: https://gerrit.libreoffice.org/36253 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-06loplugin:useuniqueptr extend to catch more localvar casesNoel Grandin2-11/+7
i.e. where the code looks like { foo * p = new foo; ... delete p; return ...; } Change-Id: Id5f2e55d0363fc62c72535a23faeaaf1f0ac6aee Reviewed-on: https://gerrit.libreoffice.org/36190 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-03ofz#721 use vector::at to check indexCaolán McNamara1-2/+2
Change-Id: I786b5d6fb10afe3ebb8482f999115fe72ffe2d4c Reviewed-on: https://gerrit.libreoffice.org/34851 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-31tdf#82580 tools: rename Rectangle to tools::RectangleMiklos Vajna5-8/+8
Mostly generated using make check COMPILER_EXTERNAL_TOOL=1 CCACHE_PREFIX=clang-rename-wrapper RENAME_ARGS="-qualified-name=Rectangle -new-name=tools::Rectangle" Except some modules have their own foo::tools namespace, so there have to use ::tools::Rectangle. This commit just moves the class from the global namespace, it does not update pre/postwin.h yet. Change-Id: I42b2de3c6f769fcf28cfe086f98eb31e42a305f2 Reviewed-on: https://gerrit.libreoffice.org/35923 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-28ofz#955 timeout in lwp loadingCaolán McNamara1-1/+4
Change-Id: I3665bd870cd601f2ac7fee59c087034d406ed07c
2017-03-26lwp: convert hopeful asserts to exceptionsCaolán McNamara1-7/+5
Change-Id: I3111929ea84aa8280607811c851d033156c65731
2017-03-26ofz#944 avoid recurse to deathCaolán McNamara2-1/+7
Change-Id: I27ed8cf5e8296a1ad91c33614913fc7af4a56d45
2017-03-25Fix typosAndrea Gelmini7-7/+7
Change-Id: Id5811d092917c872715559f4508d01e4173d090c Reviewed-on: https://gerrit.libreoffice.org/35636 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-23loplugins:redundantcast teach it about c-style typedef castsNoel Grandin1-3/+3
Change-Id: I1ac11a2481c0f4d8be1e1fd7c7637ac0ece3d65c Reviewed-on: https://gerrit.libreoffice.org/35558 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-23Typo: boder->borderJulien Nabet2-28/+28
Change-Id: I46940c5b584f93b478b1dfca9aa66e036fe951c2 Reviewed-on: https://gerrit.libreoffice.org/35547 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-20Resolves: ofz#820 an exception is an acceptable outcomeCaolán McNamara1-2/+1
Change-Id: Ifc5be483387202c371596fd52f1e2ce682151ca8
2017-03-19fix typo/grammar: "the the" --> thedennisroczek1-11/+6
* also removing pointless ASCII art (tdf#62475) * truncate ending whitespace in Doxyfile Change-Id: I59b012f41ac0d170216229da85a49aa41689dee5 Reviewed-on: https://gerrit.libreoffice.org/35151 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-17Get rid of some unnecessary macrosStephan Bergmann13-144/+137
Change-Id: I872dd72429eae8d183ea1ca8d76fb30b0e8be715 Reviewed-on: https://gerrit.libreoffice.org/35321 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-15ofz: avoid oomCaolán McNamara1-0/+8
Change-Id: Ia4b9c46949017a53c80f729af66b99c2e4f05cee
2017-03-15Avoid unnecessary, wrong downcastStephan Bergmann3-4/+4
...causing UBSan failure with the new lotuswordpro/qa/cppunit/data/fail/stack-1.lwp from e68faf7d42179c4f9b90b514f5b3bfcb7f1e9cb0 "ofz#866 crash in LwpFormulaInfo::ReadArguments": > Testing file:///.../lotuswordpro/qa/cppunit/data/fail/stack-1.lwp: > lotuswordpro/source/filter/bencont.cxx:132:11: runtime error: downcast of address 0x60800043af28 which does not point to an object of type 'OpenStormBento::CBenObject' > 0x60800043af28: note: object is of type 'OpenStormBento::CUtListElmt' > 89 7f 00 00 70 94 cc 7f 89 7f 00 00 80 ae 2d 00 70 60 00 00 80 ae 2d 00 70 60 00 00 30 95 cc 7f > ^~~~~~~~~~~~~~~~~~~~~~~ > vptr for 'OpenStormBento::CUtListElmt' > #0 0x7f897ed108f7 in OpenStormBento::LtcBenContainer::RegisterPropertyName(char const*, OpenStormBento::CBenPropertyName**) lotuswordpro/source/filter/bencont.cxx:132:11 > #1 0x7f897ed11df7 in OpenStormBento::LtcBenContainer::FindNextValueStreamWithPropertyName(char const*) lotuswordpro/source/filter/bencont.cxx:227:5 > #2 0x7f897ed12492 in OpenStormBento::LtcBenContainer::FindValueStreamWithPropertyName(char const*) lotuswordpro/source/filter/bencont.cxx:256:12 > #3 0x7f897ef1fc19 in Decompress(SvStream*, SvStream*&) lotuswordpro/source/filter/lwpfilter.cxx:122:72 > #4 0x7f897ef20deb in GetLwpSvStream(SvStream*, LwpSvStream*&) lotuswordpro/source/filter/lwpfilter.cxx:164:14 > #5 0x7f897ef21836 in ReadWordproFile(SvStream&, com::sun::star::uno::Reference<com::sun::star::xml::sax::XDocumentHandler>&) lotuswordpro/source/filter/lwpfilter.cxx:195:13 > #6 0x7f897ed290cd in LotusWordProImportFilter::importImpl(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) lotuswordpro/source/filter/LotusWordProImportFilter.cxx:76:14 > #7 0x7f897ed296fd in LotusWordProImportFilter::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) lotuswordpro/source/filter/LotusWordProImportFilter.cxx:88:12 > #8 0x7f898eb6db9a in (anonymous namespace)::LotusWordProTest::load(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int) lotuswordpro/qa/cppunit/test_lotuswordpro.cxx:59:27 > #9 0x7f898e3c7901 in test::FiltersTest::recursiveScan(test::filterStatus, rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) unotest/source/cpp/filters-test.cxx:130:20 > #10 0x7f898e3c9fd5 in test::FiltersTest::testDir(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) unotest/source/cpp/filters-test.cxx:158:5 > #11 0x7f898eb6ee58 in (anonymous namespace)::LotusWordProTest::test() lotuswordpro/qa/cppunit/test_lotuswordpro.cxx:64:9 > #12 0x7f898eb7006b in CppUnit::TestCaller<(anonymous namespace)::LotusWordProTest>::runTest() workdir/UnpackedTarball/cppunit/include/cppunit/TestCaller.h:166:6 > #13 0x7f89d2d74d8b in CppUnit::TestCaseMethodFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:32:5 > #14 0x7f89b944f99f in (anonymous namespace)::Protector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) test/source/vclbootstrapprotector.cxx:36:14 > #15 0x7f89d2d333ce in CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25 > #16 0x7f89c2f440cf in (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) unotest/source/cpp/unobootstrapprotector/unobootstrapprotector.cxx:89:12 > #17 0x7f89d2d333ce in CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25 > #18 0x7f89c6bff2c4 in (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) unotest/source/cpp/unoexceptionprotector/unoexceptionprotector.cxx:63:16 > #19 0x7f89d2d333ce in CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25 > #20 0x7f89d2cb1350 in CppUnit::DefaultProtector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) workdir/UnpackedTarball/cppunit/src/cppunit/DefaultProtector.cpp:15:12 > #21 0x7f89d2d333ce in CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25 > #22 0x7f89d2d2fe70 in CppUnit::ProtectorChain::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:77:18 > #23 0x7f89d2def0f5 in CppUnit::TestResult::protect(CppUnit::Functor const&, CppUnit::Test*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:181:28 > #24 0x7f89d2d72fa4 in CppUnit::TestCase::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:91:13 > #25 0x7f89d2d777a7 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:30 > #26 0x7f89d2d76819 in CppUnit::TestComposite::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3 > #27 0x7f89d2d777a7 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:30 > #28 0x7f89d2d76819 in CppUnit::TestComposite::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3 > #29 0x7f89d2e2d5c9 in CppUnit::TestRunner::WrappingSuite::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:47:27 > #30 0x7f89d2ded40d in CppUnit::TestResult::runTest(CppUnit::Test*) workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:148:9 > #31 0x7f89d2e2e89b in CppUnit::TestRunner::run(CppUnit::TestResult&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:96:14 > #32 0x53043c in (anonymous namespace)::ProtectedFixtureFunctor::run() const sal/cppunittester/cppunittester.cxx:305:20 > #33 0x52c089 in sal_main() sal/cppunittester/cppunittester.cxx:455:20 > #34 0x52a742 in main sal/cppunittester/cppunittester.cxx:362:1 > #35 0x7f89d0fb8400 in __libc_start_main /usr/src/debug/glibc-2.24-33-ge9e69e4/csu/../csu/libc-start.c:289 > #36 0x437d49 in _start (workdir/LinkTarget/Executable/cppunittester+0x437d49) Change-Id: I556c3ab6fcc7a08fceac5a7195f81d570fc2a025
2017-03-14ofz#866 crash in LwpFormulaInfo::ReadArgumentsCaolán McNamara2-2/+2
Change-Id: Id301c21c8a4a0556b6326b621171aa62bd939d8d
2017-03-14improve scopingCaolán McNamara1-5/+3
Change-Id: Ie5a5eacddba747d3b9cff6b8252add54473eb3f2
2017-03-14ofz: use std::vector for long buffersCaolán McNamara2-30/+12
and set size of buffer to successfully read data for short reads Change-Id: I8d132446682104f2a4b8c476b7f2bda188bb3cdf
2017-03-13ofz#836 fix leakCaolán McNamara1-3/+3
Change-Id: Ifd818cdf81516bd449db14bb1e84ed508e4b7d96
2017-03-12Fix typosAndrea Gelmini2-8/+8
Change-Id: I63da858b3f264cd099e60192633b44d362b6fad7 Reviewed-on: https://gerrit.libreoffice.org/35055 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-11ofz: turn assert into throwCaolán McNamara1-1/+2
cause size arg is controllable by the file data Change-Id: Ia92b56c04271557afbec1ab47620bcb34f1c0e8a
2017-03-10ofz#801 avoid oomCaolán McNamara3-0/+15
Change-Id: Id3167d1eb3f058543ab7596008012d51b3d242b7
2017-03-07loplugin:loopvartoosmallStephan Bergmann1-9/+6
Change-Id: Ifaa80d22852a6806a7a5c267164383a356fa0086
2017-03-04fail on unknown version flagsCaolán McNamara1-3/+2
Change-Id: Icbd2608a3341652b1b40f6bdebb66c4caf6e810a Reviewed-on: https://gerrit.libreoffice.org/34894 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-03Remove redundant 'inline' keywordStephan Bergmann9-27/+27
...from function definitions occurring within class definitions. Done with a rewriting Clang plugin (to be pushed later). Change-Id: I9c6f2818a57ccdb361548895a7743107cbacdff8 Reviewed-on: https://gerrit.libreoffice.org/34874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-02fix leakCaolán McNamara1-12/+12
Change-Id: Ic91bb15cafa97538a61247660044c1af57b59d84
2017-03-02add lwp fuzzerCaolán McNamara1-3/+2
Change-Id: I72a2d8ce47059f9af65d89fbdcc09d96c40cb79b
2017-03-02avoid recursive register styleCaolán McNamara2-1/+1
Change-Id: I090cec1f311be5e5a34e208d066925b294310e43
2017-03-02Fix typosAndrea Gelmini4-4/+4
Change-Id: Ic6c41fbcc36c11a7528cde0986593a39c2d6738b Reviewed-on: https://gerrit.libreoffice.org/34803 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-02fix leakCaolán McNamara1-6/+6
Change-Id: I01c7ebf10831a27eaab55c2082cbe0a0f28bda1f
2017-03-02dig out lotuswordpros table limitsCaolán McNamara2-0/+11
Change-Id: Iea7d436a78336de150b3d3ae317b99b554fb8657
2017-03-01build WordProCellsMap much fasterCaolán McNamara1-4/+1
Change-Id: I1fbc1f7ec14c8133fb8fcd3532d5d551dcc7ddfb
2017-03-01ofz: oom on seeks past end of SvMemoryStreamCaolán McNamara1-1/+4
cause it grows to fit if its a resizable stream Change-Id: I28b42becdfc8eb591d19d2512cdc1f1ec32c3bbe
2017-03-01fix leakCaolán McNamara1-10/+8
Change-Id: I61e21619e949fe0dda7c4820e6ddbb8d4d597652
2017-03-01fix leakCaolán McNamara8-114/+98
Change-Id: I985d422f4c0b41937e4df616fb3154bb7cbad28d
generated by cgit v1.2.3 (git 2.39.1) at 2024-11-30 10:50:38 +0000