summaryrefslogtreecommitdiff
path: root/jvmfwk/source
AgeCommit message (Collapse)AuthorFilesLines
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann1-1/+1
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-07-08loplugin:redundantcast: redundant static_casts in jvmfwkStephan Bergmann1-1/+1
Change-Id: I6aef36bd21043460e74b5e3d478665a35213bb1a
2016-05-22Convert javaPluginError to scoped enumNoel Grandin1-19/+19
Change-Id: Ib3a32227d50fa9e0f9cc4106ce40a4c3e840f8c7 Reviewed-on: https://gerrit.libreoffice.org/25206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann2-5/+5
Change-Id: I65fdd933e2a3973053359024d8d9c733f79a6477
2016-04-05Values read from the Windows registry shouldn't be assert'edStephan Bergmann1-2/+3
Change-Id: I1a6cc78025790fa22e91ae91dda5644bdc384ca3
2016-03-15tdf#91794 remove OSL_DEBUG_LEVEL > 1 conditionalsRohan Kumar1-6/+2
I replaced OSL_ASSERT() with standard C++ assert Change-Id: I92e07d62f3dfe2ad914c49e2b596aef28c35e225 Reviewed-on: https://gerrit.libreoffice.org/23231 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-03-10No more need for jfw_freeJavaInfoStephan Bergmann1-14/+8
Change-Id: I2426a76936b4099a243ce8c102da867e7868aac3
2016-03-10Turn JavaInfo sal_Sequence* member into rtl::ByteSequenceStephan Bergmann2-12/+3
Change-Id: Iecd476970b0b7a46afe223f71e95b0010048d7b1
2016-03-10Turn JavaInfo rtl_uString* members into OUStringStephan Bergmann2-21/+8
Change-Id: Ieb23b0c36ef56a4793a56cdb450df34e4d9bce1d
2016-03-10Manage JavaInfo instances via new/deleteStephan Bergmann2-14/+8
Change-Id: I10a113718e525b646c51aa8a19f9f2b75a36714a
2016-03-10No need to repeat SAL_CALL in definitionsStephan Bergmann1-20/+18
Change-Id: Ief75af9d08d9b7e31d821773db2363fa201f3038
2016-03-10No need for extern "C" hereStephan Bergmann1-6/+6
...and fix resulting loplugin:salbool fallout Change-Id: I5ae1497608d31c20b0d10676450a7673dee1c651
2016-03-09include/jvmfwk/*.h -> .hxx (only ever included from C++ code)Stephan Bergmann3-3/+3
Change-Id: Ia912e937d5a48afb6f8f5345b20bb7bd517fc4f1
2016-02-17use consistent #define checks for the Windows platformNoel Grandin4-5/+5
stage 2 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro In this stage we focus on replacing usage of the WIN macro Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84 Reviewed-on: https://gerrit.libreoffice.org/22393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-09Remove excess newlinesChris Sherlock4-8/+0
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-08loplugin:unusedmethodsNoel Grandin2-3/+0
using an idea from dtardon: <dtardon> noelgrandin, hi. could you try to run the unusedmethods clang plugin with "make build-nocheck"? that would catch functions that are only used in tests. e.g., i just removed the whole o3tl::range class, which has not been used in many years, but htere was a test for it... <noelgrandin> dtardon, interesting idea! Sure, I can do that. Change-Id: I5653953a426a2186a1e43017212d87ffce520387 Reviewed-on: https://gerrit.libreoffice.org/22041 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-10Fix typosAndrea Gelmini1-1/+1
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2015-11-24cppcheck: noExplicitConstructorCaolán McNamara1-4/+4
Change-Id: I1934441858baeeb41a46f694dbcef2d846b308b7
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann4-106/+106
Change-Id: I9dfcec9488b2a25e32d3934766d6d4b208a8c2dc
2015-11-09new loplugin: oncevarNoel Grandin1-11/+5
Change-Id: If57390510dde4d166be3141b9f658a7453755d3f Reviewed-on: https://gerrit.libreoffice.org/19815 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-04yyyyyNoel Grandin1-13/+5
Change-Id: I9a947beefd2dfe21da8239e841ea3fb416bd1548
2015-10-27loplugin:unusedmethodsNoel Grandin3-52/+0
Change-Id: I161cd52606c11b6008f5d8b1d8ee391692f91861 Reviewed-on: https://gerrit.libreoffice.org/19231 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-25tdf#39440: fix several warnings reported by cppcheckSerge Krot1-2/+2
Change-Id: I560d28b7cc67740c6479494d0e5aa62d2ac6ffae Reviewed-on: https://gerrit.libreoffice.org/19587 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-10-12Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY codeStephan Bergmann2-9/+9
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
2015-10-01loplugin:unusedmethodsNoel Grandin1-4/+0
- improvements to the plugin to find more method calls - improvements to python script to remove more false+ - fix the FORCE_COMPILE_ALL build flag to include code in the $WORKDIR Change-Id: I4d6015dcb9b9d60c26f0bcee8abad807177a7836 Reviewed-on: https://gerrit.libreoffice.org/19064 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-31loplugin:stringconstant: OUStringBuffer: appendAscii -> appendStephan Bergmann1-2/+2
Change-Id: I09552b4ddd8900952f499c8b9c44933c7240c866
2015-08-27Clean up sEmptyStephan Bergmann1-4/+3
Change-Id: If1b2bfe308caa2bce92e73d2c5c86ee273faed93
2015-07-16loplugin:simplifyboolStephan Bergmann1-2/+2
Change-Id: Iaa3c04ba936512f511de238f5a3ca5b0f9afc06d
2015-06-17Replace boost::scoped_array<T> with std::unique_ptr<T[]>Takeshi Abe2-5/+5
This may reduce some degree of dependency on boost. Done by running a script like: git grep -l '#include *.boost/scoped_array.hpp.' \ | xargs sed -i -e 's@#include *.boost/scoped_array.hpp.@#include <memory>@' git grep -l '\(boost::\)\?scoped_array<\([^<>]*\)>' \ | xargs sed -i -e 's/\(boost::\)\?scoped_array<\([^<>]*\)>/std::unique_ptr<\2[]>/' ... and then killing duplicate or unnecessary includes, while changing manually m_xOutlineStylesCandidates in xmloff/source/text/txtimp.cxx, extensions/source/ole/unoconversionutilities.hxx, and extensions/source/ole/oleobjw.cxx. Change-Id: I3955ed3ad99b94499a7bd0e6e3a09078771f9bfd Reviewed-on: https://gerrit.libreoffice.org/16289 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-08loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann2-5/+5
Change-Id: I62a6714749eba8226ba3a5416ee81f2d76cf0afc
2015-06-02loplugin:cstylecast: deal with those that are (technically) const_castStephan Bergmann1-1/+1
Change-Id: Ie8e3bde0eeeec6cd35a7f73f9a29c28cdd03ad02
2015-05-27fprintf -> SAL_INFOStephan Bergmann2-43/+27
Change-Id: I4808e89cf5b90c99df3d4c4474c578a8c8f611a6
2015-05-11loplugin:cstylecast: nop between pointer types of exactly same spellingStephan Bergmann1-1/+1
Change-Id: I21cac03d5100822ef99d4b7fb7c192c0d2adf1b2
2015-05-08std::ptr_fun became deprecated since C++11Takeshi Abe1-2/+2
Change-Id: If93609d032c9864e0251230bf9ed76e6b6741a62 Reviewed-on: https://gerrit.libreoffice.org/15672 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-04-27More loplugin:simplifyboolStephan Bergmann3-10/+9
Change-Id: I51e7a11149676a8b5396d9eb993a509859cdf725
2015-03-28Clean up C-style casts from pointers to voidStephan Bergmann2-8/+8
Change-Id: I302d313f2d14d908672d4534aad1818e820eaae4
2015-03-27loplugin:staticfunctionNoel Grandin2-2/+2
Change-Id: I10c30ef28e7321882a720d1e7869a75a89febfc5
2015-03-26const_cast: convert some C-style casts and remove some redundant onesStephan Bergmann1-2/+2
Change-Id: I81dc70639a866368b9a6c69afffdfd42464e9138
2015-02-07loplugin:deletedspecialStephan Bergmann2-9/+9
Change-Id: I6827530316561e600b760a2620f859b28c6c91e6
2015-01-20Some more loplugin:cstylecast: jvmfwkStephan Bergmann5-119/+119
Change-Id: Iaa1be4b338b75c340555eb4bf0760cadca16713f
2014-12-16jvmfwk: Use appropriate OUString functions on string constantsStephan Bergmann1-3/+2
Change-Id: I3e0b70c61c4e92f2cbd27ce7c45e67ae04dfe14c
2014-12-15Check each potential JRE location only onceStephan Bergmann1-4/+12
i.e., after recent "fdo#83753: consider JAVA_HOME and PATH when selecting JRE" fix, if jfw_findAndSelectJRE found no suitable JRE in jfw_plugin_getJavaInfoFromJavaHome or jfw_plugin_getJavaInfosFromPath, do not re-check those locations in jfw_plugin_getAllJavaInfos. Change-Id: If4e085b4fceff5b2494c7b7b84ac51691dbc78cc
2014-12-15fdo#83753: consider JAVA_HOME and PATH when selecting JREMichael Weghorn1-101/+180
adapted algorithm that selects the Java runtime to be used so that Java installations associated with the JAVA_HOME and PATH environment variables are preferred over others Java installations are now analysed in the following order: * installation that the JAVA_HOME environment variable refers to (if it is set) * Java installations in PATH * other Java installation (algorithm that was used before) Signed-off-by: Stephan Bergmann <sbergman@redhat.com> Conflicts: jvmfwk/source/framework.cxx Change-Id: I3a3ade25322def0c0432b369848f13a6b82034a1
2014-12-15Remove unused cModule leftoversStephan Bergmann1-8/+4
Change-Id: Id08194460e9a42896591047e36b3a95e5fbc47be
2014-12-08callcatcher: update unused codeCaolán McNamara2-16/+0
Change-Id: I3cd65d112339fa9c67ed462fe39acbbef91d4d8d
2014-12-04callcatcher: update unused codeCaolán McNamara8-150/+0
Change-Id: Ia25b857738bb7b6c3baf18c68ef0d1bc0b3e142e
2014-11-28Fold URE: Linux ure/lib/* -> program/Stephan Bergmann1-1/+1
The ../../../program/ links in the URE jar Class-Paths are a temporary kludge (and juh.jar had lacked adaption for Mac OS X). Change-Id: I2542d8a582866485dd61c05df3fc6b4b39a8403d
2014-11-19changed type of parameters from rtl_uString to OUStringMichael Weghorn1-18/+20
changed type of several parameters of the functions jfw_plugin_getAllJavaInfos and jfw_plugin_getJavaInfoByPath from rtl_uString to OUString Change-Id: I80feb311542e6ccded9f9924f800c75a7e14a1e7 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava1-2/+2
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini2-2/+2
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>