summaryrefslogtreecommitdiff
path: root/include/svx/sdr
AgeCommit message (Collapse)AuthorFilesLines
2016-10-05Remove _TYPED suffix from tools/link.hxx macrosStephan Bergmann1-1/+1
...which was introduced with 3ead3ad52f9bb2f9d1d6cf8dfc73a0a25e6778ed "Gradually typed Link" to distinguish the new, typed versions from the old, untyped ones, but is no longer necessary since 382eb1a23c390154619c385414bdbe6f6e461173 "remove untyped Link<>" removed the old versions. Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
2016-09-20convert constants to scoped enum TblActionJochen Nitschke1-4/+14
move enum to header because default function parameters need them. added default case to switch to mute 'not handled case' warnings. Change-Id: I54d8734232e7568fd21ad0178a8492b4903866a3 Reviewed-on: https://gerrit.libreoffice.org/29038 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann24-27/+27
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-13Remove nonsense comments: // bitfieldTor Lillqvist6-6/+0
Surely the actual bitfield syntax is enough to tell the code reader that it is a bitfield. Change-Id: Ic9552e01b19c8b34b2a17db56b9ff63e7c7de926
2016-09-12impress: extend dumpAsXml to table cell and stylesNoel Grandin1-0/+3
Change-Id: If11ca945cae4f5127394dcc3871f4b6a76c24fac
2016-09-09loplugin:constantparam in svxNoel Grandin2-4/+2
Change-Id: Id08850b90a0e286ff837dd6b0c1691fa7dc793fa Reviewed-on: https://gerrit.libreoffice.org/28746 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-09-02loplugin:countusersofdefaultparamsNoel Grandin4-8/+8
Change-Id: I2ed581e58523ac8b52aa520f7a02f69f408665fe Reviewed-on: https://gerrit.libreoffice.org/28587 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-29cid#1371256 Missing move assignment operatorNoel Grandin1-0/+2
Change-Id: Idf50c8f56e1d409fbd1306ee0fec20360bf99c86
2016-08-29cid#1371188 Missing move assignment operatorNoel Grandin1-0/+2
Change-Id: I775db6b3c9db0847184f12fad778a1fc3fcd92eb
2016-08-24convert OverlayType to scoped enumNoel Grandin1-4/+4
Change-Id: Ic7758ec96bdf7f532b5b95048dbb7eb5f360f74a
2016-08-24remove CellOverlayTypeNoel Grandin1-4/+1
since only the CELL_OVERLAY_TRANSPARENT value was in use Change-Id: Ia7a0dfbf09b08e2dfed62d51af42e1409b05f275
2016-08-11loplugin:constantparamNoel Grandin1-1/+0
Change-Id: Ia06b9b189033b9409d7a59a211866f66a0614886 Reviewed-on: https://gerrit.libreoffice.org/28016 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-27improve passstuffbyref return analysisNoel Grandin4-4/+4
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c Reviewed-on: https://gerrit.libreoffice.org/27317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-14loplugin:passstuffbyref in svxNoel Grandin3-4/+4
Change-Id: I7d405830785cb12aaceb65d6ed03dda04aa90fd8
2016-04-12Avoid reserved identifiersStephan Bergmann1-3/+3
Change-Id: I85135c3fa5e6fe823491739c3c1ab601505f0626
2016-03-17loplugin:constantparam in svxNoel Grandin1-1/+1
Change-Id: I50fa7e4c7525d2f8107a11d8203957a47680eb80 Reviewed-on: https://gerrit.libreoffice.org/23303 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-09loplugin:constantparam in svxNoel Grandin1-2/+2
Change-Id: Ib2a432fc334898c75ab5e5cf629a21fd310bd467
2016-03-01loplugin:unuseddefaultparam in svx (part2)Noel Grandin1-2/+2
Change-Id: I99e3d6137ec17e3fc782253c85e5fa4f1da4cec4
2016-02-22loplugin:write only fieldsNoel Grandin1-3/+2
Change-Id: I45895e9845a9037da207f001fece427452ed499f
2016-02-09Remove excess newlinesChris Sherlock27-44/+0
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-20loplugin:unusedmethodsNoel Grandin1-2/+0
Change-Id: Ib2dc804f55d1a96ae01f2cf31b7d55956040a72e Reviewed-on: https://gerrit.libreoffice.org/21603 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-13loplugin:unusedmethods unused return value in include/svxNoel Grandin1-1/+1
Change-Id: I9a5e937905fd71ecbbf9cb215ff6cc2b7defc6f3
2016-01-10Fix typosAndrea Gelmini3-3/+3
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2015-12-19Use std::unique_ptr for mpViewContact member instance of SdrPage.Kohei Yoshida1-3/+4
And fix some const-incorrect-ness while at it. Change-Id: I0314c8e5b73f1a7edce040b2a57fbc5d1081d70c Reviewed-on: https://gerrit.libreoffice.org/20815 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2015-12-15use vector as container for Primitive3DReferenceNoel Grandin2-9/+9
rather than uno::Sequence, since we modify this container a lot and uno::Sequence is expensive to update Change-Id: Id5bc5171cbc4b90b243e6dda6d572f21b3bdf00d
2015-12-11tdf#69977: uno::Sequence is expensiveNoel Grandin22-54/+54
when used as a mutable data-structure. Plain std::vector halves the time taken to display the chart dialog Create a class to represent the std::vector we are going to be passing around, and move some of the utility methods into it to make the code prettier. Also create an optimised append(&&) method for the common case of appending small temporaries. Change-Id: I7f5b43fb4a8a84e40e6a52fcb7e9f974091b4485
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann6-17/+17
Change-Id: I71682f28c6a54d33da6b0c971f34d0a705ff04f5
2015-10-23com::sun::star->css in include/sot to include/typelibNoel Grandin2-3/+3
Change-Id: I9cd92b53370a6b6018d2f7c648890f9c014a27de
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann22-80/+80
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY codeStephan Bergmann3-6/+6
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
2015-10-01remove old standalone Sun bug numbersNoel Grandin1-1/+0
Sun bug numbers without any accompanying text are completely useless. Fixed with git grep -lP '//\s*#\d+#\s*$' | xargs perl -i -ne'/\/\/\s*#\d+#\s*$/d or print' And then hand-checking the result to restore places where it deleted code. And then some more grepping and hand-editing to kill the others. Change-Id: Ia96ce4466db8bb8da363ebf41f0ae7f45f28bf29 Reviewed-on: https://gerrit.libreoffice.org/19023 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-30Fix typosAndrea Gelmini1-1/+1
Change-Id: If877778a98d8f06f6f596b4c186d9c4cf5c33438 Reviewed-on: https://gerrit.libreoffice.org/18957 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-09-29loplugin:removeunusedmethods, remove unused stuffNoel Grandin1-1/+0
Change-Id: I35456b2a3ad2a84a1d045f09cdfb29e4c19b8350
2015-09-20chained editeng: Add chaining attributes and chaining primitive creation logicmatteocam1-1/+8
Change-Id: I957d5261dd847fe5e950441585e879cfd5ae2fb2
2015-09-20chained editeng: Enhance existing svx classes with chaining-related methodsmatteocam1-0/+1
Change-Id: I10829d8f07f8881af6d1a9422cbdae00e83a7ac8
2015-09-01refactor to create a HasMarked, no logic changeCaolán McNamara1-0/+1
Change-Id: I667a8582a740f5fbbcdbcd82907e40e82f6165a1
2015-08-28make PostUserEvent Link<> typedNoel Grandin1-1/+1
Change-Id: I13f10bda985d55d419a5bff481130a456ae2db8a
2015-07-30loplugin:unusedmethodsNoel Grandin1-3/+0
Change-Id: Ib4d77ee01e7362f5951f81fceeca3c489872d971 Reviewed-on: https://gerrit.libreoffice.org/17378 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-16loplugin:unusedmethods svx(part2)Noel Grandin2-4/+0
Change-Id: I161360e2f3113c4814fe1c2c095e602b2c93dcd7 Reviewed-on: https://gerrit.libreoffice.org/17120 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-16loplugin:unusedmethods svxNoel Grandin6-20/+4
Change-Id: I92158457b3ffaaf7c84c6f4c87708d766c8c9f61 Reviewed-on: https://gerrit.libreoffice.org/17117 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-22Fix typosAndrea Gelmini1-1/+1
Change-Id: I60ed5eb658d50cbc7dc572facb5463b7527b4d9b Reviewed-on: https://gerrit.libreoffice.org/16408 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-05-24tdf#62525: use cow_wrapper for SdrTextAttributeThorsten Behrens1-2/+5
Change-Id: I8daf6d155c631cbdb850a6af95c92a578905d6e6
2015-05-24tdf#62525: use cow_wrapper for SdrFormTextAttributeThorsten Behrens1-2/+5
Change-Id: I0fd55ea6c775d771e001c0db78bb72c50e9b81cf
2015-04-30Get rid of initial :: for the sdr namespaceTor Lillqvist4-6/+6
Change-Id: Ibbeb069b6fcb2aa0581429ac5cb6db519548fd00
2015-04-30Bin some pointless comments and reduce some vertical whitespaceTor Lillqvist5-38/+5
Bin pointless '// predeclarations' or '// forward declarations' comments. If a programmer doesn't know what a forward declaration is, well, why read C++ source code? Also bin some pointless '// end of namespace foo' comments after namespace blocks just a handful of lines long, and some superfluous vertical whitespace. Change-Id: I2a31c5d73d9b4de8825fb8eb9e7559dbd7303ef9
2015-04-23loplugin:staticmethodsNoel Grandin2-2/+2
Change-Id: I6207b475127099872c6f3764331006688129b673
2015-04-07Change "blink times" to be of type sal_uInt64Stephan Bergmann2-2/+2
...and thus consistent with Timer::Get/SetTimeout since 9c7016b5b530ca212b1275f44f9e2fc0527109ee "Scheduler: Changed uLong to uInt32/uInt64." Otherwise, at least JunitTest_forms_unoapi on 32-bit Linux would stay busy forever in vcl::Cursor::ImplTimerHdl, alternating among ImplRestore() and ImplDraw(). Change-Id: Ic3fd349344c105078b52749ca85559fce485d0c4
2015-04-07Remove unused getBlinkTime functionsStephan Bergmann1-3/+0
Change-Id: I9820f0ede94e1b335410a3aa803ff10b6f246b00
2015-04-07sd tiled rendering: support turning an editeng selection into a table oneMiklos Vajna1-1/+1
With this, it's possible to drag the selection handle of an editeng selection in an Impress table and drag it outside the table cell to create an Impress table selection. Some unexpected graphic selection still appears, though. Change-Id: Ia7b36036ce2bda5cca570e8b6075238d5167090f
2015-03-30Add SvxTableController::setCursorLogicPosition()Miklos Vajna1-0/+2
With this, it's possible to drag the start or end handle of an Impress table selection and let it grow/shrink. Change-Id: Icdee1207c1c3a6b1c4fb15d00008db6327d6e2de